[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc updated this revision to Diff 102605. mibintc added a comment. Thanks for your review, Fedor. I moved AddGnuIncludeArgs out of GCCInstallation, like you suggested, and put it along where the library includes are added. I also pulled out the change for MipsLinux since I don't have a wa

[libcxx] r305417 - Rework some metaprogramming to use the detection idiom; no functional change

Author: marshall Date: Wed Jun 14 16:23:57 2017 New Revision: 305417 URL: http://llvm.org/viewvc/llvm-project?rev=305417&view=rev Log: Rework some metaprogramming to use the detection idiom; no functional change Modified: libcxx/trunk/include/memory Modified: libcxx/trunk/include/memory URL:

r305418 - AST: Add missing break at end of switch

Author: dexonsmith Date: Wed Jun 14 16:26:31 2017 New Revision: 305418 URL: http://llvm.org/viewvc/llvm-project?rev=305418&view=rev Log: AST: Add missing break at end of switch Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL: http://llvm.org/viewvc/

[PATCH] D34156: [LTO] Add -femit-summary-index flag to emit summary for regular LTO

mehdi_amini added a comment. In https://reviews.llvm.org/D34156#780570, @tobiasvk wrote: > - Change patch to always emit a module summary for regular LTO > > I don't see any real downside of having a summary given the marginal time > and space overhead it takes to construct and save it. I th

[PATCH] D34175: [driver][macOS] Pick the system version for the deployment target if the SDK is newer than the system

arphaman updated this revision to Diff 102607. arphaman added a comment. Remove redundant driver version correctness checks. Repository: rL LLVM https://reviews.llvm.org/D34175 Files: lib/Driver/ToolChains/Darwin.cpp test/Driver/darwin-sdkroot.c Index: test/Driver/darwin-sdkroot.c

[PATCH] D34156: [LTO] Add -femit-summary-index flag to emit summary for regular LTO

tobiasvk added a comment. In https://reviews.llvm.org/D34156#780714, @mehdi_amini wrote: > In https://reviews.llvm.org/D34156#780570, @tobiasvk wrote: > > > - Change patch to always emit a module summary for regular LTO > > > > I don't see any real downside of having a summary given the margina

[PATCH] D34156: [LTO] Add -femit-summary-index flag to emit summary for regular LTO

pcc added a comment. In https://reviews.llvm.org/D34156#780714, @mehdi_amini wrote: > In https://reviews.llvm.org/D34156#780570, @tobiasvk wrote: > > > - Change patch to always emit a module summary for regular LTO > > > > I don't see any real downside of having a summary given the marginal tim

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

zaks.anna added a comment. Great cleanup! Some comments below. Comment at: www/analyzer/alpha_checks.html:91 +(C, C++) +Check for logical errors for function calls and Objective-C message +expressions (e.g., uninitialized arguments, null function pointers, fo

[PATCH] D31029: [analyzer] Fix logical not for pointers with different bit width

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Looks good with a nit! Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:325 + Loc makeNull() { return loc::ConcreteInt(BasicVals.getZeroWith

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

zaks.anna added a comment. Should this revision be "abandoned" or is the plan to iterate on it? Repository: rL LLVM https://reviews.llvm.org/D31320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D33841: [clang-tidy] redundant keyword check

aaron.ballman added inline comments. Comment at: clang-tidy/readability/RedundantKeywordCheck.cpp:22 +template +static bool startsWith(const T &Node, StringRef Value) { + Token Result; Why do you need to do a textual search that the first token in the declarati

r305425 - [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments,

Author: erichkeane Date: Wed Jun 14 18:09:01 2017 New Revision: 305425 URL: http://llvm.org/viewvc/llvm-project?rev=305425&view=rev Log: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments StringifiedArguments is allocated (resized) based on the size the

[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/SValBuilder.cpp:356 QualType ResultTy) { - if (!State->isTainted(RHS) && !State->isTainted(LHS)) -return UnknownVal(); I am concerned that removing the g

[PATCH] D32046: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments

This revision was automatically updated to reflect the committed changes. erichkeane marked 3 inline comments as done. Closed by commit rL305425: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D320

[clang-tools-extra] r305426 - Update callbacks tracker to match change in 305425

Author: erichkeane Date: Wed Jun 14 18:15:51 2017 New Revision: 305426 URL: http://llvm.org/viewvc/llvm-project?rev=305426&view=rev Log: Update callbacks tracker to match change in 305425 Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp Modified: clang-tools-extra/trunk/pp-t

[libcxx] r305427 - [locale] Avoid copy of __atoms when char_type is char

Author: hiraditya Date: Wed Jun 14 18:17:45 2017 New Revision: 305427 URL: http://llvm.org/viewvc/llvm-project?rev=305427&view=rev Log: [locale] Avoid copy of __atoms when char_type is char The function num_get<_CharT>::stage2_int_prep makes unnecessary copy of src into atoms when char_type is ch

[PATCH] D30268: Avoid copy of __atoms when char_type is char

This revision was automatically updated to reflect the committed changes. Closed by commit rL305427: [locale] Avoid copy of __atoms when char_type is char (authored by hiraditya). Changed prior to commit: https://reviews.llvm.org/D30268?vs=102566&id=102621#toc Repository: rL LLVM https://re

[PATCH] D34156: [LTO] Add -femit-summary-index flag to emit summary for regular LTO

mehdi_amini added a comment. OK! Thanks both :) https://reviews.llvm.org/D34156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34224: [NFC] remove trailing WS

hiraditya created this revision. https://reviews.llvm.org/D34224 Files: include/memory Index: include/memory === --- include/memory +++ include/memory @@ -724,7 +724,7 @@ struct __has_element_type : false_type {}; template -s

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp:41 + forEachConstructorInitializer( + cxxCtorInitializer(

[PATCH] D34091: Support for querying the exception specification type through libclang

aaron.ballman added inline comments. Comment at: include/clang-c/Index.h:185 + */ + CXCursor_ExceptionSpecificationKind_None, ///< no exception specification + You can drop the trailing comment. Comment at: include/clang-c/Index.h:208 + /**

[PATCH] D33904: Add a __has_attribute_enhancement macro to clang

aaron.ballman added a comment. In https://reviews.llvm.org/D33904#778165, @george.burgess.iv wrote: > > Why not just use __has_feature(overloadable_unmarked) or similar? > > My impression was that `__has_feature` was was for larger features than > tweaks to attributes. If this would be an approp

[PATCH] D34179: [Frontend] PR32318 Handle -ast-dump-all properly.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D34179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D34225: [clang-format] Teach clang-format how to handle C++ coroutines

EricWF created this revision. Herald added a subscriber: klimek. This patch (1) enable parsing for coroutines by default and (2) teaches clang-format how to properly handle them. https://reviews.llvm.org/D34225 Files: lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp lib/Format/Unwrapp

[PATCH] D34179: [Frontend] PR32318 Handle -ast-dump-all properly.

hintonda added a comment. Great, thanks Aaron. Could you commit it for me when you get a chance? https://reviews.llvm.org/D34179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r305432 - Handle -ast-dump-all when passed as the only option.

Author: aaronballman Date: Wed Jun 14 19:00:08 2017 New Revision: 305432 URL: http://llvm.org/viewvc/llvm-project?rev=305432&view=rev Log: Handle -ast-dump-all when passed as the only option. Patch by Don Hinton Modified: cfe/trunk/lib/Frontend/ASTConsumers.cpp cfe/trunk/test/Coverage/as

[PATCH] D34179: [Frontend] PR32318 Handle -ast-dump-all properly.

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r305432. You should consider reaching out to Chris Lattner for svn access! https://reviews.llvm.org/D34179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D34179: [Frontend] PR32318 Handle -ast-dump-all properly.

hintonda added a comment. I have, but just haven't heard back yet... Thanks again... https://reviews.llvm.org/D34179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r305434 - Update Append Argument to more efficiently traverse tokens

Author: erichkeane Date: Wed Jun 14 19:27:23 2017 New Revision: 305434 URL: http://llvm.org/viewvc/llvm-project?rev=305434&view=rev Log: Update Append Argument to more efficiently traverse tokens This function was previously making (correct) assumptions without complete knowledge of MacroArgs gua

r305435 - Fix LexerTest signed/unsigned comparison.

Author: erichkeane Date: Wed Jun 14 19:28:13 2017 New Revision: 305435 URL: http://llvm.org/viewvc/llvm-project?rev=305435&view=rev Log: Fix LexerTest signed/unsigned comparison. Werror was catching a signed/unsigned compare in an assert, correct the signed 'expected' value to be unsigned. Modi

r305437 - [clang-format] Allow git-clang-format to handle empty extensions.

Author: ericwf Date: Wed Jun 14 19:54:08 2017 New Revision: 305437 URL: http://llvm.org/viewvc/llvm-project?rev=305437&view=rev Log: [clang-format] Allow git-clang-format to handle empty extensions. Most of libc++'s header files don't use extension. This prevents using git-clang-format on them, w

r305440 - [ODRHash] Hash TemplateArgument::Pack and TemplateTypeParmType

Author: rtrieu Date: Wed Jun 14 20:35:06 2017 New Revision: 305440 URL: http://llvm.org/viewvc/llvm-project?rev=305440&view=rev Log: [ODRHash] Hash TemplateArgument::Pack and TemplateTypeParmType Modified: cfe/trunk/lib/AST/ODRHash.cpp cfe/trunk/test/Modules/odr_hash.cpp Modified: cfe/tr

r305439 - [Basic] Use a static_assert instead of using the old array of size -1 trick.

Author: ctopper Date: Wed Jun 14 20:27:58 2017 New Revision: 305439 URL: http://llvm.org/viewvc/llvm-project?rev=305439&view=rev Log: [Basic] Use a static_assert instead of using the old array of size -1 trick. Modified: cfe/trunk/include/clang/Basic/AllDiagnostics.h Modified: cfe/trunk/incl

[libcxx] r305442 - Move external instantiation for __vector_base_common to vector.cpp

Author: ericwf Date: Wed Jun 14 20:53:12 2017 New Revision: 305442 URL: http://llvm.org/viewvc/llvm-project?rev=305442&view=rev Log: Move external instantiation for __vector_base_common to vector.cpp Previously the explicit instantiation for this was in locale.cpp, but that didn't make much sense

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai added a comment. Dear Anna, Long time no see, miss you :) > Should this revision be "abandoned" or is the plan to iterate on it? I wanna the plan to iterate on it, Artem reviewed the patch, and I fixed the issue as he suggested, ran `make check-clang-analysis` also used it for check

[libcxx] r305446 - Add hack to get --param=enable_modules=true working with a __config_site header

Author: ericwf Date: Wed Jun 14 21:54:15 2017 New Revision: 305446 URL: http://llvm.org/viewvc/llvm-project?rev=305446&view=rev Log: Add hack to get --param=enable_modules=true working with a __config_site header Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils

[libcxx] r305445 - Fix test when modules are enabled

Author: ericwf Date: Wed Jun 14 21:54:12 2017 New Revision: 305445 URL: http://llvm.org/viewvc/llvm-project?rev=305445&view=rev Log: Fix test when modules are enabled Modified: libcxx/trunk/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.cxx1z.pass.cpp Modi

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Kindly ping Artem and Anna :) Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r305447 - remove incorrectly committed assertion

Author: ericwf Date: Wed Jun 14 22:02:43 2017 New Revision: 305447 URL: http://llvm.org/viewvc/llvm-project?rev=305447&view=rev Log: remove incorrectly committed assertion Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL: http://llvm.

[libcxx] r305448 - Fix another test with modules enabled

Author: ericwf Date: Wed Jun 14 22:03:45 2017 New Revision: 305448 URL: http://llvm.org/viewvc/llvm-project?rev=305448&view=rev Log: Fix another test with modules enabled Modified: libcxx/trunk/test/libcxx/depr/depr.function.objects/depr.adaptors.cxx1z.pass.cpp Modified: libcxx/trunk/test/

[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

puneetha updated this revision to Diff 102635. puneetha added a comment. Added testcase. https://reviews.llvm.org/D34198 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/type-traits.cpp Index: test/SemaCXX/type-traits.cpp === ---

r305450 - Correct documentation about the AfterClass clang-format option

Author: ericwf Date: Wed Jun 14 22:38:08 2017 New Revision: 305450 URL: http://llvm.org/viewvc/llvm-project?rev=305450&view=rev Log: Correct documentation about the AfterClass clang-format option Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst Modified: cfe/trunk/docs/ClangFormatStyleOp

[libcxx] r305451 - attempt to fix GCC ToT build failures

Author: ericwf Date: Wed Jun 14 22:50:02 2017 New Revision: 305451 URL: http://llvm.org/viewvc/llvm-project?rev=305451&view=rev Log: attempt to fix GCC ToT build failures Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL: http://llvm.org/viewvc/llvm-project

[PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

dberris added a comment. @dblaikie it turns out that this is a much simpler change now. PTAL? https://reviews.llvm.org/D34052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r305453 - Renamed some of the newly added tests. No functional change

Author: marshall Date: Thu Jun 15 00:44:49 2017 New Revision: 305453 URL: http://llvm.org/viewvc/llvm-project?rev=305453&view=rev Log: Renamed some of the newly added tests. No functional change Added: libcxx/trunk/test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp -

[PATCH] D34233: [CFI] Add ability to explicitly link classes

egoktas created this revision. egoktas created this object with visibility "All Users". User can explicitly specify classlinks in a sanitizer blacklist file. During compilation with Control-Flow Integrity (CFI), the specified classes will be linked so that (vtables of) the class type Y can be us

[PATCH] D34233: [CFI] Add ability to explicitly link classes

egoktas updated this revision to Diff 102641. egoktas added a comment. Remove the edits to CGExpr.cpp which accidentally got included in the diff. https://reviews.llvm.org/D34233 Files: include/clang/Basic/SanitizerBlacklist.h lib/Basic/SanitizerBlacklist.cpp lib/CodeGen/CGVTables.cpp l

[PATCH] D34233: [CFI] Add ability to explicitly link classes

pcc added a comment. Before looking at this patch in detail, can you please explain the need for this feature? How difficult would it be to change your code to avoid relying on invalid casts? https://reviews.llvm.org/D34233 ___ cfe-commits mailing

<    1   2