[PATCH] D34194: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

2017-06-13 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 102486. EricWF added a comment. - Remove unneeded assertion. https://reviews.llvm.org/D34194 Files: lib/AST/ExprClassification.cpp lib/CodeGen/CGCoroutine.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCoroutines/coro-await.cp

[PATCH] D34194: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

2017-06-13 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 102487. EricWF added a comment. - Improve tests https://reviews.llvm.org/D34194 Files: lib/AST/ExprClassification.cpp lib/CodeGen/CGCoroutine.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCoroutines/coro-await.cpp Index: tes

[PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

2017-06-13 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris updated this revision to Diff 102491. dberris added a comment. - fixup: use bool arg in checkFunctionOrMethodParameterIndex https://reviews.llvm.org/D34052 Files: lib/Sema/SemaDeclAttr.cpp test/Sema/xray-log-args-class.cpp Index: test/Sema/xray-log-args-class.cpp =

[PATCH] D34194: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

2017-06-13 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 102492. EricWF added a comment. - Improve test by using regular expressions and [[Name]] where possible. https://reviews.llvm.org/D34194 Files: lib/AST/ExprClassification.cpp lib/CodeGen/CGCoroutine.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunct

<    1   2