Re: r305022 - [ASTMatchers] Add clang-query support for equals matcher

2017-06-08 Thread Kostya Serebryany via cfe-commits
The test seems to be failing: llvm/tools/clang/unittests/ASTMatchers/Dynamic/RegistryTest.cpp:533: Failure Value of: matches("double x = 1.2f;", DoubleStmt) Actual: false (Could not find match in "double x = 1.2f;") Expected: true On Thu, Jun 8, 2017 at 3:00 PM, Peter Wu via cfe-commits < cfe-c

r305026 - [sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. Reapplying revisions 304630, 304631, 304632, 304673, see

2017-06-08 Thread Kostya Serebryany via cfe-commits
Author: kcc Date: Thu Jun 8 17:58:19 2017 New Revision: 305026 URL: http://llvm.org/viewvc/llvm-project?rev=305026&view=rev Log: [sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. Reapplying revisions 304630, 304

r305025 - [ASTMatchers] temporary disable tests with floating suffix

2017-06-08 Thread Peter Wu via cfe-commits
Author: lekensteyn Date: Thu Jun 8 17:58:12 2017 New Revision: 305025 URL: http://llvm.org/viewvc/llvm-project?rev=305025&view=rev Log: [ASTMatchers] temporary disable tests with floating suffix r305022 assumed that floatLiteral(equals(1.2)) would also match 1.2f and 1.2l, but apparently that is

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

2017-06-08 Thread Bryce Adelstein Lelbach via Phabricator via cfe-commits
wash added inline comments. Comment at: include/numeric:182 +{ + _Tp __saved = __init; + for (; __first != __last; ++__first, (void) ++__result) { If `__first == __last`, this initialization is unnecessary; I'd refactor this so that we check for `__f

Re: r305022 - [ASTMatchers] Add clang-query support for equals matcher

2017-06-08 Thread Peter Wu via cfe-commits
Yes, mea culpa :( I forgot to rebuild after doing the final revision of the patch (in which two new tests were added). The failing tests are temporary disabled in r305025 until a proper fix is developed. Kind regards, Peter On Thu, Jun 08, 2017 at 03:58:01PM -0700, Kostya Serebryany wrote: > The

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

2017-06-08 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added inline comments. Comment at: include/clang/AST/Decl.h:901 +/// member functions. +unsigned ImplicitParamKind : 3; }; aaron.ballman wrote: > rjmccall wrote: > > ABataev wrote: > > > aaron.ballman wrote: >

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

2017-06-08 Thread Bryce Adelstein Lelbach via Phabricator via cfe-commits
wash added a comment. https://gist.github.com/brycelelbach/137f1e45b737d615134e228ec0c84f3a <- some crude tests I wrote based on slides/notes of mine. https://reviews.llvm.org/D34038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

2017-06-08 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh added a comment. Android source is suppressing misc-noexcept-move-constructor warnings because -fno-exceptions is used and Android does not like to add more exception specific code. It's not a big deal for Android to suppress this check one way or the other. I don't mind reverting it, just cu

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

2017-06-08 Thread Bryce Adelstein Lelbach via Phabricator via cfe-commits
wash added a comment. This implementation works, but performs unnecessary operations. https://gist.github.com/brycelelbach/907ac3b8a74603cc189897ab789a65a9 The "next" result is calculated in each iteration; this means one unnecessary application of the binary op (the "next" result on the final

r305039 - Represent debug information compression type fully

2017-06-08 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Jun 8 19:40:30 2017 New Revision: 305039 URL: http://llvm.org/viewvc/llvm-project?rev=305039&view=rev Log: Represent debug information compression type fully This is tied with the LLVM side of the change to expose the debug information compression types to clang. We n

r305044 - [libclang] Introduce a new parsing option 'CXTranslationUnit_SingleFileParse' that puts preprocessor in a mode for parsing a single file only.

2017-06-08 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Thu Jun 8 20:20:48 2017 New Revision: 305044 URL: http://llvm.org/viewvc/llvm-project?rev=305044&view=rev Log: [libclang] Introduce a new parsing option 'CXTranslationUnit_SingleFileParse' that puts preprocessor in a mode for parsing a single file only. This is useful f

[PATCH] D34021: [coroutines] Fix co_await for range statement

2017-06-08 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: test/SemaCXX/coawait_range_for.cpp:133 + +struct ForLoopAwaiterCoawaitLookup { + struct promise_type { This test is incorrect WRT ADL lookup. https://reviews.llvm.org/D34021

r305045 - Remove 'Filename' parameter from BeginSourceFileAction.

2017-06-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jun 8 20:36:10 2017 New Revision: 305045 URL: http://llvm.org/viewvc/llvm-project?rev=305045&view=rev Log: Remove 'Filename' parameter from BeginSourceFileAction. No-one was using this, and it's not meaningful in general -- FrontendActions can be run on inputs that don't

[clang-tools-extra] r305046 - [clangd] Update for ASTUnit API change.

2017-06-08 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Thu Jun 8 21:04:19 2017 New Revision: 305046 URL: http://llvm.org/viewvc/llvm-project?rev=305046&view=rev Log: [clangd] Update for ASTUnit API change. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp URL

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

2017-06-08 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. > Should the non-parallel implementation of reduce static_assert or SFINAE away > when these requirements are not met? That may be desirable, but that's not what the standard says. There's nothing there about "shall not participate in overload resolution". //Require

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

2017-06-08 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists updated this revision to Diff 101988. mclow.lists added a comment. Added a `_VSTD::`, made some assertions `static_assert`, and addressed Bryce's concerns about doing an init when the input range is empty. https://reviews.llvm.org/D34038 Files: include/numeric test/std/numeric

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

2017-06-08 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists updated this revision to Diff 101989. mclow.lists added a comment. Turn the for loops into do-while loops, saving a comparison. https://reviews.llvm.org/D34038 Files: include/numeric test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan_iter_iter_iter.pass.cpp test/std

[PATCH] D30375: Function with unparsed body is a definition

2017-06-08 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. Thank you for explanation. Probably making new semantic action is an overkill. The intent was to postpone setting flag `WillHaveBody` as late as possible, to the moment when it becomes clear that the function indeed will have a body. Otherwise parsing of deleted funct

[PATCH] D30375: Function with unparsed body is a definition

2017-06-08 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 101993. sepavloff added a comment. Changed implementation https://reviews.llvm.org/D30375 Files: include/clang/AST/Decl.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp test/SemaCX

[PATCH] D33493: Speed up preamble loading

2017-06-08 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan updated this revision to Diff 101995. yvvan added a comment. "what kind of performance benefits do you get for the preamble load times?" In cases where many windows headers are included preamble loading takes almost the half of reparse time. With this fix time to load preamble goes towards

<    1   2