Re: r304956 - [ODRHash] Change the fall-back diagnostic error.

On 7 June 2017 at 17:56, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Wed Jun 7 19:56:21 2017 > New Revision: 304956 > > URL: http://llvm.org/viewvc/llvm-project?rev=304956&view=rev > Log: > [ODRHash] Change the fall-back diagnostic error. > > Provid

r304957 - Weaken restriction in r304862 to allow implicit deduction guides to reference

Author: rsmith Date: Wed Jun 7 20:08:50 2017 New Revision: 304957 URL: http://llvm.org/viewvc/llvm-project?rev=304957&view=rev Log: Weaken restriction in r304862 to allow implicit deduction guides to reference the injected-class-name of a specialization that uses a partial / explicit specializati

Re: r304956 - [ODRHash] Change the fall-back diagnostic error.

Yes, I will go correct the diagnostic text. In theory, there is nothing that is supposed to reach this diagnostic or the one below it. Except that the hasher isn't complete yet and some things slip through. Once things are more stable, these should be replaced with llvm_unreachable instead. On

r304960 - Simplify.

Author: rsmith Date: Wed Jun 7 21:05:55 2017 New Revision: 304960 URL: http://llvm.org/viewvc/llvm-project?rev=304960&view=rev Log: Simplify. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sema

Re: r284060 - Implement MS _BitScan intrinsics

I'm worried about changing this signature all the time. I suspect that it will cause the following to be emitted for valid code: warning: incompatible pointer types passing 'unsigned long *' to parameter of type 'unsigned int *' [-Wincompatible-pointer-types] Switching the signature on LP64 soun

[PATCH] D33598: [libclang] [OpenCL] Expose CIndex functions for typedef and address space

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! sorry for the delay. https://reviews.llvm.org/D33598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai updated this revision to Diff 101847. xiangzhai added a comment. Herald added a subscriber: xazax.hun. Hi Artem, I updated my patch please review it, thanks a lot! Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868 Files: lib/StaticAnalyzer/Checkers/CStrin

[PATCH] D30268: Avoid copy of __atoms when char_type is char

hiraditya added a comment. Ping https://reviews.llvm.org/D30268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r304962 - [ODRHash] Make diagnostic message more readable.

Author: rtrieu Date: Wed Jun 7 23:47:29 2017 New Revision: 304962 URL: http://llvm.org/viewvc/llvm-project?rev=304962&view=rev Log: [ODRHash] Make diagnostic message more readable. Change the diagnostic message from r304956 to be less confusing by reordering the flow of information. Modified:

Re: r304956 - [ODRHash] Change the fall-back diagnostic error.

After r304962, it should now produce messages like: 'foo' defined here has different definitions in different modules; first difference is this unexpected decl but in 'Module' found another unexpected decl 'foo' with definition in module 'FirstModule' has different definitions in different module

[PATCH] D34021: [coroutines] Fix co_await for range statement

EricWF created this revision. Currently we build the co_await expressions on the wrong implicit statements of the implicit ranged for; Specifically we build the co_await expression wrapping the range declaration, but it should wrap the begin expression. This patch fixes co_await on range for.

[PATCH] D34021: [coroutines] Fix co_await for range statement

EricWF updated this revision to Diff 101853. EricWF added a comment. - Add FIXME comments for incorrect use of `getCurScope()` after initial parse. https://reviews.llvm.org/D34021 Files: include/clang/Sema/Sema.h lib/Sema/SemaCoroutine.cpp lib/Sema/SemaStmt.cpp test/SemaCXX/coawait_rang

[PATCH] D34021: [coroutines] Fix co_await for range statement

EricWF updated this revision to Diff 101854. EricWF added a comment. - Fix clang-format nonsense in tests. https://reviews.llvm.org/D34021 Files: include/clang/Sema/Sema.h lib/Sema/SemaCoroutine.cpp lib/Sema/SemaStmt.cpp test/SemaCXX/coawait_range_for.cpp Index: test/SemaCXX/coawait_ra

[PATCH] D34021: [coroutines] Fix co_await for range statement

EricWF updated this revision to Diff 101857. EricWF added a comment. - More test cleanup. Sorry for the noise. https://reviews.llvm.org/D34021 Files: include/clang/Sema/Sema.h lib/Sema/SemaCoroutine.cpp lib/Sema/SemaStmt.cpp test/SemaCXX/coawait_range_for.cpp Index: test/SemaCXX/coawai

r304963 - Catch invalid bitwise operation on vector of floats

Author: sepavloff Date: Thu Jun 8 00:25:19 2017 New Revision: 304963 URL: http://llvm.org/viewvc/llvm-project?rev=304963&view=rev Log: Catch invalid bitwise operation on vector of floats Bitwise complement applied to vector of floats described with attribute `ext_vector_type` is not diagnosed as

[PATCH] D33732: Catch invalid bitwise operation on vector of floats

This revision was automatically updated to reflect the committed changes. Closed by commit rL304963: Catch invalid bitwise operation on vector of floats (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D33732?vs=101359&id=101856#toc Repository: rL LLVM https://revi

[PATCH] D34021: [coroutines] Fix co_await for range statement

EricWF updated this revision to Diff 101858. https://reviews.llvm.org/D34021 Files: include/clang/Sema/Sema.h lib/Sema/SemaCoroutine.cpp lib/Sema/SemaStmt.cpp test/SemaCXX/coawait_range_for.cpp Index: test/SemaCXX/coawait_range_for.cpp

r304964 - Improve diagnostics if friend function redefines file-level function.

Author: sepavloff Date: Thu Jun 8 01:07:07 2017 New Revision: 304964 URL: http://llvm.org/viewvc/llvm-project?rev=304964&view=rev Log: Improve diagnostics if friend function redefines file-level function. Clang makes check for function redefinition after it merged the new declaration with the ex

[PATCH] D26065: Improve diagnostics if friend function redefines file-level function.

This revision was automatically updated to reflect the committed changes. Closed by commit rL304964: Improve diagnostics if friend function redefines file-level function. (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D26065?vs=101666&id=101859#toc Repository: rL

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. Here's a simple example that demonstrates the corruption I'm seeing: #include "llvm/ADT/StringRef.h" int main() { std::string ss = ""; llvm::StringRef Ref = true ? "noexcept" : ss; std::string s = Ref; return 0; } https://reviews.llvm.org/D20693 _

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 101860. hintonda added a comment. - Make sure types for ternary operator are the same. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp

r304965 - Do not inherit default arguments for friend function in class template.

Author: sepavloff Date: Thu Jun 8 01:31:19 2017 New Revision: 304965 URL: http://llvm.org/viewvc/llvm-project?rev=304965&view=rev Log: Do not inherit default arguments for friend function in class template. A function declared in a friend declaration may have declarations prior to the containing

[PATCH] D30393: Do not inherit default arguments for friend function in class template.

This revision was automatically updated to reflect the committed changes. Closed by commit rL304965: Do not inherit default arguments for friend function in class template. (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D30393?vs=101512&id=101861#toc Repository: r

<    1   2