Yes, the thing that it's supposed to be testing is -Wuninitialized and
other analysis warnings.
I'll re-name the test and add more test cases to this effect shortly.
Thanks for the input.
On Mon, Jun 5, 2017 at 10:33 AM, David Blaikie wrote:
>
>
> On Mon, May 29, 2017 at 3:28 PM Eric Fiselier v
Author: alexfh
Date: Wed Jun 7 03:25:51 2017
New Revision: 304879
URL: http://llvm.org/viewvc/llvm-project?rev=304879&view=rev
Log:
[clang-tidy] Make misc-inaccurate-erase work with real C++11 containers.
The check failed to match iterator->const_iterator conversion that is happening
at least wh
frej added a comment.
Ping, I don't have have commit permissions, so I am at the mercy of others for
getting this fix committed...
https://reviews.llvm.org/D32745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
alexfh added a comment.
In https://reviews.llvm.org/D20693#774693, @hintonda wrote:
> In order to fix diagnostic corruption in some of the buildbot tests
> (unable to reproduce locally):
>
> - make NoexceptMacro a static variable so it's lifetime doesn't end when
> UseNoexceptCheck is destroyed
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
In any case, I'm strongly against these hacks, please revert them.
https://reviews.llvm.org/D20693
___
cfe-commits mailing list
cfe-com
Author: chefmax
Date: Wed Jun 7 03:51:15 2017
New Revision: 304880
URL: http://llvm.org/viewvc/llvm-project?rev=304880&view=rev
Log:
[Driver] Add test to cover case when LSan is not supported
This commit adds a testcase for uncovered code paths in LSan options parsing
logic in driver.
Differen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304880: [Driver] Add test to cover case when LSan is not
supported (authored by chefmax).
Changed prior to commit:
https://reviews.llvm.org/D33941?vs=101557&id=101672#toc
Repository:
rL LLVM
https:/
Author: ericwf
Date: Wed Jun 7 04:06:05 2017
New Revision: 304883
URL: http://llvm.org/viewvc/llvm-project?rev=304883&view=rev
Log:
Fix test with exceptions disabled
Modified:
libcxx/trunk/test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp
Modified:
libcxx/trunk/test/
chrib added a comment.
OK, I have created a RFE tracker (BZ #32501). I will forward to cfe-dev.
Regarding the need to avoid table-based unwinding, the way to handle those
request for an explicit frame pointer when not required by the ABI is to use
-fno-omit-frame-pointer flag, catching up with
chrib updated this revision to Diff 101675.
chrib added a comment.
- do not omit the frame pointer for netbsd-eabi and darwin-eabi
https://reviews.llvm.org/D31972
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/frame-pointer.c
Index: test/Driver/frame-pointer.c
Author: javed.absar
Date: Wed Jun 7 05:02:02 2017
New Revision: 304889
URL: http://llvm.org/viewvc/llvm-project?rev=304889&view=rev
Log:
[ARM] Fix Neon vector type alignment to 64-bit
This is restricted version of patch - https://reviews.llvm.org/D33205
that I reverted as it was leading to ABI b
Author: mpark
Date: Wed Jun 7 05:22:43 2017
New Revision: 304891
URL: http://llvm.org/viewvc/llvm-project?rev=304891&view=rev
Log:
Implement LWG 2904.
Summary:
- Removed the move-constructibe requirement from copy-assignable.
- Updated `__assign_alt` such that we direct initialize if
`_Tp` can
Author: d0k
Date: Wed Jun 7 05:23:17 2017
New Revision: 304892
URL: http://llvm.org/viewvc/llvm-project?rev=304892&view=rev
Log:
[Sema] Silence unused variable warning.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-proj
Author: mpark
Date: Wed Jun 7 05:27:17 2017
New Revision: 304893
URL: http://llvm.org/viewvc/llvm-project?rev=304893&view=rev
Log:
Mark LWG 2904 as complete.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llvm-project/l
fhahn updated this revision to Diff 101687.
fhahn added a comment.
rebased
https://reviews.llvm.org/D33448
Files:
lib/Basic/Targets.cpp
test/CodeGen/arm-long-calls.c
test/CodeGen/arm-no-movt.c
test/CodeGen/arm-target-features.c
test/CodeGen/arm-thumb-mode-target-feature.c
Index: test
mharoush updated this revision to Diff 101688.
mharoush marked an inline comment as done.
mharoush added a comment.
Simplified the AsmRewrite condition in x86AsmParser. Some fixes to simplify the
Intel State Machine immediate value rewrite treatment divergence.
Repository:
rL LLVM
https://re
mharoush marked an inline comment as done.
mharoush added inline comments.
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:722
+ bool ParseIntelExpression(IntelExprStateMachine &SM, SMLoc &End,
+bool &ReplaceEnumIdentifier);
std::unique_ptr
mharoush updated this revision to Diff 101689.
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
lib/Sema/SemaStmtAsm.cpp
test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
Index: lib/Sema/SemaStmtAsm.cpp
===
--- lib/Se
dim created this revision.
In https://reviews.llvm.org/D33900, I added printing of the registered targets
in clang's
`PrintVersion` function, which is not only used for `--version` output,
but also for `-v` (verbose mode) and `-###`. Especially the latter
seems to trip up some test cases, so it
mharoush updated this revision to Diff 101693.
mharoush added a comment.
added struct case to the test
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
lib/Sema/SemaStmtAsm.cpp
test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
Index: lib/Sema/SemaStmtAsm.cpp
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM. This cleans up the failures on PPC (and probably SystemZ) so the bots
should go back to green.
https://reviews.llvm.org/D33981
___
cfe
Author: fhahn
Date: Wed Jun 7 06:50:45 2017
New Revision: 304897
URL: http://llvm.org/viewvc/llvm-project?rev=304897&view=rev
Log:
[CodeGen] Add thumb-mode to target-features for arm/thumb triples.
Summary:
The thumb-mode target feature is used to force Thumb or ARM code
generation on a per-func
xazax.hun updated this revision to Diff 101695.
xazax.hun edited the summary of this revision.
xazax.hun added a comment.
- Migrate to use USR instead of mangled names. Name mangling related changes
are reverted.
- Better error handling in some cases.
- File paths containing spaces are now handle
Author: dim
Date: Wed Jun 7 07:05:41 2017
New Revision: 304899
URL: http://llvm.org/viewvc/llvm-project?rev=304899&view=rev
Log:
Only print registered targets for `--version`
Summary:
In D33900, I added printing of the registered targets in clang's
`PrintVersion` function, which is not only used
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304899: Only print registered targets for `--version`
(authored by dim).
Changed prior to commit:
https://reviews.llvm.org/D33981?vs=101690&id=101697#toc
Repository:
rL LLVM
https://reviews.llvm.org
xazax.hun marked 2 inline comments as done.
xazax.hun added a comment.
In https://reviews.llvm.org/D30691#731617, @zaks.anna wrote:
> I agree that scan-build or scan-build-py integration is an important issue to
> resolve here. What I envision is that users will just call scan-build and
> pass
hintonda updated this revision to Diff 101708.
hintonda added a comment.
- Rollback to previous version: rebased + r293218 and r293234.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptC
hintonda added a comment.
Unfortunately, the logs are no longer available, and I don't have copies.
However, I think I know what's going on, so I'll try to submit a fix later
today.
https://reviews.llvm.org/D20693
___
cfe-commits mailing list
cfe-
Author: mprobst
Date: Wed Jun 7 07:53:22 2017
New Revision: 304904
URL: http://llvm.org/viewvc/llvm-project?rev=304904&view=rev
Log:
clang-format: [JS] recognize exported type definitions.
Summary: Support "export type T = {...};", in addition to just "type T =
{...};".
Reviewers: klimek
Diff
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: lib/Format/WhitespaceManager.cpp:112
+assert(PreviousOriginalWhitespaceEndOffset <=
OriginalWhitespaceStartOffset);
+StringRef Text(SourceMgr.getChara
svenvh created this revision.
Generalize getOpenCLImageAddrSpace into getOpenCLTypeAddrSpace, such
that targets can select the address space per type.
No functional changes intended. In particular, this is already
covered by test/CodeGenOpenCL/opencl_types.cl .
Patch by Simon Perretta.
https:
hintonda updated this revision to Diff 101722.
hintonda added a comment.
- Only pass %2 parameter if %2 is included in format.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cp
joerg added a comment.
Actually, for NetBSD we want to use -fomit-frame-pointer by default whenever
the implicit -funwind-tables is also present. In general, that should be the
justification for the default behavior: "Can I reliably unwind a binary with
the available information?" Performance o
sberg added a comment.
Just a heads up that I ran into an arguably somewhat unexpected instance of
this with (a copy of the Graphite project included in) LibreOffice, see the
commit message of
https://cgit.freedesktop.org/libreoffice/core/commit/?id=681b4a49d797996229513d3e842d2a431030730a
"ex
joerg added a comment.
In https://reviews.llvm.org/D33726#774105, @ruiu wrote:
> I'm totally against adding per-OS path knowledge to our linker. Compilers
> already know include paths and I don't want to maintain another list of paths
> in the linker. Also this can be more confusing than useful
krasimir updated this revision to Diff 101734.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D33982
Files:
lib/Format/WhitespaceManager.cpp
unittests/Format/FormatTestComments.cpp
Index: unittests/Format/FormatTestComments.cpp
===
Author: krasimir
Date: Wed Jun 7 09:05:06 2017
New Revision: 304912
URL: http://llvm.org/viewvc/llvm-project?rev=304912&view=rev
Log:
[clang-format] Fix alignment of preprocessor trailing comments
Summary:
This patch is a follow-up of https://reviews.llvm.org/rL304687, which fixed an
overflow in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304912: [clang-format] Fix alignment of preprocessor
trailing comments (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D33982?vs=101734&id=101736#toc
Repository:
rL LLVM
ht
aaron.ballman added inline comments.
Comment at: include/clang/AST/Decl.h:901
+/// member functions.
+unsigned ImplicitParamKind : 3;
};
It's a bit strange to me that the non-parameter declaration bits now have a
field for implicit parameter informati
ABataev added inline comments.
Comment at: include/clang/AST/Decl.h:901
+/// member functions.
+unsigned ImplicitParamKind : 3;
};
aaron.ballman wrote:
> It's a bit strange to me that the non-parameter declaration bits now have a
> field for implicit
aaron.ballman added inline comments.
Comment at: include/clang/AST/Decl.h:901
+/// member functions.
+unsigned ImplicitParamKind : 3;
};
ABataev wrote:
> aaron.ballman wrote:
> > It's a bit strange to me that the non-parameter declaration bits now have
ABataev added inline comments.
Comment at: include/clang/AST/Decl.h:901
+/// member functions.
+unsigned ImplicitParamKind : 3;
};
aaron.ballman wrote:
> ABataev wrote:
> > aaron.ballman wrote:
> > > It's a bit strange to me that the non-parameter decl
alexfh added a comment.
In https://reviews.llvm.org/D20693#775014, @hintonda wrote:
> - Only pass %2 parameter if %2 is included in format.
I thought, DiagnosticsBuilder handles placeholders in conditional parts
correctly. Did you find an evidence of the opposite? Can you add a test that
cons
alexfh added a comment.
In https://reviews.llvm.org/D20693#775153, @alexfh wrote:
> In https://reviews.llvm.org/D20693#775014, @hintonda wrote:
>
> > - Only pass %2 parameter if %2 is included in format.
>
>
> I thought, DiagnosticsBuilder handles placeholders in conditional parts
> correctly. D
regehr added a comment.
I'm taking a look. For reference here's the test program I'm using.
#include
typedef struct {
int x[2];
} T;
int main(void) {
T f;
T *p = &f;
ptrdiff_t d = -3293184;
p += d / sizeof(T);
return 0;
}
Repository:
rL LLVM
https://r
Sure thing. I'll expand the test to verify that frontend emit expected IR
for this case.
Thank you for the feedback
On Mon, Jun 5, 2017 at 9:58 AM, David Blaikie wrote:
>
>
> On Wed, May 31, 2017 at 5:45 PM Gor Nishanov via Phabricator via
> cfe-commits wrote:
>
>> GorNishanov created this revi
regehr added a comment.
Sorry, let's go with this example instead, which makes it clear that the
program is attempting to do something completely sensible:
#include
typedef struct {
int x[2];
} T;
int main(void) {
T f[1000];
T *p = &f[500];
ptrdiff_t d = -10;
p
hintonda added a comment.
I have not, as yet, been able to reproduce the buildbot failures. They were
essentially intermittent seg-faults, and corrupt diag output.
I will work on creating a test that can reproduce the problem.
https://reviews.llvm.org/D20693
___
ABataev updated this revision to Diff 101751.
ABataev added a comment.
Update after review
https://reviews.llvm.org/D33735
Files:
include/clang/AST/Decl.h
lib/AST/ASTImporter.cpp
lib/AST/Decl.cpp
lib/AST/DeclObjC.cpp
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGCXXABI.cpp
lib/CodeGen/CG
arphaman added inline comments.
Comment at: include/clang/Frontend/ASTUnit.h:192
+ /// of that loading
+ std::map SrcLocCache;
+
You can use an `llvm::StringMap` instead.
Comment at: lib/Frontend/ASTUnit.cpp:1152
+ else
+SrcLocCache.clea
mclow.lists created this revision.
There are versions of `reduce` and `transform_reduce` that take an execution
policy, and those that do not.
This implements the ones that do not.
https://reviews.llvm.org/D33997
Files:
include/numeric
test/std/numerics/numeric.ops/reduce/reduce_iter_iter.
mclow.lists added inline comments.
Comment at: include/numeric:98
#include // for numeric_limits
+#include
I don't like adding this dependency; but the standard requires the use of
`std::plus` and `std::multiplies`
https://reviews.llvm.org/D33997
_
regehr added a comment.
Well, my second program should subtract a multiple of sizeof(T). But anyway, my
view is that this is a real overflow and a nasty consequence of the unsigned
size_t and the usual arithmetic conversions and I don't think we want to try to
poke a hole in UBSan to allow this
mclow.lists closed this revision.
mclow.lists added a comment.
Landed as r300123
https://reviews.llvm.org/D31956
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added a comment.
In https://reviews.llvm.org/D33304#771493, @alexfh wrote:
> IIUC, these checks enforce a certain - Android-specific - way of using POSIX
> APIs. I'm not sure if the recommendations are universally useful. Or am I
> mistaken?
OK, that makes sense. I may miss some backgr
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: petarj
Date: Wed Jun 7 12:17:57 2017
New Revision: 304929
URL: http://llvm.org/viewvc/llvm-project?rev=304929&view=rev
Log:
[mips] Add runtime options to enable/disable madd.fmt and msub.fmt
Add options to clang: -mmadd4 and -mno-madd4, use it to enable or disable
generation of madd.fmt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304929: [mips] Add runtime options to enable/disable
madd.fmt and msub.fmt (authored by petarj).
Changed prior to commit:
https://reviews.llvm.org/D33401?vs=101562&id=101767#toc
Repository:
rL LLVM
Author: yawanng
Date: Wed Jun 7 12:41:59 2017
New Revision: 304931
URL: http://llvm.org/viewvc/llvm-project?rev=304931&view=rev
Log:
[clang-tidy] When" -fno-exceptions is used", this warning is better to be
suppressed.
Summary: clang-tidy is better not to issues this warning, which checks wher
yvvan added inline comments.
Comment at: include/clang/Frontend/ASTUnit.h:192
+ /// of that loading
+ std::map SrcLocCache;
+
arphaman wrote:
> You can use an `llvm::StringMap` instead.
I will change that
Comment at: lib/Frontend/ASTUnit.cpp:
chh added a comment.
LGTM, leave this to alexfh's approval.
Repository:
rL LLVM
https://reviews.llvm.org/D34002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from one minor nit, LGTM
Comment at: clang-tidy/misc/NoexceptMoveConstructorCheck.cpp:23
// provide any benefit to other languages, despite being benig
Author: petarj
Date: Wed Jun 7 13:57:56 2017
New Revision: 304935
URL: http://llvm.org/viewvc/llvm-project?rev=304935&view=rev
Log:
Revert r304929 [mips] Add runtime options to enable/disable madd/sub.fmt
Revert r304929 since the test broke buildbots.
Original commit:
[mips] Add runtime opti
rdwampler updated this revision to Diff 101787.
rdwampler marked 6 inline comments as done.
rdwampler added a comment.
This should resolve the bug (a conditional was inverted) in the last revision
along with the other changes requested.
https://reviews.llvm.org/D33478
Files:
test/Index/avail
mclow.lists created this revision.
Like https://reviews.llvm.org/D33997, this implements the non-parallel versions
of these algorithms
https://reviews.llvm.org/D33997 implemented `reduce` and `transform_reduce`,
this adds `inclusive_scan` and `transform_inclusive_scan`.
There will be another p
alexfh added a comment.
In https://reviews.llvm.org/D20693#775197, @hintonda wrote:
> I have not, as yet, been able to reproduce the buildbot failures. They were
> essentially intermittent seg-faults, and corrupt diag output.
>
> I will work on creating a test that can reproduce the problem.
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: docs/clang-tidy/checks/readability-redundant-keyword.rst:8
+
+`extern` is redundant in function declarations
+
Could you explain, w
You've left an empty file in test/CodeGen/mips-madd4.c
On Wed, Jun 7, 2017 at 11:57 AM, Petar Jovanovic via cfe-commits
wrote:
> Author: petarj
> Date: Wed Jun 7 13:57:56 2017
> New Revision: 304935
>
> URL: http://llvm.org/viewvc/llvm-project?rev=304935&view=rev
> Log:
> Revert r304929 [mips] A
kevinoid created this revision.
Add --cached option to git-clang-format which behaves analogously to the
use of --cached for other git subcommands, by causing the operation to
work against the index state rather than the working directory state.
This can be particularly useful for hook scripts wh
kevinoid abandoned this revision.
kevinoid added a comment.
Meant to update diff for https://reviews.llvm.org/D33944. My mistake. Closing.
https://reviews.llvm.org/D34010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
kevinoid updated this revision to Diff 101799.
kevinoid added a comment.
Fixed handling of case when no formatting changes are made but `old_tree !=
new_tree` in `apply_changes`.
https://reviews.llvm.org/D33944
Files:
tools/clang-format/git-clang-format
Index: tools/clang-format/git-clang-f
Author: sdardis
Date: Wed Jun 7 15:02:24 2017
New Revision: 304936
URL: http://llvm.org/viewvc/llvm-project?rev=304936&view=rev
Log:
Finish revert of "r304929, [mips] Add runtime options to enable/disable
madd/sub.fmt"
The r304935 missed deleting the test case.
Removed:
cfe/trunk/test/Cod
mclow.lists added a comment.
Re-reading this, I may have implemented `exclusive_scan` instead of
`inclusive_scan` here.
https://reviews.llvm.org/D34007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
arphaman added inline comments.
Comment at: lib/Frontend/ASTUnit.cpp:1152
+ else
+SrcLocCache.clear();
yvvan wrote:
> arphaman wrote:
> > Why is `clear` in an `else` here? We always create a new `SourceManager` in
> > this function, so the previously cach
Appears to be fixed, r304936. I'll keep an eye on the buildbots.
Thanks,
Simon
From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Evgenii
Stepanov via cfe-commits [cfe-commits@lists.llvm.org]
Sent: 07 June 2017 20:53
To: Petar Jovanovic
Cc
Anastasia added a comment.
Sam, do you think you have some time to look at this change? Thanks!
https://reviews.llvm.org/D33598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D33681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: ericwf
Date: Wed Jun 7 15:47:42 2017
New Revision: 304942
URL: http://llvm.org/viewvc/llvm-project?rev=304942&view=rev
Log:
Fix compile error with Bionic's PTHREAD_MUTEX_INITIALIZER
On Bionic PTHREAD_MUTEX_INITIALIZER contains the expression " &
",
which causes ADL to perform name looku
arphaman added a comment.
This looks better, it's almost ready. A couple of small requests:
Comment at: tools/libclang/CIndex.cpp:7262
+LHS->getMessage() == RHS->getMessage() &&
+LHS->getReplacement() == RHS->getReplacement())
+ return true;
---
Lekensteyn updated this revision to Diff 101816.
Lekensteyn marked 8 inline comments as done.
Lekensteyn added a comment.
diff from previous version:
diff --git a/include/clang/ASTMatchers/Dynamic/Parser.h
b/include/clang/ASTMatchers/Dynamic/Parser.h
index 0d0c2ba540..5ec4a9abf4 100644
---
Lekensteyn added a comment.
Rebased patches on latest clang master (trunk), there were no changes in
ASTMatchers.
boolean literal patch was unchanged, this floating literal patch was updated to
address comments.
Comment at: include/clang/ASTMatchers/Dynamic/VariantValue.h:335
Lekensteyn updated this revision to Diff 101817.
Lekensteyn marked 7 inline comments as done.
Lekensteyn added a comment.
diff from previous patch:
diff --git a/unittests/ASTMatchers/Dynamic/RegistryTest.cpp
b/unittests/ASTMatchers/Dynamic/RegistryTest.cpp
index 29fcdec6c1..84e31f721a 100644
Lekensteyn added inline comments.
Comment at: unittests/ASTMatchers/Dynamic/RegistryTest.cpp:545
+ .getTypedMatcher();
+ EXPECT_TRUE(matches("int x = 'x';", CharStmt));
+ EXPECT_FALSE(matches("int x = 120;", CharStmt));
Lekensteyn wrote:
> aaron.ballman wr
Author: rsmith
Date: Wed Jun 7 16:46:22 2017
New Revision: 304946
URL: http://llvm.org/viewvc/llvm-project?rev=304946&view=rev
Log:
[c++1z] Support deducing B in noexcept(B).
This is not required by the standard (yet), but there seems to be reasonable
support for this being a defect according to
hintonda updated this revision to Diff 101819.
hintonda added a comment.
- Rollback last change.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseNoex
[... excuse the necromancy...]
Hi Albert (and Reid and David),
This commit is breaking some uses of -fms-extensions on Apple platforms. In
particular, Brian and Erik (CC'ed) build against a version of the Windows SDK
on Apple platforms. _BitScanReverse is expected to be 32-bit, matching
Wind
yawanng updated this revision to Diff 101831.
yawanng marked an inline comment as done.
https://reviews.llvm.org/D33304
Files:
clang-tidy/CMakeLists.txt
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/FileOpenFlagCheck.cpp
clang-tidy/android
rjmccall added inline comments.
Comment at: include/clang/AST/Decl.h:1387
+IPK_CapturedContext, /// Parameter for captured context
+IPK_GeneralParam,/// General implicit parameter
+ };
ABataev wrote:
> rjmccall wrote:
> > I would just call this "Othe
yawanng updated this revision to Diff 101834.
yawanng marked an inline comment as done.
https://reviews.llvm.org/D34002
Files:
clang-tidy/misc/NoexceptMoveConstructorCheck.cpp
test/clang-tidy/misc-noexcept-move-constructor.cpp
Index: test/clang-tidy/misc-noexcept-move-constructor.cpp
==
mclow.lists abandoned this revision.
mclow.lists added a comment.
I don't think that this is a correct implementation. Also, I need tests for
when the result overwrites the source.
As they say .. I'll be back :-)
https://reviews.llvm.org/D34007
___
Author: rjmccall
Date: Wed Jun 7 18:00:05 2017
New Revision: 304951
URL: http://llvm.org/viewvc/llvm-project?rev=304951&view=rev
Log:
When determining the target function of an explicit instantiation, make
sure that non-template functions don't end up in the candidate set.
Fixes PR14211.
Patch
rjmccall added a comment.
Sure thing, r304951.
https://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Just ran asan on linux and we have a heap-use-after-free in the std::string
ctor.
Here's a partial stack dump:
4980==ERROR: AddressSanitizer: heap-use-after-free on address 0x60424328 at
pc 0x0057ad32 bp 0x7ffd240a7f50 sp 0x7ffd240a7700
---
hintonda added a comment.
btw, here's how I built it, in case that matters...
CC=../../4.0.0/build/Release/bin/clang
CXX=../../4.0.0/build/Release/bin/clang++ \
cmake ../../llvm/ \
-GNinja \
-DLLVM_USE_SANITIZER=Address \
-DCMAKE_BUILD_TYPE=Debug \
-DLLVM_TARGETS_TO_BUILD="X86" \
-DLLVM_P
Author: petarj
Date: Wed Jun 7 18:51:52 2017
New Revision: 304953
URL: http://llvm.org/viewvc/llvm-project?rev=304953&view=rev
Log:
Reapply r304929 [mips] Add runtime options to enable/disable madd/sub.fmt
The test in r304929 broke multiple buildbots as it expected mips target to
be registered a
krytarowski created this revision.
This adds support for __float128 from GNU libstdc++ with Clang on NetBSD
x86/x86_64 targets.
This corrects compilation at least of CMake and probably others like Firefox.
In file included from
/tmp/pkgsrc-tmp/devel/cmake/work/cmake-3.8.2/Source/kwsys/Director
I reverted the patch too quickly and have not noticed the file was not
actually deleted. I am reapplying the patch with minor modifications now,
hopefully no issues this time.
Thanks.
Regards,
Petar
From: Simon Dardis
Sent: Wednesday, June 07, 2017 10:36 P
rdwampler marked an inline comment as done.
rdwampler added inline comments.
Comment at: test/Index/availability.c:20
// CHECK-2: (macos, introduced=10.4, deprecated=10.5, obsoleted=10.7)
// CHECK-2: EnumConstantDecl=old_enum:6:3 (Definition) (deprecated)
Can
Author: ericwf
Date: Wed Jun 7 19:38:56 2017
New Revision: 304955
URL: http://llvm.org/viewvc/llvm-project?rev=304955&view=rev
Log:
Fix class template deduction for scoped_lock.
r304862 changed how CTD handles deducing a non-primary class template
using a non-dependent constructor of the primary
Author: rtrieu
Date: Wed Jun 7 19:56:21 2017
New Revision: 304956
URL: http://llvm.org/viewvc/llvm-project?rev=304956&view=rev
Log:
[ODRHash] Change the fall-back diagnostic error.
Provide a little more information when a ODR violation is detected, but the
specific error could not be diagnosed.
1 - 100 of 123 matches
Mail list logo
