[PATCH] D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls.

2017-06-02 Thread Jorge Gorbe via Phabricator via cfe-commits
jgorbe added a comment. Ping? https://reviews.llvm.org/D30963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r304617 - Fix some undefined behavior in __hash_table. Thanks to vsk for the report and the patch. Reviewed as https://reviews.llvm.org/D33588.

2017-06-02 Thread Marshall Clow via cfe-commits
Author: marshall Date: Fri Jun 2 19:08:32 2017 New Revision: 304617 URL: http://llvm.org/viewvc/llvm-project?rev=304617&view=rev Log: Fix some undefined behavior in __hash_table. Thanks to vsk for the report and the patch. Reviewed as https://reviews.llvm.org/D33588. Added: libcxx/trunk/tes

[PATCH] D33588: Fix two sources of UB in __next_hash_pow2 (from __hash_table)

2017-06-02 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists accepted this revision. mclow.lists added inline comments. This revision is now accepted and ready to land. Comment at: include/__hash_table:140 +return (__n > 1) ? (size_t(1) << (std::numeric_limits::digits - __clz(__n-1))) : __n; } I turned

r304618 - Revert r304592

2017-06-02 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Fri Jun 2 19:11:23 2017 New Revision: 304618 URL: http://llvm.org/viewvc/llvm-project?rev=304618&view=rev Log: Revert r304592 r304592 - [ODRHash] Add support for TemplateArgument types. Possibly causing one of the errors in modules build bot. Modified: cfe/trunk/lib/AST

[PATCH] D33797: [coroutines] Fix rebuilding of dependent coroutine parameters

2017-06-02 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:1285 + // We needed to check it, but we don't need to generate code for it. + if (!paramDecl->getIdentifier()) +continue; rsmith wrote: > EricWF wrote: > > @rsmith Is there a b

r304620 - [coroutines] Fix rebuilding of dependent coroutine parameters

2017-06-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jun 2 19:22:18 2017 New Revision: 304620 URL: http://llvm.org/viewvc/llvm-project?rev=304620&view=rev Log: [coroutines] Fix rebuilding of dependent coroutine parameters Summary: We were not handling correctly rebuilding of parameter and were not creating copies for them

Buildbot numbers for the week of 05/14/2017 - 05/20/2017

2017-06-02 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 05/14/2017 - 05/20/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the last week of 05/21/2017 - 05/27/2017

2017-06-02 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the last week of 05/21/2017 - 05/27/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

[PATCH] D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls.

2017-06-02 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: lib/Sema/SemaLookup.cpp:3792-3793 static void checkCorrectionVisibility(Sema &SemaRef, TypoCorrection &TC) { if (TC.begin() == TC.end()) return; Do we need to clear the flag on this path too? (This might happen

[PATCH] D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls.

2017-06-02 Thread Jorge Gorbe via Phabricator via cfe-commits
jgorbe updated this revision to Diff 101302. jgorbe added a comment. Also clear the 'requires import' flag when the TypoCorrection has no decls at all. https://reviews.llvm.org/D30963 Files: lib/Sema/SemaLookup.cpp test/Modules/Inputs/crash-typo-correction-visibility/module.h test/Module

[PATCH] D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls.

2017-06-02 Thread Jorge Gorbe via Phabricator via cfe-commits
jgorbe added inline comments. Comment at: lib/Sema/SemaLookup.cpp:3792-3793 static void checkCorrectionVisibility(Sema &SemaRef, TypoCorrection &TC) { if (TC.begin() == TC.end()) return; rsmith wrote: > Do we need to clear the flag on this path too? (T

[libcxx] r304629 - Fix the recently introduced test to work on C++03

2017-06-02 Thread Marshall Clow via cfe-commits
Author: marshall Date: Fri Jun 2 20:21:29 2017 New Revision: 304629 URL: http://llvm.org/viewvc/llvm-project?rev=304629&view=rev Log: Fix the recently introduced test to work on C++03 Modified: libcxx/trunk/test/libcxx/containers/unord/next_pow2.pass.cpp Modified: libcxx/trunk/test/libcxx/c

r304631 - [sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. (clang part)

2017-06-02 Thread Kostya Serebryany via cfe-commits
Author: kcc Date: Fri Jun 2 20:36:23 2017 New Revision: 304631 URL: http://llvm.org/viewvc/llvm-project?rev=304631&view=rev Log: [sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. (clang part) Modified: cfe/

[PATCH] D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls.

2017-06-02 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaLookup.cpp:3792-3793 static void checkCorrectionVisibility(Sema &SemaRef, TypoCorrection &TC) { if (TC.begin() == TC.end()) return; --

[PATCH] D32111: [modules] Attempt to fix PR31905 - #include "stddef.h" breaks module map search paths; causes redefinitions.

2017-06-02 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 101307. EricWF edited the summary of this revision. EricWF added reviewers: rtrieu, dexonsmith, dblaikie, aprantl, v.g.vassilev. EricWF added a comment. - Only allow the top level header search directories to be search for `module.modulemap` files when loadin

r304640 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:23:19 2017 New Revision: 304640 URL: http://llvm.org/viewvc/llvm-project?rev=304640&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/ARCMigrate/TransRetainReleaseDealloc.cpp cfe/tr

r304641 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:23:51 2017 New Revision: 304641 URL: http://llvm.org/viewvc/llvm-project?rev=304641&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Analysis/PrintfFormatString.cpp cfe/trunk/lib/A

r304643 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:25:47 2017 New Revision: 304643 URL: http://llvm.org/viewvc/llvm-project?rev=304643&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Lex/Lexer.cpp Modified: cfe/trunk/lib/Lex/Lexer.cp

r304642 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through + formatted. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:25:29 2017 New Revision: 304642 URL: http://llvm.org/viewvc/llvm-project?rev=304642&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through + formatted. NFC. Modified: cfe/trunk/lib/Lex/LiteralSupport.cpp Modified: cfe/

r304644 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:26:27 2017 New Revision: 304644 URL: http://llvm.org/viewvc/llvm-project?rev=304644&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp c

r304645 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:27:16 2017 New Revision: 304645 URL: http://llvm.org/viewvc/llvm-project?rev=304645&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Frontend/CompilerInstance.cpp cfe/trunk/lib/Fro

r304646 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:29:16 2017 New Revision: 304646 URL: http://llvm.org/viewvc/llvm-project?rev=304646&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/Parser.cpp Modified: cfe/trunk/lib/Parse/Par

r304647 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:29:40 2017 New Revision: 304647 URL: http://llvm.org/viewvc/llvm-project?rev=304647&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Rewrite/HTMLRewrite.cpp Modified: cfe/trunk/lib/Re

r304648 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:30:08 2017 New Revision: 304648 URL: http://llvm.org/viewvc/llvm-project?rev=304648&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Edit/RewriteObjCFoundationAPI.cpp Modified: cfe/tr

r304649 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:30:46 2017 New Revision: 304649 URL: http://llvm.org/viewvc/llvm-project?rev=304649&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/lib/CodeGen/CGC

r304650 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:31:42 2017 New Revision: 304650 URL: http://llvm.org/viewvc/llvm-project?rev=304650&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/AST/ASTDiagnos

r304651 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:35:06 2017 New Revision: 304651 URL: http://llvm.org/viewvc/llvm-project?rev=304651&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp cfe/trunk/lib/Sema/Se

r304652 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:38:22 2017 New Revision: 304652 URL: http://llvm.org/viewvc/llvm-project?rev=304652&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Basic/TargetInfo.cpp Modified: cfe/trunk/lib/Basic

r304653 - Added missing break.

2017-06-02 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:40:10 2017 New Revision: 304653 URL: http://llvm.org/viewvc/llvm-project?rev=304653&view=rev Log: Added missing break. Modified: cfe/trunk/lib/Basic/IdentifierTable.cpp Modified: cfe/trunk/lib/Basic/IdentifierTable.cpp URL: http://llvm.org/viewvc/llvm-

<    1   2