[libcxx] r304487 - [test] Allow non-libc++ coroutine_handle::done to strengthen noexcept

Author: caseycarter Date: Thu Jun 1 17:40:16 2017 New Revision: 304487 URL: http://llvm.org/viewvc/llvm-project?rev=304487&view=rev Log: [test] Allow non-libc++ coroutine_handle::done to strengthen noexcept Modified: libcxx/trunk/test/std/experimental/language.support/support.coroutines/cor

[PATCH] D33692: [ThinLTO] Wire up ThinLTO and new PM

This revision was automatically updated to reflect the committed changes. Closed by commit rL304496: [ThinLTO] Wire up ThinLTO and new PM (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D33692?vs=101106&id=101135#toc Repository: rL LLVM https://reviews.llvm.org/D336

r304496 - [ThinLTO] Wire up ThinLTO and new PM

Author: timshen Date: Thu Jun 1 18:27:51 2017 New Revision: 304496 URL: http://llvm.org/viewvc/llvm-project?rev=304496&view=rev Log: [ThinLTO] Wire up ThinLTO and new PM Summary: This patch teaches clang to use and propagate new PM in ThinLTO. Reviewers: davide, chandlerc, tejohnson Subscriber

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

bruno added a comment. Hi Richard, Thanks for improving this further! Questions / comments: - I've noticed in the patch that on the ASTWriter side we serialize the introduced size / mtime, but there are no changes to the ASTReader, so I assume in the reader side you still need the module map

r304499 - [CodeGen] Surround assertion with parentheses.

Author: davide Date: Thu Jun 1 18:55:18 2017 New Revision: 304499 URL: http://llvm.org/viewvc/llvm-project?rev=304499&view=rev Log: [CodeGen] Surround assertion with parentheses. This should placate GCC's -Wparentheses. Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp Modified: cfe/trunk/l

[PATCH] D33108: Generate extra .ll files before/after optimization when using -save-temps.

jgorbe added inline comments. Comment at: lib/Driver/Driver.cpp:2603-2614 + // lipo-able. + if (!MultiArchUniversalBuild) { +if (isSaveTempsEnabled() && Phase == phases::Compile) { + Actions.push_back( + C.MakeAction(Current, types::TY_LLVM

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

rsmith added a comment. In https://reviews.llvm.org/D33703#770896, @bruno wrote: > - I've noticed in the patch that on the ASTWriter side we serialize the > introduced size / mtime, but there are no changes to the ASTReader, so I > assume in the reader side you still need the module map around

r304501 - [ThinLTO] Add x86 requires to thin_link_bitcode. NFC.

Author: timshen Date: Thu Jun 1 19:08:58 2017 New Revision: 304501 URL: http://llvm.org/viewvc/llvm-project?rev=304501&view=rev Log: [ThinLTO] Add x86 requires to thin_link_bitcode. NFC. It already specifies the triples, so the intention was to test x86 for now (or then). Differential Revision:

[PATCH] D33706: CodeGen: Cast temporary variable to proper address space

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3805 +Address Addr = +CreateMemTemp(I->Ty, ArgInfo.getIndirectAlign(), "tmp", false); IRCallArgs[FirstIRArg] = Addr.getPointer(); How about "indirect-arg-temp" as the

Re: r304376 - PR33232: implement support for MSVC's __is_trivially_destructible trait.

On 31 May 2017 at 17:41, Eric Fiselier wrote: > I'm assuming libc++ should move to this trait instead? > Yes, that'd be a good idea. Though now that you mention it, I'm not sure we have a good feature detection story for these builtins. Looks like a bunch of the existing ones are (oddly) covered

[PATCH] D32520: Support __fp16 vectors

bruno added a comment. Hi Akira, This is nice, thanks for doing it! Comment at: include/clang/Sema/Sema.h:9270 + QualType RHSType, + bool CompAssign = false); Can you

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

It crashes when there is an anonymous ivar of a bitfield type. @interface FormatScanner { int : 1; } @end @implementation FormatScanner @end I'm not sure if the code above is valid or not, but out of curiosity, why would you want an anonymous bitfield variable? > On Jun 1, 2017, at 11:33 AM,

r304506 - PR32848: There isn't necessarily a FileChanged or FileSkipped for every InclusionDirective callback.

Author: rsmith Date: Thu Jun 1 20:05:44 2017 New Revision: 304506 URL: http://llvm.org/viewvc/llvm-project?rev=304506&view=rev Log: PR32848: There isn't necessarily a FileChanged or FileSkipped for every InclusionDirective callback. In particular, you don't get one if the inclusion directive en

r304507 - [Sema] Improve -Wstrict-prototypes diagnostic message for blocks.

Author: ahatanak Date: Thu Jun 1 20:07:08 2017 New Revision: 304507 URL: http://llvm.org/viewvc/llvm-project?rev=304507&view=rev Log: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks. Print "this block declaration is not a prototype" for non-prototype declarations of blocks inste

[PATCH] D33739: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL304507: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D33739?vs=100916&id=101155#toc Repository: rL LLVM

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington created this revision. This patch drops support for suppressing -Wunguarded-availability with redeclarations. This was behavior left over from the -Wpartial-availability days, where it was the only way of silencing the diagnostic. Now that we have @available and better support f

[PATCH] D33719: Add _Float16 as a C/C++ source language type

bruno added a comment. Hi Sjoerd, Thanks for working on this. Can you add context to your patch? Comment at: test/CodeGenCXX/float16-declarations-error.cpp:1 +// RUN: not %clang -S -emit-llvm --target=aarch64 %s -o - 2>&1 | FileCheck %s --check-prefix=CHECK-ERROR + --

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

rsmith updated this revision to Diff 101157. rsmith marked an inline comment as done. rsmith added a comment. Rebased and added requested test. https://reviews.llvm.org/D33703 Files: docs/Modules.rst include/clang/Basic/DiagnosticLexKinds.td include/clang/Basic/DiagnosticSerializationKind

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D33703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D33788: Return a canonical path from getClangResourcePath()

bruno added a reviewer: bruno. bruno added a comment. Hi Aaron, Nice catch! Any chance you can add a testcase to this? https://reviews.llvm.org/D33788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

r304515 - Support lazy stat'ing of files referenced by module maps.

Author: rsmith Date: Thu Jun 1 20:55:39 2017 New Revision: 304515 URL: http://llvm.org/viewvc/llvm-project?rev=304515&view=rev Log: Support lazy stat'ing of files referenced by module maps. This patch adds support for a `header` declaration in a module map to specify certain `stat` information (

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

This revision was automatically updated to reflect the committed changes. Closed by commit rL304515: Support lazy stat'ing of files referenced by module maps. (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D33703?vs=101157&id=101162#toc Repository: rL LLVM https://r

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

compnerd added inline comments. Comment at: test/Driver/linux-ld.c:467-471 +// RUN: %clang %s -### -o %t.o 2>&1 --target=x86_64-everest-linux +// RUN: %clang %s -### -o %t.o 2>&1 --target=x86_64-pure64-linux +// RUN: %clang %s -### -o %t.o 2>&1 --target=i686-isoft-linux +// RUN:

r304519 - Minor fixes to for-loop warning.

Author: rtrieu Date: Thu Jun 1 23:24:46 2017 New Revision: 304519 URL: http://llvm.org/viewvc/llvm-project?rev=304519&view=rev Log: Minor fixes to for-loop warning. The warning for unchanged loop variables outputted a diagnostic that was dependent on iteration order from a pointer set, which is

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 updated this revision to Diff 101167. jyu2 marked an inline comment as done. jyu2 added a comment. Update to address review comments. https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp test/CXX/except/except.spec/p11.c

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 marked 8 inline comments as done. jyu2 added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:334 + continue; +else + HasThrowOutFunc = true; aaron.ballman wrote: > You can drop the `else` here and just set `HasThrowOutFunc` to t

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 added a comment. In https://reviews.llvm.org/D3#770238, @aaron.ballman wrote: > In https://reviews.llvm.org/D3#768332, @jyu2 wrote: > > > Okay this CFG version of this change. In this change I am basic using same > > algorithm with -Winfinite-recursion. > > > > In addition to my or

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 marked 12 inline comments as done. jyu2 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6341 +: Warning<"%0 has a non-throwing exception specification but can still " + "throw, may result in unexpected program termination.">, + In

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

nemanjai created this revision. This just adds the CPU to a list of commands passed to GAS when not using the integrated assembler. Repository: rL LLVM https://reviews.llvm.org/D33820 Files: lib/Driver/ToolChains/Arch/PPC.cpp lib/Driver/ToolChains/Arch/PPC.h lib/Driver/ToolChains/Gnu.

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

nemanjai updated this revision to Diff 101169. nemanjai added a comment. Initially, forgot to add a test case. Repository: rL LLVM https://reviews.llvm.org/D33820 Files: lib/Driver/ToolChains/Arch/PPC.cpp lib/Driver/ToolChains/Arch/PPC.h lib/Driver/ToolChains/Gnu.cpp test/Driver/linu

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

zaks.anna added a comment. These are great additions! Going back to my comment about adding these to CheckerContext, I think we should be adding helper functions as methods on CheckerContext as it is **the primary place where checker writers look for helpers**. Two of the three methods added t

<    1   2