arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks
https://reviews.llvm.org/D33661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
mprobst created this revision.
Herald added a subscriber: klimek.
calculateBraceTypes decides for braced init for empty brace pairs ({}). In
context of a function declaration, this incorrectly classifies empty function
or method bodies as braced inits, leading to missing wraps:
class C {
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Apart from fixme LG.
Comment at: lib/Format/UnwrappedLineParser.cpp:397
// blocks (for example while parsing lambdas).
+ // TODO(martinprobst): Some of th
mprobst updated this revision to Diff 100839.
mprobst added a comment.
TODO => FIXME
https://reviews.llvm.org/D33714
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
mprobst updated this revision to Diff 100840.
mprobst added a comment.
- restrict to JS, C++ actually wants this.
https://reviews.llvm.org/D33714
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
==
Author: mprobst
Date: Wed May 31 04:29:40 2017
New Revision: 304290
URL: http://llvm.org/viewvc/llvm-project?rev=304290&view=rev
Log:
clang-format: [JS] improve calculateBraceType heuristic
Summary:
calculateBraceTypes decides for braced init for empty brace pairs ({}).
In context of a function
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304290: clang-format: [JS] improve calculateBraceType
heuristic (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D33714?vs=100840&id=100841#toc
Repository:
rL LLVM
https://re
Typz added a comment.
That will be slightly more complicated to check, esp. we will need to keep
track of the matching-closing-brace (currently only the matching-opening-brace)
is stored.
But I can try to update the patch in that direction, if that is the consensus.
https://reviews.llvm.org/D3
dtemirbulatov added a comment.
> We should've asked this first: is that fold allowed in the default FPENV
> state that we assume that clang is operating in?
I suppose it is FE_ALL_EXCEPT.
https://reviews.llvm.org/D33406
___
cfe-commits mailing lis
javed.absar updated this revision to Diff 100846.
javed.absar added a comment.
Herald added a subscriber: kristof.beyls.
Thanks Roger for the review and the suggestion to add documentation in
LanguageExtensions.rst. I have done so now.
--Javed
https://reviews.llvm.org/D33412
Files:
docs/Lan
baloghadamsoftware updated this revision to Diff 100848.
baloghadamsoftware added a comment.
Rebased to (committed) Part1 (https://reviews.llvm.org/rL304160) and updated
according to comments.
https://reviews.llvm.org/D32642
Files:
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/Analy
baloghadamsoftware added a comment.
The matcher in https://reviews.llvm.org/D33537 could be reused here as well.
Maybe I should make it common, but it is more complex than any of the common
matchers.
Repository:
rL LLVM
https://reviews.llvm.org/D31370
baloghadamsoftware added a comment.
There is a patch (https://reviews.llvm.org/D33537) for a check which is a
superset of this: It does not only check for noexcept (and throw()) functions,
but also for destructors, move constructors, move assignments, the main()
function, swap() functions and a
SjoerdMeijer created this revision.
Herald added a subscriber: klimek.
This adds _Float16 as a source language type. As a first step, _Float16 behaves
the same as __fp16 and is thus an alias. This means that _Float16 also behaves
like a storage-only type. Subsequent patches will implement the pr
alexfh added a comment.
It's awesome to see another two checks, and it seems to justify adding a
separate module, but I'd prefer the other two checks to be sent for review as
separate patches to make the review easier and faster.
https://reviews.llvm.org/D33304
_
fhahn created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
This patch adds support for the target("arm") and target("thumb")
attributes, which can be used to force the compiler to generated ARM or
Thumb code for a function.
In LLVM, ARM or Thumb code generation c
rogfer01 added inline comments.
Comment at: include/clang-c/Index.h:3015
CXType_Half = 31,
+ CXType_Float16 = 30,
CXType_FirstBuiltin = CXType_Void,
This enumerator is the same as `CXType_Float128` above, is that intended?
https://reviews.llvm.org/D33719
SjoerdMeijer added inline comments.
Comment at: include/clang-c/Index.h:3015
CXType_Half = 31,
+ CXType_Float16 = 30,
CXType_FirstBuiltin = CXType_Void,
rogfer01 wrote:
> This enumerator is the same as `CXType_Float128` above, is that intended?
Ah, thanks,
szdominik created this revision.
Herald added a subscriber: mgorny.
Finds copy constructors where the constructor don't call
the constructor of the base class.
class X : public Copyable {
X(const X& other) {}; // Copyable(other) is missing
};
Also finds copy constructors where the bas
javed.absar added a comment.
Comment at: include/clang/Basic/Attr.td:1774
+
+// Convert GNU target names for arm and thumb to thumb-mode target
+// feature.
Would this be a more accurate comment:
"...arm and thumb to thumb-mode" => "arm and th
javed.absar added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:283
static const TST TST_double = clang::TST_double;
+ static const TST TST_Float16 = clang::TST_Float16;
static const TST TST_float128 = clang::TST_float128;
Any particular reaso
Author: alexfh
Date: Wed May 31 09:35:50 2017
New Revision: 304302
URL: http://llvm.org/viewvc/llvm-project?rev=304302&view=rev
Log:
Enable the ARM Neon intrinsics test by default.
The test being marked 'REQUIRES: long-tests' doesn't make sense. It's not the
first time the test is broken without
Author: rnk
Date: Wed May 31 09:50:28 2017
New Revision: 304303
URL: http://llvm.org/viewvc/llvm-project?rev=304303&view=rev
Log:
[clang-cl] Ignore /Zc:ternary, clang behaves this way already
Addresses part of PR33237
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/
SjoerdMeijer updated this revision to Diff 100866.
SjoerdMeijer added a comment.
Fixed typos 'TST_float16' and 'CXType_Float16 = 30', and have also added it to
a switch that I had missed.
https://reviews.llvm.org/D33719
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
includ
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Few questions, but address them as you see fit.
Comment at: utils/TableGen/ClangDiagnosticsEmitter.cpp:1280-1281
writeHeader((IsRemarkGroup ? "-R" : "-W") +
-
Author: rnk
Date: Wed May 31 10:39:28 2017
New Revision: 304305
URL: http://llvm.org/viewvc/llvm-project?rev=304305&view=rev
Log:
[clang-cl] Improve default calling convention flag handling
Ignore default CC flags that don't make sense for the target arch. This
is consistent with MSVC.
Addresses
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304306: [Sema][ObjC] Don't emit availability diags for
category @implementations (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D33661?vs=100645&id=100869#toc
Repository:
rL L
Author: epilk
Date: Wed May 31 10:45:57 2017
New Revision: 304306
URL: http://llvm.org/viewvc/llvm-project?rev=304306&view=rev
Log:
[Sema][ObjC] Don't emit availability diags for category @implementations
These diagnostics can't be disabled, and can't actually catch any bugs.
rdar://32427296
Dif
rogfer01 updated this revision to Diff 100868.
rogfer01 added a comment.
Fix formatting of tests.
Thanks for the review @aaron.ballman !
https://reviews.llvm.org/D33398
Files:
lib/AST/ItaniumMangle.cpp
test/CodeGenCXX/pr33080.cpp
test/CodeGenCXX/unaligned-duplicated-mangle-name.cpp
tes
Author: rnk
Date: Wed May 31 10:50:35 2017
New Revision: 304308
URL: http://llvm.org/viewvc/llvm-project?rev=304308&view=rev
Log:
Fix incorrect spelling of calling conv flag and add -Wno-msvc-not-found to test
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
cfe/trunk/test/Driver/cl-cc
sdardis requested changes to this revision.
sdardis added a comment.
This revision now requires changes to proceed.
This also requires that __mips_no_madd4 is defined when the -mnomadd4 option is
in use.
https://reviews.llvm.org/D33401
___
cfe-comm
atanasyan created this revision.
This patch builds and passes `-L` arguments to the linker in case of NetBSD
target. That makes possible to use LLD linker which does not have any built-in
per-OS paths configuration.
To do so the patch a) constructs paths to the library directories explicitly
w
fhahn updated this revision to Diff 100880.
fhahn added a comment.
reworded comment and improved test case to ensure only a single thumb-mode
attribute is added.
https://reviews.llvm.org/D33721
Files:
include/clang/Basic/Attr.td
test/CodeGen/arm-target-attr.c
Index: test/CodeGen/arm-targ
sbarzowski added a comment.
In https://reviews.llvm.org/D19201#768693, @baloghadamsoftware wrote:
> There is a patch (https://reviews.llvm.org/D33537) for a check which is a
> superset of this: [...] A more important difference is that we traverse the
> whole call-chain and check all the throw
krytarowski added a comment.
Looks great! I'm going to test it.
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D33698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
krytarowski added inline comments.
Comment at: lib/Driver/ToolChains/NetBSD.cpp:324
: Generic_ELF(D, Triple, Args) {
if (getDriver().UseStdLib) {
// When targeting a 32-bit platform, try the special directory used on
What's the rationale for this con
MatzeB accepted this revision.
MatzeB added a comment.
I assume you have checked that the tablegen output doesn't change. Apart from
that I'm all for more StringRef and SmallStrings or even Twines where possible.
So LGTM.
https://reviews.llvm.org/D33711
_
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/misc-undelegated-copy-of-base-classes.rst:29
+
+The checker suggests a FixItHint in every scenario including multiple
+missing initial
zaks.anna accepted this revision.
zaks.anna added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:1674
const Decl *D = CalleeLC->getDecl();
-addEdgeToPath(PD.getActivePath(), PrevLoc,
-
yawanng added a comment.
In https://reviews.llvm.org/D33304#768731, @alexfh wrote:
> It's awesome to see another two checks, and it seems to justify adding a
> separate module, but I'd prefer the other two checks to be sent for review as
> separate patches to make the review easier and faster.
Author: rnk
Date: Wed May 31 12:37:49 2017
New Revision: 304316
URL: http://llvm.org/viewvc/llvm-project?rev=304316&view=rev
Log:
[clang-cl] Implement /diagnostic: flag
This flag has three possible values: caret, column, and classic.
"caret" corresponds to clang's default mode, "column" removes
rnk added inline comments.
Comment at: lib/CodeGen/CGCleanup.cpp:458
InsertBefore = Invoke->getNormalDest()->getFirstInsertionPt();
+else if (isa(Inst))
+ InsertBefore = std::next(AllocaInsertPt->getIterator());
This doesn't seem right, `Inst` cou
alexfh added a comment.
In https://reviews.llvm.org/D33304#768961, @yawanng wrote:
> In https://reviews.llvm.org/D33304#768731, @alexfh wrote:
>
> > It's awesome to see another two checks, and it seems to justify adding a
> > separate module, but I'd prefer the other two checks to be sent for re
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D32604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Anastasia added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1107
assert(T.getAddressSpace() == LangAS::Default);
if (getASTAllocaAddressSpace() != LangAS::Default) {
auto *Addr = getTargetHooks().performAddrSpaceCast(
Is this code still needed
GorNishanov updated this revision to Diff 100889.
GorNishanov added a comment.
Make sure that we use AllocaInsertPt for only static allocas in the entry block
https://reviews.llvm.org/D33663
Files:
lib/CodeGen/CGCleanup.cpp
test/CodeGenCoroutines/coro-await-domination.cpp
Index: test/Code
efriedma added reviewers: t.p.northover, efriedma.
efriedma added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:569
+ if (Triple.getEnvironment() == llvm::Triple::EABI) {
+switch (Triple.getArch()) {
Specifically checking for "llvm::Triple::
sepavloff created this revision.
Bitwise complement applied to vector of floats described with
attribute `ext_vector_type` is not diagnosed as error. Attempt to
compile such construct causes assertion violation in Instruction.cpp.
With this change the complement is treated similar to the case of
v
beanz added a comment.
Is this really something we should be supporting? Building and testing clang
with potentially out-of-sync lit or gtest seems undesirable to me.
It is worth noting that we do have mods to gtest, so supporting any standard
distribution of it seems like a not great idea. The
szdominik updated this revision to Diff 100892.
szdominik added a comment.
Update with fixed docs.
https://reviews.llvm.org/D33722
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp
clang-tidy/misc/UndelegatedCo
GorNishanov added inline comments.
Comment at: lib/CodeGen/CGCleanup.cpp:458
InsertBefore = Invoke->getNormalDest()->getFirstInsertionPt();
+else if (isa(Inst))
+ InsertBefore = std::next(AllocaInsertPt->getIterator());
rnk wrote:
> This doesn't s
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
This all looks great. I'm really excited to have such a complete toolchain
build example in-tree. Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D32817
__
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1107
assert(T.getAddressSpace() == LangAS::Default);
if (getASTAllocaAddressSpace() != LangAS::Default) {
auto *Addr = getTargetHooks().performAddrSpaceCast(
-
GorNishanov created this revision.
This is a follow up for the https://reviews.llvm.org/rL297084 which made sure
that dominance is preserved during expression cleanup emission.
We ran into a case where dominance fixup code was inserting the store in the
middle of allocas.
%x = alloca i32, ali
krytarowski added a comment.
This works for me!
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 100899.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Remove redundant code.
https://reviews.llvm.org/D33706
Files:
lib/Basic/Targets.cpp
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFun
ABataev created this revision.
If the first parameter of the function is the ImplicitParamDecl codegen
automatically marks it as an implicit argument with `this` or `self`
pointer. To fix this problem Implicit ThisOrSelfAttr is added. This
attribute is used to mark real `this` or `self` pointers o
Author: davide
Date: Wed May 31 13:51:36 2017
New Revision: 304322
URL: http://llvm.org/viewvc/llvm-project?rev=304322&view=rev
Log:
[CodeGen] Surround assertion with parens and format.
This should placate GCC7 with -Werror.
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/tr
Author: ctopper
Date: Wed May 31 14:01:22 2017
New Revision: 304326
URL: http://llvm.org/viewvc/llvm-project?rev=304326&view=rev
Log:
[TableGen] Clang changes to support Record::getValueAsString and
getValueAsListOfStrings returning StringRef instead of std::string
This is the clang version of D
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304326: [TableGen] Clang changes to support
Record::getValueAsString and… (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D33711?vs=100826&id=100906#toc
Repository:
rL LLVM
rnk added inline comments.
Comment at: test/CodeGenCoroutines/coro-await-domination.cpp:33
+ int x = 42;
+ x = co_await A{};
+}
It looks like this is the expression in question. This expression should have
aggregate evaluation kind, not scalar. We don't need t
mgorny added a comment.
This is going to break Gentoo. We're relying on the ability to specify
LLVM_MAIN_SRC_DIR to provide unpacked LLVM sources with gtest. Without that, I
don't see how we can use tests.
https://reviews.llvm.org/D32595
___
cfe-c
mgorny added a comment.
(note that I don't mind removing the llvm-config bit for it; but we need the
cache variable to stay)
https://reviews.llvm.org/D32595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
JonasToth added a comment.
In https://reviews.llvm.org/D31370#768684, @baloghadamsoftware wrote:
> The matcher in https://reviews.llvm.org/D33537 could be reused here as well.
> Maybe I should make it common, but it is more complex than any of the common
> matchers.
yes, the matcher seems int
rnk added a comment.
This was filed as https://bugs.llvm.org/show_bug.cgi?id=33178
Isn't there a space in the mangling for vendor extensions? Can we use that here?
https://reviews.llvm.org/D33398
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Author: ericwf
Date: Wed May 31 14:36:59 2017
New Revision: 304331
URL: http://llvm.org/viewvc/llvm-project?rev=304331&view=rev
Log:
[coroutines] Fix assertion during -Wuninitialized analysis
Summary: @rsmith Is there a better place to put this test?
Reviewers: GorNishanov, rsmith
Reviewed By:
rsmith added a comment.
In https://reviews.llvm.org/D33398#769152, @rnk wrote:
> Isn't there a space in the mangling for vendor extensions? Can we use that
> here?
We are using that here: that's what `mangleVendorQualifier` does.
Comment at: lib/AST/ItaniumMangle.cpp:2210
+
tstellar added a comment.
In https://reviews.llvm.org/D32595#769044, @beanz wrote:
> Is this really something we should be supporting? Building and testing clang
> with potentially out-of-sync lit or gtest seems undesirable to me.
This is actually what this patch is trying to avoid. For exam
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:83
+
+ Finds copy constructors where the ctor don't call the constructor of the
base class.
+
I think will be good idea to replace ctor with constructor. Or re-phrase
sentence to avoid rep
rnk accepted this revision.
rnk added inline comments.
This revision is now accepted and ready to land.
Comment at: test/CodeGenCoroutines/coro-await-domination.cpp:33
+ int x = 42;
+ x = co_await A{};
+}
rnk wrote:
> It looks like this is the expression in que
Author: rnk
Date: Wed May 31 14:59:41 2017
New Revision: 304335
URL: http://llvm.org/viewvc/llvm-project?rev=304335&view=rev
Log:
Don't try to spill static allocas when emitting expr cleanups with branches
Credit goes to Gor Nishanov for putting together the fix in
https://reviews.llvm.org/D33733
Author: rnk
Date: Wed May 31 15:02:27 2017
New Revision: 304336
URL: http://llvm.org/viewvc/llvm-project?rev=304336&view=rev
Log:
Add test case for r304316 which implemented clang-cl /diagnostics:*
Added:
cfe/trunk/test/Driver/cl-diagnostics.c
Added: cfe/trunk/test/Driver/cl-diagnostics.c
UR
Author: rnk
Date: Wed May 31 15:07:36 2017
New Revision: 304337
URL: http://llvm.org/viewvc/llvm-project?rev=304337&view=rev
Log:
Fix cl-diagnostics.c test by hardcoding the version of MSVC to mimic
Modified:
cfe/trunk/test/Driver/cl-diagnostics.c
Modified: cfe/trunk/test/Driver/cl-diagnosti
echristo added inline comments.
Comment at: include/clang/Basic/Attr.td:1790-1794
+// target features respectively.
+if (Feature.compare("arm") == 0)
+ Ret.first.push_back("-thumb-mode");
+else if (Feature.compare("thumb") == 0)
+ Ret.fir
Author: rnk
Date: Wed May 31 15:42:43 2017
New Revision: 304345
URL: http://llvm.org/viewvc/llvm-project?rev=304345&view=rev
Log:
[clang-cl] Expose -nostdinc and -nobuiltininc
These are already wired up to work in the MSVC toolchain header search
code. However, they were unreachable from clang-cl
ahatanak created this revision.
Currently, clang prints the same warning message "this function declaration is
not a prototype" for non-prototype declarations of blocks and normal functions.
This commit makes changes needed to print a more accurate warning "this block
declaration is not a proto
rnk added a comment.
Darn, I think Richard is right, the signed div/mod doesn't do the right thing
for negative values. Honestly I need to rig up a test case for this, and then
I'll come back to it.
What do you folks think is best:
- Add an LLVM intrinsic for this and use it
- Use inline assem
Author: rsmith
Date: Wed May 31 15:56:55 2017
New Revision: 304346
URL: http://llvm.org/viewvc/llvm-project?rev=304346&view=rev
Log:
[modules] When compiling a preprocessed module map, look for headers relative
to the original module map.
Also use the path and name of the original module map when
rsmith added a comment.
My feeling is that there's not much value in adding an LLVM intrinsic for
something that can be expressed directly in a handful of IR instructions; those
instructions seem like the way to express this that would allow the most
optimization potential, and the backend shou
Author: ericwf
Date: Wed May 31 16:20:18 2017
New Revision: 304348
URL: http://llvm.org/viewvc/llvm-project?rev=304348&view=rev
Log:
Remove uses of _UI because Windows is evil and tchar.h #define's it
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/include/random
libcxx/trunk/te
Author: ericwf
Date: Wed May 31 16:34:43 2017
New Revision: 304351
URL: http://llvm.org/viewvc/llvm-project?rev=304351&view=rev
Log:
Transform the libc++ coroutine shell tests into normal .pass.cpp tests.
The shell test versions didn't get all of the flags normal tests
do, specifically warning fl
Author: ericwf
Date: Wed May 31 16:39:54 2017
New Revision: 304352
URL: http://llvm.org/viewvc/llvm-project?rev=304352&view=rev
Log:
Guard against more macros in tchar.h
Modified:
libcxx/trunk/test/support/nasty_macros.hpp
Modified: libcxx/trunk/test/support/nasty_macros.hpp
URL:
http://llv
EricWF accepted this revision.
EricWF added a comment.
LGTM.
https://reviews.llvm.org/D33080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added a comment.
Thanks for the review! I've rebased the patch and plan on checking it in
tomorrow. At the moment I'm getting some additional test coverage (running
check-libcxx and testing more backends).
https://reviews.llvm.org/D33305
___
c
Author: ericwf
Date: Wed May 31 17:07:49 2017
New Revision: 304357
URL: http://llvm.org/viewvc/llvm-project?rev=304357&view=rev
Log:
[Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows
Summary:
This patch improves how libc++ handles min/max macros within the headers.
Pr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304357: [Libc++] Use #pragma push_macro/pop_macro to better
handle min/max on Windows (authored by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D33080?vs=100361&id=100925#toc
Repository:
Author: ericwf
Date: Wed May 31 17:11:42 2017
New Revision: 304359
URL: http://llvm.org/viewvc/llvm-project?rev=304359&view=rev
Log:
Remove requirement for libunwind sources. Patch by Shiz.
As per r241993, libunwind_ext.h is not used anymore, and thus only the public
libunwind includes are neede
EricWF closed this revision.
EricWF added a comment.
Committed as r304359.
Repository:
rL LLVM
https://reviews.llvm.org/D33178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joerg added a comment.
I'm against it. I consider this a strong bug on the LLD side and the behavior
of clang correct.
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304360: Fix Libc++ build with MinGW64 (authored by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D33082?vs=100358&id=100926#toc
Repository:
rL LLVM
https://reviews.llvm.org/D33082
Files
Author: ericwf
Date: Wed May 31 17:14:05 2017
New Revision: 304360
URL: http://llvm.org/viewvc/llvm-project?rev=304360&view=rev
Log:
Fix Libc++ build with MinGW64
Summary: This patch corrects the build errors I encountered when building on
MinGW64.
Reviewers: mati865, rnk, compnerd, smeenai, bc
atanasyan added a comment.
In https://reviews.llvm.org/D33726#769301, @joerg wrote:
> I'm against it. I consider this a strong bug on the LLD side and the behavior
> of clang correct.
Do you suggest to add knowledge about various OS (linux/*bsd) and arch
(x86,arm,mips,...) specific paths to t
Author: ericwf
Date: Wed May 31 17:20:42 2017
New Revision: 304364
URL: http://llvm.org/viewvc/llvm-project?rev=304364&view=rev
Log:
Fix silly mistakes in recent changes made to coroutine test
Modified:
libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/fullexp
krytarowski added a comment.
Regardless of LLD, `--sysroot` is still needed I think.
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
Ah. I see what you're saying. I was thinking of the mismatch in a different
way, but your solution makes sense. LGTM.
https://reviews.llvm.org/D32595
chapuni added a comment.
I don't think this would be ready to land.
https://reviews.llvm.org/D32595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yawanng updated this revision to Diff 100928.
yawanng added a comment.
Split the commit to three ones that each of them contains one. This is the
first part.
https://reviews.llvm.org/D33304
Files:
clang-tidy/CMakeLists.txt
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMake
joerg added a comment.
Such knowledge is necessary anyway. There is enough software that wants to use
the linker directly.
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
joerg added a comment.
sysroot is already handled in NetBSD.cpp line 118 or so.
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 134 matches
Mail list logo
