[PATCH] D29877: Warn about unused static file scope function template declarations.

rsmith added a comment. In https://reviews.llvm.org/D29877#766196, @EricWF wrote: > No. But I can point you to `range-v3` which uses this pattern and I think the > idiom is somewhat appealing, but that's orthogonal to Clang diagnosing it. I found this: https://github.com/ericniebler/range-v3/

[PATCH] D33616: [MS] Fix _bittest* intrinsics for values bigger than 31

rnk created this revision. These intrinsics are supposed to select to BT, BTS, etc instructions. Those instructions actually perform a bitwise array indexing memory operation that LLVM doesn't currently expose. This change implements the shifting and array indexing in plain C. Fixes PR33188 If

[PATCH] D29877: Warn about unused static file scope function template declarations.

EricWF added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:631 // UnusedParameter, (matches GCC's behavior) +// UnusedTemplate, (clean-up libc++ before enabling) // UnusedMemberFuncti

[PATCH] D33525: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

chandlerc added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:913-914 +std::error_code EC; +ThinLinkOS.emplace(CodeGenOpts.ThinLinkBitcodeFile, EC, + llvm::sys::fs::F_None); +if (EC) { The clang s

[PATCH] D33538: [coroutines] Support "coroutines" feature in module map requires clause

EricWF added a comment. Even after fixing the libc++ guards, the header still emits a #warning when it's processed when coroutines are unavailable. It seems like a useful feature test to have available. I'll commit shortly. https://reviews.llvm.org/D33538 ___

r304054 - [coroutines] Support "coroutines" feature in module map requires clause

Author: ericwf Date: Fri May 26 21:46:17 2017 New Revision: 304054 URL: http://llvm.org/viewvc/llvm-project?rev=304054&view=rev Log: [coroutines] Support "coroutines" feature in module map requires clause Summary: In order for libc++ to add `` to its module map, there has to be a feature that ca

[PATCH] D33509: [OpenMP] Create COMDAT group for OpenMP offload registration code to avoid multiple copies

This revision was automatically updated to reflect the committed changes. Closed by commit rL304056: [OpenMP] Create COMDAT group for OpenMP offload registration code to avoid… (authored by grokos). Changed prior to commit: https://reviews.llvm.org/D33509?vs=100134&id=100518#toc Repository:

[PATCH] D33509: [OpenMP] Create COMDAT group for OpenMP offload registration code to avoid multiple copies

grokos added a comment. I committed the patch. Thanks for submitting it! Repository: rL LLVM https://reviews.llvm.org/D33509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r304057 - Revert "[coroutines] Support "coroutines" feature in module map requires clause"

Author: ericwf Date: Fri May 26 22:04:51 2017 New Revision: 304057 URL: http://llvm.org/viewvc/llvm-project?rev=304057&view=rev Log: Revert "[coroutines] Support "coroutines" feature in module map requires clause" This reverts commit r304054. Removed: cfe/trunk/test/Modules/Inputs/DependsOnM

r304056 - [OpenMP] Create COMDAT group for OpenMP offload registration code to avoid multiple copies

Author: grokos Date: Fri May 26 22:03:13 2017 New Revision: 304056 URL: http://llvm.org/viewvc/llvm-project?rev=304056&view=rev Log: [OpenMP] Create COMDAT group for OpenMP offload registration code to avoid multiple copies Thanks to Sergey Dmitriev for submitting the patch. Differential Revisi

[PATCH] D33620: [CodeGenCXX] do not default to dllimport storage for mingw-w64

martell created this revision. GNU frontends don't have options like `/MT`, `/MD` etc so it makes little sense. This fixes a few link error regressions with libc++ and libc++abi Repository: rL LLVM https://reviews.llvm.org/D33620 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/runti

<    1   2