t.p.northover updated this revision to Diff 100321.
t.p.northover added a comment.
Sounds very reasonable to me. I've uploaded a new diff.
https://reviews.llvm.org/D33568
Files:
clang/lib/AST/ExprConstant.cpp
clang/test/SemaCXX/null-cast.cpp
Index: clang/test/SemaCXX/null-cast.cpp
===
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D33538#765062, @rsmith wrote:
> In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
>
> > Do we need to conditionalize this part of libc++? Nothing in the
> >
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D33568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: rtrieu
Date: Thu May 25 18:25:36 2017
New Revision: 303934
URL: http://llvm.org/viewvc/llvm-project?rev=303934&view=rev
Log:
"*" => "+" to avoid matching on empty string.
Modified:
cfe/trunk/test/Driver/baremetal.cpp
Modified: cfe/trunk/test/Driver/baremetal.cpp
URL:
http://llvm.org
EricWF added a comment.
In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
> Do we need to conditionalize this part of libc++? Nothing in the
> header appears to need compiler support.
That's correct. I was mistaken as to why this was needed. I mistook a bug in
libc++ for the reason t
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
Actually, looking through the comments, it appears that everyone (eventually)
agreed with the approach in the patch. I agree too. LGTM.
Mehdi, are you able to rebase and commit, or s
Author: ericwf
Date: Thu May 25 18:39:29 2017
New Revision: 303936
URL: http://llvm.org/viewvc/llvm-project?rev=303936&view=rev
Log:
Re-add to the module map.
The original issues were caused because
didn't correctly #ifdef out enough of the header, which caused incomplete
types to be used.
Thi
martell added a comment.
> ! In https://reviews.llvm.org/D33082#764617, @EricWF wrote:
> Defining `_GNU_SOURCE` during the library build isn't enough, it's also has
> to be defined when people are using the headers,
> and in that case we must depend on the compiler to pre-define it. Is it
> im
EricWF added a comment.
Also see r303936, which re-adds to the module map and
fixes the bug.
https://reviews.llvm.org/D33538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Thu May 25 19:01:53 2017
New Revision: 303945
URL: http://llvm.org/viewvc/llvm-project?rev=303945&view=rev
Log:
Factor resolving of header directives -> files out of module map parser.
Modified:
cfe/trunk/include/clang/Lex/ModuleMap.h
cfe/trunk/lib/Lex/ModuleMap.cpp
rsmith added a comment.
In https://reviews.llvm.org/D33538#765146, @EricWF wrote:
> In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
>
> > Do we need to conditionalize this part of libc++? Nothing in the
> > header appears to need compiler support.
>
>
> That's correct. I was mistaken
On 25 May 2017 19:22, "Eugene Zelenko via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: eugenezelenko
Date: Thu May 25 12:22:29 2017
New Revision: 303884
URL: http://llvm.org/viewvc/llvm-project?rev=303884&view=rev
Log:
[Documentation] Mention hicpp check group in Clang-tidy main docu
Hi, Alexander!
On Thu, May 25, 2017 at 5:16 PM, Alexander Kornienko wrote:
>
>
> On 25 May 2017 19:22, "Eugene Zelenko via cfe-commits"
> wrote:
>
> Author: eugenezelenko
> Date: Thu May 25 12:22:29 2017
> New Revision: 303884
>
> URL: http://llvm.org/viewvc/llvm-project?rev=303884&view=rev
> Lo
EricWF added a comment.
In https://reviews.llvm.org/D33538#765225, @rsmith wrote:
> In https://reviews.llvm.org/D33538#765146, @EricWF wrote:
>
> > In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
> >
> > > Do we need to conditionalize this part of libc++? Nothing in the
> > > header a
Author: caseycarter
Date: Thu May 25 19:37:33 2017
New Revision: 303947
URL: http://llvm.org/viewvc/llvm-project?rev=303947&view=rev
Log:
[test] make_shared(...) is, uh, libc++-specific
Modified:
libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.c
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
One minor nit and LGTM.
Thanks!
-eric
Comment at: lib/Basic/Targets.cpp:5353
+// enable or disable thumb-mode per function
+if (isThumb())
Mi
Author: caseycarter
Date: Thu May 25 20:00:56 2017
New Revision: 303951
URL: http://llvm.org/viewvc/llvm-project?rev=303951&view=rev
Log:
[test] Fix breakage from r303947 =(
Modified:
libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/make_s
Shiz added a comment.
@EricWF: Thanks for reviewing! Is there anything else I need to do at this
point or will it be committed automatically?
Repository:
rL LLVM
https://reviews.llvm.org/D33178
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: ericwf
Date: Thu May 25 20:27:08 2017
New Revision: 303953
URL: http://llvm.org/viewvc/llvm-project?rev=303953&view=rev
Log:
Remove incorrect #ifdef guards around variant tests.
The tests were previously guarded by #if defined(_LIBCPP_VER) ||
defined(_MSVC_STL_VER),
which is both incorre
ahatanak updated this revision to Diff 100354.
ahatanak added a comment.
Rebase.
https://reviews.llvm.org/D32520
Files:
include/clang/Sema/Sema.h
lib/CodeGen/CGExprScalar.cpp
lib/Sema/SemaExpr.cpp
test/CodeGen/fp16vec-ops.c
test/Sema/fp16vec-sema.c
Index: test/Sema/fp16vec-sema.c
===
bcraig added a comment.
> Are you suggesting that libc++ should stop declaring/defining these
> functions, at least publically?
I think that we generally shouldn't be giving functions names that are already
claimed elsewhere (like mbsnrtowcs and wcsnrtombs). It is my opinion that
these should
Author: ericwf
Date: Thu May 25 20:52:59 2017
New Revision: 303956
URL: http://llvm.org/viewvc/llvm-project?rev=303956&view=rev
Log:
Guard against older Clang versions.
Clang started providing -fcoroutines and defining __cpp_coroutines
way before it implemented the __builtin_coro_foo functions.
t.p.northover closed this revision.
t.p.northover added a comment.
Thanks Richard. I've committed this as r303957.
https://reviews.llvm.org/D33568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: tnorthover
Date: Thu May 25 21:16:00 2017
New Revision: 303957
URL: http://llvm.org/viewvc/llvm-project?rev=303957&view=rev
Log:
Create valid LValue to represent null pointers in constant exprs
We were leaving the SubobjectDesignator in a surprising situation, where
it was allegedly valid
Author: gbiv
Date: Thu May 25 21:56:51 2017
New Revision: 303962
URL: http://llvm.org/viewvc/llvm-project?rev=303962&view=rev
Log:
[docs] Point coroutine link to an actual document
Unsure if there's a better document, but what we had before led to a
404. :)
Modified:
cfe/trunk/www/cxx_status
Author: ericwf
Date: Thu May 25 22:02:54 2017
New Revision: 303963
URL: http://llvm.org/viewvc/llvm-project?rev=303963&view=rev
Log:
Get working in C++03.
Clang supports coroutines in all dialects; Therefore libc++ should too,
otherwise the Clang extension is unusable.
I'm not convinced extendi
EricWF added a comment.
In https://reviews.llvm.org/D33082#765282, @bcraig wrote:
> I think that we generally shouldn't be giving functions names that are
> already claimed elsewhere (like mbsnrtowcs and wcsnrtombs). It is my opinion
> that these should always be qualified as __libcpp_* symbol
EricWF updated this revision to Diff 100358.
EricWF added a comment.
- remove `asprintf` declaration and definition entirely. It's not used anywhere
within libc++.
https://reviews.llvm.org/D33082
Files:
include/__config
include/__locale
include/locale
include/stdio.h
include/support/
EricWF updated this revision to Diff 100361.
EricWF added a comment.
- Fix whitespace in `__config`.
@compnerd Any final thoughts?
https://reviews.llvm.org/D33080
Files:
include/__bit_reference
include/__config
include/__hash_table
include/__mutex_base
include/__split_buffer
includ
Author: ericwf
Date: Thu May 25 23:09:38 2017
New Revision: 303966
URL: http://llvm.org/viewvc/llvm-project?rev=303966&view=rev
Log:
Workaround debug info bug in Clangs coroutine implementation
Modified:
libcxx/trunk/test/libcxx/experimental/language.support/support.coroutines/dialect_suppor
101 - 130 of 130 matches
Mail list logo
