alekseyshl added a comment.
This bot reports leaks in coro-alloc.cpp:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1401/steps/check-clang%20asan/logs/stdio.
Please fix.
Repository:
rL LLVM
https://reviews.llvm.org/D31584
__
alekseyshl added a comment.
Leaks and warnings are reported in coro-await.cpp:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1400/steps/check-clang%20asan/logs/stdio.
Please fix.
https://reviews.llvm.org/D31608
___
cfe-
Any specific reason why this doesn't contain a testcase?
On Tue, May 23, 2017 at 4:37 AM, Ilya Biryukov via cfe-commits
wrote:
> Author: ibiryukov
> Date: Tue May 23 06:37:52 2017
> New Revision: 303630
>
> URL: http://llvm.org/viewvc/llvm-project?rev=303630&view=rev
> Log:
> Allow to use vfs::Fi
Author: bruno
Date: Tue May 23 18:53:17 2017
New Revision: 303705
URL: http://llvm.org/viewvc/llvm-project?rev=303705&view=rev
Log:
[Modules] Fix overly conservative assertion for import diagnostic
We currenltly assert when want to diagnose a missing import and the decl
in question is already vis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303705: [Modules] Fix overly conservative assertion for
import diagnostic (authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D32828?vs=100016&id=100023#toc
Repository:
rL LLVM
ht
marcel abandoned this revision.
marcel added a comment.
Closed. Patch https://reviews.llvm.org/D33368 addresses PR32890 more
comprehensively.
https://reviews.llvm.org/D33393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
compnerd added a comment.
Looks generally pretty good. This is going to be a pretty cool addition!
Comment at: lib/Driver/ToolChains/BareMetal.cpp:68
+ SmallString<128> Dir(getDriver().ResourceDir);
+ llvm::sys::path::append(Dir, "lib", "baremetal");
+ return Dir.str();
---
Author: akirtzidis
Date: Tue May 23 19:46:27 2017
New Revision: 303712
URL: http://llvm.org/viewvc/llvm-project?rev=303712&view=rev
Log:
Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods
and properties as well
This is an initial commit to allow using it with constant e
mpark added a comment.
Thanks for the tests! I'll try this out with an implementation shortly.
https://reviews.llvm.org/D32515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kastiglione created this revision.
This change allows `llvm-nm` to print symbols found in import libraries, in part
by allowing `COFFImportFile`s to be casted to `SymbolicFile`s.
https://reviews.llvm.org/D33474
Files:
include/llvm/Object/Binary.h
test/tools/llvm-nm/X86/Inputs/example.lib
mpark added a comment.
@CaseyCarter: Does this not pass with the current version?
Also, have you seen the tests in
`test/libcxx/utilities/variant/variant.variant`?
If yes, do those tests and the ones in this diff overlap at all?
Curious as to how we should merge them.
https://reviews.llvm.org/D
Author: akirtzidis
Date: Tue May 23 20:38:00 2017
New Revision: 303713
URL: http://llvm.org/viewvc/llvm-project?rev=303713&view=rev
Log:
Change __has_feature(objc_diagnose_if_attr) to
__has_feature(attribute_diagnose_if_objc) for consistency with rest of
attribute checks.
Modified:
cfe/trun
GorNishanov added a comment.
In https://reviews.llvm.org/D31608#762783, @alekseyshl wrote:
> Leaks and warnings are reported in coro-await.cpp:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1400/steps/check-clang%20asan/logs/stdio.
> Please fix.
Thank you! The fi
Author: gornishanov
Date: Tue May 23 20:54:37 2017
New Revision: 303714
URL: http://llvm.org/viewvc/llvm-project?rev=303714&view=rev
Log:
[coroutines] Fix leak in CGCoroutine.cpp
FinalBB need to be emitted even when unused to make sure it is deleted
Modified:
cfe/trunk/lib/CodeGen/CGCoroutin
GorNishanov added a comment.
Fixed:
r303714 = 8832327ab89f3668378d70d1c4e5a218446ce36e
https://reviews.llvm.org/D31608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dexonsmith added inline comments.
Comment at: src/cxa_demangle.cpp:3036
break;
-if (db.names.size() < 2)
+assert(k0 <= k1 && "parse_type() mutated the name stack");
+if (k1 == k0)
---
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/misc-default-numerics.rst:11
+Consider scenario:
+1. Have `typedef long long BigInt` in source code
+2. Use `std::numeric_limits::min()`
May be code-block will be better?
https://reviews.l
GorNishanov updated this revision to Diff 100027.
GorNishanov added a comment.
merge with tot, preparing to land
https://reviews.llvm.org/D31670
Files:
lib/CodeGen/CGCoroutine.cpp
test/CodeGenCoroutines/coro-gro.cpp
Index: test/CodeGenCoroutines/coro-gro.cpp
===
GorNishanov created this revision.
Herald added a subscriber: EricWF.
Sema creates a declaration for gro variable as:
auto $gro = $promise.get_return_object();
However, gro variable has to outlive coroutine frame and coroutine promise, but,
it can only be initialized after the coroutine promise
Author: gornishanov
Date: Tue May 23 21:38:26 2017
New Revision: 303716
URL: http://llvm.org/viewvc/llvm-project?rev=303716&view=rev
Log:
[coroutines] Implement correct GRO lifetime
Summary:
Sema creates a declaration for gro variable as:
auto $gro = $promise.get_return_object();
However, gro v
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303716: [coroutines] Implement correct GRO lifetime
(authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D33477?vs=100029&id=100030#toc
Repository:
rL LLVM
https://reviews.ll
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
Landed as: https://reviews.llvm.org/rL303716
https://reviews.llvm.org/D31670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
GorNishanov closed this revision.
GorNishanov added a comment.
Closed by commit https://reviews.llvm.org/rL303716: [coroutines] Implement
correct GRO lifetime (authored by GorNishanov)
https://reviews.llvm.org/D31670
___
cfe-commits mailing list
cf
rdwampler created this revision.
https://reviews.llvm.org/D33478
Files:
test/Index/availability.c
tools/libclang/CIndex.cpp
Index: tools/libclang/CIndex.cpp
===
--- tools/libclang/CIndex.cpp
+++ tools/libclang/CIndex.cpp
@@ -720
GorNishanov created this revision.
- Test that coroutine promise destructor is called.
- Test that we call return_void on fallthrough
- Test that we call unhandled exception in a try catch surrounding the body
https://reviews.llvm.org/D33479
Files:
test/CodeGenCoroutines/Inputs/coroutine.h
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
GorNishanov created this revision.
Now we helpfully provide a note pointing at the promise_type in question.
https://reviews.llvm.org/D33481
Files:
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutine-unhandled_exception-warning.cpp
test/SemaCXX/coroutines.cpp
Index: test/SemaCXX/coroutine
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: lib/Sema/SemaExpr.cpp:15747
+ // warn when it's used inappropriately (i.e. not if(@available)).
+ if (getCurFunctionOrMethodDecl
erik.pilkington added inline comments.
Comment at: src/cxa_demangle.cpp:3036
break;
-if (db.names.size() < 2)
+assert(k0 <= k1 && "parse_type() mutated the name stack");
+if (k1 == k0)
--
Author: epilk
Date: Wed May 24 00:44:19 2017
New Revision: 303718
URL: http://llvm.org/viewvc/llvm-project?rev=303718&view=rev
Log:
[demangler] Fix a crash in the demangler during parsing of a lamdba
The problem is that multiple types could have been parsed from parse_type(),
which the lamdba par
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303718: [demangler] Fix a crash in the demangler during
parsing of a lamdba (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D33368?vs=99930&id=100041#toc
Repository:
rL LLVM
h
Author: dberris
Date: Wed May 24 00:46:36 2017
New Revision: 303719
URL: http://llvm.org/viewvc/llvm-project?rev=303719&view=rev
Log:
[XRay][clang] Allow imbuing arg1 logging attribute via -fxray-always-instrument=
Summary:
This change allows us to add arg1 logging support to functions through
th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303719: [XRay][clang] Allow imbuing arg1 logging attribute
via -fxray-always-instrument= (authored by dberris).
Changed prior to commit:
https://reviews.llvm.org/D33392?vs=99715&id=100042#toc
Repositor
george.burgess.iv updated this revision to Diff 99851.
george.burgess.iv added a comment.
Remove the `transparent_overloadable` attribute entirely.
This approach presents one problem that I didn't see until I implemented it:
I'd like to have something to detect that this feature exists. The quic
rogfer01 added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:2329-2333
+ // __unaligned is not currently mangled in any way. This implies that it is
+ // not a relevant qualifier for substitutions (while CVR and maybe others
+ // are). This triggers an assertion when
george.burgess.iv added a comment.
Shortly after I pressed submit, I realized that this patch allows the following
code if you tweak an assert to check for `overloadable` on the most recent
redecl of a function:
void foo(int);
void foo(int) __attribute__((overloadable));
void foo(float);
Typz updated this revision to Diff 99854.
Typz marked 5 inline comments as done.
Typz added a comment.
respond to review comments
https://reviews.llvm.org/D32479
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/TokenAnnotator.cpp
Typz added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:196
+ FormatStyle::BCIS_AfterColonAndComma) &&
+ (State.Column + State.Line->Last->TotalLength - Previous.TotalLength >
+ getColumnLimit(State) ||
djasper wrote:
Typz updated this revision to Diff 99856.
Typz added a comment.
Add missing doc for BreakConstructorInitializers
https://reviews.llvm.org/D32479
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/TokenAnnotator.cpp
unittests/Forma
jyu2 updated this revision to Diff 99857.
jyu2 added a comment.
I missed two place which Aaron point out.
1> using isNothrow function instead NR_Nothrow.
2> A format problem.
Changed.
Thanks.
https://reviews.llvm.org/D3
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Se
Author: ibiryukov
Date: Tue May 23 03:12:45 2017
New Revision: 303616
URL: http://llvm.org/viewvc/llvm-project?rev=303616&view=rev
Log:
[clangd] Split clangd into library+executable (mainly for unit tests).
Summary:
This commit itself doesn't add any unit tests, but one that does will
follow shor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303616: [clangd] Split clangd into library+executable
(mainly for unit tests). (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D33395?vs=99774&id=99858#toc
Repository:
rL L
arichardson added a comment.
I don't have commit access, could you commit for me please?
https://reviews.llvm.org/D32425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D33397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Typz added inline comments.
Comment at: unittests/Format/FormatTest.cpp:2476
"bool value = a\n"
- " + a\n"
- " + aa
Author: sdardis
Date: Tue May 23 04:42:50 2017
New Revision: 303619
URL: http://llvm.org/viewvc/llvm-project?rev=303619&view=rev
Log:
[mips] Make checks in CodeGen/mips-varargs.c less fragile
This test was failing on our fork of clang because it was not capturing
[[ARG]] in the N32 case. Therefor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303619: [mips] Make checks in CodeGen/mips-varargs.c less
fragile (authored by sdardis).
Changed prior to commit:
https://reviews.llvm.org/D32425?vs=98059&id=99868#toc
Repository:
rL LLVM
https://re
bkramer added inline comments.
Comment at: unittests/clangd/ClangdTests.cpp:118
+ llvm::SmallString<128> TmpDir2;
+ llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, TmpDir2);
+
We should delete those when we're done, otherwise the unit test will
krasimir added inline comments.
Comment at: clangd/ClangdServer.cpp:85
+Request = std::move(RequestQueue.front());
+RequestQueue.pop_front();
} // unlock Mutex
Why are we taking it from the front and not from the back? Maybe at least add a
krasimir added inline comments.
Comment at: clangd/ClangdUnitStore.h:56
+ template
+ void runOnExistingUnit(PathRef File, Func Action) {
+std::lock_guard Lock(Mutex);
krasimir wrote:
> Maybe make it less generic and put the implementation in the source fil
Author: d0k
Date: Tue May 23 05:17:48 2017
New Revision: 303623
URL: http://llvm.org/viewvc/llvm-project?rev=303623&view=rev
Log:
[clangd] Pick up deps via LLVM components, which will hopefully include pthread.
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
Modified: clang-tools-ext
krasimir added a comment.
@klimek: ping
https://reviews.llvm.org/D32351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D32351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh added inline comments.
Comment at: lib/Tooling/CommonOptionsParser.cpp:122
+ FixedCompilationDatabase::loadFromCommandLine(argc, argv, ErrorMessage);
+ if (!Compilations && StringRef(ErrorMessage).startswith("error"))
+llvm::errs() << ErrorMessage;
--
Author: d0k
Date: Tue May 23 05:29:54 2017
New Revision: 303625
URL: http://llvm.org/viewvc/llvm-project?rev=303625&view=rev
Log:
[clangd] Explicitly link against pthread.
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt
URL:
ht
Author: svenvh
Date: Tue May 23 05:36:43 2017
New Revision: 303626
URL: http://llvm.org/viewvc/llvm-project?rev=303626&view=rev
Log:
[libclang] [OpenCL] Expose more OpenCL CIndex types
Expose pipe, sampler_t, clk_event_t, queue_t, reserve_id_t, and all
image types.
Update the opencl-types.cl tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303626: [libclang] [OpenCL] Expose more OpenCL CIndex types
(authored by svenvh).
Changed prior to commit:
https://reviews.llvm.org/D33197?vs=99574&id=99877#toc
Repository:
rL LLVM
https://reviews.l
rogfer01 updated this revision to Diff 99876.
rogfer01 retitled this revision from "Remove __unaligned preventively when
mangling types in Itanium ABI" to "Mangle __unaligned in Itanium ABI".
rogfer01 edited the summary of this revision.
rogfer01 added a reviewer: majnemer.
rogfer01 added a commen
bader added inline comments.
Comment at: lib/Headers/opencl-c.h:16020
+// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID.
+#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t))
bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);
---
djasper added a comment.
That's what I meant by "The name NamespaceIndentation might then be a bit
confusing, but not sure whether it's worth changing it.".
I am honestly not sure. Let's get a third opinion.
If we add this additional option, I think we need to fix the behavior and make
what pe
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:196
+ FormatStyle::BCIS_AfterColonAndComma) &&
+ (State.Column + State.Line->Last->TotalLength - Previous.TotalLength >
+ getColumnLimit(State) ||
Typz wrote:
Author: ibiryukov
Date: Tue May 23 06:37:52 2017
New Revision: 303630
URL: http://llvm.org/viewvc/llvm-project?rev=303630&view=rev
Log:
Allow to use vfs::FileSystem for file accesses inside ASTUnit.
Reviewers: bkramer, krasimir, arphaman, akyrtzi
Reviewed By: bkramer
Subscribers: klimek, cfe-co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303630: Allow to use vfs::FileSystem for file accesses
inside ASTUnit. (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D33397?vs=99725&id=99880#toc
Repository:
rL LLVM
htt
krasimir added a comment.
This change should also adapt NamespaceEndCommentFixer to respect the new
option and not introduce/remove/change the comments unexpectedly.
https://reviews.llvm.org/D32480
___
cfe-commits mailing list
cfe-commits@lists.llv
Typz added a comment.
Just to be clear: as it is, the patch does not implement what you describe,
both on the 'indent' side (as expected, we are discussing it), but also on the
"merging" of braces side. Consecutive namespace opening are merged on one side;
and consecutive namespace closing are
krasimir added a comment.
In any case, adding a namespace end comment to a line closing multiple
namespaces is super confusing for me: what does the comment refer to: the inner
one, the outer one, or both?
`}} // namespace A::B`
https://reviews.llvm.org/D32480
__
Typz added a comment.
In https://reviews.llvm.org/D32480#761859, @krasimir wrote:
> This change should also adapt NamespaceEndCommentFixer to respect the new
> option and not introduce/remove/change the comments unexpectedly.
This should be handled already (pending further changes to the patch
ilya-biryukov updated this revision to Diff 99883.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
Added more comments to addToEnd/addToFront, added explicit flush instead of
relying on raw_ostream's destructor to do it implicitly.
https://reviews.llvm.org/D33415
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:85
+Request = std::move(RequestQueue.front());
+RequestQueue.pop_front();
} // unlock Mutex
krasimir wrote:
> Why are w
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:102
} // unlock Mutex
+ RequestCV.notify_one();
Worker.join();
krasimir wrote:
> Why did this get out?
"The notifying thread does not need to hold the lock on the same mutex as the
o
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D33415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Prazek created this revision.
We can emit vtable definition having inline function
if they are all emitted.
https://reviews.llvm.org/D33437
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
lib/CodeGen/ItaniumC
Typz marked 6 inline comments as done.
Typz added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:196
+ FormatStyle::BCIS_AfterColonAndComma) &&
+ (State.Column + State.Line->Last->TotalLength - Previous.TotalLength >
+ getColumnLimit(Sta
Typz updated this revision to Diff 99886.
Typz marked 3 inline comments as done.
Typz added a comment.
Refactor to avoid duplicating code, and fix typo in test.
https://reviews.llvm.org/D32479
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
Typz added a comment.
In https://reviews.llvm.org/D32525#760710, @djasper wrote:
> Then you also (accidentally?) change the spacing in dict literals. However,
> the latter is already controlled by SpacesInContainerLiterals.
not really accidentally: I want the space on the 'outside' of dict lit
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:196
+ FormatStyle::BCIS_AfterColonAndComma) &&
+ (State.Column + State.Line->Last->TotalLength - Previous.TotalLength >
+ getColumnLimit(State) ||
Typz wrote:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D33430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
djasper added a comment.
Don't C99 designated literals use "=" instead of ":"?
https://reviews.llvm.org/D32525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz updated this revision to Diff 99887.
Typz added a comment.
Cleanup according to review comment
https://reviews.llvm.org/D32479
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.
Typz added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:196
+ FormatStyle::BCIS_AfterColonAndComma) &&
+ (State.Column + State.Line->Last->TotalLength - Previous.TotalLength >
+ getColumnLimit(State) ||
djasper wrote:
Typz added a comment.
In https://reviews.llvm.org/D32480#761862, @krasimir wrote:
> In any case, adding a namespace end comment to a line closing multiple
> namespaces is super confusing for me: what does the comment refer to: the
> inner one, the outer one, or both?
> `}} // namespace A::B`
aaron.ballman added inline comments.
Comment at: test/CodeGenCXX/pr33080.cpp:19
+void hb(__unaligned struct A*, __unaligned const struct A*) {}
+// CHECK: define void @_Z2hbPU11__unaligned1APU11__unalignedKS_(
Can we also get a test like `struct A * __unaligned *
Typz added a comment.
Indeed, so this is why :-)
https://reviews.llvm.org/D32525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek updated this revision to Diff 99897.
Prazek added a comment.
Removed debug print
https://reviews.llvm.org/D33437
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
lib/CodeGen/ItaniumCXXABI.cpp
test/Cod
yaxunl added inline comments.
Comment at: lib/Headers/opencl-c.h:16020
+// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID.
+#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t))
bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);
--
ilya-biryukov added inline comments.
Comment at: unittests/clangd/ClangdTests.cpp:118
+ llvm::SmallString<128> TmpDir2;
+ llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, TmpDir2);
+
bkramer wrote:
> We should delete those when we're done, otherw
Author: ibiryukov
Date: Tue May 23 08:42:59 2017
New Revision: 303634
URL: http://llvm.org/viewvc/llvm-project?rev=303634&view=rev
Log:
[clangd] Replaced WorkerRequest with std::function...
Summary:
And implemented a helper function to dump an AST of a file for
testing/debugging purposes.
Review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303634: [clangd] Replaced WorkerRequest with
std::function... (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D33415?vs=99883&id=99900#toc
Repository:
rL LLVM
https://revi
ilya-biryukov updated this revision to Diff 99902.
ilya-biryukov added a comment.
Changed tests to use Windows-style paths for virtual directory when running on
Windows.
https://reviews.llvm.org/D33416
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303635: [Tooling][libclang] Remove unused
CompilationDatabase::MappedSources (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D32351?vs=96138&id=99905#toc
Repository:
rL LLVM
arphaman added a comment.
In https://reviews.llvm.org/D33357#761400, @bruno wrote:
> Any idea why we're hitting this issue in the first place? The error that gets
> cleaned up is reported at some point before? Seems to me that we're going to
> fail to update the timestamp but continue as nothin
Author: krasimir
Date: Tue May 23 08:50:43 2017
New Revision: 303635
URL: http://llvm.org/viewvc/llvm-project?rev=303635&view=rev
Log:
[Tooling][libclang] Remove unused CompilationDatabase::MappedSources
Summary:
This field is never assigned to and it's only ever read from libclang.
This patch re
arphaman updated this revision to Diff 99904.
arphaman added a comment.
Remove the first redundant error check.
Repository:
rL LLVM
https://reviews.llvm.org/D33357
Files:
lib/Serialization/ASTReader.cpp
Index: lib/Serialization/ASTReader.cpp
==
tstellar added inline comments.
Comment at: cfe/trunk/lib/Basic/Targets.cpp:2037-2038
-static const LangAS::Map AMDGPUPrivateIsZeroMap = {
-4, // Default
-1, // opencl_global
-3, // opencl_local
-2, // opencl_constant
-4, // opencl_generic
-1, // c
I think if there is no triple environment or if the triple environment is
"opencl", I should always map default address space to 0. Then it should not
break libclc and previous OpenCL applications.
Sam
-Original Message-
From: Tom Stellard via Phabricator [mailto:revi...@reviews.llvm.or
Author: ibiryukov
Date: Tue May 23 08:59:37 2017
New Revision: 303636
URL: http://llvm.org/viewvc/llvm-project?rev=303636&view=rev
Log:
[clangd] Added a missing dependency on clangdAST to fix the build
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
Modified: clang-tools-extra/trunk/
Typz created this revision.
Herald added a subscriber: klimek.
These macros are used in the body of function, and actually contain
the trailing semicolon: they should thus be automatically followed by
a new line, and not get merged with the next line.
void foo(int a, int b) {
Q_UNUSED(a)
GorNishanov updated this revision to Diff 99911.
GorNishanov added a comment.
merged with top of the trunk
https://reviews.llvm.org/D31670
Files:
lib/CodeGen/CGCoroutine.cpp
test/CodeGenCoroutines/coro-gro.cpp
Index: test/CodeGenCoroutines/coro-gro.cpp
=
malhar1995 added a comment.
In https://reviews.llvm.org/D32449#761303, @NoQ wrote:
> Thanks, this is great! Two more things:
>
> - You have touched other code, unrelated to your patch, with clang-format;
> we're usually trying to avoid that, because it creates merge conflicts out of
> nowhere,
1 - 100 of 178 matches
Mail list logo
