[PATCH] D32977: [OpenCL] Emit function-scope variable in constant address space as static variable

rjmccall added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10286 + // these variables must be a compile time constant. + VDecl->getType().getAddressSpace() == LangAS::opencl_constant) CheckForConstantInitializer(Init, DclT); yaxu

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi updated this revision to Diff 98887. schroedersi added a comment. - Ran clang-format (current trunk version) on the changes (except on some test files) - Adapted patch to current trunk version https://reviews.llvm.org/D30946 Files: include/clang/AST/PrettyPrinter.h include/clan

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi added a comment. In https://reviews.llvm.org/D30946#740567, @bkramer wrote: > Also the mutable state in PrintingPolicy is really really ugly, is there no > better way for this? :( Thanks for your comment :-) I assume with mutable state you mean `PrintingPolicy::TemporarySuppressSc

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Add a test case like the one that currently crashes (see inline comment). Also, please do the following: - Put a note in the description (and the commit message) with a link to t

[PATCH] D33010: Make google-build-using-namespace skip std::.*literals

marejde updated this revision to Diff 98893. marejde added a comment. Removed use of getQualifiedNameAsString(). https://reviews.llvm.org/D33010 Files: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp clang-tidy/google/UsingNamespaceDirectiveCheck.h test/clang-tidy/google-namespaces.cpp

[PATCH] D33049: [libcxx] Support for Objective-C++ tests

dexonsmith added inline comments. Comment at: utils/libcxx/compiler.py:110-114 +if input_is_text: +if is_objcxx: +cmd += ['-x', 'objective-c++', '-fobjc-arc'] +else: +cmd += ['-x', 'c++'] Do we need/

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

vlad.tsyrklevich added inline comments. Comment at: lib/StaticAnalyzer/Core/ProgramState.cpp:656-659 + // If the SVal is a LazyCompoundVal it might only cover sub-region of a given + // symbol. For example, the LCV might represent a field in an uninitialized + // struct. In th

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

vlad.tsyrklevich updated this revision to Diff 98905. vlad.tsyrklevich added a comment. Some stylistic & comment updates. https://reviews.llvm.org/D30909 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h include/clang/StaticAnalyzer/Core/PathSensitive/TaintManager.h li