waltl created this revision.
https://reviews.llvm.org/D33020
Files:
lib/Driver/ToolChains/Myriad.cpp
test/Driver/myriad-toolchain.c
Index: test/Driver/myriad-toolchain.c
===
--- test/Driver/myriad-toolchain.c
+++ test/Driver/my
waltl updated this revision to Diff 98369.
https://reviews.llvm.org/D33020
Files:
lib/Driver/ToolChains/Myriad.cpp
test/Driver/myriad-toolchain.c
Index: test/Driver/myriad-toolchain.c
===
--- test/Driver/myriad-toolchain.c
+++
Author: vedantk
Date: Tue May 9 18:34:49 2017
New Revision: 302598
URL: http://llvm.org/viewvc/llvm-project?rev=302598&view=rev
Log:
[ubsan] Mark overflow checks with !nosanitize
Sanitizer instrumentation generally needs to be marked with !nosanitize,
but we're not doing this properly for ubsan'
BillyONeal created this revision.
Update is_trivially_copyable tests with CWG 2094
Clang 5.0 implements this here:
https://github.com/llvm-mirror/clang/commit/87cd035326a39523eeb1b295ad36cff337141ef9
MSVC++ will implement it in the first toolset update for VS 2017.
https://reviews.llvm.org/D33
majnemer added inline comments.
Comment at: include/support/win32/msvc_builtin_support.h:33
+
+_LIBCPP_ALWAYS_INLINE int __builtin_popcount(unsigned int x)
+{
compnerd wrote:
> I think I prefer the following implementation:
>
> _LIBCPP_ALWAYS_INLINE int __bu
BillyONeal added inline comments.
Comment at:
test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp:25
+ #define IMPLEMENTS_CWG_2094 false
+ #endif /* defined(_MSC_VER) && _MSC_VER >= 1911 */
+#endif
Whoops, I fat fingered the closin
aprantl added inline comments.
Comment at: include/clang/Basic/Sanitizers.h:64
- /// \brief Disable all sanitizers.
- void clear() { Mask = 0; }
+ /// \brief Disable the sanitizers specified in \p K (by default, disable
+ /// all sanitizers).
Might as well
BillyONeal updated this revision to Diff 98370.
BillyONeal edited the summary of this revision.
BillyONeal added a comment.
Eric asked to just nuke the offending lines.
https://reviews.llvm.org/D33021
Files:
test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp
Author: ericwf
Date: Tue May 9 18:47:20 2017
New Revision: 302600
URL: http://llvm.org/viewvc/llvm-project?rev=302600&view=rev
Log:
Fix misspelling of environment throughout libc++
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
libcxx/trunk/test/support/filesystem_dynamic_test_helper.py
vsk updated this revision to Diff 98371.
vsk marked 2 inline comments as done.
vsk added a comment.
Address comments from Adrian. (I settled on renaming 'getModularSanitizers' to
'getPPTransparentSanitizers'.)
https://reviews.llvm.org/D32724
Files:
include/clang/Basic/Sanitizers.h
lib/Basi
Author: ericwf
Date: Tue May 9 18:57:22 2017
New Revision: 302602
URL: http://llvm.org/viewvc/llvm-project?rev=302602&view=rev
Log:
Fix test runtime environment on Windows
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http://llvm
Author: rsmith
Date: Tue May 9 19:01:13 2017
New Revision: 302603
URL: http://llvm.org/viewvc/llvm-project?rev=302603&view=rev
Log:
When instantiating a friend function template, don't forget to inherit default
template arguments from other declarations.
Modified:
cfe/trunk/lib/Sema/SemaTem
Author: ericwf
Date: Tue May 9 19:05:04 2017
New Revision: 302604
URL: http://llvm.org/viewvc/llvm-project?rev=302604&view=rev
Log:
Attempt to unbreak Libc++ test configuration
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http:/
BillyONeal updated this revision to Diff 98376.
BillyONeal added a comment.
Bill got confused.
https://reviews.llvm.org/D33021
Files:
test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp
Index:
test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_co
EricWF added inline comments.
Comment at: include/__config:232-235
+#ifndef NOMINMAX
+#define NOMINMAX
+#endif
+
compnerd wrote:
> bcraig wrote:
> > I can see this helping when we are build libc++, but I don't think it helps
> > client apps. They could have inc
Author: ericwf
Date: Tue May 9 19:23:58 2017
New Revision: 302607
URL: http://llvm.org/viewvc/llvm-project?rev=302607&view=rev
Log:
Improve how LIT reports the added environment variables
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
U
Author: ericwf
Date: Tue May 9 21:30:16 2017
New Revision: 302614
URL: http://llvm.org/viewvc/llvm-project?rev=302614&view=rev
Log:
Add MinGW64 builder to Appveyor.
With the amount of work happening on Windows we should
have a MinGW bot to make sure we don't regress that functionality.
Currently
Author: rsmith
Date: Tue May 9 21:30:28 2017
New Revision: 302615
URL: http://llvm.org/viewvc/llvm-project?rev=302615&view=rev
Log:
When we see a '<' operator, check whether it's a probable typo for a
template-id.
The heuristic that we use here is:
* the left-hand side must be a simple identif
Author: ericwf
Date: Tue May 9 21:34:56 2017
New Revision: 302616
URL: http://llvm.org/viewvc/llvm-project?rev=302616&view=rev
Log:
attempt to fix appveyor syntax error
Modified:
libcxx/trunk/appveyor.yml
Modified: libcxx/trunk/appveyor.yml
URL:
http://llvm.org/viewvc/llvm-project/libcxx/t
hfinkel added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:388
+
+ // add paths specified in LIBRARY_PATH environment variable as -L options.
+ addDirectoryList(Args, CmdArgs, "-L", "LIBRARY_PATH");
Comment sentences should start with a capital l
Author: ericwf
Date: Tue May 9 21:36:48 2017
New Revision: 302617
URL: http://llvm.org/viewvc/llvm-project?rev=302617&view=rev
Log:
Support using MinGW POSIX threads on Windows
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/llvm-
Author: ericwf
Date: Tue May 9 21:43:02 2017
New Revision: 302619
URL: http://llvm.org/viewvc/llvm-project?rev=302619&view=rev
Log:
Rename Appveyor install helper script.
I'm really lazy and the old name for the helper script
killed 2 letter tab completion for the include directory.
This patch r
vlad.tsyrklevich updated this revision to Diff 98390.
vlad.tsyrklevich marked 3 inline comments as done.
vlad.tsyrklevich added a comment.
Herald added a subscriber: xazax.hun.
- Update the logic to move the LCV symbol logic into
ProgramState::addTaint(SVal) out of the GenericTaintChecker. This a
sepavloff updated this revision to Diff 98395.
sepavloff added a comment.
Addressed reviewer's notes.
https://reviews.llvm.org/D33013
Files:
lib/Driver/Driver.cpp
test/Driver/aarch64-cpus.c
test/Driver/amdgpu-features.c
test/Driver/arm-darwin-builtin.c
test/Driver/arm-default-build-at
2017-05-10 3:46 GMT+07:00 Richard Smith :
> On 1 March 2017 at 02:50, Serge Pavlov via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
>>
>> Format of configuration file is similar to file used in the construct
>> `@file`, it is a set of options. Configuration file have advantage over
>> this c
iris added a comment.
How can I make z3constraintmanager.cpp work in the command line?Or how to make
z3 work?
Repository:
rL LLVM
https://reviews.llvm.org/D28952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
stringham created this revision.
stringham added a project: clang-tools-extra.
Herald added a subscriber: klimek.
This adds an option to clang-format to support dangling parenthesis.
If you have a parameter list like
Foo(
param1,
param2,
param3,
);
clang-format currently only supports p
djasper added a comment.
Please read and address:
https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options
https://reviews.llvm.org/D33029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
> These new "extra notes" of mine might be useful (we could put them at
> property declaration), i could add them if everybody likes this idea.
What are these? Is there a PR?
It would b
ahatanak created this revision.
r276215 made a change to annotate _Unwind_Exception with
"__attribute__((__aligned__))" so that exception objects are double-word
aligned. This fix hasn't been incorporated to unwind.h on Darwin yet and, since
it is an ABI breaking change, I'm not sure it will e
zaks.anna added a comment.
Sorry for the delay!!!
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:180
+ inline const llvm::APSInt &getZeroWithTypeSize(QualType T,
+ bool isUnsigned = true) {
+
NoQ added a comment.
> What are these? Is there a PR?
The best explanation we currently have, with examples, is
https://reviews.llvm.org/D24278
> It would be great if we could place a note on a parent that has location.
That's actually the best approach in my opinion, if achievable.
> For exa
zaks.anna added a comment.
> That wouldn't work this way because we'd have the completely redundant
> "calling property accessor" piece before that, and "returning..." after that.
I think we should not print "calling" and "returning" for calling into and
returning from autogenerated code, If we
NoQ added a comment.
In https://reviews.llvm.org/D32437#750622, @zaks.anna wrote:
> > That wouldn't work this way because we'd have the completely redundant
> > "calling property accessor" piece before that, and "returning..." after
> > that.
>
> I think we should not print "calling" and "retur
idlecode added a comment.
Oh, sorry about this - I forgot. I will send patch during this weekend
https://reviews.llvm.org/D30748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 135 of 135 matches
Mail list logo
