Re: r301410 - [OPENMP] Move handling of threadprivate vars from the stack, NFC.

2017-04-26 Thread Ahmed Bougacha via cfe-commits
Hey Alexey, This is causing asan errors, e.g.: ==4735==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61f00e70 at pc 0x00010a8a7f4a bp 0x7fff5c57a390 sp 0x7fff5c57a388 READ of size 4 at 0x61f00e70 thread T0 #0 0x10a8a7f49 in (anonymous namespace)::DSAStackTy::hasDSA(clang:

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

2017-04-26 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for your patience! LGTM with a minor comment below. Comment at: test/Sema/vector-gcc-compat.c:101 + + v2i64_r = v2i64_a && 1; // expected-error {{invalid vector operand

[PATCH] D32576: [Modules] Improve diagnostics for incomplete umbrella

2017-04-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM after a couple of changes inline. Comment at: lib/Lex/PPLexerChange.cpp:290-292 +static void +collectAllSubModulesWithUmbrellaHeader(Module *Mod, +

[PATCH] D32576: [Modules] Improve diagnostics for incomplete umbrella

2017-04-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Oh, and it would be nice to split out `Preprocessor::diagnoseMissingHeaderInUmbrellaDir` in a separate NFC commit ahead of time. https://reviews.llvm.org/D32576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D31588: Fix PR25627: Certain constant local variables must be usable as template arguments (without being odr-used)

2017-04-26 Thread Faisal Vali via Phabricator via cfe-commits
faisalv updated this revision to Diff 96858. faisalv marked 3 inline comments as done. faisalv added a comment. Updated the patch following Richard's feedback: - teach ParseConstantExpression to create its own ExpressionEvaluationContext only if asked to. https://reviews.llvm.org/D31588 Files

[PATCH] D31588: Fix PR25627: Certain constant local variables must be usable as template arguments (without being odr-used)

2017-04-26 Thread Faisal Vali via Phabricator via cfe-commits
faisalv updated this revision to Diff 96861. faisalv added a comment. Fixed a regression test that should have passed without emitting error diagnostics - and now does. https://reviews.llvm.org/D31588 Files: include/clang/Parse/Parser.h lib/Parse/ParseExpr.cpp lib/Parse/ParseTemplate.cpp

[PATCH v2] [PPC64]: Add support for Swift calling convention

2017-04-26 Thread Andrew Jeffery via cfe-commits
For the tests I've extracted the int5 and int8 cases to cater for different alignments for different platform ABIs. For Linux on POWER the 5 and 8 element vectors must be naturally aligned with respect to the total "soft" vector size, despite being represented as an aggregate. Specifically, the pat

[PATCH] D32455: detect integer overflow inside arms of conditional operator with non-constant expression

2017-04-26 Thread Richard Smith via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D32455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D32412: analyze all kinds of expressions for integer overflow

2017-04-26 Thread Richard Smith via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. If we're now catching integer overflow in more cases, please add some relevant testcases. If this is a pure refactoring that enables those additional diagnostics to be produced in future, then

<    1   2