[libcxx] r300786 - Add appveyor.yml config for a future Windows bot.

2017-04-19 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Apr 19 18:26:21 2017 New Revision: 300786 URL: http://llvm.org/viewvc/llvm-project?rev=300786&view=rev Log: Add appveyor.yml config for a future Windows bot. I'm currently trying to get a libc++ Windows builder working on appveyor. This patch adds the configuration file n

[libcxx] r300788 - change what branches Appveyor builds

2017-04-19 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Apr 19 18:27:48 2017 New Revision: 300788 URL: http://llvm.org/viewvc/llvm-project?rev=300788&view=rev Log: change what branches Appveyor builds Modified: libcxx/trunk/appveyor.yml Modified: libcxx/trunk/appveyor.yml URL: http://llvm.org/viewvc/llvm-project/libcxx/t

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

2017-04-19 Thread Richard Smith via Phabricator via cfe-commits
rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:1464 + /// Determine if \p D abd \p Suggested have a structurally compatibale + /// layout as described in C11 6.2.7/1. Typo 'abd' Comment at: lib/Parse/ParseDecl.cpp:4236-

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

2017-04-19 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D32199#731332, @rsmith wrote: > > ! In https://reviews.llvm.org/D32199#731252, @hfinkel wrote: > > > >> How about renaming this to something more like `-fsanitize=type`? > > > > I'm fine with that. Do you like TypeSanitizer or TypeAccessSanti

Re: Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

2017-04-19 Thread Eric Fiselier via cfe-commits
Adding cfe-dev list... On Wed, Apr 19, 2017 at 5:50 PM, Eric Fiselier wrote: > Hi Will, > > I would like to request collaborator permissions for the Libc++ github > mirror. > > I plan to use the access to setup Appveyor buildbots for libc++. In order > to do this I need to be listed as a collabo

Re: r300762 - Fix assertion failure in codegen on non-template deduction guide.

2017-04-19 Thread Galina Kistanova via cfe-commits
Hello Richard, This commit broke one of our builders: Failing Tests (1): Clang :: CodeGenCXX/cxx1z-class-deduction.cpp http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1267 Please have a look at this? Thanks Galina On Wed, Apr 19, 2017 at 2:15 PM, Richard

[PATCH] D32260: [TBAA] Vector types should (only) alias with their element types

2017-04-19 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel created this revision. Herald added a subscriber: mcrosier. Currently, all of our builtin vector types are equivalent to char for TBAA purposes. It would be useful to make this less conservative. This patch makes vector types equivalent to their element types for type-aliasing purposes.

r300802 - [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for

2017-04-19 Thread Carlo Bertolli via cfe-commits
Author: cbertol Date: Wed Apr 19 19:39:39 2017 New Revision: 300802 URL: http://llvm.org/viewvc/llvm-project?rev=300802&view=rev Log: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for https://reviews.llvm.org/D32237 This patch prepares sema with additional fie

[PATCH] D32251: Implement DR1601 - Promotion of enumeration with fixed underlying type

2017-04-19 Thread Richard Smith via Phabricator via cfe-commits
rsmith added inline comments. Comment at: lib/Sema/SemaOverload.cpp:3850-3853 // In Microsoft mode, prefer an integral conversion to a // floating-to-integral conversion if the integral conversion // is between types of the same size. // For example:

[PATCH] D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for

2017-04-19 Thread Carlo Bertolli via Phabricator via cfe-commits
carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 300802. Repository: rL LLVM https://reviews.llvm.org/D32237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D31885: Remove TBAA information from LValues representing union members

2017-04-19 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D31885#731306, @hfinkel wrote: > In https://reviews.llvm.org/D31885#730853, @hfinkel wrote: > > > > > > ... > > > > > > >> (And the nonsensicality of the standard very much continues. The code that > >> we've all agreed is obviously being m

[PATCH] D32192: Enable leak sanitizer builds for darwin

2017-04-19 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Please add a test case. The change itself looks reasonable. https://reviews.llvm.org/D32192 ___ cfe-commits mailing list cfe-commi

r300803 - Add a triple to codegen test.

2017-04-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 19 20:02:29 2017 New Revision: 300803 URL: http://llvm.org/viewvc/llvm-project?rev=300803&view=rev Log: Add a triple to codegen test. Modified: cfe/trunk/test/CodeGenCXX/cxx1z-class-deduction.cpp Modified: cfe/trunk/test/CodeGenCXX/cxx1z-class-deduction.cpp URL:

Re: r300762 - Fix assertion failure in codegen on non-template deduction guide.

2017-04-19 Thread Richard Smith via cfe-commits
Sorry about that, target triple added in r300803. On 19 April 2017 at 17:12, Galina Kistanova wrote: > Hello Richard, > > This commit broke one of our builders: > > Failing Tests (1): > Clang :: CodeGenCXX/cxx1z-class-deduction.cpp > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64- > e

[PATCH] D31568: Add Python 3 support to clang.cindex

2017-04-19 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. I think it would've been nice to split this up into the changes for map/filter rather than group it together. But sure, this looks reasonable. Repository: rL LLVM https://reviews.llvm

[PATCH] D18478: python bindings: expose the clang version string

2017-04-19 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a subscriber: jbcoe. compnerd added a comment. This revision is now accepted and ready to land. This would ideally wait for the change that @jbcoe has in the works to enable python 3, but the change itself is fine. https://reviews.llvm.org/D18478

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

2017-04-19 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. > As I've currently implemented it, both reads and writes set the type of > previously-unknown storage, and after that it says fixed (unless you memcpy > to it, memset it, or its lifetime ends (the type gets reset on > lifetime.start/end and for malloc/allocas/etc.). The

r300804 - [Sema] Use MSVC inner class behavior on Itanium

2017-04-19 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Wed Apr 19 20:11:42 2017 New Revision: 300804 URL: http://llvm.org/viewvc/llvm-project?rev=300804&view=rev Log: [Sema] Use MSVC inner class behavior on Itanium Windows Itanium aims to use MSVC export and import semantics. Inner class members shouldn't be exported on a dllexp

[PATCH] D32213: [Sema] Use MSVC inner class behavior on Itanium

2017-04-19 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL300804: [Sema] Use MSVC inner class behavior on Itanium (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D32213?vs=95689&id=95867#toc Repository: rL LLVM https://reviews.llvm

r300805 - PR32673: Don't wrap parameter packs in SubstTemplateTypeParmPackType nodes when forming implicit deduction guides.

2017-04-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 19 20:15:31 2017 New Revision: 300805 URL: http://llvm.org/viewvc/llvm-project?rev=300805&view=rev Log: PR32673: Don't wrap parameter packs in SubstTemplateTypeParmPackType nodes when forming implicit deduction guides. Doing so thwarts template type deduction. Instea

[libcxx] r300808 - Fix dllimport on a class template

2017-04-19 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Apr 19 20:45:15 2017 New Revision: 300808 URL: http://llvm.org/viewvc/llvm-project?rev=300808&view=rev Log: Fix dllimport on a class template Modified: libcxx/trunk/include/utility Modified: libcxx/trunk/include/utility URL: http://llvm.org/viewvc/llvm-project/libcx

[PATCH] D32263: Preprocessor: Suppress -Wnonportable-include-path for header maps

2017-04-19 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. If a file search involves a header map, suppress -Wnonportable-include-path. It's firing lots of false positives for framework authors internally, and it's not trivial to fix. Consider a framework called "Foo" with a main (installed) framework header "Foo/Foo.h"

[libcxx] r300809 - Make linker errors verbose on Windows

2017-04-19 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Apr 19 20:50:39 2017 New Revision: 300809 URL: http://llvm.org/viewvc/llvm-project?rev=300809&view=rev Log: Make linker errors verbose on Windows Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL: http://llvm.o

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

2017-04-19 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Ping. https://reviews.llvm.org/D31856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

2017-04-19 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Marshall, that's what I assumed originally, but I figured Hal had some non-standard-but-worth-supporting use case in mind. Hal, what do you think? https://reviews.llvm.org/D31561 ___ cfe-commits mailing list cfe-commits

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

2017-04-19 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Eric: somehow I never got an email notification for your review :/. If Marshall is okay with the current state, I'll document that before commit. https://reviews.llvm.org/D31561 ___ cfe-commits mailing list cfe-commits@

r300814 - [ODRHash] clean up test and add new examples. NFC

2017-04-19 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Wed Apr 19 21:53:53 2017 New Revision: 300814 URL: http://llvm.org/viewvc/llvm-project?rev=300814&view=rev Log: [ODRHash] clean up test and add new examples. NFC Use a macro to generate the struct with all decls. Previously, four identical changes would be needed to update

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

2017-04-19 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai updated this revision to Diff 95874. xiangzhai added a comment. Hi David, Thanks for your review! I updated my patch as you suggested! Please review it, thanks a lot! but I argue that: > I have the feeling this should be renamed. Since its purpose is to calculate > the total size ma

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

2017-04-19 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. Herald added subscribers: dschuff, jfb. Libc++ currently implements the `ATOMIC__LOCK_FREE` macros using the `__GCC_ATOMIC__LOCK_FREE` macros. However these are not available when MSVC compatibility is enabled even though C11 `_Atomic` is. This prevents libc++ fro

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

2017-04-19 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D31561#731498, @dexonsmith wrote: > Marshall, that's what I assumed originally, but I figured Hal had some > non-standard-but-worth-supporting use case in mind. In this case, future-proofing and mathematical precision seemed aligned. I susp

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

2017-04-19 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai resigned from this revision. smeenai edited reviewers, added: compnerd; removed: smeenai. smeenai added a comment. This looks good to me, but I'm not familiar enough with this part of clang to be comfortable accepting. https://reviews.llvm.org/D32265 _

[PATCH] D32260: [TBAA] Vector types should (only) alias with their element types

2017-04-19 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel abandoned this revision. hfinkel added a comment. @rjmccall said, on this topic, in https://reviews.llvm.org/D31885: > The root problem there is that the design of vector types and vector > interfaces is generally quite bad; you cannot rely on things like vectors > being stored with an

[libcxx] r300817 - Rename the static version of libc++ on Windows.

2017-04-19 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Apr 19 23:19:02 2017 New Revision: 300817 URL: http://llvm.org/viewvc/llvm-project?rev=300817&view=rev Log: Rename the static version of libc++ on Windows. Previously both the static version of libc++ and the import library for the DLL had the same name, 'c++.lib'. This

[PATCH] D29827: [AVR] Add -mmcu option to the driver

2017-04-19 Thread Leslie Zhai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL300818: [AVR] Add -mmcu option to the driver (authored by xiangzhai). Changed prior to commit: https://reviews.llvm.org/D29827?vs=95707&id=95879#toc Repository: rL LLVM https://reviews.llvm.org/D298

r300818 - [AVR] Add -mmcu option to the driver

2017-04-19 Thread Leslie Zhai via cfe-commits
Author: xiangzhai Date: Wed Apr 19 23:23:24 2017 New Revision: 300818 URL: http://llvm.org/viewvc/llvm-project?rev=300818&view=rev Log: [AVR] Add -mmcu option to the driver A patch by Peter Wu! Reviewers: jroelofs, xiangzhai Reviewed By: jroelofs, dylanmckay, xiangzhai Subscribers: dlj, dylanm

[libcxx] r300820 - Disable the filesystem library on Windows by default

2017-04-19 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Apr 19 23:24:29 2017 New Revision: 300820 URL: http://llvm.org/viewvc/llvm-project?rev=300820&view=rev Log: Disable the filesystem library on Windows by default Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/l

[PATCH] D32248: CodeGen: Cast alloca to expected address space

2017-04-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1105-1119 + // Alloca always returns a pointer in alloca address space, which may + // be different from the type defined by the language. For example, + // in C++ the auto variables are in the default address sp

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

2017-04-19 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai updated this revision to Diff 95880. Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c === --- test/Analy

[PATCH] D31975: [Analyzer] Iterator Checkers

2017-04-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I think for this case it'd be great to (instead) add comments all over the place (especially in checker callbacks, eg. `check[Pre|Post]Call()` function bodies) to indicate what check every piece of code is for. That'd be equally easy to review, at least for me, but it'd als

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

2017-04-19 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai created this revision. Hi LLVM developers, I am a Linux engineer of operating system department at iSOFT , I want to add iSOFTLinux to GNU ToolChains X86Triple, please review my patch, thanks a lot! Regards, Leslie Zhai Repository: rL LLVM h

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

2017-04-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Yay, now that's a lot cleaner! Regarding style, recently we tend to ask for updating the style in the new code, and i don't think the Golden Rule (http://llvm.org/docs/CodingStandards.html#introduction) does much in our case, but i don't have a strong opinion on that. Mayb

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

2017-04-19 Thread Mehdi Amini via cfe-commits
What would be the status of these buildbots? Is it for your private usage? Otherwise having “project' bots” using a non-official mirror may sound like a strange situation to me. — Mehdi > On Apr 19, 2017, at 5:04 PM, Eric Fiselier via llvm-dev > wrote: > > Adding cfe-dev list... > > On Wed

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

2017-04-19 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai updated this revision to Diff 95887. xiangzhai added a comment. Hi Artem, Thanks for your review! I updated my patch, please review it. Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/

[PATCH] D32248: CodeGen: Cast alloca to expected address space

2017-04-19 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1118 +AddrTy->getElementType()->getPointerTo(ExpectedAddrSpace)), +address.getAlignment()); + } This is a lot of work to be doing in a pretty common routine for the benefit of on

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

2017-04-19 Thread Daniel Marjamäki via Phabricator via cfe-commits
danielmarjamaki added a comment. > I hold the view that I need to respect original developers' code, and it need > a Global Patch for Capital variable, just like KDE's Use nullptr everywhere Yes I was too picky. Please respect the original developers' code. Comment at: lib/St

[PATCH] D31975: [Analyzer] Iterator Checkers

2017-04-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Hmm. 1. Could you do renaming the checker file in a separate patch, so that we saw an actual diff, not a whole greenish file, here on phabricator? 2. The invalidated iterator checker looks relatively small (a single check and a few rounds of iterator invalidations), would i

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

2017-04-19 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai added a comment. Hi Daniel, I respect you! the father of cppcheck and KDE's buildbot use cppcheck for example Static Analysis K3B thanks for your great job! Regards, Leslie Zhai Repository:

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2017-04-19 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added a comment. I agree that scan-build or scan-build-py integration is an important issue to resolve here. What I envision is that users will just call scan-build and pass -whole-project as an option to it. Everything else will happen automagically:) Another concern is dumping the A

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

2017-04-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 95890. NoQ marked 5 inline comments as done. NoQ added a comment. Fix comments! https://reviews.llvm.org/D31982 Files: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp lib/StaticAnalyzer/Core/Store.cpp test/Analysis/explain-svals.cpp test/Analysis/inlini

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

2017-04-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:965 + +// Performing operator `&' on an lvalue expression is essentially a no-op. +// Then, if we are taking addresses of fields or elements, these are also zaks.anna w

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

2017-04-19 Thread Daniel Marjamäki via Phabricator via cfe-commits
danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:788 +SVal MallocChecker::SValBinMulOp(CheckerContext &C, const Expr *Blocks, + const Expr *BlockBytes, ProgramStateRef State) { dan

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

2017-04-19 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai updated this revision to Diff 95894. xiangzhai added a comment. `SValBinMulOp` -> `evalMulForBufferSize` Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

2017-04-19 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai marked an inline comment as done. xiangzhai added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:788 +SVal MallocChecker::SValBinMulOp(CheckerContext &C, const Expr *Blocks, + const Expr *BlockBytes, ProgramS

<    1   2