[libcxx] r300530 - Update google benchmark

Author: ericwf Date: Tue Apr 18 02:17:20 2017 New Revision: 300530 URL: http://llvm.org/viewvc/llvm-project?rev=300530&view=rev Log: Update google benchmark Added: libcxx/trunk/utils/google-benchmark/cmake/Config.cmake.in libcxx/trunk/utils/google-benchmark/docs/ libcxx/trunk/utils/go

[PATCH] D30863: [clang-format] make docs/tools/{dump_format_style.py, dump_ast_matchers.py} flake8 compliant

sylvestre.ledru added a comment. Manuel, ping? https://reviews.llvm.org/D30863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r300533 - Emit benchmark tests into the benchmarks build directory, not lib/

Author: ericwf Date: Tue Apr 18 02:40:22 2017 New Revision: 300533 URL: http://llvm.org/viewvc/llvm-project?rev=300533&view=rev Log: Emit benchmark tests into the benchmarks build directory, not lib/ Modified: libcxx/trunk/benchmarks/CMakeLists.txt Modified: libcxx/trunk/benchmarks/CMakeList

[PATCH] D31976: Avoid assert when a non-static member function is qualified with __unaligned

rogfer01 added a comment. `clang::Sema::IsOverload` explicitly forbids the `__restrict` case for the qualifier of non-static member functions. I assume `__unaligned` is not forbidden because the MSVC ABI does encode this qualifier while the Itanium ABI currently does not. This patch just makes

[clang-tools-extra] r300534 - [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

Author: hokein Date: Tue Apr 18 02:46:39 2017 New Revision: 300534 URL: http://llvm.org/viewvc/llvm-project?rev=300534&view=rev Log: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations Summary: The "performance-inefficient-vector-operation" check finds vector oprations

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

This revision was automatically updated to reflect the committed changes. Closed by commit rL300534: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D31757?vs=95338&id=95534#toc Repository:

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein added a comment. @alexfh, I'm submitting the patch now. If you have following comments, I'm happy to address them afterwards. Repository: rL LLVM https://reviews.llvm.org/D31757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D32144: [Coverage] Don't emit mappings for functions in dependent contexts (fixes PR32679)

adamf added a comment. !MD->getParent()->getDescribedClassTemplate() looks like redundant now. This check is already done in isDependentContext. https://reviews.llvm.org/D32144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D31029: [analyzer] Fix logical not for pointers with different bit width

danielmarjamaki added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D31029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki added a comment. I would recommend that this is either fixed soon or that we commit my changes so it can be implemented more properly later. Right now users will see false positives. Repository: rL LLVM https://reviews.llvm.org/D31097 _

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi Artem, If it looks good to you, I want to try commit by myself for testing commit, thanks! Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D32144: [Coverage] Don't emit mappings for functions in dependent contexts (fixes PR32679)

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. I agree with Adam, the old check is now redundant. LGTM after removing it. Comment at: test/CoverageMapping/pr32679.cpp:2 +// RUN: %clang_cc1 -cc1 -triple i686-pc-window

[PATCH] D30489: [analyzer] catch out of bounds for VLA

danielmarjamaki added a comment. I would propose that I rename and cleanup RangeConstraintManager::uglyEval() and add it. When I tested it, the Z3 does not seem to handle this. Repository: rL LLVM https://reviews.llvm.org/D30489 ___ cfe-commits

Re: r299226 - [Modules][PCH] Serialize #pragma pack

Thanks Duncan! On 15 April 2017 at 01:25, Duncan P. N. Exon Smith wrote: > FYI, I reverted the modules side of this in r300380. For details, see the > commit message. TL;DR: this didn't actually make modules builds closer to > matching non-modules builds, thanks to how submodules work; on the

[PATCH] D31739: Add markup for libc++ dylib availability

arphaman added inline comments. Comment at: include/__config:1160 + +#endif // _LIBCPP_CONFIG Redundant whitespace added? Comment at: utils/libcxx/test/config.py:358 +def add_deployement_feature(self, feature): +(arch, name, vers

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

sanwou01 updated this revision to Diff 95541. sanwou01 added a comment. Rebased and clang-formatted. https://reviews.llvm.org/D31709 Files: include/clang/Basic/SourceLocation.h include/clang/Frontend/DiagnosticRenderer.h include/clang/Frontend/TextDiagnostic.h lib/Basic/SourceLocation.c

[PATCH] D32132: [AArch64][clang] Pass cpu/arch information to assembler for AArch64.

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Silly omission. LGTM. Thanks! https://reviews.llvm.org/D32132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D32159: [NFC] Move ParseDiagnosticArgs into Frontend

sanwou01 created this revision. Herald added subscribers: mgorny, klimek. https://reviews.llvm.org/D32159 Files: include/clang/Frontend/CompilerInvocation.h include/clang/Frontend/DiagnosticOptions.h lib/Frontend/CMakeLists.txt lib/Frontend/CompilerInvocation.cpp lib/Frontend/Diagnostic

r300540 - [TableGen] Fix MSVC warning that occurs in TableGen generated function

Author: arphaman Date: Tue Apr 18 04:59:27 2017 New Revision: 300540 URL: http://llvm.org/viewvc/llvm-project?rev=300540&view=rev Log: [TableGen] Fix MSVC warning that occurs in TableGen generated function This should fix the Windows buildbot failure that happened after r300539. Modified: cf

r300542 - Fix one more 'not all control paths return a value' MSVC warning

Author: arphaman Date: Tue Apr 18 05:17:41 2017 New Revision: 300542 URL: http://llvm.org/viewvc/llvm-project?rev=300542&view=rev Log: Fix one more 'not all control paths return a value' MSVC warning The warning was caused by r300539. Modified: cfe/trunk/lib/Parse/ParsePragma.cpp cfe/tru

[PATCH] D23610: [ARM] Add pre-defined macros for ROPI and RWPI

olista01 added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D23610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31501: [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine

sanwou01 updated this revision to Diff 95548. sanwou01 added a comment. Herald added subscribers: mgorny, klimek. Rebase on top of https://reviews.llvm.org/D31709 and https://reviews.llvm.org/D32159 https://reviews.llvm.org/D31501 Files: include/clang/Basic/Diagnostic.h include/clang/Basic

[PATCH] D31501: [diagnostics] Integrate clang -cc1as diagnostics into DiagnosticsEngine

sanwou01 updated this revision to Diff 95549. sanwou01 added a comment. Don't include the changes from https://reviews.llvm.org/D31709 and https://reviews.llvm.org/D32159 in this patch (oops). https://reviews.llvm.org/D31501 Files: include/clang/Basic/Diagnostic.h include/clang/Basic/Sourc

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

danielmarjamaki added a comment. Please click "Done" on fixed review comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2038 + // If the size can be nonzero, we have to check the other arguments. + if (StateNonZeroSize) { +State = StateNonZeroSize; -

[PATCH] D31830: Emit invariant.group.barrier when using union field

Prazek added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3517 +CGM.getCodeGenOpts().StrictVTablePointers && +CGM.getCodeGenOpts().OptimizationLevel > 0) + addr = Address(Builder.CreateInvariantGroupBarrier(addr.getPointer()), rjmccall

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

baloghadamsoftware added a comment. OK, please create a patch where implicit casts are disabled by default. You can also find a new name for the checker. Repository: rL LLVM https://reviews.llvm.org/D31097 ___ cfe-commits mailing list cfe-commit

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

baloghadamsoftware added a comment. Or I can do it for you if you wish. Repository: rL LLVM https://reviews.llvm.org/D31097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32161: Testing commit access.

manojgupta created this revision. Test commit access. https://reviews.llvm.org/D32161 Files: unittests/Driver/ToolChainTest.cpp Index: unittests/Driver/ToolChainTest.cpp === --- unittests/Driver/ToolChainTest.cpp +++ unittests/

[clang-tools-extra] r300545 - clang-tools-extra/test/clang-tidy/performance-inefficient-vector-operation.cpp: Appease targeting msvc with -fno-ms-extensions.

Author: chapuni Date: Tue Apr 18 07:13:30 2017 New Revision: 300545 URL: http://llvm.org/viewvc/llvm-project?rev=300545&view=rev Log: clang-tools-extra/test/clang-tidy/performance-inefficient-vector-operation.cpp: Appease targeting msvc with -fno-ms-extensions. FIXME: This may work with -target

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki added a comment. > Or I can do it for you if you wish. yes please Repository: rL LLVM https://reviews.llvm.org/D31097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis added a comment. Realised I've some comments to submit. Comment at: lib/Sema/SemaExpr.cpp:8032 + + return InvalidOperands(Loc, LHS, RHS); +} bruno wrote: > Double checking here: are there tests for the `InvalidOperands` case above? Yes, this case is co

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

chapuni added a comment. Does it work for targeting msvc? See also; http://bb.pgr.jp/builders/test-clang-tools-msc-x64-on-i686-linux-RA/builds/1043 Appeased in r300545. Would it be happier if it worked with "-target x86_64-win32"? Repository: rL LLVM https://reviews.llvm.org/D31757

r300549 - [ARM, AArch64] Define __ELF__ for arm-none-eabihf and AArch64

Author: olista01 Date: Tue Apr 18 08:12:36 2017 New Revision: 300549 URL: http://llvm.org/viewvc/llvm-project?rev=300549&view=rev Log: [ARM,AArch64] Define __ELF__ for arm-none-eabihf and AArch64 This macro is defined for arm-none-eabi as of r266625, but it should also be defined for eabihf and a

r300550 - [ARM] Add hardware build attributes in assembler

Author: olista01 Date: Tue Apr 18 08:21:05 2017 New Revision: 300550 URL: http://llvm.org/viewvc/llvm-project?rev=300550&view=rev Log: [ARM] Add hardware build attributes in assembler This passes an option to the ARM assembly parser to emit build attributes for the hardware selected by command li

[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D31542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:494 + SymbolManager &SM = C.getSymbolManager(); + return SM.getDerivedSymbol(Sym, LCV.getRegion()); } vlad.tsyrklevich wrote: > NoQ wrote: > > vlad.tsyrklevich wrote: >

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

NoQ added a comment. Wow, so you're doing the binding thing now? Thanks! It was not critical for landing this patch, so you could have fixed comments here, allowing us to commit what's already done, and then proceed with further improvements. It's also easier to review and aligns with the LLVM'

[PATCH] D32164: [clang-tidy] misc-misplaced-widening-cast: Disable checking of implicit widening casts by default

baloghadamsoftware created this revision. Herald added a subscriber: whisperity. Users reported some false positives using this check. This patch sets the default value of the option for checking implicit widening casts to false. We also suggest renaming the check to something like missing-or-mi

r300555 - Driver: Better detection of mingw-gcc

Author: martell Date: Tue Apr 18 09:27:36 2017 New Revision: 300555 URL: http://llvm.org/viewvc/llvm-project?rev=300555&view=rev Log: Driver: Better detection of mingw-gcc Stop blindly searching for "gcc.exe" on windows. Stop assuming "/usr" on unix, fixes cross compiling. Reviewers: mati865, ya

[PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

This revision was automatically updated to reflect the committed changes. Closed by commit rL300555: Driver: Better detection of mingw-gcc (authored by martell). Changed prior to commit: https://reviews.llvm.org/D15005?vs=41206&id=95568#toc Repository: rL LLVM https://reviews.llvm.org/D1500

[PATCH] D15006: Driver: Better detection of mingw-gcc

martell added a comment. Committed as https://reviews.llvm.org/rL300555 Repository: rL LLVM https://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r300555 - Driver: Better detection of mingw-gcc

I think you've got the wrong Phabricator link in the commit log. On 18 April 2017 at 15:27, Martell Malone via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: martell > Date: Tue Apr 18 09:27:36 2017 > New Revision: 300555 > > URL: http://llvm.org/viewvc/llvm-project?rev=300555&view=re

[PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

martell added a comment. In case anyone comes here looking for https://reviews.llvm.org/rL300555 that should be https://reviews.llvm.org/D15006 no https://reviews.llvm.org/D15005. Thanks Repository: rL LLVM https://reviews.llvm.org/D15005 ___ c

[PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

martell added a comment. It won't let me revert the automatically updated diff to the previous one because I am not the author. @faisalv are you able todo this and Sorry for the confusion. Repository: rL LLVM https://reviews.llvm.org/D15005 ___

Re: r300555 - Driver: Better detection of mingw-gcc

Yes I do :) I updated https://reviews.llvm.org/D15005 with a comment incase anyone goes there. I also updated https://reviews.llvm.org/D15006 (the correct link) to point to the commit revision. Thanks for pointing that out Alex On Tue, Apr 18, 2017 at 3:49 PM, Alex L wrote: > I think you've got

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi All, Thanks for your review! I will update my patch tomorrow! Almost 4+ days no see, I miss you :) Regards, Leslie Zhaii Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list cfe-commits

Re: r300555 - Driver: Better detection of mingw-gcc

No problem, thanks for the quick update! On 18 April 2017 at 15:56, Martell Malone wrote: > Yes I do :) > I updated https://reviews.llvm.org/D15005 with a comment incase anyone > goes there. > I also updated https://reviews.llvm.org/D15006 (the correct link) to > point to the commit revision. >

r300560 - [ASTPrinter] Print template parameter lists for out-of-line functions

Author: arphaman Date: Tue Apr 18 10:12:34 2017 New Revision: 300560 URL: http://llvm.org/viewvc/llvm-project?rev=300560&view=rev Log: [ASTPrinter] Print template parameter lists for out-of-line functions Modified: cfe/trunk/lib/AST/DeclPrinter.cpp cfe/trunk/test/Misc/ast-print-out-of-lin

[PATCH] D32081: Add support for editor placeholders to Clang's lexer

benlangmuir added inline comments. Comment at: include/clang/Basic/IdentifierTable.h:358 + /// Return true if this identifier is an editor placeholder. + bool isEditorPlaceholder() const { Nitpick: There should probably be an example in the doc comment. The

r300562 - mingw-w64: enable support for __declspec(selectany)

Author: martell Date: Tue Apr 18 10:56:24 2017 New Revision: 300562 URL: http://llvm.org/viewvc/llvm-project?rev=300562&view=rev Log: mingw-w64: enable support for __declspec(selectany) Add selectany as a GCC spelling for mingw-w64 Reviewers: rnk Differential revision: https://reviews.llvm.org/

[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

joshz added a comment. Thanks, Aaron! Repository: rL LLVM https://reviews.llvm.org/D31542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

joshz added a comment. I don't believe I have access to commit this revision myself; can someone please do it for me? Thanks! :-) Repository: rL LLVM https://reviews.llvm.org/D31542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D32170: Add a FixItHint for -Wmissing-prototypes to insert 'static '.

alexfh created this revision. Missing 'static' on functions that are intended to be local to a translation unit seems to be the most common cause of -Wmissing-prototypes warnings, so suggesting a fix seems to be convenient and useful. https://reviews.llvm.org/D32170 Files: include/clang/Basic

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein added a comment. @chapuni, thanks for the workaround. It makes sense to make it work for targeting msvc. Will fix it in a follow-up. Repository: rL LLVM https://reviews.llvm.org/D31757 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang-tools-extra] r300563 - Make the test pass on x86_64-win32 target.

Author: hokein Date: Tue Apr 18 11:25:03 2017 New Revision: 300563 URL: http://llvm.org/viewvc/llvm-project?rev=300563&view=rev Log: Make the test pass on x86_64-win32 target. Modified: clang-tools-extra/trunk/test/clang-tidy/performance-inefficient-vector-operation.cpp Modified: clang-too

[PATCH] D32176: Add #pragma clang attribute support for the external_source_symbol attribute

arphaman created this revision. Right now the `external_source_symbol` attribute isn't supported by `#pragma clang attribute` for the following two reasons: - The `Named` attribute subject isn't supported by TableGen. - There was no way to specify a subject match rule for `#pragma clang attribu

[PATCH] D32176: Add #pragma clang attribute support for the external_source_symbol attribute

arphaman updated this revision to Diff 95593. arphaman added a comment. Avoid a vector copy by using a reference variable. Repository: rL LLVM https://reviews.llvm.org/D32176 Files: include/clang/Basic/Attr.td lib/Sema/SemaDeclAttr.cpp test/Misc/pragma-attribute-supported-attributes-li

[PATCH] D32164: [clang-tidy] misc-misplaced-widening-cast: Disable checking of implicit widening casts by default

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D32164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D32081: Add support for editor placeholders to Clang's lexer

arphaman updated this revision to Diff 95596. arphaman marked 2 inline comments as done. arphaman added a comment. Add comments and remove `-fno-allow-editor-placeholders` from CC1 options. Repository: rL LLVM https://reviews.llvm.org/D32081 Files: include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D32178: Delete unstable integration tests

jroelofs created this revision. These tests are breaking when tested under the upstream 3.8.1 release + the 10.12 / 16C58 sdk. They use headers from the host SDKs, so they are not stable with respect to adding new language features, such as class `@properties`. Regression tests should not depen

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

alexfh added a comment. Awesome, thanks! A few late comments inline. Comment at: clang-tools-extra/trunk/clang-tidy/performance/InefficientVectorOperationCheck.cpp:56 +void InefficientVectorOperationCheck::registerMatchers(MatchFinder *Finder) { + const auto VectorDecl = cxxR

[libcxx] r300568 - Mark LWG#2788 as complete - we already do this

Author: marshall Date: Tue Apr 18 12:22:49 2017 New Revision: 300568 URL: http://llvm.org/viewvc/llvm-project?rev=300568&view=rev Log: Mark LWG#2788 as complete - we already do this Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.or

[clang-tools-extra] r300569 - [clang-tidy] Fix google-explicit-constructor issue with out-of-line conversions

Author: alexfh Date: Tue Apr 18 12:26:00 2017 New Revision: 300569 URL: http://llvm.org/viewvc/llvm-project?rev=300569&view=rev Log: [clang-tidy] Fix google-explicit-constructor issue with out-of-line conversions Modified: clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.cpp

r300570 - Testing commit access.

Author: manojgupta Date: Tue Apr 18 12:34:46 2017 New Revision: 300570 URL: http://llvm.org/viewvc/llvm-project?rev=300570&view=rev Log: Testing commit access. Summary: Test commit access. Reviewers: gbiv, george.burgess.iv Reviewed By: george.burgess.iv Subscribers: cfe-commits Differential

r300571 - [AArch64][clang] Pass cpu/arch information to assembler for AArch64.

Author: manojgupta Date: Tue Apr 18 12:36:10 2017 New Revision: 300571 URL: http://llvm.org/viewvc/llvm-project?rev=300571&view=rev Log: [AArch64][clang] Pass cpu/arch information to assembler for AArch64. Summary: Pass Cpu/Arch options to assembler for AArch64 with no-integrated-as. This fixes P

r300572 - Remove unused varible

Author: rnk Date: Tue Apr 18 12:44:41 2017 New Revision: 300572 URL: http://llvm.org/viewvc/llvm-project?rev=300572&view=rev Log: Remove unused varible The Result variable is unused both in Sema::CheckARMBuiltinFunctionCall and Sema::CheckAArch64BuiltinFunctionCall, remove it. Patch by Wei-Ren C

[PATCH] D32014: Remove unused varible

This revision was automatically updated to reflect the committed changes. Closed by commit rL300572: Remove unused varible (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D32014?vs=95123&id=95602#toc Repository: rL LLVM https://reviews.llvm.org/D32014 Files: cfe/trunk

[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

alexfh accepted this revision. alexfh added a comment. LG with one nit. Comment at: clang-tidy/readability/ContainerSizeEmptyCheck.cpp:209 + "the 'empty' method should be used to check " + "for emptiness instead of comparing to an empty object.") +<< Hin

[PATCH] D32181: Remove use of coverage-file flag

aaron.ballman created this revision. The -coverage-file flag was removed in r280306, but I believe this part may have been missed. However, since I'm unfamiliar with this feature, I wanted to be sure. https://reviews.llvm.org/D32181 Files: lib/Driver/Job.cpp Index: lib/Driver/Job.cpp

[PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

alexfh added inline comments. Comment at: cfe/trunk/include/clang/Basic/AttrDocs.td:2792 + namespace N { +[[clang::suppress("type", "bounds")]]; +... Should this be `gsl::suppress` as well? Repository: rL LLVM https://reviews.llvm.org/D24886

[PATCH] D32119: Emit warning when umbrella directory does not exists

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[libcxx] r300575 - [test] Silence unused parameter/typedef warnings

Author: caseycarter Date: Tue Apr 18 13:44:33 2017 New Revision: 300575 URL: http://llvm.org/viewvc/llvm-project?rev=300575&view=rev Log: [test] Silence unused parameter/typedef warnings Modified: libcxx/trunk/test/std/language.support/support.exception/except.nested/throw_with_nested.pass.c

Re: [libcxx] r300575 - [test] Silence unused parameter/typedef warnings

Sorry I've been meaning to enable `-Wunused-typedef" for a while but I haven't had a chance to clean up the remaining occurrences Thanks for the cleanup. On Tue, Apr 18, 2017 at 12:44 PM, Casey Carter via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: caseycarter > Date: Tue Apr 18 1

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

eugenis added a comment. Ping. I don't really have a preference. Repository: rL LLVM https://reviews.llvm.org/D32064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300578 - [DOXYGEN] Minor improvements in doxygen comments.

Author: kromanova Date: Tue Apr 18 14:44:07 2017 New Revision: 300578 URL: http://llvm.org/viewvc/llvm-project?rev=300578&view=rev Log: [DOXYGEN] Minor improvements in doxygen comments. - To be consistent with the rest of the intrinsics headers, I removed the tags .. for marking instruction na

[libcxx] r300581 - [test] Silence another unused-typedef warning

Author: caseycarter Date: Tue Apr 18 15:04:39 2017 New Revision: 300581 URL: http://llvm.org/viewvc/llvm-project?rev=300581&view=rev Log: [test] Silence another unused-typedef warning Modified: libcxx/trunk/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move_convert.

[PATCH] D32046: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments

erichkeane added a comment. Bump! I'll note that this patch has nothing to do with MSVC and should simply be a memory-usage savings. https://reviews.llvm.org/D32046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D32187: [CodeGen][ObjC]

ahatanak created this revision. This fixes a bug in EmitObjCForCollectionStmt which is causing clang to generate malformed IR. When the following code (which I think is legal, at least when it is not compiled with ARC) is compiled: $ cat test1.m @interface Obj @end void bar(void); voi

[PATCH] D31976: Avoid assert when a non-static member function is qualified with __unaligned

ahatanak added a comment. I see, thank you for the explanation. https://reviews.llvm.org/D31976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r300588 - [clang-tidy] Address a few late comments.

Author: hokein Date: Tue Apr 18 15:47:34 2017 New Revision: 300588 URL: http://llvm.org/viewvc/llvm-project?rev=300588&view=rev Log: [clang-tidy] Address a few late comments. Modified: clang-tools-extra/trunk/clang-tidy/performance/InefficientVectorOperationCheck.cpp Modified: clang-tools-

r300591 - The SubjectMatchRule enum should not be used as a DenseMap key to avoid

Author: arphaman Date: Tue Apr 18 15:54:23 2017 New Revision: 300591 URL: http://llvm.org/viewvc/llvm-project?rev=300591&view=rev Log: The SubjectMatchRule enum should not be used as a DenseMap key to avoid UBSAN 'invalid value' failures The commit r300556 introduced a UBSAN issue that was caught

[PATCH] D32187: [CodeGen][ObjC]

rjmccall added a comment. I wouldn't mind unconditionally banning this in JumpDiagnostics, actually. https://reviews.llvm.org/D32187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300594 - PR30508: Downgrade error to warning if the umbrella folder doesn't exist.

Author: vvassilev Date: Tue Apr 18 15:57:29 2017 New Revision: 300594 URL: http://llvm.org/viewvc/llvm-project?rev=300594&view=rev Log: PR30508: Downgrade error to warning if the umbrella folder doesn't exist. Patch by Yuka Takahashi (D32119)! Modified: cfe/trunk/include/clang/Basic/Diagnost

[libcxx] r300595 - Cleanup _LIBCPP_HAS_NO_ for std::set and std::multiset

Author: ericwf Date: Tue Apr 18 15:58:03 2017 New Revision: 300595 URL: http://llvm.org/viewvc/llvm-project?rev=300595&view=rev Log: Cleanup _LIBCPP_HAS_NO_ for std::set and std::multiset Modified: libcxx/trunk/include/set libcxx/trunk/test/std/containers/associative/multiset/emplace.pass

[PATCH] D32119: Emit warning when umbrella directory does not exists

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r300594. https://reviews.llvm.org/D32119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r300600 - Cleanup _LIBCPP_HAS_NO_ macros in std::map and std::multimap

Author: ericwf Date: Tue Apr 18 16:08:06 2017 New Revision: 300600 URL: http://llvm.org/viewvc/llvm-project?rev=300600&view=rev Log: Cleanup _LIBCPP_HAS_NO_ macros in std::map and std::multimap Modified: libcxx/trunk/include/map libcxx/trunk/test/std/containers/associative/map/map.access

[libcxx] r300602 - Cleanup _LIBCPP_HAS_NO_ macro uses in std::stack.

Author: ericwf Date: Tue Apr 18 16:16:26 2017 New Revision: 300602 URL: http://llvm.org/viewvc/llvm-project?rev=300602&view=rev Log: Cleanup _LIBCPP_HAS_NO_ macro uses in std::stack. Modified: libcxx/trunk/include/stack libcxx/trunk/test/std/containers/container.adaptors/stack/stack.cons

[PATCH] D32192: Enable leak sanitizer builds for darwin

fjricci created this revision. Support for leak sanitizer on darwin has been added to compiler-rt, this patch adds compiler support. https://reviews.llvm.org/D32192 Files: lib/Driver/ToolChains/Darwin.cpp Index: lib/Driver/ToolChains/Darwin.cpp ==

[libcxx] r300604 - Cleanup _LIBCPP_HAS_NO_ for std::queue and std::priority_queue.

Author: ericwf Date: Tue Apr 18 16:23:18 2017 New Revision: 300604 URL: http://llvm.org/viewvc/llvm-project?rev=300604&view=rev Log: Cleanup _LIBCPP_HAS_NO_ for std::queue and std::priority_queue. Modified: libcxx/trunk/include/queue libcxx/trunk/test/std/containers/container.adaptors/pr

[PATCH] D32170: Add a FixItHint for -Wmissing-prototypes to insert 'static '.

djasper added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11652 static bool ShouldWarnAboutMissingPrototype(const FunctionDecl *FD, - const FunctionDecl*& PossibleZeroParamPrototype) { + const FunctionDecl*& Possible

r300609 - Do not warn about whitespace between ??/ trigraph and newline in line comments if trigraphs are disabled in the current language.

Author: rsmith Date: Tue Apr 18 16:45:04 2017 New Revision: 300609 URL: http://llvm.org/viewvc/llvm-project?rev=300609&view=rev Log: Do not warn about whitespace between ??/ trigraph and newline in line comments if trigraphs are disabled in the current language. Modified: cfe/trunk/lib/Lex/L

r300611 - [modules-ts] Fold together -x c++ and -x c++-module at -cc1 level.

Author: rsmith Date: Tue Apr 18 16:55:37 2017 New Revision: 300611 URL: http://llvm.org/viewvc/llvm-project?rev=300611&view=rev Log: [modules-ts] Fold together -x c++ and -x c++-module at -cc1 level. The driver needs to know whether it's building a module interface or implementation unit because

[libcxx] r300619 - Cleanup _LIBCPP_HAS_NO_ macros in std::unordered_set and std::unordered_multiset

Author: ericwf Date: Tue Apr 18 17:37:32 2017 New Revision: 300619 URL: http://llvm.org/viewvc/llvm-project?rev=300619&view=rev Log: Cleanup _LIBCPP_HAS_NO_ macros in std::unordered_set and std::unordered_multiset Modified: libcxx/trunk/include/unordered_set libcxx/trunk/test/std/contain

[libcxx] r300620 - Cleanup _LIBCPP_HAS_NO_ in std::unordered_map and std::unordered_multimap

Author: ericwf Date: Tue Apr 18 17:50:56 2017 New Revision: 300620 URL: http://llvm.org/viewvc/llvm-project?rev=300620&view=rev Log: Cleanup _LIBCPP_HAS_NO_ in std::unordered_map and std::unordered_multimap This completes the cleanup of the containers, at least within the tests. Modified: l

[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

joshz updated this revision to Diff 95655. joshz added a comment. Updated per some suggestions by sbenza@ on dealing with the parentheses; IsBinaryOrTernary is based on a function he wrote at Google. PTAL. Repository: rL LLVM https://reviews.llvm.org/D31542 Files: clang-tidy/readability/

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel created this revision. Herald added subscribers: mcrosier, emaste. This patch introduces the runtime components of a TBAA sanitizer: a sanitizer for type-based aliasing violations. C/C++ have type-based aliasing rules, and LLVM's optimizer can exploit these given TBAA metadata added by

[libcxx] r300622 - Cleanup _LIBCPP_HAS_NO_ macros in thread.

Author: ericwf Date: Tue Apr 18 18:05:08 2017 New Revision: 300622 URL: http://llvm.org/viewvc/llvm-project?rev=300622&view=rev Log: Cleanup _LIBCPP_HAS_NO_ macros in thread. Modified: libcxx/trunk/include/__mutex_base libcxx/trunk/include/mutex libcxx/trunk/include/thread libcxx

[libcxx] r300623 - Cleanup _LIBCPP_HAS_NO_ macros for std::initializer_list

Author: ericwf Date: Tue Apr 18 18:09:36 2017 New Revision: 300623 URL: http://llvm.org/viewvc/llvm-project?rev=300623&view=rev Log: Cleanup _LIBCPP_HAS_NO_ macros for std::initializer_list Added: libcxx/trunk/test/std/language.support/support.initlist/include_cxx03.pass.cpp Modified: li

[libcxx] r300625 - Cleanup _LIBCPP_HAS_NO_ in algorithm

Author: ericwf Date: Tue Apr 18 18:26:47 2017 New Revision: 300625 URL: http://llvm.org/viewvc/llvm-project?rev=300625&view=rev Log: Cleanup _LIBCPP_HAS_NO_ in algorithm Modified: libcxx/trunk/include/algorithm libcxx/trunk/test/std/algorithms/alg.modifying.operations/alg.move/move.pass.

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

mclow.lists added inline comments. Comment at: libcxx/include/math.h:400 +inline _LIBCPP_INLINE_VISIBILITY +typename std::enable_if::value, int>::type +fpclassify(_A1 __lcpp_x) _NOEXCEPT hfinkel wrote: > Maybe we should predicate this, and other infinity-related

  1   2   >