mehdi_amini added a comment.
Ping?
https://reviews.llvm.org/D31739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Sun Apr 16 04:19:59 2017
New Revision: 300420
URL: http://llvm.org/viewvc/llvm-project?rev=300420&view=rev
Log:
[coroutines] Fix building of new/delete expressions when
get_return_object_on_allocation_failure() is present.
Summary:
This patch implements [dcl.fct.def.coroutin
Author: ericwf
Date: Sun Apr 16 04:34:28 2017
New Revision: 300421
URL: http://llvm.org/viewvc/llvm-project?rev=300421&view=rev
Log:
Revert r300420 - [coroutines] Fix building of new/delete expressions when
get_return_object_on_allocation_failure() is present
Modified:
cfe/trunk/include/clan
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D32112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
v.g.vassilev added a comment.
@bruno, ok, sounds good.
https://reviews.llvm.org/D28832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added inline comments.
Comment at: utils/libcxx/test/config.py:289
+def configure_availability(self):
+# FIXME doc
+self.with_availability = self.get_lit_bool('with_availability', False)
Can you expand on what the FIXME here wants? Is
Author: yrnkrn
Date: Sun Apr 16 10:53:19 2017
New Revision: 300423
URL: http://llvm.org/viewvc/llvm-project?rev=300423&view=rev
Log:
Use setUsedForHeaderGuard() accessor function instead of direcly accessing
UsedForHeaderGuard.
Modified:
cfe/trunk/lib/Lex/PPLexerChange.cpp
Modified: cfe/tru
teemperor added a subscriber: cfe-commits.
teemperor added a comment.
https://reviews.llvm.org/D32113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Is that bug filed?
On Sat, Apr 15, 2017 at 10:47 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Sat Apr 15 21:47:46 2017
> New Revision: 300411
>
> URL: http://llvm.org/viewvc/llvm-project?rev=300411&view=rev
> Log:
> Workaround Clang bug regarding
One better, it has already been fixed.
On Apr 16, 2017 12:48 PM, "Nico Weber" wrote:
> Is that bug filed?
>
> On Sat, Apr 15, 2017 at 10:47 PM, Eric Fiselier via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ericwf
>> Date: Sat Apr 15 21:47:46 2017
>> New Revision: 300411
>>
>>
teemperor added a comment.
@yamaguchi Did you test the latest revision of this patch and get the desired
output paths? I just tested it and it seems on my system doxygen can't handle
the `@abs_srcdir@/../`.
At least on my system it gets correctly generated as:
STRIP_FROM_PATH= /home
Author: alexshap
Date: Sun Apr 16 14:05:17 2017
New Revision: 300427
URL: http://llvm.org/viewvc/llvm-project?rev=300427&view=rev
Log:
[clang] Register isConstexpr matcher
This diff registers isConstexpr matcher.
Test plan:
make check-all
check that "match varDecl(isConstexpr())"
works in clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300427: [clang] Register isConstexpr matcher (authored by
alexshap).
Changed prior to commit:
https://reviews.llvm.org/D32112?vs=95385&id=95411#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3211
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D31992#726447, @joerg wrote:
> let's escape ... all the known ASCII control characters,
Do you mean encode all of them with \u or keep the two characters
representation for those that exist? I think \n is nicer than \u000A and i
malaperle-ericsson updated this revision to Diff 95414.
malaperle-ericsson added a comment.
Handle other control characters and add test
https://reviews.llvm.org/D31992
Files:
clangd/ASTManager.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
test/clangd/encoding.
joerg added a comment.
The short version is perfectly fine as long as works for both JSON and YAML.
Less output is always good :)
https://reviews.llvm.org/D31992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
malaperle-ericsson added a comment.
Once the use of "two characters representation" is clarified, I will update the
patch again.
https://reviews.llvm.org/D31992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
malaperle-ericsson updated this revision to Diff 95416.
malaperle-ericsson removed a subscriber: Sarcasm.
malaperle-ericsson added a comment.
Update with comments (extra backticks, etc)
https://reviews.llvm.org/D31887
Files:
docs/clangd.rst
docs/index.rst
Index: docs/index.rst
joerg added a comment.
Just to avoid any confusion: this should be the generic YAML escape routine in
llvm/lib/Support, i.e. IMO we don't want to have separate YAML and JSON escape
routines.
Effective, change YAMLParser.cpp line 697 to use \u and drop the whole UTF-8
handling part.
https://re
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D31992#728036, @joerg wrote:
> Just to avoid any confusion: this should be the generic YAML escape routine
> in llvm/lib/Support, i.e. IMO we don't want to have separate YAML and JSON
> escape routines.
> Effective, change YAMLPar
joerg added a comment.
We already have a couple of case that expect the encoding to be compatible. I'm
not very attached to the additional special cases from YAML, but having either
a common escape function OR a JSON escape in LLVM/Support is quite important.
https://reviews.llvm.org/D31992
GorNishanov added a comment.
It is a simple change. If there is no objections, I'll commit it tomorrow.
https://reviews.llvm.org/D31584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
yamaguchi added a comment.
Doxygen couldn't handle @abs_srcsdir@/../ , so I changed it to @abs_arcdir@/..
in Diff 95410, then it worked OK.
Document will now show the path of #include "include/clang/Sema/Sema.h" .
https://reviews.llvm.org/D32113
__
ahatanak added inline comments.
Comment at: test/CodeGenCXX/unaligned-duplicated-mangle-name.cpp:15
+
+void A::foo() // expected-error {{definition with same mangled name as another
definition}}
+ // expected-note@-6 {{previous definition is here}}
ahatanak added a comment.
Can you add a test case?
https://reviews.llvm.org/D31972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xiangzhai added a comment.
ping :)
https://reviews.llvm.org/D29827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:255
+// If PointerAlignment is PAS_Right, keep *s or &s next to the token
+if (Style.PointerAlignment == FormatStyle::PAS_Right &&
+Changes[i].Spaces != 0) {
This needs to
27 matches
Mail list logo
