[PATCH] D31696: Automatically add include-what-you-use for when building in tree

rnk added inline comments. Comment at: clang/tools/.gitignore:12 +#==# +# The include-what-you-use project, for when building in-tree. +include-what-you-use LLVM doesn't currently have an

[PATCH] D31798: [libc++] Drop support for CRTs older than VS 2015

smeenai created this revision. LLVM dropped support for Visual Studio versions older than 2015 quite some time ago, so I consider it safe to drop libc++'s support for older CRTs. The CRT in Visual Studio 2015 provides a lot of previously missing functions, so targeting it requires less special cas

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno added inline comments. Comment at: include/clang/AST/ASTStructuralEquivalence.h:52 + /// \brief Whether warn or error on tag type mismatches. + bool ErrorOnTagTypeMismatch; aprantl wrote: > No need to use \brief in new code any more. We are compiling wi

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno updated this revision to Diff 94471. bruno added a comment. Update patch on top of Adrian comments https://reviews.llvm.org/D31778 Files: include/clang/AST/ASTStructuralEquivalence.h include/clang/Basic/DiagnosticASTKinds.td include/clang/Parse/Parser.h include/clang/Sema/Sema.h

[libcxx] r299734 - Allow a standard library to implement conditional noexcept for optional and unique_ptr hash functions.

Author: bion Date: Thu Apr 6 18:50:21 2017 New Revision: 299734 URL: http://llvm.org/viewvc/llvm-project?rev=299734&view=rev Log: Allow a standard library to implement conditional noexcept for optional and unique_ptr hash functions. These tests were unconditionally asserting that optional and u

[libcxx] r299735 - Add noexcept(false) to more strongly indicate that not being noexcept is important for hash tests.

Author: bion Date: Thu Apr 6 18:50:33 2017 New Revision: 299735 URL: http://llvm.org/viewvc/llvm-project?rev=299735&view=rev Log: Add noexcept(false) to more strongly indicate that not being noexcept is important for hash tests. Modified: libcxx/trunk/test/std/utilities/memory/util.smartpt

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea updated this revision to Diff 94475. gtbercea added a comment. Address some of the reviews. Repository: rL LLVM https://reviews.llvm.org/D29654 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains/CommonArgs.cpp lib/Driver/ToolChains/CommonArgs.h lib/Driver/ToolChains/Cuda.cpp

[libcxx] r299743 - [libc++] Drop support for CRTs older than VS 2015

Author: smeenai Date: Thu Apr 6 21:20:52 2017 New Revision: 299743 URL: http://llvm.org/viewvc/llvm-project?rev=299743&view=rev Log: [libc++] Drop support for CRTs older than VS 2015 LLVM dropped support for Visual Studio versions older than 2015 quite some time ago, so I consider it safe to dro

[PATCH] D31798: [libc++] Drop support for CRTs older than VS 2015

This revision was automatically updated to reflect the committed changes. Closed by commit rL299743: [libc++] Drop support for CRTs older than VS 2015 (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D31798?vs=94468&id=94476#toc Repository: rL LLVM https://reviews.ll

[PATCH] D31673: Allow casting C pointers declared using extern "C" to ObjC pointer types

rjmccall added inline comments. Comment at: lib/Sema/SemaExprObjC.cpp:3358 var && - var->getStorageClass() == SC_Extern && + !var->isThisDeclarationADefinition() && var->getType().isConstQualified()) { ahatanak wrote: > rjm

[PATCH] D31401: [clangd] Extract FsPath from file:// uri

stanionascu marked 2 inline comments as done. stanionascu added a comment. Thank you for the review! If there are no other comments/suggestions, would be great if someone would merge it as I'm lacking the permission to do so. https://reviews.llvm.org/D31401 _

Re: [libcxx] r299734 - Allow a standard library to implement conditional noexcept for optional and unique_ptr hash functions.

It looks like this commit and r299735 are causing bots to fail: http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/66/ The test hash_unique_ptr.pass.cpp doesn’t compile when -std=c++03 is on the command line because Pointe

[libcxx] r299744 - Revert "Allow a standard library to implement conditional noexcept for optional and unique_ptr hash functions."

Author: ahatanak Date: Fri Apr 7 00:55:28 2017 New Revision: 299744 URL: http://llvm.org/viewvc/llvm-project?rev=299744&view=rev Log: Revert "Allow a standard library to implement conditional noexcept for optional and unique_ptr hash functions." This reverts commit r299734. Modified: libc

Re: [libcxx] r299734 - Allow a standard library to implement conditional noexcept for optional and unique_ptr hash functions.

I reverted r299734 in r299744. Feel free to recommit it once the test is fixed. > On Apr 6, 2017, at 10:36 PM, Akira Hatanaka via cfe-commits > wrote: > > It looks like this commit and r299735 are causing bots to fail: > > http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/66/ >

<    1   2