[PATCH] D31637: [Sema] Implement LWG 2015 for the builtin type-traits.

EricWF planned changes to this revision. EricWF added a comment. Woops. This may actually be entirely unneeded. Comment at: lib/Sema/SemaExprCXX.cpp:4083 case UTT_HasTrivialDestructor: case UTT_HasVirtualDestructor: +// C++14 [meta.unary.prop] aaron.b

r299410 - Modules/builtins.m requires shell.

Author: gkistanova Date: Mon Apr 3 21:50:40 2017 New Revision: 299410 URL: http://llvm.org/viewvc/llvm-project?rev=299410&view=rev Log: Modules/builtins.m requires shell. Modified: cfe/trunk/test/Modules/builtins.m Modified: cfe/trunk/test/Modules/builtins.m URL: http://llvm.org/viewvc/llv

[libcxx] r299411 - Fix more -Wshadow warnings introduced by recent Clang change

Author: ericwf Date: Mon Apr 3 21:54:27 2017 New Revision: 299411 URL: http://llvm.org/viewvc/llvm-project?rev=299411&view=rev Log: Fix more -Wshadow warnings introduced by recent Clang change Modified: libcxx/trunk/test/std/containers/associative/map/map.cons/iter_iter_comp_alloc.pass.cpp

Re: r299410 - Modules/builtins.m requires shell.

What was your issue? Seems nothing to do "shell". On Tue, Apr 4, 2017 at 12:03 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gkistanova > Date: Mon Apr 3 21:50:40 2017 > New Revision: 299410 > > URL: http://llvm.org/viewvc/llvm-project?rev=299410&view=rev > L

Re: r299410 - Modules/builtins.m requires shell.

Just wanted temporarily disable this test on Windows bots while investigating the clang assert which happens once in a while By the way, do you see something like this on your bots? Assertion failed: (Imported == nullptr || Imported == SuggestedModule.getModule()) && "the imported module is differ

[PATCH] D31644: [libcxx] Fix check-cxx-abilist on OS X

EricWF created this revision. Herald added a subscriber: mgorny. Recent commits broke the check-cxx-abilist by changing the default OS X to use `-rexport_library` instead of `-reexport_symbol_list`. Apparently `-reexport_library` doesn't export the symbols into `libc++.dylib`s symbol table, whe

[PATCH] D31644: [libcxx] Fix check-cxx-abilist on OS X

EricWF updated this revision to Diff 94000. EricWF added a comment. - Remove silly changes to `libc++abi2.exp` https://reviews.llvm.org/D31644 Files: lib/CMakeLists.txt lib/libc++abi-new-delete.exp lib/libc++abi2.exp Index: lib/libc++abi2.exp

[PATCH] D31276: Add #pragma clang fp

anemet added a comment. In https://reviews.llvm.org/D31276#717390, @aaron.ballman wrote: > This continues to look good to me with the new name. Thank you, Aaron! https://reviews.llvm.org/D31276 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D31646: [coroutines] Build GRO declaration and return GRO statement

GorNishanov created this revision. 1. build declaration of the gro local variable that keeps the result of get_return_object. 2. build return statement returning the gro variable 3. emit them during CodeGen 4. sema and CodeGen tests updated https://reviews.llvm.org/D31646 Files: include/clan

[PATCH] D31644: [libcxx] Fix check-cxx-abilist on OS X

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Makes sense to me. Some questions inline, but they may not necessitate changes, so I'm accepting. Comment at: lib/CMakeLists.txt:166 + if (NOT LIBCXX_ENABLE_NEW_DELET

[libcxxabi] r299414 - Uses quote to include cxxabi.h to make sure the local one is included

Author: mehdi_amini Date: Tue Apr 4 00:38:38 2017 New Revision: 299414 URL: http://llvm.org/viewvc/llvm-project?rev=299414&view=rev Log: Uses quote to include cxxabi.h to make sure the local one is included Modified: libcxxabi/trunk/src/cxa_exception.hpp libcxxabi/trunk/src/cxa_unexpecte

[PATCH] D31408: Add more examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 94008. https://reviews.llvm.org/D31408 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: docs/ClangFormatStyleOptions.rst === --- docs/ClangFormatStyleOpti

[PATCH] D31408: Add more examples to clang-format configuration

sylvestre.ledru added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:941 + ContinuationIndentWidth: 2 + ColumnLimit: 15 + djasper wrote: > You could force line wraps with tailing //-comments instead. much better. thanks

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

ahmedasadi updated this revision to Diff 94007. ahmedasadi added a comment. Updated diff to address Eric's comment - it's best not to issue a warning if the shadowing declaration is part of a class (this is what GCC currently does). I will need someone to commit this new patch for me. https://

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

Hahnfeld added a comment. Ping! https://reviews.llvm.org/D30087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r299416 - [X86] Remove some code that tries to disable HLE feature. This feature flag was removed from the backend.

Author: ctopper Date: Tue Apr 4 01:38:44 2017 New Revision: 299416 URL: http://llvm.org/viewvc/llvm-project?rev=299416&view=rev Log: [X86] Remove some code that tries to disable HLE feature. This feature flag was removed from the backend. Modified: cfe/trunk/lib/Driver/ToolChains/Arch/X86.c

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

EricWF added a comment. this LGTM. thanks for the update. https://reviews.llvm.org/D31235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2