[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

2017-03-28 Thread Erik Nyquist via Phabricator via cfe-commits
enyquist updated this revision to Diff 9. enyquist marked 2 inline comments as done. Repository: rL LLVM https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/WhitespaceManager.cpp lib/Format/Whitesp

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

2017-03-28 Thread Tony Tye via Phabricator via cfe-commits
t-tye added inline comments. Comment at: include/clang/AST/ASTContext.h:2319 return AddrSpaceMapMangling || - AS < LangAS::Offset || - AS >= LangAS::Offset + LangAS::Count; + AS > LangAS::target_first; } Should this be >= s

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

2017-03-28 Thread Erik Nyquist via Phabricator via cfe-commits
enyquist updated this revision to Diff 93341. enyquist added a comment. Apologies-- forgot to update a comment Repository: rL LLVM https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/WhitespaceManager.

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

2017-03-28 Thread Ahmed Asadi via Phabricator via cfe-commits
ahmedasadi updated this revision to Diff 93342. ahmedasadi marked 4 inline comments as done. https://reviews.llvm.org/D31235 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp test/SemaCXX/warn-shadow.cpp Index: test/SemaCXX/warn-shadow.cpp

r298976 - [OpenCL] Added parsing for OpenCL vector types.

2017-03-28 Thread Egor Churaev via cfe-commits
Author: echuraev Date: Wed Mar 29 00:08:18 2017 New Revision: 298976 URL: http://llvm.org/viewvc/llvm-project?rev=298976&view=rev Log: [OpenCL] Added parsing for OpenCL vector types. Reviewers: cfe-commits, Anastasia Reviewed By: Anastasia Subscribers: yaxunl, bader Differential Revision: http

Re: r298976 - [OpenCL] Added parsing for OpenCL vector types.

2017-03-28 Thread Dean Michael Berris via cfe-commits
This seems to have broken multiple builds. On Wed, Mar 29, 2017 at 4:20 PM Egor Churaev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: echuraev > Date: Wed Mar 29 00:08:18 2017 > New Revision: 298976 > > URL: http://llvm.org/viewvc/llvm-project?rev=298976&view=rev > Log: > [OpenCL

Re: r298976 - [OpenCL] Added parsing for OpenCL vector types.

2017-03-28 Thread Egor Churaev via cfe-commits
I see it. I'm reverting this patch and I'll investigate why it has happend. 2017-03-29 8:43 GMT+03:00 Dean Michael Berris : > This seems to have broken multiple builds. > > On Wed, Mar 29, 2017 at 4:20 PM Egor Churaev via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: echuraev >>

Re: r298976 - [OpenCL] Added parsing for OpenCL vector types.

2017-03-28 Thread Dean Michael Berris via cfe-commits
Thanks Egor! On Wed, Mar 29, 2017 at 4:51 PM Egor Churaev wrote: > I see it. I'm reverting this patch and I'll investigate why it has happend. > > 2017-03-29 8:43 GMT+03:00 Dean Michael Berris : > > This seems to have broken multiple builds. > > On Wed, Mar 29, 2017 at 4:20 PM Egor Churaev via c

r298978 - Reverted r298976 [OpenCL] Added parsing for OpenCL vector types.

2017-03-28 Thread Egor Churaev via cfe-commits
Author: echuraev Date: Wed Mar 29 00:40:45 2017 New Revision: 298978 URL: http://llvm.org/viewvc/llvm-project?rev=298978&view=rev Log: Reverted r298976 [OpenCL] Added parsing for OpenCL vector types. Removed: cfe/trunk/test/Parser/vector-cast-define.cl Modified: cfe/trunk/include/clang/Pa

[PATCH] D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests

2017-03-28 Thread Michał Górny via Phabricator via cfe-commits
mgorny added inline comments. Comment at: test/sanitizer_common/CMakeLists.txt:7 set(SUPPORTED_TOOLS) -if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID) +if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID AND + COMPILER_RT_HAS_ASAN)

<    1   2