[PATCH] D23796: [libcxx] Make it possible to test static builds of libc++ on OSX

2017-03-27 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. Is this still needed? https://reviews.llvm.org/D23796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31272: Do not pass an explicit reexported symbol list when building libc++ dylib if also defining new/delete

2017-03-27 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Strange. So installing the command line tools is not enough. It has to be that CMAKE_OSX_SYSROOT is only defined on Apple internal install maybe? Anyway, if you're exporting through the ABI list and have LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS I expect the link to fail

[PATCH] D31272: Do not pass an explicit reexported symbol list when building libc++ dylib if also defining new/delete

2017-03-27 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. In https://reviews.llvm.org/D31272#711876, @mehdi_amini wrote: > Strange. So installing the command line tools is not enough. It has to be > that CMAKE_OSX_SYSROOT is only defined on Apple internal install maybe? Are you sure you're starting with a clean CMake build dir

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

2017-03-27 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:413 + + while (Param && !Param->is(tok::l_paren)) { +if (!Param->is(tok::identifier) && !Param->is(tok::comma)) enyquist wrote: > djasper wrote: > > I think you should be able to use

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

2017-03-27 Thread Tony Tye via Phabricator via cfe-commits
t-tye added inline comments. Comment at: lib/AST/ASTContext.cpp:9547-9555 +unsigned ASTContext::getTargetAddressSpace(unsigned AS) const { + // For OpenCL, the address space qualifier is 0 in AST. + if (AS == 0 && LangOpts.OpenCL) +return getTargetInfo().getDataLayout().get

[PATCH] D31334: [clang-format] Add options for indenting preprocessor directives

2017-03-27 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added a comment. Thank you for working on this. Unfortunately, this is done at the wrong level: - You are using a separate pass, which means that as soon as the preprocessor directives exceed the column limit, they won't be wrapped correctly. - You aren't using Clang's Lexer to separate

[PATCH] D31272: Do not pass an explicit reexported symbol list when building libc++ dylib if also defining new/delete

2017-03-27 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. In https://reviews.llvm.org/D31272#711877, @EricWF wrote: > In https://reviews.llvm.org/D31272#711876, @mehdi_amini wrote: > > > Strange. So installing the command line tools is not enough. It has to be > > that CMAKE_OSX_SYSROOT is only defined on Apple internal ins

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-03-27 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 93213. Hahnfeld added a comment. Herald added a subscriber: rengolin. Rebase and ping. https://reviews.llvm.org/D30087 Files: lib/Driver/ToolChains/CommonArgs.cpp lib/Driver/ToolChains/CommonArgs.h lib/Driver/ToolChains/Darwin.cpp lib/Driver/ToolCh

<    1   2