RE: r298410 - Correct class-template deprecation behavior

Thanks, and yes, the PS4 target has slightly different defaults for both C and C++. I should have mentioned that in my original email, but I also was running out to lunch. :) Sorry about that. Douglas Yung > -Original Message- > From: Keane, Erich [mailto:erich.ke...@intel.com] > Sent:

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl created this revision. Herald added subscribers: Anastasia, tpr, dstuttard, nhaehnle, wdng, kzhuravl. A new target feature new-addr is added. When it is on, AMDGPU uses new address space mapping where generic address space is 0 and private address space is 5. The data layout is also chang

[PATCH] D31210: [AMDGPU] Add new address space mapping

kzhuravl added a comment. getDWARFAddressSpace also needs to be updated. https://reviews.llvm.org/D31210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31210: [AMDGPU] Add new address space mapping

rampitec added a comment. I'm concerned about the default address space to be 64 bit. It would move alloca into generic address space effectively making private address to be 64 bit. This may have very undesirable performance implications, like address arithmetic can become expensive 64 bit and

[PATCH] D30760: Record command lines in objects built by clang

zhizhouy updated this revision to Diff 92546. zhizhouy marked 3 inline comments as done. zhizhouy edited the summary of this revision. zhizhouy added a reviewer: dblaikie. zhizhouy added a comment. Herald added a subscriber: mehdi_amini. Fixed George's comments. Still need to create a test for th

[PATCH] D31210: [AMDGPU] Add new address space mapping

kzhuravl added a comment. In https://reviews.llvm.org/D31210#706880, @rampitec wrote: > I'm concerned about the default address space to be 64 bit. It would move > alloca into generic address space effectively making private address to be 64 > bit. > This may have very undesirable performance

[PATCH] D30760: Record command lines in objects built by clang

echristo requested changes to this revision. echristo added a comment. This revision now requires changes to proceed. Why aren't we passing the flags down as a string in the IR? Needs a testcase: you should only check for IR in clang tests. To make sure something is propagated to the other end u

[PATCH] D31213: Add support for -fno-auto-profile and -fno-profile-sample-use

danielcdh created this revision. We need to be able to disable samplepgo for specific files by supporting -fno-auto-profile and -fno-profile-sample-use https://reviews.llvm.org/D31213 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChains/CommonArgs.

r298441 - [c-index-test] Fix memory leak in c-index-test tool.

Author: akirtzidis Date: Tue Mar 21 16:34:05 2017 New Revision: 298441 URL: http://llvm.org/viewvc/llvm-project?rev=298441&view=rev Log: [c-index-test] Fix memory leak in c-index-test tool. Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified: cfe/trunk/tools/c-index-test/c-index-t

[PATCH] D31213: Add support for -fno-auto-profile and -fno-profile-sample-use

echristo added a comment. Can you add a test for fno-auto-profile? https://reviews.llvm.org/D31213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r298442 - Apply clang-tidy's performance-unnecessary-value-param to clang-tidy.

Author: d0k Date: Tue Mar 21 16:34:58 2017 New Revision: 298442 URL: http://llvm.org/viewvc/llvm-project?rev=298442&view=rev Log: Apply clang-tidy's performance-unnecessary-value-param to clang-tidy. No functionality change intended. Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguide

Re: r298392 - [index/AST] Determine if a typedef shares a name and spelling location with its underlying tag type

Fixed in r298441, thanks! > On Mar 21, 2017, at 2:05 PM, Vitaly Buka wrote: > > Could you please take a look at these leaks > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/3606/steps/check-clang%20asan/logs/stdio > >

r298443 - Apply clang-tidy's performance-unnecessary-value-param to parts of clang.

Author: d0k Date: Tue Mar 21 16:35:04 2017 New Revision: 298443 URL: http://llvm.org/viewvc/llvm-project?rev=298443&view=rev Log: Apply clang-tidy's performance-unnecessary-value-param to parts of clang. No functionality change intended. Modified: cfe/trunk/include/clang/Driver/ToolChain.h

[PATCH] D31213: Add support for -fno-auto-profile and -fno-profile-sample-use

danielcdh updated this revision to Diff 92554. danielcdh added a comment. add more test https://reviews.llvm.org/D31213 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChains/CommonArgs.cpp lib/Driver/ToolChains/CommonArgs.h test/Driver/clang_f_op

[PATCH] D31213: Add support for -fno-auto-profile and -fno-profile-sample-use

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. -eric https://reviews.llvm.org/D31213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl added a comment. In https://reviews.llvm.org/D31210#706890, @kzhuravl wrote: > In https://reviews.llvm.org/D31210#706880, @rampitec wrote: > > > I'm concerned about the default address space to be 64 bit. It would move > > alloca into generic address space effectively making private addre

r298446 - Add support for -fno-auto-profile and -fno-profile-sample-use

Author: dehao Date: Tue Mar 21 16:40:53 2017 New Revision: 298446 URL: http://llvm.org/viewvc/llvm-project?rev=298446&view=rev Log: Add support for -fno-auto-profile and -fno-profile-sample-use Summary: We need to be able to disable samplepgo for specific files by supporting -fno-auto-profile an

r298449 - Remove the -faltivec alias option and replace it with -maltivec everywhere.

Author: echristo Date: Tue Mar 21 17:06:18 2017 New Revision: 298449 URL: http://llvm.org/viewvc/llvm-project?rev=298449&view=rev Log: Remove the -faltivec alias option and replace it with -maltivec everywhere. The alias was only ever used on darwin and had some issues there, and isn't used in pra

[PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

echristo added a comment. In https://reviews.llvm.org/D30415#706370, @sfertile wrote: > > I have a patch to do this now. I'll plan on committing it in a bit. > > Is there a way to mark the -f form of the option as deprecated? We should > warn and suggest users switch to the -maltivec option for

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

vsk added a comment. Hi Eli, thanks for your feedback :). In https://reviews.llvm.org/D30283#702085, @efriedma wrote: > I'm not sure we actually want to skip these checks for DeclRefExps. I mean, > you can rely on the backend to correctly align a local variable (assuming the > stack is correc

[PATCH] D31219: Update the SamplePGO test to verify that unroll/icp is not invoked in thinlto compile phase.

danielcdh created this revision. Herald added a subscriber: Prazek. This is the test added for https://reviews.llvm.org/D31217 https://reviews.llvm.org/D31219 Files: test/CodeGen/Inputs/pgo-sample-thinlto-summary.prof test/CodeGen/pgo-sample-thinlto-summary.c Index: test/CodeGen/pgo-sampl

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

efriedma added a comment. It's possible to misalign a global definition by misaligning its section with a linker script... but we can probably ignore that possibility. It's very easy to misalign global declaration, though; for example: a.c: extern int a[]; int f(int x) { return a[x]; } b.

[PATCH] D31210: [AMDGPU] Add new address space mapping

scchan added a comment. In https://reviews.llvm.org/D31210#706955, @yaxunl wrote: > In https://reviews.llvm.org/D31210#706890, @kzhuravl wrote: > > > In https://reviews.llvm.org/D31210#706880, @rampitec wrote: > > > > > I'm concerned about the default address space to be 64 bit. It would move >

[PATCH] D31168: Set FMF for -ffp-contract=fast rather than a TargetConfig

anemet added a comment. Thanks, Akira. You're right on both accounts. I actually had a test written but failed to git add it. https://reviews.llvm.org/D31168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D31168: Set FMF for -ffp-contract=fast rather than a TargetConfig

anemet updated this revision to Diff 92564. anemet added a comment. Address Akira's comments https://reviews.llvm.org/D31168 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/ffp-contract-fast-option.c Index: test/CodeGen/ffp-contract-fast-option.c =

[PATCH] D30954: Modules: Simulate diagnostic settings for implicit modules

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM > - The patch-as-is checks whether pragmas should be demoted to warnings for > all AST files, not just implicit modules. I can add a bit of logic to > `ReadPragmaDiagnosticMappings` that

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl added a comment. In https://reviews.llvm.org/D31210#707014, @scchan wrote: > In https://reviews.llvm.org/D31210#706955, @yaxunl wrote: > > > In https://reviews.llvm.org/D31210#706890, @kzhuravl wrote: > > > > > In https://reviews.llvm.org/D31210#706880, @rampitec wrote: > > > > > > > I'm c

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

vsk added a comment. In https://reviews.llvm.org/D30283#707007, @efriedma wrote: > It's possible to misalign a global definition by misaligning its section with > a linker script... but we can probably ignore that possibility. The current implementation does ignore this case. > It's very easy

[PATCH] D30760: Record command lines in objects built by clang

aprantl added a comment. Sorry for being late to the party, but have you looked at CodeGenOptions::DwarfDebugFlags? It looks like it almost does what you want, but it is currently only enabled for MachO and when a specific environment variable is set. Would it make sense to generalize that mech

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

vsk updated this revision to Diff 92572. vsk added a comment. Add a test which shows that we don't regress alignment-checking when accessing extern variables. https://reviews.llvm.org/D30283 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprCXX.cpp lib/CodeGen/CodeGenFunction.cpp test/Co

r298464 - [Modules] Rebuild modules on umbrella header mismatch

Author: bruno Date: Tue Mar 21 19:11:21 2017 New Revision: 298464 URL: http://llvm.org/viewvc/llvm-project?rev=298464&view=rev Log: [Modules] Rebuild modules on umbrella header mismatch This restores behavior pre-r230064 since after PCMCache work (r298278) we don't reload PCMs from disk within th

[PATCH] D30810: Preserve vec3 type.

jaykang10 added a comment. In https://reviews.llvm.org/D30810#706677, @Anastasia wrote: > In https://reviews.llvm.org/D30810#706676, @Anastasia wrote: > > > In https://reviews.llvm.org/D30810#699428, @Anastasia wrote: > > > > > Would you be able to update ScalarExprEmitter::VisitAsTypeExpr > > >

Re: [PATCH] D30760: Record command lines in objects built by clang

I think that's a good idea. On Tue, Mar 21, 2017 at 5:19 PM Adrian Prantl via Phabricator < revi...@reviews.llvm.org> wrote: > aprantl added a comment. > > Sorry for being late to the party, but have you looked at > CodeGenOptions::DwarfDebugFlags? It looks like it almost does what you > want, bu

[PATCH] D30760: Record command lines in objects built by clang

zhizhouy added a comment. Hi aprantl, thanks for replying. I checked the usage of DwarfDebugFlags, it seems that it really did the same work of recording command line options. And I noticed that it is set to false by default. Is it because of some concerns like the debug info size? Is it prope

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

efriedma added inline comments. Comment at: test/CodeGenCXX/ubsan-global-alignment.cpp:9 +extern S1 S1_array[]; +extern S1 *S1ptr_array[]; + Probably a good idea to also test extern globals which aren't arrays; arrays are sort of a special-case due to array->poi

Buildbot numbers for the week of 03/05/2017 - 03/11/2017

Hello everyone, Below are some buildbot numbers for the week of 03/05/2017 - 03/11/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the week of 03/12/2017 - 03/18/2017

Hello everyone, Below are some buildbot numbers for the last week of 03/12/2017 - 03/18/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

r298469 - Remove -ffp-contract=fast from this test

Author: anemet Date: Tue Mar 21 19:58:18 2017 New Revision: 298469 URL: http://llvm.org/viewvc/llvm-project?rev=298469&view=rev Log: Remove -ffp-contract=fast from this test It does not need it and causes mismatch after -ffp-contract=fast is turned into an FMF. Modified: cfe/trunk/test/CodeG

r298468 - Change -ffp-contract=fast test to run on Aarch64

Author: anemet Date: Tue Mar 21 19:58:15 2017 New Revision: 298468 URL: http://llvm.org/viewvc/llvm-project?rev=298468&view=rev Log: Change -ffp-contract=fast test to run on Aarch64 (I don't have powerpc enabled in my build and I am changing how -ffp-contract=fast works.) Modified: cfe/trunk

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

On 21 March 2017 at 12:01, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Tue Mar 21 14:01:17 2017 > New Revision: 298421 > > URL: http://llvm.org/viewvc/llvm-project?rev=298421&view=rev > Log: > Prevent cppcoreguidelines-pro-bounds-array-to-point

[clang-tools-extra] r298470 - Reverting r298421 due to using a header that's unavailable to all systems and some other post-commit review feedback.

Author: aaronballman Date: Tue Mar 21 20:08:54 2017 New Revision: 298470 URL: http://llvm.org/viewvc/llvm-project?rev=298470&view=rev Log: Reverting r298421 due to using a header that's unavailable to all systems and some other post-commit review feedback. Modified: clang-tools-extra/trunk/

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

On Tue, Mar 21, 2017 at 9:15 PM, Richard Smith wrote: > On 21 March 2017 at 12:01, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Tue Mar 21 14:01:17 2017 >> New Revision: 298421 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=298421&view=rev >> Log: >> Prevent cppc

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This change was reverted in r298470. The use of the include is a problem because this is not a clang-supplied header file. Also, there's a (good) question about what array decay

[PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

ahatanak updated this revision to Diff 92583. ahatanak added a comment. Rebase and ping. https://reviews.llvm.org/D22391 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaChecking.cpp lib/Sema/SemaDecl.cpp

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

Thank you! On 21 March 2017 at 18:22, Aaron Ballman wrote: > On Tue, Mar 21, 2017 at 9:15 PM, Richard Smith > wrote: > > On 21 March 2017 at 12:01, Aaron Ballman via cfe-commits > > wrote: > >> > >> Author: aaronballman > >> Date: Tue Mar 21 14:01:17 2017 > >> New Revision: 298421 > >> > >> UR

[PATCH] D30760: Record command lines in objects built by clang

aprantl added a comment. In https://reviews.llvm.org/D30760#707178, @zhizhouy wrote: > Hi aprantl, thanks for replying. I checked the usage of DwarfDebugFlags, it > seems that it really did the same work of recording command line options. > > And I noticed that it is set to false by default. Is

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

Hey guys, I'm sorry the test did not make the decay explicit. It's indeed sort of tricky: https://bugs.llvm.org/show_bug.cgi?id=32239 Basically, assert is expanded into: (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) Well, __func__ and __FILE__ are const char[], wh

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl updated this revision to Diff 92587. yaxunl added a comment. Fix getDWARFAddressSpace. https://reviews.llvm.org/D31210 Files: include/clang/Driver/Options.td lib/Basic/Targets.cpp test/CodeGenOpenCL/amdgpu-new-addr.cl Index: test/CodeGenOpenCL/amdgpu-new-addr.cl ==

r298477 - Suppress warning on unreachable [[clang::fallthrough]] within a template instantiation.

Author: rsmith Date: Tue Mar 21 20:49:19 2017 New Revision: 298477 URL: http://llvm.org/viewvc/llvm-project?rev=298477&view=rev Log: Suppress warning on unreachable [[clang::fallthrough]] within a template instantiation. We don't know whether some other instantiation of the template might be abl

[PATCH] D31069: Don't warn about an unreachable fallthrough annotation in a template function

This revision was automatically updated to reflect the committed changes. Closed by commit rL298477: Suppress warning on unreachable [[clang::fallthrough]] within a template… (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D31069?vs=92104&id=92588#toc Repository: rL L

[PATCH] D30018: [XRay] Add __xray_customeevent(...) as a clang-supported builtin

dberris added a reviewer: rnk. dberris added a subscriber: rnk. dberris added a comment. @rnk -- if you have time, a review for this would be appreciated too. https://reviews.llvm.org/D30018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

On 21 March 2017 at 18:57, Breno Guimarães via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hey guys, > > I'm sorry the test did not make the decay explicit. It's indeed sort of > tricky: https://bugs.llvm.org/show_bug.cgi?id=32239 > > Basically, assert is expanded into: > > (__builtin_expec

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

Hi, Thanks for the suggestions. I actually had tested with a fake header file (so I could build more interesting testcases) but it didn't occur to me to actually make it part of the codebase test. I was afraid of being too kind to exempt PredefinedExpr symbols in any context, and that's why I onl

[PATCH] D31234: Implement P0599 - noexcept for hash functions

mclow.lists created this revision. Mark most of the hash functions provided by libc++ as noexcept; the exceptions being `optional` and `variant`. Tests to ensure this. There's still some investigation to be done on `unique_ptr` and fancy pointer support, but that can come later. https://revie

r298487 - Move setting of LangOpts based on target flags out of CompilerInstance

Author: echristo Date: Wed Mar 22 01:36:09 2017 New Revision: 298487 URL: http://llvm.org/viewvc/llvm-project?rev=298487&view=rev Log: Move setting of LangOpts based on target flags out of CompilerInstance and into TargetInfo::adjust so that it gets called in more places throughout the compiler (A

<    1   2