igorb updated this revision to Diff 92263.
igorb marked an inline comment as done.
igorb added a comment.
Thanks for the comments.
Repository:
rL LLVM
https://reviews.llvm.org/D31034
Files:
lib/Headers/avx512fintrin.h
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/avx512f-builtins.
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D31034
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Author: ibreger
Date: Sun Mar 19 03:27:16 2017
New Revision: 298208
URL: http://llvm.org/viewvc/llvm-project?rev=298208&view=rev
Log:
[X86][AVX512][Clang][Intrinsics] Adding missing intrinsics to Clang .
Summary:
Adding missing intrinsics :
_mm512_set_epi16,
_mm512_set_epi8,
_mm512_pe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298208: [X86][AVX512][Clang][Intrinsics] Adding missing
intrinsics to Clang . (authored by ibreger).
Changed prior to commit:
https://reviews.llvm.org/D31034?vs=92263&id=92266#toc
Repository:
rL LLVM
myatsina added inline comments.
Comment at: test/CodeGen/alloc-align-attr.c:19
+}
+// Condition where test2 param needs casting.
+__INT32_TYPE__ test2(__SIZE_TYPE__ a) {
Where exactly do we see this test2 param casting?
I think you have a missing check before the
sepavloff created this revision.
If expensive checks are enabled, safe mode of libstdc++ is enabled too.
In this mode the library uses more complex data that allow additional
checks, for instance, a container may keep list of iterators that points
to it. If a code crashes it can leave these comple
Author: aaronballman
Date: Sun Mar 19 10:15:28 2017
New Revision: 298215
URL: http://llvm.org/viewvc/llvm-project?rev=298215&view=rev
Log:
Cleaning up the IdentifierResolver::iterator class a bit; NFC.
The comment about there being three different forms that Ptr represents was
stale. Also, the o
aaron.ballman added a comment.
I'd also like to see some tests in Misc that confirm the attribute is being
attached to the appropriate AST nodes for declarations, statements, and at
namespace scope.
Comment at: include/clang/Basic/Attr.td:1527
+def Suppress : StmtAttr {
+ le
aaron.ballman created this revision.
Herald added a subscriber: mgorny.
This module is intended to comply with the High-Integrity C++ coding standard
by PRQA, so we should be explicit about that in the name of the module and the
checks. This patch looks larger than it really is. It:
- Renames t
jbcoe added inline comments.
Comment at: clang-tidy/hicpp/NoAssemblerCheck.cpp:46
+
+ diag(ASMLocation, "do not use inline assembler in safety-critical code");
+}
Should this message use text taken directly from the HICPP rules?
https://reviews.llvm.org/D31128
aaron.ballman added inline comments.
Comment at: clang-tidy/hicpp/NoAssemblerCheck.cpp:46
+
+ diag(ASMLocation, "do not use inline assembler in safety-critical code");
+}
jbcoe wrote:
> Should this message use text taken directly from the HICPP rules?
The wordin
jbcoe accepted this revision.
jbcoe added a comment.
This revision is now accepted and ready to land.
LGTM.
Great work on getting this module approved by PRQA Aaron.
Comment at: clang-tidy/hicpp/NoAssemblerCheck.cpp:46
+
+ diag(ASMLocation, "do not use inline assembler in saf
JonasToth accepted this revision.
JonasToth added a comment.
thank you very much for dealing with this issue :)
I will update the aliases. But maybe later this week since i have an exam. :)
https://reviews.llvm.org/D31128
___
cfe-commits mailing lis
aaron.ballman added inline comments.
Comment at: clang-tidy/hicpp/NoAssemblerCheck.cpp:46
+
+ diag(ASMLocation, "do not use inline assembler in safety-critical code");
+}
jbcoe wrote:
> aaron.ballman wrote:
> > jbcoe wrote:
> > > Should this message use text tak
Author: aaronballman
Date: Sun Mar 19 12:23:23 2017
New Revision: 298229
URL: http://llvm.org/viewvc/llvm-project?rev=298229&view=rev
Log:
Rename the clang-tidy safety module to be hicpp, for the High-Integrity C++
coding standard from PRQA.
This commit renames all of the safety functionality to
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r298229. If we want to reword the hicpp-no-assembler diagnostic, we
can do so in a follow-up patch.
https://reviews.llvm.org/D31128
___
cfe-commits mailing list
cfe-commit
brenoguim added a reviewer: cfe-commits.
brenoguim added a comment.
Forgot to add cfe-commits...
https://reviews.llvm.org/D31130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
17 matches
Mail list logo
