[PATCH] D27334: [OpenCL] Ambiguous function call.

Anastasia added a comment. I don't actually. But remembering the follow up discussion: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161205/178846.html and since we have to deviate from the standard C/C++ implementation anyways I am wondering whether modifying overloading resolution i

[PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

nemanjai added a subscriber: echristo. nemanjai added a comment. This seems to change the relationship between -m[no-]altivec and -f[no-]altivec which has been kind of contentious for a while. Can you add a note as to whether the new behaviour matches the GCC behaviour. Also, perhaps @echristo

[PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

hfinkel added a comment. In https://reviews.llvm.org/D30415#700534, @nemanjai wrote: > This seems to change the relationship between -m[no-]altivec and > -f[no-]altivec which has been kind of contentious for a while. Can you add a > note as to whether the new behaviour matches the GCC behaviour

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

mehdi_amini added a comment. In https://reviews.llvm.org/D30920#700433, @tejohnson wrote: > In https://reviews.llvm.org/D30920#700133, @pcc wrote: > > > In https://reviews.llvm.org/D30920#700077, @tejohnson wrote: > > > > > Until everything is converted to using size attributes, it seems like a

[PATCH] D30937: [OpenCL] Added diagnostic for checking length of vector

Anastasia added inline comments. Comment at: lib/Sema/SemaExprMember.cpp:287 +// OpenCL spec (Section 6.1.7 Vector Components): +// The component group notation can occur on the left hand side of an expression. To form an lvalue, The format is normally: OpenCL

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

hfinkel added a comment. In https://reviews.llvm.org/D30920#700557, @mehdi_amini wrote: > In https://reviews.llvm.org/D30920#700433, @tejohnson wrote: > > > In https://reviews.llvm.org/D30920#700133, @pcc wrote: > > > > > In https://reviews.llvm.org/D30920#700077, @tejohnson wrote: > > > > > > >

[libunwind] r297744 - DarwinParser: include limits

Author: compnerd Date: Tue Mar 14 10:17:55 2017 New Revision: 297744 URL: http://llvm.org/viewvc/llvm-project?rev=297744&view=rev Log: DarwinParser: include limits In debug mode, we have assertions that the values do not exceed the limits of the type holding them. In order to account for the typ

[PATCH] D30923: Warn on enum assignment to bitfields that can't fit all values

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Looks like a cool warning. Two suggestions for more exhaustive testing, but I think this looks good. Comment at: test/SemaCXX/warn-bitfield-enum-conversion.cpp:1 +// RUN: %c

[PATCH] D30923: Warn on enum assignment to bitfields that can't fit all values

thakis added a comment. Maybe it should have some "to suppress the warning, do X" fixit? https://reviews.llvm.org/D30923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30923: Warn on enum assignment to bitfields that can't fit all values

hfinkel added a comment. In https://reviews.llvm.org/D30923#700620, @thakis wrote: > Maybe it should have some "to suppress the warning, do X" fixit? I think we should at least include how many bits the field should have to fix the problem (pointing to the relevant field definition certainly s

Re: LLVM Lab SVN mirror is behind

r297634 was the 4.0.0 release commit. We'll probably see similar-size commits for 4.0.1 and 5.0.0. Can we make the buildbot svn mirror ignore that component of the repository to avoid this happening again? - Hans On Tue, Mar 14, 2017 at 12:23 AM, Galina Kistanova via cfe-commits wrote: > The SV

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1501 - std::string Objc1String = + std::string ObjCString = +"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n" aaron.ballman wrote: > These changes are u

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama updated this revision to Diff 91738. pirama added a comment. Explicitly pass -O2 instead of relying on the default opt level. https://reviews.llvm.org/D30920 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/gold-lto.c Index: test/Driver/gold-lto.c ===

[PATCH] D30945: Fix mis-spelled enum

jroelofs created this revision. https://reviews.llvm.org/D30945 Files: include/clang/Parse/Parser.h lib/Parse/ParseOpenMP.cpp lib/Parse/ParseStmt.cpp Index: lib/Parse/ParseStmt.cpp === --- lib/Parse/ParseStmt.cpp +++ lib/Pars

[PATCH] D30945: Fix mis-spelled enum

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D30945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D29818: [libcxx] Threading support: Attempt to externalize system_clock::now() and steady_clock::now() implementations

rmaprath added a comment. @EricWF: Ping? https://reviews.llvm.org/D29818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi created this revision. Herald added subscribers: mgorny, klimek. PrintingPolicy::SuppressScope was replaced by PrintingPolicy::Scope. Possible values for PrintingPolicy::Scope are: - FullScope: Print all nested name specifiers (including the global scope specifier). This is necessary

[PATCH] D29757: [libcxx] Threading support: Externalize hardware_concurrency()

rmaprath added a comment. @EricWF: Ping? https://reviews.llvm.org/D29757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1547 + std::string ObjCString = +"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n" +"@protocol Proto " kastiglione wrote: > aaron.ballman wrote: > > Ins

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

kastiglione updated this revision to Diff 91740. kastiglione added a comment. Use -fobjc-nonfragile-abi https://reviews.llvm.org/D30854 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchers

[PATCH] D30931: [clang-tidy] added new identifier naming case type for ignoring case style

alexfh added a comment. BTW, next time please add cfe-commits to subscribers when you create the patch to get it sent properly to the mailing list. https://reviews.llvm.org/D30931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D30923: Warn on enum assignment to bitfields that can't fit all values

rnk added a comment. In https://reviews.llvm.org/D30923#700626, @hfinkel wrote: > In https://reviews.llvm.org/D30923#700620, @thakis wrote: > > > Maybe it should have some "to suppress the warning, do X" fixit? > > > I think we should at least include how many bits the field should have to fix >

[PATCH] D30923: Warn on enum assignment to bitfields that can't fit all values

rnk updated this revision to Diff 91741. rnk added a comment. - Beef up test as Nico suggests - Add two notes, one to change the bitfield signedness, one to indicate the required bitwidth https://reviews.llvm.org/D30923 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/Dia

<    1   2