berenm added a comment.
In https://reviews.llvm.org/D30931#700690, @alexfh wrote:
> I understand your use case, but this patch makes the check's behavior more
> confusing: having both "any case" and "ignore case" with subtle differences
> in behavior seems very misleading. The problem seems to
hfinkel added a comment.
In https://reviews.llvm.org/D30923#700696, @rnk wrote:
> In https://reviews.llvm.org/D30923#700626, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D30923#700620, @thakis wrote:
> >
> > > Maybe it should have some "to suppress the warning, do X" fixit?
> >
> >
> > I thi
enyquist added a comment.
@sylvestre.ledru No, unfortunately not. My apologies, I've been taken up with
work mostly.
I will make a marked attempt to do it this weekend :)
Repository:
rL LLVM
https://reviews.llvm.org/D28462
___
cfe-commits mailin
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1547
+ std::string ObjCString =
+"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n"
+"@protocol Proto "
kastiglione wrote:
> kastiglione wrote:
> > aar
Author: vedantk
Date: Tue Mar 14 11:48:29 2017
New Revision: 297750
URL: http://llvm.org/viewvc/llvm-project?rev=297750&view=rev
Log:
[ubsan] Use the nicer nullability diagnostic handlers
This is a follow-up to r297700 (Add a nullability sanitizer).
It addresses some FIXME's re: using nullabilit
pirama updated this revision to Diff 91743.
pirama added a comment.
Update commit message
https://reviews.llvm.org/D30700
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/arch-specific-libdir-rpath.c
test/Driver/arch-specific-libdir.c
test/lit.cf
Author: pirama
Date: Tue Mar 14 11:58:07 2017
New Revision: 297751
URL: http://llvm.org/viewvc/llvm-project?rev=297751&view=rev
Log:
[Driver] Add flag to request arch-specific-subdir in -rpath
Summary:
This patch adds -f[no-]rtlib-add-rpath, which if enabled, embeds the
arch-specific subdirectory
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297751: [Driver] Add flag to request arch-specific-subdir in
-rpath (authored by pirama).
Changed prior to commit:
https://reviews.llvm.org/D30700?vs=91743&id=91744#toc
Repository:
rL LLVM
https://r
kastiglione added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1547
+ std::string ObjCString =
+"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n"
+"@protocol Proto "
aaron.ballman wrote:
> kastiglione wrote:
> > kas
john.brawn updated this revision to Diff 91745.
john.brawn added a comment.
Respond to review comments, and also fix a couple of 80-column violations that
I spotted.
Repository:
rL LLVM
https://reviews.llvm.org/D30582
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/fast-math.c
Index
Author: marshall
Date: Tue Mar 14 12:08:47 2017
New Revision: 297752
URL: http://llvm.org/viewvc/llvm-project?rev=297752&view=rev
Log:
Implement LWG2784, and mark 2786, 2795, 2804, 2812, 2826, 2834, 2837 and 2838
as complete - since we do them already
Modified:
libcxx/trunk/include/exception
mehdi_amini added a comment.
In https://reviews.llvm.org/D30920#700574, @hfinkel wrote:
> In https://reviews.llvm.org/D30920#700557, @mehdi_amini wrote:
>
> > In https://reviews.llvm.org/D30920#700433, @tejohnson wrote:
> >
> > > In https://reviews.llvm.org/D30920#700133, @pcc wrote:
> > >
> > >
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1547
+ std::string ObjCString =
+"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n"
+"@protocol Proto "
kastiglione wrote:
> aaron.ballman wrote:
> > k
Author: marshall
Date: Tue Mar 14 12:24:29 2017
New Revision: 297753
URL: http://llvm.org/viewvc/llvm-project?rev=297753&view=rev
Log:
Also mark LWG#2785 as complete, because we already implemented that
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
pirama created this revision.
Fix the test by adding missing -target flags with a 'linux' triple.
https://reviews.llvm.org/D30947
Files:
test/Driver/arch-specific-libdir-rpath.c
Index: test/Driver/arch-specific-libdir-rpath.c
=
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D30947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297754: [Driver] Fix arch-specific-libdir-rpath.c (authored
by pirama).
Changed prior to commit:
https://reviews.llvm.org/D30947?vs=91746&id=91747#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
Author: pirama
Date: Tue Mar 14 12:26:56 2017
New Revision: 297754
URL: http://llvm.org/viewvc/llvm-project?rev=297754&view=rev
Log:
[Driver] Fix arch-specific-libdir-rpath.c
Summary: Fix the test by adding missing -target flags with a 'linux' triple.
Reviewers: rnk, srhines
Subscribers: cfe-co
rnk updated this revision to Diff 91749.
rnk added a comment.
- Test that explicit casts suppress the warning
https://reviews.llvm.org/D30923
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaCXX/warn-bitfield-en
rnk added a comment.
In https://reviews.llvm.org/D30923#700708, @hfinkel wrote:
> In https://reviews.llvm.org/D30923#700696, @rnk wrote:
>
> > Do you think it's worth indicating that the error can be suppressed with an
> > explicit cast, or is that wasted space?
>
>
> What might this look like?
Author: marshall
Date: Tue Mar 14 12:35:56 2017
New Revision: 297758
URL: http://llvm.org/viewvc/llvm-project?rev=297758&view=rev
Log:
Mark LWG issues 2868, 2872, and 2890 as complete. There's nothing we need to do
for them.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trun
Author: jroelofs
Date: Tue Mar 14 12:29:33 2017
New Revision: 297756
URL: http://llvm.org/viewvc/llvm-project?rev=297756&view=rev
Log:
Fix misspelled enum
https://reviews.llvm.org/D30945
Modified:
cfe/trunk/include/clang/Parse/Parser.h
cfe/trunk/lib/Parse/ParseOpenMP.cpp
cfe/trunk/li
jroelofs closed this revision.
jroelofs added a comment.
r297756
https://reviews.llvm.org/D30945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ributzka
Date: Tue Mar 14 12:46:26 2017
New Revision: 297759
URL: http://llvm.org/viewvc/llvm-project?rev=297759&view=rev
Log:
Add more debugging code for the SystemZ bot.
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittests/Basic/VirtualFileSys
hfinkel added a comment.
In https://reviews.llvm.org/D30923#700780, @rnk wrote:
> In https://reviews.llvm.org/D30923#700708, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D30923#700696, @rnk wrote:
> >
> > > Do you think it's worth indicating that the error can be suppressed with
> > > an ex
rnk marked an inline comment as done.
rnk added a comment.
Cool, thanks for the reviews, this is definitely in better shape now. This is
off by default, so I'm going to commit and experiment with it on a few
codebases.
I'd still like to hear if either of the Richards have diagnostic wording
su
Author: rnk
Date: Tue Mar 14 13:01:02 2017
New Revision: 297761
URL: http://llvm.org/viewvc/llvm-project?rev=297761&view=rev
Log:
Warn on enum assignment to bitfields that can't fit all values
This adds -Wbitfield-enum-conversion, which warns on implicit
conversions that happen on bitfield assign
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297761: Warn on enum assignment to bitfields that can't fit
all values (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D30923?vs=91749&id=91752#toc
Repository:
rL LLVM
https://r
vsk created this revision.
LLVM has a nifty linter which checks for some common kinds of unusual or
undefined behavior by doing some basic IR-level static analysis.
Add a CC1 option to clang which enables this analysis.
Having the linter available through clang could be a useful debugging
tool.
Author: rnk
Date: Tue Mar 14 13:24:41 2017
New Revision: 297764
URL: http://llvm.org/viewvc/llvm-project?rev=297764&view=rev
Log:
Fix arch-specific-libdir tests on Windows
This is pretty horrible, but I forget if we have any better ways to
handle these backslashing issues.
Modified:
cfe/trun
jaykang10 added a comment.
In https://reviews.llvm.org/D30810#700476, @Anastasia wrote:
> In https://reviews.llvm.org/D30810#699827, @jaykang10 wrote:
>
> > In https://reviews.llvm.org/D30810#699695, @bruno wrote:
> >
> > > Hi JinGu,
> > >
> > > I just read the discussion on cfe-dev, some comment
Author: dexonsmith
Date: Tue Mar 14 14:31:27 2017
New Revision: 297770
URL: http://llvm.org/viewvc/llvm-project?rev=297770&view=rev
Log:
Modules: Optimize bitcode encoding of diagnostic state
Since bitcode uses VBR encoding, large numbers are more expensive than
small ones. Instead of emitting a
Author: bion
Date: Tue Mar 14 14:36:30 2017
New Revision: 297772
URL: http://llvm.org/viewvc/llvm-project?rev=297772&view=rev
Log:
Fixed unintentional assignment-in-assert in new "extending memory management
tools" algorithms.
Modified:
libcxx/trunk/test/std/utilities/memory/specialized.alg
hfinkel added a comment.
> Note that in contrast to the original suggestion -fsource-asm here we use the
> preferred -fverbose-asm. Basically explicitly saying -fverbose-asm in the
> command line enables a minimum amount of debugging, so in AsmPrinter we can
> use it to print the source code.
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg, do you have commit access?
https://reviews.llvm.org/D30675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D30675#700917, @bkramer wrote:
> lg, do you have commit access?
No I do not have commit access. Could you commit it? Thank you very much!
https://reviews.llvm.org/D30675
___
cfe-comm
Author: kparzysz
Date: Tue Mar 14 15:29:23 2017
New Revision: 297778
URL: http://llvm.org/viewvc/llvm-project?rev=297778&view=rev
Log:
[Hexagon] Recognize hexagonv62 as a valid target CPU
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/tes
Author: d0k
Date: Tue Mar 14 15:41:28 2017
New Revision: 297779
URL: http://llvm.org/viewvc/llvm-project?rev=297779&view=rev
Log:
[clangd] Fix not being able to attach a debugger on macOS
Clangd is often waiting for input on getline as it awaits requests. If the
getline is interrupted, it causes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297779: [clangd] Fix not being able to attach a debugger on
macOS (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D30675?vs=91246&id=91768#toc
Repository:
rL LLVM
https://review
ed added a comment.
Worth mentioning: the latest version of macOS now supports `clock_gettime()`.
Maybe better to leave the code as is and simply axe the Mach time code at some
point in the future?
https://reviews.llvm.org/D29818
___
cfe-commits m
jroelofs added a comment.
In https://reviews.llvm.org/D29818#700949, @ed wrote:
> Worth mentioning: the latest version of macOS now supports `clock_gettime()`.
> Maybe better to leave the code as is and simply axe the Mach time code at
> some point in the future?
Supporting only the latest an
Author: rksimon
Date: Tue Mar 14 16:43:52 2017
New Revision: 297784
URL: http://llvm.org/viewvc/llvm-project?rev=297784&view=rev
Log:
Fix Wdocumentation warning
Modified:
cfe/trunk/lib/CodeGen/CGDecl.cpp
Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe
dexonsmith created this revision.
This is a follow-up to r293123 that makes it work with implicit modules.
Some background:
An implicit module build (using Clang's internal build system) uses the same
PCM file location for different `-Werror` levels.
E.g., if a TU has `-Werror
ahatanak updated this revision to Diff 91782.
ahatanak marked 3 inline comments as done.
ahatanak added a comment.
Address review comments from Aaron.
https://reviews.llvm.org/D30766
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clan
ahatanak added inline comments.
Comment at: test/Sema/enum-attr.c:27
+
+enum __attribute__((enum_extensibility(arg1))) EnumInvalidArg { //
expected-warning{{'enum_extensibility' attribute argument not supported:
'arg1'}}
+ G
aaron.ballman wrote:
> ahatanak wro
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
Ugh... I really don't like how `LLVM_UTILS_PROVIDED` is implemented, but I
guess it is fine. This patch is good.
Repository:
rL LLVM
https://reviews.llvm.org/D29851
__
ahatanak added a comment.
It looks like converting vec3 to vec4 is incorrect in some cases. In the
following program, IRGen emits "store <4 x float>" to store g1 to *a, which
will overwrite s1.f2.
typedef __attribute__((__ext_vector_type__(3))) float float3;
struct S1 {
float3 f1;
ahatanak added a comment.
Actually, it's not a mis-compile. The record layout shows that there is a
padding before field f2 and f2 starts at byte 16. So using "store <4 x float>"
doesn't overwrite the field.
https://reviews.llvm.org/D30810
___
cfe
Author: adrian
Date: Tue Mar 14 18:07:49 2017
New Revision: 297790
URL: http://llvm.org/viewvc/llvm-project?rev=297790&view=rev
Log:
Canonicalize the path provided by -fmodules-cache-path.
This fixes lookup mismatches that could happen when the module cache
path contained a '/./' component.
Di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297790: Canonicalize the path provided by
-fmodules-cache-path. (authored by adrian).
Changed prior to commit:
https://reviews.llvm.org/D30915?vs=91628&id=91791#toc
Repository:
rL LLVM
https://revie
GorNishanov updated this revision to Diff 91790.
GorNishanov added a comment.
- reworked EmitAwait/Yield to has the signature similar to EmitAnyExpr
- await expresions now support _Complex types.
- s/Suffix/Prefix in buildCoroutineSuffix, since it was actually building a
prefix
- buildCoroutineSu
jaykang10 added a comment.
In https://reviews.llvm.org/D30810#701132, @ahatanak wrote:
> Actually, it's not a mis-compile. The record layout shows that there is a
> padding before field f2 and f2 starts at byte 16. So using "store <4 x
> float>" doesn't overwrite the field.
It depends on floa
GorNishanov marked 4 inline comments as done.
GorNishanov added inline comments.
Comment at: lib/CodeGen/CGCoroutine.cpp:26
+enum class AwaitKind { Init, Normal, Yield, Final };
+char const *AwaitKindStr[] = {"init", "await", "yield", "final"};
+}
majnemer wrote:
Author: adrian
Date: Tue Mar 14 18:29:40 2017
New Revision: 297791
URL: http://llvm.org/viewvc/llvm-project?rev=297791&view=rev
Log:
Make a blind attempt to fix this testcase on Windows.
Modified:
cfe/trunk/test/Modules/modules-cache-path-canonicalization.m
Modified: cfe/trunk/test/Modules/m
On Mon, Mar 13, 2017 at 10:37:41PM +, Reid Kleckner via Phabricator via
cfe-commits wrote:
> I don't agree. If we want to be good citizens on Linux, what's supposed
> to happen is that we install our shared libraries into
> /usr/lib/${distro_target}, which is what GCC does with its shared
> co
dexonsmith updated this revision to Diff 91799.
dexonsmith added a comment.
Rebased again, and cleaned up tests, and a ping... now that dependencies are
resolved.
Richard and/or Ben, can you take a look?
https://reviews.llvm.org/D28299
Files:
clang/include/clang/Basic/DiagnosticSerializatio
kastiglione updated this revision to Diff 91801.
kastiglione added a comment.
Overload matchesConditionally() for multiple compiler args
https://reviews.llvm.org/D30854
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
dexonsmith added a comment.
> ! In https://reviews.llvm.org/D28299#701194, @dexonsmith wrote:
> Rebased again, and cleaned up tests, and a ping... now that dependencies are
> resolved.
>
> Richard and/or Ben, can you take a look?
(Or anyone else that feels comfortable confirming that the owner
jgorbe created this revision.
The TypoCorrection::RequiresImport flag is managed by
checkCorrectionVisibility() in SemaLookup.cpp. Currently, when none of the
declarations in the typo correction are visible RequiresImport is set to true,
and if there are no declarations, it's implicitly set to fal
bruno added a comment.
> Thanks for your comment. We have a pass to undo the vec4 to vec3. I wondered
> why clang generates the vec4 for vec3 load/store. As you can see the comment
> on clang's code, they are generated for better performance. I had a questions
> at this point. clang should cons
mehdi_amini updated this revision to Diff 91804.
mehdi_amini added a comment.
Update: we set deployment by default even when not testing the system library.
It is intentional because a REQUIRE in a test might be because an issue with
libc for example.
So for now the default is the OS on which the
Author: mehdi_amini
Date: Tue Mar 14 19:59:54 2017
New Revision: 297798
URL: http://llvm.org/viewvc/llvm-project?rev=297798&view=rev
Log:
Add deployment knobs to tests (for Apple platforms)
The tests for libc++ specify -target on the command-line to the
compiler, but this is problematic for a few
dberris added a comment.
Ping?
https://reviews.llvm.org/D30388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dyung
Date: Tue Mar 14 20:38:24 2017
New Revision: 297799
URL: http://llvm.org/viewvc/llvm-project?rev=297799&view=rev
Log:
Fix test on Windows. Only a single backslash was required, not a double.
Modified:
cfe/trunk/test/Modules/modules-cache-path-canonicalization.m
Modified: cfe/tr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297806: [test] Fix test dependencies when using installed
tools (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D29851?vs=88055&id=91824#toc
Repository:
rL LLVM
https://revie
Author: mgorny
Date: Wed Mar 15 00:55:43 2017
New Revision: 297806
URL: http://llvm.org/viewvc/llvm-project?rev=297806&view=rev
Log:
[test] Fix test dependencies when using installed tools
Use the LLVM_UTILS_PROVIDED variable to determine whether test tool
dependencies should be exposed for clang
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCoroutine.cpp:32
struct CGCoroData {
+ AwaitKind CurrentAwaitKind = AwaitKind::Init;
GorNishanov wrote:
> majnemer wrote:
> > Shouldn't this struct be in an anonymous namespace?
> It is forward declare
The SVN mirror is back up and running.
Please let me know if you would see any issues.
Thanks for your patience.
On Mon, Mar 13, 2017 at 4:26 PM, Galina Kistanova
wrote:
> A quick update.
>
> The SVN mirror got corrupted by r297634. Svnsync does not like huge
> commits.
> I'm in the middle of
rogfer01 added a comment.
> A somewhat obvious comment: no chance for this to be accepted without LIT
> tests. I understand you have your doubts on the best approach to testing --
> and it's OK to ask either here or on llvm-dev -- but tests should be added
> nevertheless.
Sure. I wasn't planni
pmatos marked 3 inline comments as done.
pmatos added a comment.
Thanks for the comments.
https://reviews.llvm.org/D27800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pmatos added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:4031
// C99 6.5.3.4p4: the type (an unsigned integer type) is size_t.
+ if (isUnevaluatedContext() && ExprKind == UETT_SizeOf &&
+ TInfo->getType()->isVariablyModifiedType())
efriedma wrote:
pmatos updated this revision to Diff 91684.
pmatos added a comment.
@efriedma I have uploaded a new patch taking your comments into consideration
and rebased on most recent clang sources.
https://reviews.llvm.org/D27800
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExpr.cpp
Index: lib/Se
pmatos updated this revision to Diff 91685.
pmatos added a comment.
Added missing testcase to previous patch.
https://reviews.llvm.org/D27800
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExpr.cpp
test/SemaCXX/pr31042.cpp
Index: test/SemaCXX/pr31042.cpp
=
xazax.hun added a comment.
Also, maybe the readability module would be a better place for this check.
Repository:
rL LLVM
https://reviews.llvm.org/D30896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
sylvestre.ledru added a comment.
Any progress on this? Thanks
Repository:
rL LLVM
https://reviews.llvm.org/D28462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sylvestre
Date: Tue Mar 14 04:43:55 2017
New Revision: 297721
URL: http://llvm.org/viewvc/llvm-project?rev=297721&view=rev
Log:
describe the recent changes in clang-format in the 5.0 release notes
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL
sylvestre.ledru added a comment.
Added to the release notes in r297721
Repository:
rL LLVM
https://reviews.llvm.org/D30487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sylvestre.ledru added a comment.
I did it for you
Added to the release notes in r297721
Repository:
rL LLVM
https://reviews.llvm.org/D29943
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
echuraev updated this revision to Diff 91691.
echuraev marked an inline comment as done.
https://reviews.llvm.org/D30816
Files:
include/clang/Sema/Overload.h
lib/Sema/SemaOverload.cpp
test/SemaOpenCL/overload_addrspace_resolution.cl
Index: test/SemaOpenCL/overload_addrspace_resolution.cl
Great! Thank you very much! There are two more major comment features that
I added: comment reflowing and automatically adding namespace end comments,
and now I know where to put the announcement about them!
Cheers,
Krasimir
On Tue, Mar 14, 2017 at 10:56 AM, Sylvestre Ledru via Phabricator <
revi
Welcome!
Don't hesitate if you need anything else!
Le 14/03/2017 à 10:59, Krasimir Georgiev a écrit :
> Great! Thank you very much! There are two more major comment features that I
> added: comment reflowing and automatically adding namespace end comments, and
> now I know where to put the ann
jbcoe added a comment.
@aaron.ballman
re: "perhaps the check could be relaxed to only consider cases where you have
multiple if/else if clauses".
Sadly this does not satisfy my use case where most of the time a single enum
value is used.
enum class animal_kind { herbivore, carnivore };
if
Author: krasimir
Date: Tue Mar 14 05:34:39 2017
New Revision: 297730
URL: http://llvm.org/viewvc/llvm-project?rev=297730&view=rev
Log:
Add more clang-format changes to the 5.0 release notes
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.
aaron.ballman added a comment.
In https://reviews.llvm.org/D30896#700324, @jbcoe wrote:
> @aaron.ballman
>
> re: "perhaps the check could be relaxed to only consider cases where you have
> multiple if/else if clauses".
>
> Sadly this does not satisfy my use case where most of the time a single e
bader added inline comments.
Comment at: test/SemaOpenCL/overload_addrspace_resolution.cl:1
-// RUN: %clang_cc1 -cl-std=CL2.0 -emit-llvm -o - -triple
x86_64-unknown-unknown %s | FileCheck %s
+// RUN: %clang_cc1 -cl-std=CL2.0 -emit-llvm -o - -triple spir-unknown-unknown
%s | Fil
erik.pilkington updated this revision to Diff 91660.
erik.pilkington added a comment.
In this new patch:
- We only select `allocator` when _Yp is a function type, fixing the ABI
break @EricWF pointed out.
- Only try to select a different allocator if we're using the
`__shared_ptr_pointer` layou
erik.pilkington added a comment.
In https://reviews.llvm.org/D30837#698305, @EricWF wrote:
> We can't just use an arbitrary allocator type for a number of reasons:
>
> - You just changed the type of the control block. That's ABI breaking.
Ah, I didn't think of that. This new patch only selects
bader added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263
+def err_atomic_init_addressspace : Error<
+ "initialization of atomic variables is restricted to variables in global
address space">;
def err_atomic_init_constant : Error<
---
malaperle-ericsson added a comment.
Ping :)
https://reviews.llvm.org/D30675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:2320
+
+ for (Arg *A : Args)
+ {
format
Comment at: lib/Driver/ToolChains/Clang.cpp:2324
+{
+// Options controlling individual features
+case options::OPT
tejohnson added a comment.
In https://reviews.llvm.org/D30920#700133, @pcc wrote:
> In https://reviews.llvm.org/D30920#700077, @tejohnson wrote:
>
> > Until everything is converted to using size attributes, it seems like a
> > correct fix for the bug is to accept these options in the gold-plugin
echuraev created this revision.
https://reviews.llvm.org/D30937
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExprMember.cpp
test/SemaOpenCL/vector_swizzle_length.cl
Index: test/SemaOpenCL/vector_swizzle_length.cl
==
Anastasia added inline comments.
Comment at: test/SemaOpenCL/overload_addrspace_resolution.cl:1
-// RUN: %clang_cc1 -cl-std=CL2.0 -emit-llvm -o - -triple
x86_64-unknown-unknown %s | FileCheck %s
+// RUN: %clang_cc1 -cl-std=CL2.0 -emit-llvm -o - -triple spir-unknown-unknown
%s |
Anastasia added a comment.
In https://reviews.llvm.org/D30810#699827, @jaykang10 wrote:
> In https://reviews.llvm.org/D30810#699695, @bruno wrote:
>
> > Hi JinGu,
> >
> > I just read the discussion on cfe-dev, some comments:
> >
> > > My colleague and I are implementing a transformation pass betw
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Comment at: lib/Driver/Tools.cpp:5290
+ !isa(JA)) {
+//Args.AddAllArgValues(CmdArgs, options::OPT_Xclang);
+for (auto Arg : Args.filtered(opt
echuraev updated this revision to Diff 91713.
echuraev marked 2 inline comments as done.
https://reviews.llvm.org/D30816
Files:
include/clang/Sema/Overload.h
lib/Sema/SemaOverload.cpp
test/CodeGenOpenCL/overload.cl
test/SemaOpenCL/overload_addrspace_resolution.cl
Index: test/SemaOpenCL/o
uweigand added a comment.
SystemZ parts LGTM. Thanks!
https://reviews.llvm.org/D30415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D30415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
sdardis updated this revision to Diff 91716.
sdardis added a comment.
Addressed review comments, add C++ specific test.
https://reviews.llvm.org/D25866
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaExpr.cpp
test/Sema/vector-cast.c
test/Sema/v
guansong updated this revision to Diff 91718.
guansong added a comment.
Thanks, update as suggested.
https://reviews.llvm.org/D30743
Files:
lib/Driver/Tools.cpp
test/Driver/include-default-header.cl
Index: test/Driver/include-default-header.cl
=
1 - 100 of 123 matches
Mail list logo
