Author: rnk
Date: Mon Mar 13 17:33:04 2017
New Revision: 297680
URL: http://llvm.org/viewvc/llvm-project?rev=297680&view=rev
Log:
Widen AST bitfields too small to represent all enumerators
All of these were found by a new warning that I am prototyping,
-Wbitfield-enum-conversion.
Stmt::ExprBits:
pirama created this revision.
Herald added a subscriber: mehdi_amini.
Address PR32155: Skip passing -Os and -Oz to the Gold plugin using
-plugin-opt.
https://reviews.llvm.org/D30920
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/gold-lto.c
Index: test/Driver/gold-lto.c
==
majnemer added inline comments.
Comment at: lib/CodeGen/CGCoroutine.cpp:85
+ unsigned No = 0;
+ StringRef AwaitKindStr = 0;
+ switch (Kind) {
I'd just let the default constructor do its thing.
https://reviews.llvm.org/D30809
__
A quick update.
The SVN mirror got corrupted by r297634. Svnsync does not like huge commits.
I'm in the middle of restoring and synch-ing up the mirror. Too soon to
give any ETA, unfortunately.
Thank you for your patience.
Thanks
Galina
On Mon, Mar 13, 2017 at 12:36 PM, Galina Kistanova
wro
craig.topper created this revision.
The fma libcalls are defined in Builtins.def using the 'e' attribute that says
that its only const if -fno-math-errno. It was apparently marked this way
because that's what the posix spec says. This determines whether the call gets
marked as const or not in S
rnk created this revision.
This adds -Wbitfield-enum-conversion, which warns on implicit
conversions that happen on bitfield assignment that change the value of
some enumerators.
Values of enum type typically take on a very small range of values, so
they are frequently stored in bitfields. Unfort
tejohnson added a comment.
Interested in pcc's thoughts, as https://bugs.llvm.org/show_bug.cgi?id=32155
mentioned you already discussed with him. Note that some of the passes that
check PassManagerBuilder::sizeLevel are added during the ThinLTO back end (e.g.
populateModulePassManager which che
Author: ributzka
Date: Mon Mar 13 19:14:40 2017
New Revision: 297693
URL: http://llvm.org/viewvc/llvm-project?rev=297693&view=rev
Log:
Reapply [VFS] Ignore broken symlinks in the directory iterator.
Modified the tests to accept any iteration order, to run only on Unix, and added
additional error
Author: efriedma
Date: Mon Mar 13 19:18:29 2017
New Revision: 297694
URL: http://llvm.org/viewvc/llvm-project?rev=297694&view=rev
Log:
Fix crash with interrupt attribute on ARM.
An indirect call has no associated function declaration.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/
Author: djasper
Date: Mon Mar 13 19:40:32 2017
New Revision: 297696
URL: http://llvm.org/viewvc/llvm-project?rev=297696&view=rev
Log:
clang-format: Make it very slighly more expensive to wrap between "= {".
This prevents unwanted fallout from r296664. Specifically in proto formatting,
this change
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
https://reviews.llvm.org/D30700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
thakis added inline comments.
Comment at: test/Sema/warn-bitfield-enum-conversion.c:3
+
+enum TwoBits { Hi1 = 3 } two_bits;
+enum TwoBitsSigned { Lo2 = -2, Hi2 = 1 } two_bits_signed;
can you add an enum with an explicit underlying type? will this warning always
rnk updated this revision to Diff 91652.
rnk added a comment.
- Make test C++, add fixed type enum
https://reviews.llvm.org/D30923
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaCXX/warn-bitfield-enum-conversi
rnk marked an inline comment as done.
rnk added inline comments.
Comment at: test/Sema/warn-bitfield-enum-conversion.c:3
+
+enum TwoBits { Hi1 = 3 } two_bits;
+enum TwoBitsSigned { Lo2 = -2, Hi2 = 1 } two_bits_signed;
thakis wrote:
> can you add an enum with an e
rnk updated this revision to Diff 91653.
rnk marked an inline comment as done.
rnk added a comment.
- Actually make this warning off by default
https://reviews.llvm.org/D30923
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.c
pcc added a comment.
In https://reviews.llvm.org/D30920#700077, @tejohnson wrote:
> Until everything is converted to using size attributes, it seems like a
> correct fix for the bug is to accept these options in the gold-plugin and
> pass through the LTO API to the PassManagerBuilder.
Not nec
mehdi_amini added a comment.
Agree with @pcc. Unless anyone has a need to have "perfect" support for Os,
this is the right direction.
https://reviews.llvm.org/D30920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: vedantk
Date: Mon Mar 13 20:56:34 2017
New Revision: 297700
URL: http://llvm.org/viewvc/llvm-project?rev=297700&view=rev
Log:
[ubsan] Add a nullability sanitizer
Teach UBSan to detect when a value with the _Nonnull type annotation
assumes a null value. Call expressions, initializers, assi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297700: [ubsan] Add a nullability sanitizer (authored by
vedantk).
Changed prior to commit:
https://reviews.llvm.org/D30762?vs=91382&id=91658#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30762
Author: ahatanak
Date: Mon Mar 13 23:00:52 2017
New Revision: 297702
URL: http://llvm.org/viewvc/llvm-project?rev=297702&view=rev
Log:
[CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded
correctly.
This fixes PR30413.
Patch by David Lobron.
Added:
cfe/trunk/test/CodeGenObjC/i
Committed r297702.
> On Mar 13, 2017, at 10:02 AM, Lobron, David wrote:
>
> Yes, please, if you don't mind! I'd like to commit both the path and the
> unit test, if possible.
>
> Thanks,
>
> David
>
>> On Mar 13, 2017, at 12:47 PM, Akira Hatanaka wrote:
>>
>> Do you need someone to commit
pirama updated this revision to Diff 91671.
pirama added a comment.
Address review comments
https://reviews.llvm.org/D30920
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/gold-lto.c
Index: test/Driver/gold-lto.c
===
Author: bruno
Date: Mon Mar 13 23:12:29 2017
New Revision: 297703
URL: http://llvm.org/viewvc/llvm-project?rev=297703&view=rev
Log:
Fix cmake to find the compiler-rt libs on darwin
Followup for r297553, which left darwin in a broken state
http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgS
pirama marked 3 inline comments as done.
pirama added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:369
if (A->getOption().matches(options::OPT_O4) ||
-A->getOption().matches(options::OPT_Ofast))
+A->getOption().matches(options::OPT_Ofast)
Hi Eric,
I fixed the build for darwin in r297703, let me know if you have any comments.
Thanks,
On Mon, Mar 13, 2017 at 3:04 PM, Bruno Cardoso Lopes
wrote:
> Hi Eric,
>
>> if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR
>> @@ -62,12 +66,7 @@ if (APPLE AND LLVM_USE_SANITIZER)
>>
Hi Bruno,
Thank you for the fix. I couldn't get to it today. I'll watch the sanitizer
bots more carefully in future.
On Mar 13, 2017 10:26 PM, "Bruno Cardoso Lopes"
wrote:
> Hi Eric,
>
> I fixed the build for darwin in r297703, let me know if you have any
> comments.
>
> Thanks,
>
> On Mon, Mar
101 - 126 of 126 matches
Mail list logo
