r297510 - [VFS] Ignore broken symlinks in the directory iterator.

2017-03-10 Thread Juergen Ributzka via cfe-commits
Author: ributzka Date: Fri Mar 10 15:23:27 2017 New Revision: 297510 URL: http://llvm.org/viewvc/llvm-project?rev=297510&view=rev Log: [VFS] Ignore broken symlinks in the directory iterator. The VFS directory iterator and recursive directory iterator behave differently from the LLVM counterparts.

r297467 - [clang-format] Add option to break before inheritance separation operator in class declaration.

2017-03-10 Thread Andi-Bogdan Postelnicu via cfe-commits
Author: abpostelnicu Date: Fri Mar 10 09:10:37 2017 New Revision: 297467 URL: http://llvm.org/viewvc/llvm-project?rev=297467&view=rev Log: [clang-format] Add option to break before inheritance separation operator in class declaration. Differential Revision: https://reviews.llvm.org/D30487 Modif

r297517 - Revert r297510 "[VFS] Ignore broken symlinks in the directory iterator."

2017-03-10 Thread Juergen Ributzka via cfe-commits
Author: ributzka Date: Fri Mar 10 15:46:51 2017 New Revision: 297517 URL: http://llvm.org/viewvc/llvm-project?rev=297517&view=rev Log: Revert r297510 "[VFS] Ignore broken symlinks in the directory iterator." The tests are failing on one of the bots. Modified: cfe/trunk/include/clang/Basic/Vi

r297528 - Reapply [VFS] Ignore broken symlinks in the directory iterator.

2017-03-10 Thread Juergen Ributzka via cfe-commits
Author: ributzka Date: Fri Mar 10 16:49:04 2017 New Revision: 297528 URL: http://llvm.org/viewvc/llvm-project?rev=297528&view=rev Log: Reapply [VFS] Ignore broken symlinks in the directory iterator. Modified the tests to accept any iteration order. The VFS directory iterator and recursive direct

[PATCH] D30834: [x86] these aren't the undefs you're looking for (PR32176)

2017-03-10 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Have you ran the tests all the way through to assembly and made sure we don't regress? If we do regress, I wouldn't hold up fixing this, but we should at least have bugs for what breaks. Comment at: lib/CodeGen/CGBuiltin.cpp:7384 case X86::BI_

r297531 - Adding debug output to investigate systemz bot issue.

2017-03-10 Thread Juergen Ributzka via cfe-commits
Author: ributzka Date: Fri Mar 10 18:01:24 2017 New Revision: 297531 URL: http://llvm.org/viewvc/llvm-project?rev=297531&view=rev Log: Adding debug output to investigate systemz bot issue. Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified: cfe/trunk/unittests/Basic/Virtu

[libcxx] r297532 - Fix DoNotOptimize on MSVC

2017-03-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Mar 10 18:07:08 2017 New Revision: 297532 URL: http://llvm.org/viewvc/llvm-project?rev=297532&view=rev Log: Fix DoNotOptimize on MSVC Modified: libcxx/trunk/test/support/test_macros.h Modified: libcxx/trunk/test/support/test_macros.h URL: http://llvm.org/viewvc/llvm

r297533 - Revert "Reapply [VFS] Ignore broken symlinks in the directory iterator."

2017-03-10 Thread Juergen Ributzka via cfe-commits
Author: ributzka Date: Fri Mar 10 18:14:50 2017 New Revision: 297533 URL: http://llvm.org/viewvc/llvm-project?rev=297533&view=rev Log: Revert "Reapply [VFS] Ignore broken symlinks in the directory iterator." Still broken on Windows and SystemZ bot ... sorry for the noise. Modified: cfe/trunk

[PATCH] D30834: [x86] these aren't the undefs you're looking for (PR32176)

2017-03-10 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added a comment. In https://reviews.llvm.org/D30834#698346, @craig.topper wrote: > Have you ran the tests all the way through to assembly and made sure we don't > regress? If we do regress, I wouldn't hold up fixing this, but we should at > least have bugs for what breaks. Yes - I spot

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

2017-03-10 Thread Dave Lee via Phabricator via cfe-commits
kastiglione created this revision. This adds matchers for `ObjCProtocolDecl`, `ObjCCategoryDecl`, `ObjCMethodDecl`, `ObjCIvarDecl`, and `ObjCPropertyDecl`. These matchers complement the existing matcher for `ObjCInterfaceDecl`. https://reviews.llvm.org/D30854 Files: docs/LibASTMatchersRefer

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

2017-03-10 Thread Dave Lee via Phabricator via cfe-commits
kastiglione added a comment. I'd like to add more ObjC specific matcher functionality in follow up diffs. This diff is to to start somewhere, and get feedback. https://reviews.llvm.org/D30854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30776: [coroutines] Fix diagnostics depending on the first coroutine statement.

2017-03-10 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. Alright, then. LGTM once more! https://reviews.llvm.org/D30776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

r297541 - [coroutines] Refactor SuspendExpr to create just one OpaqueValue (almost NFC)

2017-03-10 Thread Gor Nishanov via cfe-commits
Author: gornishanov Date: Fri Mar 10 19:30:17 2017 New Revision: 297541 URL: http://llvm.org/viewvc/llvm-project?rev=297541&view=rev Log: [coroutines] Refactor SuspendExpr to create just one OpaqueValue (almost NFC) Summary: Create only one OpaqueValue for await_ready/await_suspend/await_resume.

[PATCH] D30775: [coroutines] Refactor SuspendExpr to create just one OpaqueValue (almost NFC)

2017-03-10 Thread Gor Nishanov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL297541: [coroutines] Refactor SuspendExpr to create just one OpaqueValue (almost NFC) (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D30775?vs=91134&id=91442#toc Repositor

[PATCH] D30776: [coroutines] Fix diagnostics depending on the first coroutine statement.

2017-03-10 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 91447. EricWF added a comment. Merge with master. https://reviews.llvm.org/D30776 Files: include/clang/Sema/ScopeInfo.h lib/Sema/ScopeInfo.cpp lib/Sema/SemaCoroutine.cpp lib/Sema/TreeTransform.h test/SemaCXX/coroutines.cpp Index: test/SemaCXX/coro

r297547 - [coroutines] Fix diagnostics depending on the first coroutine statement.

2017-03-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Mar 10 20:35:37 2017 New Revision: 297547 URL: http://llvm.org/viewvc/llvm-project?rev=297547&view=rev Log: [coroutines] Fix diagnostics depending on the first coroutine statement. Summary: Some coroutine diagnostics need to point to the location of the first coroutine k

[libcxx] r297553 - Change test coverage generation to use llvm-cov instead of gcov.

2017-03-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Mar 10 21:24:18 2017 New Revision: 297553 URL: http://llvm.org/viewvc/llvm-project?rev=297553&view=rev Log: Change test coverage generation to use llvm-cov instead of gcov. Clang doesn't produce gcov compatible coverage files. This causes lcov to break because it uses gco

[PATCH] D30773: Make git-clang-format python 3 compatible

2017-03-10 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 91449. EricWF added a comment. Add complete implementation. As far as I've tested this works perfectly in both python2 and python3. https://reviews.llvm.org/D30773 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format

[PATCH] D30773: Make git-clang-format python 3 compatible

2017-03-10 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF marked 4 inline comments as done. EricWF added inline comments. Comment at: tools/clang-format/git-clang-format:293 +def to_bytes(str): +# Encode to UTF-8 to get binary data. These functions are all lifted directly from `lit/util.py` ==

Re: [PATCH] D30773: Make git-clang-format python 3 compatible

2017-03-10 Thread Eric Fiselier via cfe-commits
On Thu, Mar 9, 2017 at 9:36 AM, Nico Weber wrote: > Consider landing the obvious bits (print function, mostly) separately and > use this only for the interesting bits. > Sounds good. I just wanted to make sure I got the simple bits right as well. If this doesn't get reviewed in the next week I'

[PATCH] D30773: Make git-clang-format python 3 compatible

2017-03-10 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 91452. EricWF marked an inline comment as done. EricWF added a comment. - rename variables so they don't conflict with type names. https://reviews.llvm.org/D30773 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format ==

[libcxx] r297555 - fix test coverage capture dirs

2017-03-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Mar 10 23:28:09 2017 New Revision: 297555 URL: http://llvm.org/viewvc/llvm-project?rev=297555&view=rev Log: fix test coverage capture dirs Modified: libcxx/trunk/test/CMakeLists.txt Modified: libcxx/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/

[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

2017-03-10 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons accepted this revision. malcolm.parsons added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D30854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D30773: Make git-clang-format python 3 compatible

2017-03-10 Thread Michał Górny via Phabricator via cfe-commits
mgorny added inline comments. Comment at: tools/clang-format/git-clang-format:306 +try: +return to_string(bytes.decode('utf-8')) +except AttributeError: # 'str' object has no attribute 'decode'. EricWF wrote: > mgorny wrote: > > This logic looks r

<    1   2