This revision was automatically updated to reflect the committed changes.
Closed by commit rL297004: [clang-tidy] misc-use-after-move: Fix failing
assertion (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D30569?vs=90462&id=90658#toc
Repository:
rL LLVM
https://revi
Author: mboehme
Date: Mon Mar 6 02:55:42 2017
New Revision: 297004
URL: http://llvm.org/viewvc/llvm-project?rev=297004&view=rev
Log:
[clang-tidy] misc-use-after-move: Fix failing assertion
Summary:
I've added a test case that (without the fix) triggers the assertion,
which happens when a move ha
mboehme created this revision.
I've included a unit test with a function template containing a variable
of incomplete type. Clang compiles this without errors (the standard
does not require a diagnostic in this case). Without the fix, this case
triggers the crash.
https://reviews.llvm.org/D30636
Author: asl
Date: Mon Mar 6 03:32:56 2017
New Revision: 297005
URL: http://llvm.org/viewvc/llvm-project?rev=297005&view=rev
Log:
Do not include GCC "resource" directory into the set of built-in include paths
on MingW.
Patch by Mateusz Mikuła.
Differential Revision: https://reviews.llvm.org/D29
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297005: Do not include GCC "resource" directory into the set
of built-in include paths… (authored by asl).
Changed prior to commit:
https://reviews.llvm.org/D29464?vs=87827&id=90661#toc
Repository:
r
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D30636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
mati865 added a comment.
Thank you.
Repository:
rL LLVM
https://reviews.llvm.org/D29464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mati865 added a comment.
Thank you.
https://reviews.llvm.org/D29772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mboehme
Date: Mon Mar 6 03:46:27 2017
New Revision: 297006
URL: http://llvm.org/viewvc/llvm-project?rev=297006&view=rev
Log:
Revert "[clang-tidy] misc-use-after-move: Fix failing assertion"
This reverts commit r297004; it was causing buildbots to fail.
Modified:
clang-tools-extra/tr
Prazek added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+<< FixItHint::CreateRemoval(NoExceptRan
hokein created this revision.
Herald added a subscriber: JDevlieghere.
https://reviews.llvm.org/D30639
Files:
clang-tidy/modernize/UseNullptrCheck.cpp
test/clang-tidy/modernize-use-nullptr.cpp
Index: test/clang-tidy/modernize-use-nullptr.cpp
=
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/modernize-use-nullptr.cpp:252
+ public:
+ explicit TemplateClass(int a, T default_vale = 0) {}
+};
vale -> value
https://reviews.llvm.org/D30639
_
echuraev created this revision.
Herald added a subscriber: yaxunl.
I saw the same changes in the following review: https://reviews.llvm.org/D17438
I don't know in that way I could determine that atomic variable was initialized
by macro ATOMIC_VAR_INIT. Anyway I added check that atomic variables
hokein updated this revision to Diff 90677.
hokein marked an inline comment as done.
hokein added a comment.
typo: vale => value.
https://reviews.llvm.org/D30639
Files:
clang-tidy/modernize/UseNullptrCheck.cpp
test/clang-tidy/modernize-use-nullptr.cpp
Index: test/clang-tidy/modernize-use-
xazax.hun updated this revision to Diff 90676.
xazax.hun marked an inline comment as done.
xazax.hun added a comment.
- Improve the readability of test files.
- Rebased on latest ToT.
https://reviews.llvm.org/D30157
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer
xazax.hun added a comment.
In https://reviews.llvm.org/D30157#689374, @danielmarjamaki wrote:
> I am running this checker right now on various projects. Here are currently
> seen results.. https://drive.google.com/open?id=0BykPmWrCOxt2STZMOXZ5OGlwM3c
>
> Feel free to look at it and see if there
xazax.hun added inline comments.
Comment at: test/clang-tidy/modernize-use-nullptr.cpp:252
+ public:
+ explicit TemplateClass(int a, T default_value = 0) {}
+};
It might be great to have a test case for:
```
template
class TemplateClass {
public:
explicit T
On Sat, Mar 4, 2017 at 12:20 AM, Pirama Arumuga Nainar via cfe-commits
wrote:
> Author: pirama
> Date: Fri Mar 3 17:20:49 2017
> New Revision: 296927
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296927&view=rev
> Log:
> Add arch-specific directory to search path
>
> Summary:
>
> This change a
NoQ planned changes to this revision.
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:286
+ // FIXME: Why do we need to do that if WipeV was known to begin with?
+ State = State->bindLoc(Reg, ExV, LC);
+
a.sidorin wrote:
> If I und
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D30639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
hokein updated this revision to Diff 90691.
hokein marked an inline comment as done.
hokein added a comment.
Add more tests.
https://reviews.llvm.org/D30639
Files:
clang-tidy/modernize/UseNullptrCheck.cpp
test/clang-tidy/modernize-use-nullptr.cpp
Index: test/clang-tidy/modernize-use-nullp
xazax.hun added inline comments.
Comment at: test/clang-tidy/modernize-use-nullptr.cpp:254
+
+ void h(T *default_value = 0) {}
+
Great! Thanks for adding this test. I have the impression we do want to warn
and fix this case however. What do you think?
https:/
hokein added inline comments.
Comment at: test/clang-tidy/modernize-use-nullptr.cpp:252
+ public:
+ explicit TemplateClass(int a, T default_value = 0) {}
+};
xazax.hun wrote:
> It might be great to have a test case for:
>
> ```
>
> template
> class TemplateCla
mboehme added inline comments.
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]]:6: note: move occurred here
+ // CHECK-MESSAGES: [[@LINE-3]]:7: note: move occurred
mboehme created this revision.
Herald added a subscriber: JDevlieghere.
I've added a test case that (without the fix) triggers the assertion,
which happens when a move happens in an implicitly called conversion
operator.
This patch also fixes nondeterministic behavior in the source code
location
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
This wasn't trapped by my filters when it was first posted - sorry about that.
In future if it's a mips related patch you can add me directly as a reviewer
when posting the patch. Changing t
Author: hokein
Date: Mon Mar 6 08:46:44 2017
New Revision: 297009
URL: http://llvm.org/viewvc/llvm-project?rev=297009&view=rev
Log:
[clang-tidy] Ignore substituted template types in modernize-use-nullptr check.
Reviewers: alexfh
Reviewed By: alexfh
Subscribers: xazax.hun, malcolm.parsons, JDev
sylvestre.ledru marked 2 inline comments as done.
sylvestre.ledru added a comment.
Daniel, it is good for me now.
Once it is accepted, I will work on the rest in a separate commit if that is ok
with you;
https://reviews.llvm.org/D30532
___
cfe-com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297009: [clang-tidy] Ignore substituted template types in
modernize-use-nullptr check. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D30639?vs=90691&id=90694#toc
Repository:
Author: hokein
Date: Mon Mar 6 08:49:26 2017
New Revision: 297010
URL: http://llvm.org/viewvc/llvm-project?rev=297010&view=rev
Log:
Do not display highlights for clang-include-fixer-at-point
Summary: When invoking clang-include-fixer-at-point, the QuerySymbolInfos point
to offset 0, length 0. R
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. So you won the flappy column game? ;)
https://reviews.llvm.org/D30650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
xazax.hun added inline comments.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-nullptr.cpp:254
+
+ void h(T *default_value = 0) {}
+
Maybe as a separate patch, but I think it might be worth to warn here. WDYT?
(Sorry for the double post, th
mboehme added a comment.
In https://reviews.llvm.org/D30650#693136, @alexfh wrote:
> LG. So you won the flappy column game? ;)
I hope so... ;)
https://reviews.llvm.org/D30650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Eugene.Zelenko added a comment.
I think we should refactor this check as part of Static Analyzer, since it's
path-sensitive.
https://reviews.llvm.org/D30650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297019: [Sema][ObjC] Warn about 'performSelector' calls with
selectors (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D30174?vs=90473&id=90709#toc
Repository:
rL LLVM
http
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you for doing this!
https://reviews.llvm.org/D30532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Author: marshall
Date: Mon Mar 6 10:06:02 2017
New Revision: 297021
URL: http://llvm.org/viewvc/llvm-project?rev=297021&view=rev
Log:
Update list with changes from Kona meeting
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/vi
Author: arphaman
Date: Mon Mar 6 09:58:34 2017
New Revision: 297019
URL: http://llvm.org/viewvc/llvm-project?rev=297019&view=rev
Log:
[Sema][ObjC] Warn about 'performSelector' calls with selectors
that return record or vector types
The performSelector family of methods from Foundation use objc_m
Author: marshall
Date: Mon Mar 6 10:09:02 2017
New Revision: 297022
URL: http://llvm.org/viewvc/llvm-project?rev=297022&view=rev
Log:
Header update with info about the current status of C++17
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
htt
alexfh added inline comments.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-nullptr.cpp:254
+
+ void h(T *default_value = 0) {}
+
xazax.hun wrote:
> Maybe as a separate patch, but I think it might be worth to warn here. WDYT?
> (Sorry for t
Author: arphaman
Date: Mon Mar 6 10:23:04 2017
New Revision: 297023
URL: http://llvm.org/viewvc/llvm-project?rev=297023&view=rev
Log:
[CodeGen][Blocks] Refactor capture handling in code that generates
block copy/destroy routines
This is a preparation commit for work on merging unique block copy/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297023: [CodeGen][Blocks] Refactor capture handling in code
that generates (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D30345?vs=90197&id=90712#toc
Repository:
rL LLVM
hokein added inline comments.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-nullptr.cpp:254
+
+ void h(T *default_value = 0) {}
+
alexfh wrote:
> xazax.hun wrote:
> > Maybe as a separate patch, but I think it might be worth to warn here.
>
krasimir created this revision.
Herald added a subscriber: klimek.
Until now, NamespaceEndCommentFixer was adding missing comments for every run,
which results in multiple end comments for:
namespace {
int i;
int j;
}
#if A
int a = 1;
#else
int a = 2;
#endif
result befo
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Would probably be interesting to add these test cases:
#if A
namespace A {
#else
namespace B {
#endif
int i;
int j;
}//namespace A
and:
namespace A {
int i;
int j;
#
Author: sylvestre
Date: Mon Mar 6 10:35:28 2017
New Revision: 297025
URL: http://llvm.org/viewvc/llvm-project?rev=297025&view=rev
Log:
Add examples to clang-format configuration
Reviewers: klimek, djasper
Reviewed By: djasper
Subscribers: krasimir, kimgr, cfe-commits
Differential Revision: ht
Author: arphaman
Date: Mon Mar 6 10:37:06 2017
New Revision: 297027
URL: http://llvm.org/viewvc/llvm-project?rev=297027&view=rev
Log:
[Docs] Add missing quotes to the language literal in the
external_source_symbol attribute docs
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified:
krasimir updated this revision to Diff 90715.
krasimir added a comment.
- Added missing newline
https://reviews.llvm.org/D30659
Files:
lib/Format/NamespaceEndCommentsFixer.cpp
unittests/Format/NamespaceEndCommentsFixerTest.cpp
Index: unittests/Format/NamespaceEndCommentsFixerTest.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297028: [clang-format] Make NamespaceEndCommentFixer add at
most one comment (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D30659?vs=90715&id=90716#toc
Repository:
rL LLVM
Author: krasimir
Date: Mon Mar 6 10:44:45 2017
New Revision: 297028
URL: http://llvm.org/viewvc/llvm-project?rev=297028&view=rev
Log:
[clang-format] Make NamespaceEndCommentFixer add at most one comment
Summary:
Until now, NamespaceEndCommentFixer was adding missing comments for every run,
which
Author: vvassilev
Date: Mon Mar 6 10:54:40 2017
New Revision: 297030
URL: http://llvm.org/viewvc/llvm-project?rev=297030&view=rev
Log:
[modules] Make GNUMode a normal language option to fix module compilation.
GNUMode shouldn't be a benign language option because it influences the
resulting AST
sepavloff added a comment.
Ping.
https://reviews.llvm.org/D26065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added inline comments.
Comment at: test/CodeGenCXX/ubsan-bitfields.cpp:21
+ // CHECK: call void @__ubsan_handle_load_invalid_value
+ return s->e1;
+}
Can we avoid the check if the bitfield is 2 bits wide?
Comment at: test/CodeGenObjC
Author: krasimir
Date: Mon Mar 6 11:29:25 2017
New Revision: 297034
URL: http://llvm.org/viewvc/llvm-project?rev=297034&view=rev
Log:
[clang-format] Add tests for ambiguous namespaces to the comment fixer
Modified:
cfe/trunk/unittests/Format/NamespaceEndCommentsFixerTest.cpp
Modified: cfe/t
andrew.w.kaylor created this revision.
This patch updates the clang function that filters the mxcsr register name to
recognize that mxcsr is being split into two pseduo-registers that model the
control and status bits separately.
Repository:
rL LLVM
https://reviews.llvm.org/D30662
Files:
a.sidorin added a comment.
Hello Sean,
It is good to have the ability of recursive lookup. But for me (and I'm sorry),
the code becomes very hard to understand: I need to track if the Decl/DC is in
the source AST or in the AST being imported, if it was imported or if was in
the AST before acro
On Mon, Mar 6, 2017 at 6:29 PM, Krasimir Georgiev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: krasimir
> Date: Mon Mar 6 11:29:25 2017
> New Revision: 297034
>
> URL: http://llvm.org/viewvc/llvm-project?rev=297034&view=rev
> Log:
> [clang-format] Add tests for ambiguous namespa
Author: vvassilev
Date: Mon Mar 6 11:47:57 2017
New Revision: 297037
URL: http://llvm.org/viewvc/llvm-project?rev=297037&view=rev
Log:
[modules] Add missing test from r297030.
Added:
cfe/trunk/test/Modules/Inputs/gnumode-non-benign/
cfe/trunk/test/Modules/Inputs/gnumode-non-benign/module
zaks.anna added a comment.
This is waiting for a resolution on a CallEvent API patch as described in
https://reviews.llvm.org/D27091.
This is blocked on https://reviews.llvm.org/D27091.
Comment at: lib/StaticAnalyzer/Checkers/RecursionChecker.cpp:29
+// this patch.
+REGISTER_
Adding Reid, Michal
On Mon, Mar 6, 2017 at 5:01 AM, Benjamin Kramer wrote:
> On Sat, Mar 4, 2017 at 12:20 AM, Pirama Arumuga Nainar via cfe-commits
> wrote:
> > Author: pirama
> > Date: Fri Mar 3 17:20:49 2017
> > New Revision: 296927
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=29692
twoh created this revision.
This is a revised version of https://reviews.llvm.org/D28796. Included test is
changed to
resolve the target compatibility issue reported
(https://reviews.llvm.org/rL293032).
https://reviews.llvm.org/D30663
Files:
include/clang/Frontend/FrontendOptions.h
lib/Fr
Aleksei,
thank you for your comments!
I appreciate your comments in particular about source/destination confusion. I
can relate to this, as this was (a) an area that confused me while I was
working on this code in LLDB; and (b) it was something I had to keep straight
in my head even when doin
zaks.anna requested changes to this revision.
zaks.anna added a comment.
This revision now requires changes to proceed.
Following Gabor's suggestion, we should investigate if ArrayBoundCheckerV2
supports this. If not it's possible that we are hitting the Constraint Solver
limitations.
Reposito
On Mon, Mar 6, 2017 at 7:00 PM, Pirama Arumuga Nainar wrote:
> Adding Reid, Michal
>
>
> On Mon, Mar 6, 2017 at 5:01 AM, Benjamin Kramer wrote:
>>
>> On Sat, Mar 4, 2017 at 12:20 AM, Pirama Arumuga Nainar via cfe-commits
>> wrote:
>> > Author: pirama
>> > Date: Fri Mar 3 17:20:49 2017
>> > New
inglorion added inline comments.
Comment at: test/Frontend/preprocessed-input.c:3
+// RUN: %clang -emit-llvm -S -o - %t.i | FileCheck %s
+// CHECK: source_filename = {{.*}}preprocessed-input.c"{{$}}
Actually, I think you don't even have to run the preprocessor -
dexonsmith added a subscriber: mehdi_amini.
dexonsmith added a comment.
Mehdi, are you interested in rebasing this?
https://reviews.llvm.org/D17469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: rjmccall
Date: Mon Mar 6 13:04:16 2017
New Revision: 297050
URL: http://llvm.org/viewvc/llvm-project?rev=297050&view=rev
Log:
Further fixes and improvements to the ConstantInitBuilder API.
Added:
cfe/trunk/include/clang/CodeGen/ConstantInitFuture.h
Modified:
cfe/trunk/include/cla
Hi Akira,
Pardon my slowness in addressing your question.
> This patch changes the encoding of an id conforming to a protocol, which I
> think was not intended: For example:
>
> @encode(id)
>
> Would passing IVD to the call to getObjCEncodingForType in
> CGObjCGNU::GenerateClass solve the pro
twoh added inline comments.
Comment at: test/Frontend/preprocessed-input.c:3
+// RUN: %clang -emit-llvm -S -o - %t.i | FileCheck %s
+// CHECK: source_filename = {{.*}}preprocessed-input.c"{{$}}
inglorion wrote:
> Actually, I think you don't even have to run the p
Author: rnk
Date: Mon Mar 6 13:43:16 2017
New Revision: 297057
URL: http://llvm.org/viewvc/llvm-project?rev=297057&view=rev
Log:
[MS] Add support for __ud2 and __int2c MSVC intrinsics
This was requested in PR31958 and elsewhere.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cf
GorNishanov commandeered this revision.
GorNishanov edited reviewers, added: EricWF; removed: GorNishanov.
GorNishanov added a comment.
Comandeering this patch.
Last week Richard gave me some feedback in person on this code (in the full
coroutine implementation not this patch in particular). I am
jyknight added a comment.
Ping
https://reviews.llvm.org/D30427
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh updated this revision to Diff 90735.
twoh added a comment.
Herald added a subscriber: mehdi_amini.
addressing comments from @inglorion
https://reviews.llvm.org/D30663
Files:
include/clang/Frontend/FrontendOptions.h
lib/Frontend/FrontendAction.cpp
test/Frontend/preprocessed-input.i
I
ahatanak added a comment.
Is it possible to add a test case (possibly in CodeGen)?
Repository:
rL LLVM
https://reviews.llvm.org/D30662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Gosh, I missed the reserve() call. Sorry! I'll be happy to implement this
change.
Sean
> On Mar 6, 2017, at 10:05 AM, Sean Callanan wrote:
>
> Aleksei,
>
> thank you for your comments!
>
> I appreciate your comments in particular about source/destination confusion.
> I can relate to this
vmiklos added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20
+///\brief Warns about using throw in function declared as noexcept.
+/// It complains about every throw, even if it is caught later.
+class ThrowWithNoexceptCheck : public ClangTidyCheck {
---
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20
+///\brief Warns about using throw in function declared as noexcept.
+/// It complains about every throw, even if it is caught later.
+class ThrowWithNoexceptCheck : public ClangTidyCheck {
Author: mpark
Date: Mon Mar 6 14:46:55 2017
New Revision: 297065
URL: http://llvm.org/viewvc/llvm-project?rev=297065&view=rev
Log:
Updated email address in `CREDITS.txt`.
Modified:
libcxx/trunk/CREDITS.TXT
Modified: libcxx/trunk/CREDITS.TXT
URL:
http://llvm.org/viewvc/llvm-project/libcxx/t
Author: ericwf
Date: Mon Mar 6 14:49:42 2017
New Revision: 297066
URL: http://llvm.org/viewvc/llvm-project?rev=297066&view=rev
Log:
Mark two any_cast issues as complete
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llv
Author: ericwf
Date: Mon Mar 6 14:56:13 2017
New Revision: 297069
URL: http://llvm.org/viewvc/llvm-project?rev=297069&view=rev
Log:
Mark LWG 2781 as complete. No changes required
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Hal and I discussed exactly the same problem (in the context of coroutines) on
Saturday and came up with exactly the same approach :) I think this is the
right direction.
C
Author: ericwf
Date: Mon Mar 6 15:02:06 2017
New Revision: 297071
URL: http://llvm.org/viewvc/llvm-project?rev=297071&view=rev
Log:
Implement LWG 2787 - [file_status.cons] is inconsistent
Modified:
libcxx/trunk/include/experimental/filesystem
libcxx/trunk/test/std/experimental/filesyste
Author: ericwf
Date: Mon Mar 6 15:07:18 2017
New Revision: 297073
URL: http://llvm.org/viewvc/llvm-project?rev=297073&view=rev
Log:
Mark LWG 2789 as complete. No changes required
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/
Author: ericwf
Date: Mon Mar 6 15:09:02 2017
New Revision: 297074
URL: http://llvm.org/viewvc/llvm-project?rev=297074&view=rev
Log:
Mark LWG 2806 as complete. Libc++ speculatively shiped this change in 4.0
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.
Author: gornishanov
Date: Mon Mar 6 15:12:54 2017
New Revision: 297076
URL: http://llvm.org/viewvc/llvm-project?rev=297076&view=rev
Log:
[coroutines] Add co_return statement emission
Summary:
Added co_return statement emission.
Tweaked coro-alloc.cpp test to use co_return to trigger coroutine p
Author: ericwf
Date: Mon Mar 6 15:23:36 2017
New Revision: 297079
URL: http://llvm.org/viewvc/llvm-project?rev=297079&view=rev
Log:
Add list of filesystem NB comments to TODO.TXT so they can be tracked separately
Modified:
libcxx/trunk/TODO.TXT
Modified: libcxx/trunk/TODO.TXT
URL:
http://l
andrew.w.kaylor added a comment.
In https://reviews.llvm.org/D30662#693559, @ahatanak wrote:
> Is it possible to add a test case (possibly in CodeGen)?
This is covered by CodeGen/ms-inline-asm.c, which Reid added after I broke this
adding the mxcsr register a couple of weeks ago.
Repository:
alexfh added a comment.
In https://reviews.llvm.org/D30650#693165, @Eugene.Zelenko wrote:
> I think we should refactor this check as part of Static Analyzer, since it's
> path-sensitive.
We can think about trying this as a SA checker, but it's irrelevant to this
patch.
https://reviews.llvm.
rnk added inline comments.
Comment at: lib/CodeGen/CGExprComplex.cpp:204-206
+Scope.ensureDominatingValue(&Vals.first);
+Scope.ensureDominatingValue(&Vals.second);
+Scope.ForceCleanup();
rsmith wrote:
> I'm a little concerned about the loose connectio
rnk updated this revision to Diff 90743.
rnk added a comment.
- comments
https://reviews.llvm.org/D30590
Files:
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprComplex.cpp
lib/CodeGen/CGExprScalar.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGenCXX/stmtexpr.cpp
Ind
bruno added a comment.
Hey, really sorry for the delay here.
Comment at: lib/Sema/SemaExpr.cpp:8007
+static bool canConvertIntToOtherIntTy(Sema &S, ExprResult *Int,
+ QualType OtherIntTy) {
+ QualType IntTy = Int->get()->getType().getU
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/Sema/ScopeInfo.h:138-140
+ /// \brief Whether this function has already built, or tried to build, the
+ /// the initial and final coroutine su
rnk added a comment.
I think we should really change this code to filter out clobber registers that
do not name valid gcc inline asm clobbers. That's basically what we require
later. I think if you change this condition to just check
Target.isValidGCCRegisterName.
Repository:
rL LLVM
https
Author: rnk
Date: Mon Mar 6 16:18:34 2017
New Revision: 297084
URL: http://llvm.org/viewvc/llvm-project?rev=297084&view=rev
Log:
Don't assume cleanup emission preserves dominance in expr evaluation
Summary:
Because of the existence branches out of GNU statement expressions, it
is possible that e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297084: Don't assume cleanup emission preserves dominance in
expr evaluation (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D30590?vs=90743&id=90747#toc
Repository:
rL LLVM
htt
bruno added a comment.
Hi Daniel,
This seems pretty nice. Can you share how much performance improvements you got
by this / how did you test it?
https://reviews.llvm.org/D28218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
alexshap added inline comments.
Comment at: lib/Basic/SourceManager.cpp:843
if (E.getOffset() <= SLocOffset) {
FileID Res = FileID::get(-int(I) - 2);
not particularly important (and unrelated to your changes) - nit - s /C-style
cast / static_cast /
Author: ericwf
Date: Mon Mar 6 16:52:28 2017
New Revision: 297089
URL: http://llvm.org/viewvc/llvm-project?rev=297089&view=rev
Log:
[coroutines] Improve diagnostics when building implicit constructs.
Previously when a coroutine was building the implicit setup/destroy
constructs it would emit dia
On 6 March 2017 at 14:18, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Mon Mar 6 16:18:34 2017
> New Revision: 297084
>
> URL: http://llvm.org/viewvc/llvm-project?rev=297084&view=rev
> Log:
> Don't assume cleanup emission preserves dominance in expr eva
bruno added a comment.
Hi,
Thanks for working on this. Few questions:
- What happens with the validation if +soft-float is used?
- What about the 'e' mode, can you double check if the sparc backend support
these instructions? If so it might be interesting to add it here.
Also, please attach pa
1 - 100 of 133 matches
Mail list logo
