On Fri, Mar 3, 2017 at 4:01 PM, Nico Weber wrote:
> "the specified hash does not meet the Hash requirements" isn't a very
> actionable diagnostic.
>
True, For now I was only trying to out-diagnose template barf when I wrote
it initially. So in that regard it's a bit more actionable that it was,
Author: pirama
Date: Fri Mar 3 17:48:15 2017
New Revision: 296929
URL: http://llvm.org/viewvc/llvm-project?rev=296929&view=rev
Log:
Restrict test arch-specific-libdir.c to Linux
Summary: This fails on Windows due to dependence on path separators.
Reviewers: rnk, srhines
Subscribers: llvm-commi
Author: rtrieu
Date: Fri Mar 3 18:08:58 2017
New Revision: 296932
URL: http://llvm.org/viewvc/llvm-project?rev=296932&view=rev
Log:
[ODRHash] Add support for detecting different method properties.
Now print diagnostics for static, virtual, inline, volatile, and const
differences in methods. Als
EricWF created this revision.
This is my attempt to improve the diagnostic messages emitted from the
unordered containers when the supplied hash doesn't meet the `Hash`
requirements.
Unfortunately producing reasonable diagnostics is tricky and it requires a
bunch of meta-programming to get rig
Author: ericwf
Date: Fri Mar 3 19:02:35 2017
New Revision: 296936
URL: http://llvm.org/viewvc/llvm-project?rev=296936&view=rev
Log:
Turn on -Wunused-function and cleanup occurances
Modified:
libcxxabi/trunk/CMakeLists.txt
libcxxabi/trunk/cmake/config-ix.cmake
libcxxabi/trunk/src/cxa_
Author: rizsotto
Date: Fri Mar 3 19:08:05 2017
New Revision: 296937
URL: http://llvm.org/viewvc/llvm-project?rev=296937&view=rev
Log:
[scan-build-py] create decorator for compiler wrapper methods
Differential Revision: https://reviews.llvm.org/D29260
Modified:
cfe/trunk/tools/scan-build-py/
Author: ericwf
Date: Fri Mar 3 19:26:41 2017
New Revision: 296940
URL: http://llvm.org/viewvc/llvm-project?rev=296940&view=rev
Log:
Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp
Modified:
libcxxabi/trunk/test/CMakeLists.txt
libcxxabi/trunk/test/cxa_thread_ate
Author: ericwf
Date: Fri Mar 3 19:29:51 2017
New Revision: 296942
URL: http://llvm.org/viewvc/llvm-project?rev=296942&view=rev
Log:
teach LIT how to detect the glibc version
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http://ll
dcoughlin added reviewers: zaks.anna, NoQ.
dcoughlin added a comment.
The analyzer has two different kinds of diagnostics: AST-based and
path-sensitive. AST-based diagnostics are similar to the diagnostics that clang
performs in Sema in that they can usually be localized to a single program
poi
EricWF updated this revision to Diff 90561.
EricWF added a comment.
Merge with master
https://reviews.llvm.org/D25417
Files:
src/cxa_exception.cpp
src/fallback_malloc.cpp
src/fallback_malloc.h
test/test_exception_address_alignment.pass.cpp
Index: test/test_exception_address_alignment.p
Author: ericwf
Date: Fri Mar 3 20:04:45 2017
New Revision: 296952
URL: http://llvm.org/viewvc/llvm-project?rev=296952&view=rev
Log:
[libcxxabi] Fix alignment of allocated exceptions in 32 bit builds
Summary:
In 32 bit builds on a 64 bit system `std::malloc` does not return correctly
aligned mem
Author: rtrieu
Date: Fri Mar 3 20:05:13 2017
New Revision: 296953
URL: http://llvm.org/viewvc/llvm-project?rev=296953&view=rev
Log:
[ODRHash] Change test to try to appease buildbot.
Modified:
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/test/Modules/odr_hash.cpp
URL:
http://llvm
Author: ericwf
Date: Fri Mar 3 20:15:37 2017
New Revision: 296954
URL: http://llvm.org/viewvc/llvm-project?rev=296954&view=rev
Log:
Fix CMake configuration errors on OS X
Modified:
libcxxabi/trunk/CMakeLists.txt
Modified: libcxxabi/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-proj
On 3/3/17 6:26 PM, Eric Fiselier via cfe-commits wrote:
Author: ericwf
Date: Fri Mar 3 19:26:41 2017
New Revision: 296940
URL: http://llvm.org/viewvc/llvm-project?rev=296940&view=rev
Log:
Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp
Modified:
libcxxabi/trunk
Author: ericwf
Date: Fri Mar 3 20:29:25 2017
New Revision: 296955
URL: http://llvm.org/viewvc/llvm-project?rev=296955&view=rev
Log:
Attempt to suppress test failures on OS X
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
libcxxabi/trunk/test/test_exception_address_alignment.pass
LIBCXXABI_HAS_CXA_THREAD_ATEXIT_IMPL should be set by
`check_library_exists` at the bottom of `config-ix.cmake`.
On Fri, Mar 3, 2017 at 7:22 PM, Jonathan Roelofs
wrote:
>
>
> On 3/3/17 6:26 PM, Eric Fiselier via cfe-commits wrote:
>
>> Author: ericwf
>> Date: Fri Mar 3 19:26:41 2017
>> New Revi
Author: rtrieu
Date: Fri Mar 3 20:42:41 2017
New Revision: 296956
URL: http://llvm.org/viewvc/llvm-project?rev=296956&view=rev
Log:
Handle null QualType better in Stmt::Profile
If the QualType is null, calling ASTContext::getCanonicalType on it will lead
to an assert. This was found while testi
Author: ericwf
Date: Fri Mar 3 21:03:27 2017
New Revision: 296957
URL: http://llvm.org/viewvc/llvm-project?rev=296957&view=rev
Log:
Add missing UNSUPPORTED for -fno-exception mode
Modified:
libcxxabi/trunk/test/test_exception_address_alignment.pass.cpp
Modified: libcxxabi/trunk/test/test_ex
Author: rtrieu
Date: Fri Mar 3 21:04:15 2017
New Revision: 296958
URL: http://llvm.org/viewvc/llvm-project?rev=296958&view=rev
Log:
[ODRHash] Try again to fix build bot.
Modified:
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/test/Modules/odr_hash.cpp
URL:
http://llvm.org/viewvc/
Author: ericwf
Date: Fri Mar 3 21:23:15 2017
New Revision: 296960
URL: http://llvm.org/viewvc/llvm-project?rev=296960&view=rev
Log:
Fully Reformat fallback_malloc.cpp
This patch fully reformats fallback_malloc.cpp. Previously the test
was a mess of different styles and indentations. This made it
On 3/3/17 7:45 PM, Eric Fiselier wrote:
LIBCXXABI_HAS_CXA_THREAD_ATEXIT_IMPL should be set by
`check_library_exists` at the bottom of `config-ix.cmake`.
Ah, cool.
Jon
On Fri, Mar 3, 2017 at 7:22 PM, Jonathan Roelofs
mailto:jonat...@codesourcery.com>> wrote:
On 3/3/17 6:26 PM, Eri
vsk created this revision.
UBSan's nonnull argument check applies when a parameter has the
"nonnull" attribute. The check currently works for FunctionDecls, but
not for ObjCMethodDecls. This patch extends the check to work for ObjC.
To do this, I introduced a new AbstractCallee class to represent
jroelofs added a comment.
Can the null check be performed in the callee?
That'd make this check work for a few more cases that this patch doesn't cover:
- `performSelector:` messages
- messages to `id`.
https://reviews.llvm.org/D30599
___
cfe-comm
vsk added a comment.
In https://reviews.llvm.org/D30599#692210, @jroelofs wrote:
> Can the null check be performed in the callee?
Yes, but I think that would result in perplexing diagnostics, because we
wouldn't be able to report the source location of the buggy calls.
> That'd make this chec
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM, by the way.
https://reviews.llvm.org/D30599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
twoh abandoned this revision.
twoh added a comment.
@inglorion That makes a lot of sense. Maybe we don't even need -g, because -S
-emit-llvm shows source_filename. I'll run some more experiments with
relpath/abspath and debug locations, and submit a revised patch. Thanks for the
comment!
http
101 - 126 of 126 matches
Mail list logo
