a.sidorin added a comment.
Hi Artem! Thank you for this patch. It looks very promising, but I have some
questions and remarks.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:187
const Expr *Result) {
- SVal V = State->getSVal(Ex,
Author: alexfh
Date: Fri Mar 3 02:18:49 2017
New Revision: 296858
URL: http://llvm.org/viewvc/llvm-project?rev=296858&view=rev
Log:
[clang-tidy] google-readability-casting: don't use constructor call syntax for
const types
Modified:
clang-tools-extra/trunk/clang-tidy/google/AvoidCStyleCasts
Abpostelnicu added inline comments.
Comment at: include/clang/Format/Format.h:309
+ /// inheritance.
+ bool BreakInhertianceBeforeColonAndComma;
+
djasper wrote:
> Hm. I am still not sure about this flag and it's name. Fundamentally, this is
> currently cont
alexfh created this revision.
Herald added a subscriber: JDevlieghere.
Add -format option (disabled by default for now) to trigger formatting
of replacements.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
docs/Re
a.sidorin added a comment.
Looks like a right fix.
Comment at: lib/StaticAnalyzer/Checkers/CastToStructChecker.cpp:93
// Warn when there is widening cast.
unsigned ToWidth = Ctx.getTypeInfo(ToPointeeTy).Width;
NoQ wrote:
> I think we should move the
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/readability-braces-around-statements-format.cpp:1
+// RUN: %check_clang_tidy %s readability-braces-around-statements %t --
-format --
+
Will clang-tidy look for a .clang-format file?
Does this te
alexfh updated this revision to Diff 90442.
alexfh added a comment.
Pacify llvm::Expected<> debug checks.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/cla
alexfh added inline comments.
Comment at: test/clang-tidy/readability-braces-around-statements-format.cpp:1
+// RUN: %check_clang_tidy %s readability-braces-around-statements %t --
-format --
+
malcolm.parsons wrote:
> Will clang-tidy look for a .clang-format fi
a.sidorin created this revision.
ExprEngine assumes that OpenMP statements should never appear in CFG. However,
current CFG doesn't know anything about OpenMP and passes such statements as
CFG nodes causing "UNREACHABLE executed!" crashes. Since I have no ideas on
OpenMP implementation in ExprE
kimgr added inline comments.
Comment at: docs/clang-tidy/index.rst:184
-p= - Build path
+-quiet -
+ Run clang-tidy in quiet mode. This
suppresses
This looks like a separate patch?
alexfh marked an inline comment as done.
alexfh added inline comments.
Comment at: docs/clang-tidy/index.rst:184
-p= - Build path
+-quiet -
+ Run clang-tidy in quiet mode. This
suppresses
-
djasper added a comment.
Hm. I don't actually know whether these examples are useful as is. You only
present one setting of the value in most cases. What's interesting is actually
how the flag changes the behavior. I mean in most cases, this can be derived
from the example, but in those cases,
sylvestre.ledru added a comment.
I see a lot of values in examples. If I started this review, it is because I
was lost in all the options and could not find what I was looking for.
If you want, I can update the example to provide results with and without the
option.
like
> With SpacesInCStyle
Author: nemanjai
Date: Fri Mar 3 03:49:17 2017
New Revision: 296861
URL: http://llvm.org/viewvc/llvm-project?rev=296861&view=rev
Log:
[PowerPC] Enable -fomit-frame-pointer by default for PPC
As is the case on platforms like Mips, X86 and SystemZ, the -fomit-frame-pointer
should be enabled by def
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296861: [PowerPC] Enable -fomit-frame-pointer by default for
PPC (authored by nemanjai).
Changed prior to commit:
https://reviews.llvm.org/D29750?vs=87821&id=90443#toc
Repository:
rL LLVM
https://re
djasper added a comment.
Sure, then go ahead. If these examples would have helped you, that's one
datapoint :).
As for presenting the difference in options, that would be useful I think. So
if you are up to also doing that, that'd be appreciated.
For bool options it seems easiest to do somethin
djasper added inline comments.
Comment at: include/clang/Format/Format.h:309
+ /// inheritance.
+ bool BreakInhertianceBeforeColonAndComma;
+
Abpostelnicu wrote:
> djasper wrote:
> > Hm. I am still not sure about this flag and it's name. Fundamentally, this
kimgr added a comment.
For what it's worth, I also find this useful to be able to see at a glance what
the setting does. I know I've tried several different settings in the past
before finding the one I was looking for.
https://reviews.llvm.org/D30532
___
ioeric added inline comments.
Comment at: test/clang-tidy/readability-braces-around-statements-format.cpp:1
+// RUN: %check_clang_tidy %s readability-braces-around-statements %t --
-format --
+
alexfh wrote:
> malcolm.parsons wrote:
> > Will clang-tidy look for
alexfh updated this revision to Diff 90445.
alexfh marked an inline comment as done.
alexfh added a comment.
Replace the separate -format and -style options with -format-style (default is
'none', which means no formatting).
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
cla
malcolm.parsons added a comment.
In https://reviews.llvm.org/D30564#691441, @alexfh wrote:
> Replace the separate -format and -style options with -format-style (default is
> 'none', which means no formatting).
Is there a style that means use my .clang-format file?
https://reviews.llvm.org/D3
sylvestre.ledru added a comment.
> For bool options it seems easiest to do something like:
> true: x = ( int32 )y;
> false: x = (int32)y;
That works for single declarations but for stuff like:
> SomeClass::Constructor()
> : a(a)
> , b(b)
> , c(c) {}
I won't be
alexfh updated this revision to Diff 90447.
alexfh added a comment.
Expanded -format-style option description. Run cleanup tests with different
format styles, just in case.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes
alexfh added a comment.
In https://reviews.llvm.org/D30564#691446, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D30564#691441, @alexfh wrote:
>
> > Replace the separate -format and -style options with -format-style (default
> > is
> > 'none', which means no formatting).
>
>
> Is there
alexfh updated this revision to Diff 90448.
alexfh added a comment.
Clarify the 'file' option a bit.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/clean-up-code.cpp
te
djasper added a comment.
I agree, just generally we should aim for keeping these short.
The example you gave might actually be reasonable to compare in two columns,
i.e.:
true: false:
SomeClass::Constructor() vs. SomeClass::Constructor() : a(a),
malcolm.parsons added a comment.
LGTM.
https://reviews.llvm.org/D30564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
PTAL
https://reviews.llvm.org/D30564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
https://reviews.llvm.org/D30564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ioeric added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:214
+ llvm::errs() << llvm::toString(Replacements.takeError()) << "\n";
+ continue;
+}
Maybe still apply the replacements if formatting fails?
https://reviews.llvm.org/
alexfh updated this revision to Diff 90452.
alexfh added a comment.
Apply changes even when formatting fails.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/clean-up-code
Author: alexfh
Date: Fri Mar 3 05:16:34 2017
New Revision: 296864
URL: http://llvm.org/viewvc/llvm-project?rev=296864&view=rev
Log:
[clang-tidy] Format code around applied fixes
Summary:
Add -format option (disabled by default for now) to trigger formatting
of replacements.
Reviewers: ioeric
R
danielmarjamaki added a comment.
To me it seems that the extent is calculated properly in ArrayBoundsV2.
Existing code:
DefinedOrUnknownSVal extentVal =
rawOffset.getRegion()->getExtent(svalBuilder);
This ugly little debug code will extract the needed VLA information from the
extentVal..
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296864: [clang-tidy] Format code around applied fixes
(authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D30564?vs=90452&id=90453#toc
Repository:
rL LLVM
https://reviews.llvm.or
krasimir added a comment.
I also think that examples for the flags are good. My use case is that while
developing/debugging its nice to see a short example for a random flag in the
documentation pop-up.
https://reviews.llvm.org/D30532
___
cfe-comm
Abpostelnicu added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2400
+// Returns 'true' if there is an TT_InheritanceComma in the current token list.
+static bool hasMultipleInheritance(const FormatToken &Tok) {
+ for (const FormatToken* nextTok = Tok.Next; nextTok
djasper added a comment.
Before `'`? Can you give an example?
Repository:
rL LLVM
https://reviews.llvm.org/D30487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Abpostelnicu added a comment.
In https://reviews.llvm.org/D30487#691506, @djasper wrote:
> Before `'`? Can you give an example?
MY mistake, i wanted to write ``:`
Repository:
rL LLVM
https://reviews.llvm.org/D30487
___
cfe-commits mailing list
a.sidorin added a comment.
`git blame` shows that OMP* statements were added to the switch block by
different authors while OpenMP support in clang was implemented. Looks like
they were put to "Should not appear" section instead of "Unsupported" by
mistake.
https://reviews.llvm.org/D30565
Author: prazek
Date: Fri Mar 3 06:42:22 2017
New Revision: 296867
URL: http://llvm.org/viewvc/llvm-project?rev=296867&view=rev
Log:
[clang-tidy] Fix modernize-use-emplace docs
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-emplace.rst
Modified:
clang-tools-extra/tru
djasper added a comment.
Do you know whether that is intentional? The style guide isn't really
conclusive.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2486
Style.BreakConstructorInitializersBeforeComma &&
!Style.ConstructorInitializerAllOnOneLineOrOnePerLine)
At any rate, I think this is what makes single-item ctor init lists
Abpostelnicu added a comment.
In https://reviews.llvm.org/D30487#691517, @djasper wrote:
> Do you know whether that is intentional? The style guide isn't really
> conclusive.
Well i'm not sure, because as you said the document is not clear but i think
that when we have a single initialiser it
mboehme created this revision.
Herald added a subscriber: JDevlieghere.
I've added a test case that (without the fix) triggers the assertion,
which happens when a move happens in an implicitly called conversion
operator.
https://reviews.llvm.org/D30569
Files:
clang-tidy/misc/UseAfterMoveCheck
mboehme added inline comments.
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]]:6: note: move occurred here
+ // CHECK-MESSAGES: [[@LINE-3]]:7: note: move occurred
mboehme marked an inline comment as done.
mboehme added inline comments.
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]]:6: note: move occurred here
+ // CHECK-MES
djasper added a comment.
Hm. Unfortunately, this seems to have been implemented to support Webkit style
and Webkit style is explicit about wanting this
(https://webkit.org/code-style-guidelines/) :(.
But maybe the solution to that is to add an extra flag like
AlwaysWrapInitializerList. Really
On 3 March 2017 at 12:42, Piotr Padlewski via cfe-commits
wrote:
> w.emplace_back(std::make_pair(21L, 37L);
Unbalanced ().
--
Malcolm Parsons
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]
alexfh added a comment.
What's the practical use of newlines and tab characters in the glob list?
https://reviews.llvm.org/D30567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Abpostelnicu added a comment.
In https://reviews.llvm.org/D30487#691535, @djasper wrote:
> Hm. Unfortunately, this seems to have been implemented to support Webkit
> style and Webkit style is explicit about wanting this
> (https://webkit.org/code-style-guidelines/) :(.
>
> But maybe the solutio
mboehme marked an inline comment as done.
mboehme added inline comments.
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]]:6: note: move occurred here
+ // CHECK-MES
xazax.hun added a comment.
In the meantime CheckBeginFunction has been implemented separately. I think you
should "abandon" this revision so it is shown as closed.
https://reviews.llvm.org/D15090
___
cfe-commits mailing list
cfe-commits@lists.llvm.
alexfh added inline comments.
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]]:6: note: move occurred here
+ // CHECK-MESSAGES: [[@LINE-3]]:7: note: move occurred h
danielmarjamaki updated this revision to Diff 90471.
danielmarjamaki added a comment.
Fix review comment
Repository:
rL LLVM
https://reviews.llvm.org/D30341
Files:
lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp
test/Analysis/NewDelete-checker-test.cpp
test/Analysis/diagnostics/u
arphaman marked 3 inline comments as done.
arphaman added inline comments.
Comment at: lib/AST/DeclObjC.cpp:987
unsigned noParams = param_size();
if (noParams < 1 || noParams > 3)
family = OMF_None;
ahatanak wrote:
> It seems like this code
arphaman updated this revision to Diff 90473.
arphaman marked 3 inline comments as done.
arphaman added a comment.
The updated diff:
- Warns for vector types.
- Addresses Akira's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D30174
Files:
include/clang/Basic/DiagnosticSemaKinds.t
Abpostelnicu updated this revision to Diff 90475.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.c
Abpostelnicu updated this revision to Diff 90480.
Abpostelnicu added a comment.
corrected some format issues.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Forma
sylvestre.ledru updated this revision to Diff 90482.
sylvestre.ledru added a comment.
With the changes requested by Daniel. This is much better indeed!
https://reviews.llvm.org/D30532
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
Index: include/clang/Format/Format.h
krasimir abandoned this revision.
krasimir added a comment.
This patch is superseded by https://reviews.llvm.org/D30575.
https://reviews.llvm.org/D30492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
gerazo marked an inline comment as done.
gerazo added a comment.
Hmm... I am thinking on this issue for a week now...
I've played with the idea of implementing cleansing rules in
GenericTaintChecker. It would be elegant but unfortunately, I have to think
they are not general. Cleansing of a str
sylvestre.ledru updated this revision to Diff 90486.
sylvestre.ledru added a comment.
updated => affected
+ align the vs
https://reviews.llvm.org/D30532
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
Index: include/clang/Format/Format.h
=
dcoughlin added a comment.
Looks great. Thanks!!
https://reviews.llvm.org/D30373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this! It looks like this is tracked by PR31835.
https://bugs.llvm.org//show_bug.cgi?id=31835
https://reviews.llvm.org/D30565
___
john.brawn created this revision.
The way -ffast-math and the various related options to tweak floating-point
handling are handled is inflexible and rather confusing. This patch
restructures things so that we go through the options adjusting our idea of
what's enabled as we go, instead of tryin
Author: a.sidorin
Date: Fri Mar 3 10:58:53 2017
New Revision: 296884
URL: http://llvm.org/viewvc/llvm-project?rev=296884&view=rev
Log:
[Analyzer] Terminate analysis on OpenMP code instead of assertion crash
* ExprEngine assumes that OpenMP statements should never appear in CFG.
However, curren
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296884: [Analyzer] Terminate analysis on OpenMP code instead
of assertion crash (authored by a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D30565?vs=90441&id=90499#toc
Repository:
rL
a.sidorin added a comment.
Thank you Devin. Should we submit this to 4.0? I guess there are not many users
of both CSA and OpenMP but PR you pointed is already the second report about
this issue I see.
Repository:
rL LLVM
https://reviews.llvm.org/D30565
__
Author: prazek
Date: Fri Mar 3 11:16:11 2017
New Revision: 296888
URL: http://llvm.org/viewvc/llvm-project?rev=296888&view=rev
Log:
[clang-tidy] Yet another docs fixes
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-emplace.rst
Modified:
clang-tools-extra/trunk/docs/
Author: mehdi_amini
Date: Fri Mar 3 11:24:29 2017
New Revision: 296889
URL: http://llvm.org/viewvc/llvm-project?rev=296889&view=rev
Log:
Fix libc++ test to pass in C++03 mode
Was hitting: "error: scalar initializer cannot be empty"
Modified:
libcxx/trunk/test/std/depr/depr.c.headers/stdio_h
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thanks. looks good.
https://reviews.llvm.org/D28297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
dcoughlin added a comment.
@zaks.anna: What do you think? Should we try to get this into clang 4.0?
Repository:
rL LLVM
https://reviews.llvm.org/D30565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
yaxunl updated this revision to Diff 90520.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
remove redundant code.
make mov_dpp target builtin.
https://reviews.llvm.org/D30551
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cpp
Does that mean there is a bug in libcxx that should be documented somewhere?
-- adrian
> On Mar 2, 2017, at 3:18 PM, Eric Fiselier via cfe-commits
> wrote:
>
> Author: ericwf
> Date: Thu Mar 2 17:18:40 2017
> New Revision: 296840
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296840&view=re
smeenai updated this revision to Diff 90524.
smeenai added a comment.
Address comments
https://reviews.llvm.org/D27387
Files:
include/__config
include/functional
lib/CMakeLists.txt
src/functional.cpp
Index: src/functional.cpp
===
loladiro created this revision.
Some of the magic functions take arguments of arbitrary type. However,
for semantic correctness, the compiler still requires a declaration
of these functions with the correct type. Since C does not have
argument-type-overloaded function, this made those functions ha
rnk created this revision.
Because of the existence branches out of GNU statement expressions, it
is possible that emitting cleanups for a full expression may cause the
new insertion point to not be dominated by the result of the inner
expression. Consider this example:
struct Foo { Foo(); ~Foo
lethalantidote added a comment.
Is there any subgroup that one could suggest for this warning to fall under?
https://reviews.llvm.org/D28543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
twoh created this revision.
This feature is needed to re-enable https://reviews.llvm.org/rL293004, which
resembles gcc's behavior in
finding the input file name from a preprocessed source. The patch has been
reverted in https://reviews.llvm.org/rL293032, because the test checks FILE
symbol of EL
rnk accepted this revision.
rnk added a comment.
Looks good with a minor comment about a comment in the test case.
Comment at: lib/Driver/Tools.cpp:2007-2009
+ // In the cross-compilation case, arch-specific library path is likely
+ // unavailable at runtime.
+ if (TC.isCros
rnk added a comment.
Do you guys think that maybe -flto should imply -fuse-ld=lld, or is that too
much magic?
Repository:
rL LLVM
https://reviews.llvm.org/D30239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
fgross created this revision.
Herald added a subscriber: JDevlieghere.
catch (std::exception ex)
{
}
Was flagged with "catch handler catches a pointer value".
https://reviews.llvm.org/D30592
Files:
clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp
Index: clang-tidy/misc/ThrowByVa
pirama updated this revision to Diff 90532.
pirama edited the summary of this revision.
pirama added a comment.
Fixed comment in test and added a test for -fsanitize=address without
-shared-libasan.
https://reviews.llvm.org/D30015
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChai
mehdi_amini added a comment.
In https://reviews.llvm.org/D30239#691972, @rnk wrote:
> Do you guys think that maybe -flto should imply -fuse-ld=lld, or is that too
> much magic?
I don't know enough about windows, but I would think it may be surprising for a
user that -flto changes the linker b
pirama marked an inline comment as done.
pirama added inline comments.
Comment at: lib/Driver/Tools.cpp:2007-2009
+ // In the cross-compilation case, arch-specific library path is likely
+ // unavailable at runtime.
+ if (TC.isCrossCompiling()) return;
rnk wro
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Thanks! This bugged me as well, but i didn't think of this trick :)
https://reviews.llvm.org/D30589
___
cfe-commits mailing list
cfe-commits@lists.llvm
NoQ added a comment.
The code looks good to me, but i'm expressing a tiny doubt: regardless of the
output format, the user always has the relevant argument highlighted anyway
(column number, tilde-underlined in command line, blue-ish box in scan-build,
etc.), so the only significant clarificati
Author: ericwf
Date: Fri Mar 3 16:35:58 2017
New Revision: 296919
URL: http://llvm.org/viewvc/llvm-project?rev=296919&view=rev
Log:
Fix hash requirements check in __hash_table.
r296565 attempted to add better diagnostics when an unordered container
is instantiated with a hash that doesn't meet t
NoQ added a comment.
In https://reviews.llvm.org/D30489#691475, @danielmarjamaki wrote:
> Do you agree that this is the problem? Would it be a good idea to try to keep
> the sz in the ProgramState?
Environment stores values only temporarily. It's kind of a scratch pad for
temporary symbolic c
Author: ericwf
Date: Fri Mar 3 16:47:45 2017
New Revision: 296922
URL: http://llvm.org/viewvc/llvm-project?rev=296922&view=rev
Log:
Remove the buildit and testit scripts; they haven't been supported in years
Removed:
libcxx/trunk/lib/buildit
libcxx/trunk/test/testit
Removed: libcxx/trun
"the specified hash does not meet the Hash requirements" isn't a very
actionable diagnostic. Is it possible to use some warning text that lets
people know what they need to do to make the compiler happy, instead of
just telling them that the compiler is unhappy?
On Fri, Mar 3, 2017 at 5:35 PM, Eri
kmarshall added a comment.
Note to reviewers: this diff is relative to "llvm/cfe" - I couldn't find a way
to specify a repository subpath to use for this diff.
Repository:
rL LLVM
https://reviews.llvm.org/D30593
___
cfe-commits mailing list
cfe
kmarshall created this revision.
The Clang static analyzer doesn't follow the warning suppression semantics of
the "-isystem" command line flag. This patch adds a check to BugReporter which
causes it to drop any BugReports which originated from a system header
(descendant of an -isystem path).
thakis added a comment.
http://llvm-cs.pcc.me.uk/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h/risInSystemHeader
suggests that the analyzer has some plumbing for this, so I added dcoughlin as
reviewer, who has touched some of those lines before. dcoughlin, as background
inglorion added a comment.
Checking for linux when really you want to check for ELF doesn't seem right. In
this case, I think there is an better way to do it; instead of relying on
llvm-objdump, could you emit an LLVM assembly file and check that for presence
of the string you want? I think if
Author: pirama
Date: Fri Mar 3 17:20:49 2017
New Revision: 296927
URL: http://llvm.org/viewvc/llvm-project?rev=296927&view=rev
Log:
Add arch-specific directory to search path
Summary:
This change adds an arch-specific subdirectory in /lib/
to the linker search path. This path also gets added a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296927: Add arch-specific directory to search path (authored
by pirama).
Changed prior to commit:
https://reviews.llvm.org/D30015?vs=90532&id=90545#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
pirama added a comment.
Committed. Thanks for the reviews!
Repository:
rL LLVM
https://reviews.llvm.org/D30015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
This change is missing test cases.
https://reviews.llvm.org/D30592
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
1 - 100 of 126 matches
Mail list logo
