Re: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

> On Mar 1, 2017, at 3:24 PM, Sean Silva wrote: > > > > On Wed, Mar 1, 2017 at 10:35 AM, Mehdi Amini > wrote: > I’m not sure I find this nice to see this upstream. > > I not fond in general of this kind of difference in behavior. I don’t think > it is good for

[libcxx] r296712 - Fix Apple-specific XFAIL directive in libc++ test

Author: mehdi_amini Date: Wed Mar 1 17:45:03 2017 New Revision: 296712 URL: http://llvm.org/viewvc/llvm-project?rev=296712&view=rev Log: Fix Apple-specific XFAIL directive in libc++ test This tests is failing in XCode 7.0. But Xcode 7.3 that shipped an updated clang has this test passing. This i

[libcxxabi] r296715 - Cleanup new/delete definitions

Author: ericwf Date: Wed Mar 1 17:59:34 2017 New Revision: 296715 URL: http://llvm.org/viewvc/llvm-project?rev=296715&view=rev Log: Cleanup new/delete definitions This patch cleans up how libc++abi handles the definitions for new/delete. It is in preperation for upcoming changes to fix how both

[libcxx] r296716 - Fix python 3 syntax error in sym_diff

Author: ericwf Date: Wed Mar 1 18:03:01 2017 New Revision: 296716 URL: http://llvm.org/viewvc/llvm-project?rev=296716&view=rev Log: Fix python 3 syntax error in sym_diff Modified: libcxx/trunk/utils/libcxx/sym_check/diff.py Modified: libcxx/trunk/utils/libcxx/sym_check/diff.py URL: http://

[PATCH] D30516: [libc++] Add option to disable new/delete overloads when libc++abi provides them.

EricWF created this revision. Currently both libc++ and libc++abi provide definitions for operator new/delete. However I believe this is incorrect and that one or the other should offer them. This patch adds the CMake option `-DLIBCXX_ENABLE_NEW_DELETE_DEFINITIONS` which defaults no `ON` unles

[PATCH] D30517: [libc++abi] Add option to enable definitions for the new/delete overloads.

EricWF created this revision. Currently both libc++ and libc++abi provide definitions for operator new/delete. However I believe this is incorrect and that one or the other should offer them. This patch adds the CMake option `-DLIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS` which defaults to `OFF` u

[PATCH] D30518: Fix msc-version.c test to handle _MSC_VER=1910

DaveBartolomeo created this revision. Previously, VC++ has always set _MSC_VER to a four-digit value with the two least significant digits set to zero. Visual Studio 2017, however, sets _MSC_VER=1910, and we expect to update the least significant digit as we release major updates for VS 2017. T

[PATCH] D30518: Fix msc-version.c test to handle _MSC_VER=1910

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D30518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

Mehdi, again I invite you to discuss this on the cfe-dev thread rather than here. I have posted a reply there to bump it up, and any comments you have will be more visible and better serve the community over there. Thanks, --paulr From: mehdi.am...@apple.com [mailto:mehdi.am...@apple.com] Sent:

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai added a comment. Hi Anna, Thanks for your review! > The information generated by this checker is used for array bounds checking. > For example, see https://reviews.llvm.org/D24307 I will read carefully about that ;-) > This patch looks good. Do you have commit access or should I com

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 90264. smeenai added a comment. Changing more instances to new macro, per IRC discussion with Eric https://reviews.llvm.org/D29157 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/locale include/string Index: include/string

[libcxx] r296724 - Revert "Fix Apple-specific XFAIL directive in libc++ test"

Author: mehdi_amini Date: Wed Mar 1 19:57:40 2017 New Revision: 296724 URL: http://llvm.org/viewvc/llvm-project?rev=296724&view=rev Log: Revert "Fix Apple-specific XFAIL directive in libc++ test" This reverts commit r296712. It broke our bot. It turns out that the test is passing with c++11 and

[libcxx] r296725 - Recommit r296712: "Fix Apple-specific XFAIL directive in libc++ test"

Author: mehdi_amini Date: Wed Mar 1 20:01:11 2017 New Revision: 296725 URL: http://llvm.org/viewvc/llvm-project?rev=296725&view=rev Log: Recommit r296712: "Fix Apple-specific XFAIL directive in libc++ test" The test is passing with c++11 and c++14 but not c++1z on this particular version of the

[libcxx] r296727 - Remove more usages of REQUIRES-ANY in the test-suite

Author: ericwf Date: Wed Mar 1 20:04:49 2017 New Revision: 296727 URL: http://llvm.org/viewvc/llvm-project?rev=296727&view=rev Log: Remove more usages of REQUIRES-ANY in the test-suite Modified: libcxx/trunk/test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.cons/assignment.pass.cpp libcxx/

[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

rjmccall added a comment. Thanks, LGTM. Repository: rL LLVM https://reviews.llvm.org/D30345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30523: [libc++] Mark some std::num_get method templates inline

smeenai created this revision. https://reviews.llvm.org/D29157 will make explicit template instantiations expand to default visibility, at which point these method templates will need to be explicitly marked hidden visibility to avoid leaking into other DSOs. Unfortunately, because of clang PR321

[libcxx] r296729 - [libc++] Mark some std::num_get method templates inline

Author: smeenai Date: Wed Mar 1 20:51:27 2017 New Revision: 296729 URL: http://llvm.org/viewvc/llvm-project?rev=296729&view=rev Log: [libc++] Mark some std::num_get method templates inline D29157 will make explicit template instantiations expand to default visibility, at which point these method

[PATCH] D30523: [libc++] Mark some std::num_get method templates inline

This revision was automatically updated to reflect the committed changes. Closed by commit rL296729: [libc++] Mark some std::num_get method templates inline (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D30523?vs=90270&id=90271#toc Repository: rL LLVM https://revi

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 90272. smeenai added a comment. Including inline in macro to work around PR32114 https://reviews.llvm.org/D29157 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/locale include/string Index: include/string ==

[libcxx] r296731 - [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

Author: smeenai Date: Wed Mar 1 21:02:50 2017 New Revision: 296731 URL: http://llvm.org/viewvc/llvm-project?rev=296731&view=rev Log: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members When building libc++ with hidden visibility, we want explicit template instantiations to export membe

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

This revision was automatically updated to reflect the committed changes. Closed by commit rL296731: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D29157?vs=90272&id=90274#toc Repository: rL LLVM https:

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai updated this revision to Diff 90275. smeenai added a comment. Rebase https://reviews.llvm.org/D25208 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/__locale include/__mutex_base include/condition_variable include/future include/mutex include/shared_

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

This revision was automatically updated to reflect the committed changes. Closed by commit rL296732: [libc++] Make _LIBCPP_TYPE_VIS export members (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D25208?vs=90275&id=90276#toc Repository: rL LLVM https://reviews.llvm.o

[libcxx] r296732 - [libc++] Make _LIBCPP_TYPE_VIS export members

Author: smeenai Date: Wed Mar 1 21:22:18 2017 New Revision: 296732 URL: http://llvm.org/viewvc/llvm-project?rev=296732&view=rev Log: [libc++] Make _LIBCPP_TYPE_VIS export members Summary: Most classes annotated with _LIBCPP_TYPE_VIS need to have at least some of their members exported, otherwise

[PATCH] D30514: [libc++abi] Update new/delete definitions to match libc++

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. (It seems that having libc++ and libc++abi in the same repo would help sharing code like this) https://reviews.llvm.org/D30514

[PATCH] D30516: [libc++] Add option to disable new/delete overloads when libc++abi provides them.

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D30516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D30517: [libc++abi] Add option to enable definitions for the new/delete overloads.

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. Comment at: CMakeLists.txt:416 +set(LIBCXXABI_HAS_UNDEFINED_SYMBOLS ((NOT LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS) +OR (LIBCXXABI_BUILD_EXTERNAL_THREAD_L

[PATCH] D30214: [Driver] Search for libc++ headers in ResourceDir

Hahnfeld added a comment. In https://reviews.llvm.org/D30214#690010, @jroelofs wrote: > libc++ headers should not be installed in the resource dir. They are currently not by default. But with https://reviews.llvm.org/D30015 for runtime libraries, this may become a place for headers packaged wi

<    1   2