@Hans Where are we in the release process? I would like to merge this into
4.0.
Although it's not a regression, it is a significant bug. This patch fixes
the bug by
forwarding to a compiler builtin, which is strictly better than what we
have. I'm
confident this patch is safe.
/Eric
On Tue, Feb 2
danielmarjamaki created this revision.
This is a work in progress patch. I try to detect such error:
void foo(int X) {
int Buf[X];
Buf[X] = 0;
}
The patch successfully detects this bug. However it writes FP when you try to
take the address.
I would like to know if you think my
danielmarjamaki added a comment.
I am running this checker right now on various projects. Here are currently
seen results.. https://drive.google.com/open?id=0BykPmWrCOxt2STZMOXZ5OGlwM3c
Feel free to look at it and see if there are FPs or TPs.
https://reviews.llvm.org/D30157
ioeric created this revision.
Previously, the insertion points would conflict with the old namespace
deletion.
https://reviews.llvm.org/D30490
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceT
hokein added inline comments.
Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:354
"namespace nb {\n"
+ "\n"
"class FWD;\n"
I'd create a new test for the fix instead of modifying the c
ioeric updated this revision to Diff 90135.
ioeric added a comment.
- Create a new test case. And slight refactor.
https://reviews.llvm.org/D30490
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamesp
Author: alexfh
Date: Wed Mar 1 04:16:36 2017
New Revision: 296598
URL: http://llvm.org/viewvc/llvm-project?rev=296598&view=rev
Log:
[clang-tidy] Fix handling of methods with try-statement as a body in
modernize-use-override
Summary:
Fix generated by modernize-use-override caused syntax error wh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296598: [clang-tidy] Fix handling of methods with
try-statement as a body in modernize… (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D30002?vs=88582&id=90136#toc
Repository:
Author: alexfh
Date: Wed Mar 1 04:17:32 2017
New Revision: 296599
URL: http://llvm.org/viewvc/llvm-project?rev=296599&view=rev
Log:
[clang-tidy] Add parametercount for readibility-function-size
Summary:
Add an option to function-size to warn about high parameter counts.
This might be relevant f
alexfh added a comment.
This patch is superseded by https://reviews.llvm.org/D26137.
https://reviews.llvm.org/D16183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: malcolm.parsons
Date: Wed Mar 1 04:23:38 2017
New Revision: 296602
URL: http://llvm.org/viewvc/llvm-project?rev=296602&view=rev
Log:
[Sema] Improve side effect checking for unused-lambda-capture warning
Summary:
Don't warn about unused lambda captures that involve copying a
value of a ty
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296602: [Sema] Improve side effect checking for
unused-lambda-capture warning (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D30327?vs=89988&id=90139#toc
Repository:
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
I think, we decided to extend the AST instead of working around its
incompleteness.
https://reviews.llvm.org/D30034
___
cfe-commits ma
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D30490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296604: [change-namespace] get insertion points of forward
declarations correct. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D30490?vs=90135&id=90141#toc
Repository:
rL LL
Author: ioeric
Date: Wed Mar 1 04:29:39 2017
New Revision: 296604
URL: http://llvm.org/viewvc/llvm-project?rev=296604&view=rev
Log:
[change-namespace] get insertion points of forward declarations correct.
Summary:
Previously, the insertion points would conflict with the old namespace
deletion.
sepavloff added a comment.
Glad to know that someone is interested in this feature!
Below is actual proposal.
**Adding named configuration files to clang driver**
A configuration file is a collection of driver options, which are inserted into
command line before other options specified in the c
Author: djasper
Date: Wed Mar 1 04:47:52 2017
New Revision: 296605
URL: http://llvm.org/viewvc/llvm-project?rev=296605&view=rev
Log:
clang-format: Ignore contents of #ifdef SWIG .. #endif blocks.
Those blocks are used if C++ code is SWIG-wrapped (see swig.org) and
usually do not contain C++ code
djasper added inline comments.
Comment at: include/clang/Format/Format.h:354
+ /// fixes invalid existing ones.
+ bool FixNamespaceEndComments;
+
To be consistent with the clang-tidy check, just call this
"FixNamespaceComments".
After a change like this, you
Author: djasper
Date: Wed Mar 1 05:10:11 2017
New Revision: 296608
URL: http://llvm.org/viewvc/llvm-project?rev=296608&view=rev
Log:
Fix r296605 so that stuff in #ifndef SWIG blocks is still formatted.
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
cfe/trunk/unittests/Format/Form
madsravn updated this revision to Diff 90148.
madsravn added a comment.
Updated patch according to comments by Ballman.
https://reviews.llvm.org/D30158
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/ReplaceRandomShuffleCheck.cp
rs updated this revision to Diff 90150.
rs added a comment.
Thanks for reviewing. Before I commit could you tell me if I need to update any
build systems e.g. buildbots ?
https://reviews.llvm.org/D30459
Files:
CMakeLists.txt
include/__cxxabi_config.h
include/cxxabi.h
src/abort_message.
madsravn marked 9 inline comments as done.
madsravn added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77
+
+ auto Diag = [=]() {
+std::string Message = ReplaceMessage;
aaron.ballman wrote:
> Is there a reason this needs to
rmaprath added a comment.
In https://reviews.llvm.org/D30459#689461, @rs wrote:
> Thanks for reviewing. Before I commit could you tell me if I need to update
> any build systems e.g. buildbots ?
Those two options are not used by any of the current public builders, so I
think it's safe to comm
ioeric created this revision.
When changing namespaces, the tool adds leading "::" to references that need to
be fully-qualified, which would affect readability.
We avoid adding "::" when the symbol name does not conflict with the new
namespace name. For example, a symbol name "na::nb::X" conflic
Author: rsingh
Date: Wed Mar 1 05:42:01 2017
New Revision: 296612
URL: http://llvm.org/viewvc/llvm-project?rev=296612&view=rev
Log:
[libcxxabi] Clean up macro usage.
Convention in libcxxabi is to use !defined(FOO) not !FOO.
Differential Revision: https://reviews.llvm.org/D30459
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296612: [libcxxabi] Clean up macro usage. (authored by
rsingh).
Changed prior to commit:
https://reviews.llvm.org/D30459?vs=90150&id=90155#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30459
Fi
rs added a comment.
ok thanks.
https://reviews.llvm.org/D30459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Wed Mar 1 07:14:01 2017
New Revision: 296616
URL: http://llvm.org/viewvc/llvm-project?rev=296616&view=rev
Log:
Introducing clang::tooling::AtomicChange for refactoring tools.
Summary:
An AtomicChange is used to create and group a set of source edits, e.g.
replacements or hea
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296616: Introducing clang::tooling::AtomicChange for
refactoring tools. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D27054?vs=90018&id=90165#toc
Repository:
rL LLVM
https
Abpostelnicu updated this revision to Diff 90171.
Abpostelnicu added a comment.
Also added tests.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/
xazax.hun added a comment.
There is an alternative approach idea:
This is not found by ArrayBoundCheckerV2? If no, an alternative approach would
be to properly set the constraints on the extent of the VLA's memory region.
After that, maybe ArrayBoundCheckerV2 would work automatically on this ca
krasimir updated this revision to Diff 90172.
krasimir marked 2 inline comments as done.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D30405
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Index/CommentToXML
Author: krasimir
Date: Wed Mar 1 07:53:12 2017
New Revision: 296618
URL: http://llvm.org/viewvc/llvm-project?rev=296618&view=rev
Log:
[clangd] Add a toy VS Code integration for development purposes
Summary: This patch adds bare-bone VS Code integration for development purposes
of clangd.
Revie
malaperle-ericsson added a comment.
To be honest, I don't think this needs to be merged but it makes sense to put
it somewhere people can try it.
Repository:
rL LLVM
https://reviews.llvm.org/D30476
___
cfe-commits mailing list
cfe-commits@lists.
bkramer created this revision.
This uses CodeActions to show 'apply fix' actions when code actions are
requested for a location. The actions themselves make use of a
clangd.applyFix command which has to be implemented on the editor side. I
included an implementation for vscode.
This also adds a -
Abpostelnicu updated this revision to Diff 90176.
Abpostelnicu added a comment.
added patch against the updated repo.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Form
Author: alexfh
Date: Wed Mar 1 08:41:11 2017
New Revision: 296627
URL: http://llvm.org/viewvc/llvm-project?rev=296627&view=rev
Log:
[clang-tidy] Attempt to fix the test where exceptions are disabled by default.
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-override.cpp
Mod
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D30405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
sylvestre.ledru added inline comments.
Comment at: docs/ClangFormatStyleOptions.rst:430
+ If ``true``, in the class inheritance expression clang-format will
+ break before operands ``:`` and ``,`` only if there is multiple
+ inheritance.
s/is/are/
=
NoQ created this revision.
In the following code involving GNU statement-expression extension:
struct S {
~S();
};
void foo() {
const S &x = ({ return; S(); });
}
function `foo()` returns before reference `x` is initialized. We shouldn't call
the destructor for the temporary
ddcc added a comment.
With the first method, I'm not sure how to refer to the `AnalyzerTest` class
defined in `lit.cfg` from `lit.local.cfg`. It doesn't seem to be in scope, so
unless I store an instantiation in the `config` object, I don't think it's
accessible.
Repository:
rL LLVM
https:
krasimir added inline comments.
Comment at: clangd/ASTManager.cpp:105
+ std::string Diagnostics;
+ decltype(this->FixIts) LocalFixIts; // Temporary storage
+ for (ASTUnit::stored_diag_iterator D = Unit->stored_diag_begin(),
Why not typedef the type of the FixI
Author: krasimir
Date: Wed Mar 1 09:35:39 2017
New Revision: 296632
URL: http://llvm.org/viewvc/llvm-project?rev=296632&view=rev
Log:
[clang-format] Add a new flag FixNamespaceComments to FormatStyle
Summary:
This patch enables namespace end comments under a new flag FixNamespaceComments,
which
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296632: [clang-format] Add a new flag FixNamespaceComments
to FormatStyle (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D30405?vs=90172&id=90179#toc
Repository:
rL LLVM
h
djasper added a comment.
Could you please upload a diff with the entire file as context? That makes
reviewing this easier.
Comment at: docs/ClangFormatStyleOptions.rst:428
+**BreakBeforeInhertianceDelimiter** (``boolt``)
+ If ``true``, in the class inheritance expression cl
sylvestre.ledru added a comment.
Manuel, is that ok with you? thanks (I will rename the file)
https://reviews.llvm.org/D30111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer updated this revision to Diff 90181.
bkramer added a comment.
- Use typedef instead of decltype()
- Rename local variable not to shadow member.
- Give FixIts their own mutex
- Use const instead of let in typescript
https://reviews.llvm.org/D30498
Files:
clangd/ASTManager.cpp
clangd/
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks Great!
https://reviews.llvm.org/D30498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
javed.absar added a comment.
Hi Nico:
This is for the case when using '#pragma bss_seg..' feature outside of msvc
context. That's the reason for the flag.
One could use attribute, but as attribute is attached to individual
declaration, while pragma applies to whole file (unless superseded by an
Author: d0k
Date: Wed Mar 1 10:16:29 2017
New Revision: 296636
URL: http://llvm.org/viewvc/llvm-project?rev=296636&view=rev
Log:
[clangd] Add support for FixIts.
Summary:
This uses CodeActions to show 'apply fix' actions when code actions are
requested for a location. The actions themselves make
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296636: [clangd] Add support for FixIts. (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D30498?vs=90181&id=90187#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30498
Files:
Author: d0k
Date: Wed Mar 1 10:23:40 2017
New Revision: 296637
URL: http://llvm.org/viewvc/llvm-project?rev=296637&view=rev
Log:
[clangd] Unbreak the shared build.
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt
URL:
http://ll
thakis added a comment.
Adding incompatible extensions to MS extensions sounds like bad precedent to
me. I think it'd be good if a code owner could opine on this change before it
goes in.
https://reviews.llvm.org/D30326
___
cfe-commits mailing lis
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Seems like a safe quick fix for the crash. Looks good to me!
https://reviews.llvm.org/D30499
___
cfe-commits mailing list
cfe-commits@lists
Author: krasimir
Date: Wed Mar 1 10:38:08 2017
New Revision: 296638
URL: http://llvm.org/viewvc/llvm-project?rev=296638&view=rev
Log:
[clang-format] Don't add namespace end comments for unbalanced right braces
after namespace end
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
cf
We're at the "should have tagged 'final' days ago" stage :-)
Since it's not a regression, I would prefer not to merge it unless you
feel super strongly about it.
Sounds like a good candidate for 4.0.1 (tracking bug is PR32061).
Thanks,
Hans
On Wed, Mar 1, 2017 at 1:36 AM, Eric Fiselier wrote:
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman updated this revision to Diff 90197.
arphaman marked 4 inline comments as done.
arphaman added a comment.
Addressed John's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D30345
Files:
lib/CodeGen/CGBlocks.cpp
Index: lib/CodeGen/CGBlocks.cpp
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296646: [analyzer] pr32088: Don't destroy the temporary if
its initializer causes… (authored by dcoughlin).
Changed prior to commit:
https://reviews.llvm.org/D30499?vs=90178&id=90201#toc
Repository:
Author: dcoughlin
Date: Wed Mar 1 11:48:39 2017
New Revision: 296646
URL: http://llvm.org/viewvc/llvm-project?rev=296646&view=rev
Log:
[analyzer] pr32088: Don't destroy the temporary if its initializer causes
return.
In the following code involving GNU statement-expression extension:
struct S
Author: lcharles
Date: Wed Mar 1 11:55:03 2017
New Revision: 296648
URL: http://llvm.org/viewvc/llvm-project?rev=296648&view=rev
Log:
[Test] NFC: Fixed typo in comments
Changed "declerations" to "declarations"
Modified:
cfe/trunk/test/Modules/Inputs/merge-using-decls/b.h
cfe/trunk/test/
arphaman added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3830-3837
+ unsigned NumArgs;
+ // Some Clang-scoped attributes have some special parsing behavior.
+ if (ScopeName && ScopeName->getName() == "clang")
+NumArgs =
+ParseClangAttributeArgs(AttrNa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296649: Introduce an 'external_source_symbol' attribute that
describes the origin (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D29819?vs=90042&id=90205#toc
Repository:
rL
Author: arphaman
Date: Wed Mar 1 12:06:25 2017
New Revision: 296649
URL: http://llvm.org/viewvc/llvm-project?rev=296649&view=rev
Log:
Introduce an 'external_source_symbol' attribute that describes the origin
and the nature of a declaration
This commit adds an external_source_symbol attribute to
I’m not sure I find this nice to see this upstream.
I not fond in general of this kind of difference in behavior. I don’t think it
is good for clang to have different default for this kind of settings depending
on the platform. It does not provide a very good user experience from a
cross-platfo
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77
+
+ auto Diag = [=]() {
+std::string Message = ReplaceMessage;
madsravn wrote:
> aaron.ballman wrote:
> > Is there a reason this needs to capture everythin
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D29750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
madsravn marked an inline comment as done.
madsravn added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77
+
+ auto Diag = [=]() {
+std::string Message = ReplaceMessage;
aaron.ballman wrote:
> madsravn wrote:
> > aaron.ballm
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77
+
+ auto Diag = [=]() {
+std::string Message = ReplaceMessage;
madsravn wrote:
> aaron.ballman wrote:
> > madsravn wrote:
> > > aaron.ballman wrote:
> > >
Author: bruno
Date: Wed Mar 1 13:18:42 2017
New Revision: 296656
URL: http://llvm.org/viewvc/llvm-project?rev=296656&view=rev
Log:
[PCH] Avoid VarDecl emission attempt if no owning module avaiable
This is a stopgap fix for PR31863, a regression introduced in r276159.
Consider this snippet:
str
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296656: [PCH] Avoid VarDecl emission attempt if no owning
module avaiable (authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D29753?vs=87774&id=90212#toc
Repository:
rL LLVM
http
Author: djasper
Date: Wed Mar 1 13:26:12 2017
New Revision: 296659
URL: http://llvm.org/viewvc/llvm-project?rev=296659&view=rev
Log:
clang-format: [JS/TS] Properly understand cast expressions.
Many things were wrong:
- We didn't always allow wrapping after "as", which can be necessary.
- We used
hiraditya updated this revision to Diff 90214.
hiraditya added a comment.
Guarded the new implementation with _LIBCPP_ABI_OPTIMIZED_LOCALE macro to avoid
ABI incompatibilities.
https://reviews.llvm.org/D30268
Files:
libcxx/include/__config
libcxx/include/locale
Index: libcxx/include/local
madsravn added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77
+
+ auto Diag = [=]() {
+std::string Message = ReplaceMessage;
aaron.ballman wrote:
> madsravn wrote:
> > aaron.ballman wrote:
> > > madsravn wrote:
> > > > aar
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77
+
+ auto Diag = [=]() {
+std::string Message = ReplaceMessage;
madsravn wrote:
> aaron.ballman wrote:
> > madsravn wrote:
> > > aaron.ballman wrote:
> > >
4.0.1 it is. Thanks Hans!
/Eric
On Wed, Mar 1, 2017 at 10:08 AM, Hans Wennborg wrote:
> We're at the "should have tagged 'final' days ago" stage :-)
>
> Since it's not a regression, I would prefer not to merge it unless you
> feel super strongly about it.
>
> Sounds like a good candidate for 4.
madsravn added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77
+
+ auto Diag = [=]() {
+std::string Message = ReplaceMessage;
aaron.ballman wrote:
> madsravn wrote:
> > aaron.ballman wrote:
> > > madsravn wrote:
> > > > aar
Author: djasper
Date: Wed Mar 1 13:47:28 2017
New Revision: 296664
URL: http://llvm.org/viewvc/llvm-project?rev=296664&view=rev
Log:
clang-format: [JS] Properly format object literals with shorthands.
Before:
return {
a,
b: 'b', c,
};
After:
return {
a,
b: 'b',
c,
};
aaron.ballman added a comment.
Out of curiosity, have you run this over libc++ or libstdc++ test suites
involving `std::random_shuffle`? If so, were the results acceptable?
I think this generally LGTM (aside from the minor nit about naming), but I'd
like to hear from @mclow.lists where this mee
Probably better to debate this on the cfe-dev thread "Setting default dialect
to C++11" than here.
That said, it's far from the only target-dependent setting in the driver.
There are things ranging from the default DWARF version to whether exceptions
are on by default to whether Microsoft exten
zaks.anna added a comment.
No multi-file support is a long outstanding limitation of scan-build html
output. Great to see the patch!! Thank you for working on it!
> It's not as immediately clear this is a multi-file output.
In addition to Artem's suggestions, you might want to insert multiple
rnk added a comment.
This functionality doesn't feel worth a driver flag. It customizes a very small
aspect of a Microsoft extension that was only implemented for compatibility. It
also reimplements the logic that LLVM uses in the backend to put global
variables in .bss or .data. Can you elabor
zaks.anna added a comment.
Gábor's suggestion sounds good to me. I think ArrayBoundCheckerV2 checker has a
higher chance to be productized / moved out of alpha in the future.
Should we just remove ArrayBoundChecker.cpp or is there a value in keeping it
around?
Repository:
rL LLVM
https://r
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:211
// Generate a report for this bug.
- StringRef Desc =
- describeUninitializedArgumentInCall(Call, IsFirstArgument);
+ std::string Desc =
+ des
zaks.anna added inline comments.
Comment at: test/Analysis/valist-uninitialized-no-undef.c:25
+ va_list va;
+ vprintf(isstring ? "%s" : "%d", va); //expected-warning{{Function 'vprintf'
is called with an uninitialized va_list argument}} expected-note{{Function
'vprintf' is ca
madsravn updated this revision to Diff 90223.
madsravn added a comment.
Last small changes based on comments.
https://reviews.llvm.org/D30158
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp
clang-
madsravn added a comment.
In https://reviews.llvm.org/D30158#689904, @aaron.ballman wrote:
> Out of curiosity, have you run this over libc++ or libstdc++ test suites
> involving `std::random_shuffle`? If so, were the results acceptable?
I haven't. Good idea. I will get onto that. I don't have
Hahnfeld added a comment.
Ping
https://reviews.llvm.org/D30087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
Ping
https://reviews.llvm.org/D30214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
> I am not clear why need to calculate the precise allocated size?
The information generated by this checker is used for array bounds checking.
For example, see https://reviews.llvm.org/
Author: ericwf
Date: Wed Mar 1 15:53:30 2017
New Revision: 296685
URL: http://llvm.org/viewvc/llvm-project?rev=296685&view=rev
Log:
Generate the test configuration even when LIBCXX_INCLUDE_TESTS=OFF.
This patch changes the CMake configuration so that it always
generates the test/lit.site.cfg fil
jroelofs added a comment.
libc++ headers should not be installed in the resource dir.
https://reviews.llvm.org/D30214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
madsravn added a comment.
Looks good for the two tests the are for `random_shuffle` in llvm libc++.
https://reviews.llvm.org/D30158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
In https://reviews.llvm.org/D30158#690032, @madsravn wrote:
> Looks good for the two tests the are for `random_shuffle` in llvm libc++.
There were a lot more some time ago, before @mclow.lists performed this
transformation on libc++'s testsuite. You might want to try
mati865 added a comment.
Ping.
https://reviews.llvm.org/D29464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 90243.
yaxunl edited the summary of this revision.
https://reviews.llvm.org/D27627
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/TargetInfo.h
lib/AST/ASTContext.cpp
lib/Basic/TargetInfo.cpp
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cp
On Wed, Mar 1, 2017 at 10:35 AM, Mehdi Amini wrote:
> I’m not sure I find this nice to see this upstream.
>
> I not fond in general of this kind of difference in behavior. I don’t
> think it is good for clang to have different default for this kind of
> settings depending on the platform. It does
Author: mehdi_amini
Date: Wed Mar 1 17:14:34 2017
New Revision: 296704
URL: http://llvm.org/viewvc/llvm-project?rev=296704&view=rev
Log:
Fix Apple-specific XFAIL directive in libc++ test
These tests are failing in XCode 8.0, 8.1, and 8.2, but not in Xcode
8.3. Annoyingly the version numbering fo
hfinkel added inline comments.
Comment at: lib/Driver/Tools.cpp:10334
- if (Args.hasFlag(options::OPT_fopenmp, options::OPT_fopenmp_EQ,
- options::OPT_fno_openmp, false)) {
+ // FIXME: Exclude this for platforms with libgomp that don't require
+
1 - 100 of 128 matches
Mail list logo
