r296213 - [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

2017-02-24 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Fri Feb 24 18:43:36 2017 New Revision: 296213 URL: http://llvm.org/viewvc/llvm-project?rev=296213&view=rev Log: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193) C requires the operands of arithmetic expressions to be promoted if their types are small

r296214 - [ubsan] Detect signed overflow UB in remainder operations

2017-02-24 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Fri Feb 24 18:43:39 2017 New Revision: 296214 URL: http://llvm.org/viewvc/llvm-project?rev=296214&view=rev Log: [ubsan] Detect signed overflow UB in remainder operations Teach ubsan to diagnose remainder operations which have undefined behavior due to signed overflow (e.g IN

[PATCH] D29437: [ubsan] Detect signed overflow UB in remainder operations

2017-02-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL296214: [ubsan] Detect signed overflow UB in remainder operations (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D29437?vs=89734&id=89753#toc Repository: rL LLVM https://re

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

2017-02-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL296213: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D29369?vs=89733&id=89752#toc Repository: rL

r296216 - Revert r296209, still one more test to go.

2017-02-24 Thread Paul Robinson via cfe-commits
Author: probinson Date: Fri Feb 24 18:50:34 2017 New Revision: 296216 URL: http://llvm.org/viewvc/llvm-project?rev=296216&view=rev Log: Revert r296209, still one more test to go. Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp U

RE: r296171 - Try to unbreak tests after r296166

2017-02-24 Thread Yung, Douglas via cfe-commits
Hi Nico, The test you added is causing a failure on the PS4 Windows bot. The root of the cause is that the Windows version of rm does not accept wildcards unfortunately. To fix make it work on Windows, you likely need to specify exactly what files/directories you want to delete without using a

r296221 - [ODRHash] Move inherited visitor call to end of function.

2017-02-24 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Fri Feb 24 19:29:34 2017 New Revision: 296221 URL: http://llvm.org/viewvc/llvm-project?rev=296221&view=rev Log: [ODRHash] Move inherited visitor call to end of function. Modified: cfe/trunk/lib/AST/ODRHash.cpp Modified: cfe/trunk/lib/AST/ODRHash.cpp URL: http://llvm.org

r296231 - [profiling] Fix profile counter increment when emitting selects (PR32019)

2017-02-24 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Fri Feb 24 20:30:03 2017 New Revision: 296231 URL: http://llvm.org/viewvc/llvm-project?rev=296231&view=rev Log: [profiling] Fix profile counter increment when emitting selects (PR32019) Clang has logic to lower certain conditional expressions directly into llvm select instru

[libclc] r296233 - math: Implement sinh function

2017-02-24 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Feb 24 20:46:53 2017 New Revision: 296233 URL: http://llvm.org/viewvc/llvm-project?rev=296233&view=rev Log: math: Implement sinh function mostly copied form amd_builtins Added: libclc/trunk/generic/include/clc/math/sinh.h libclc/trunk/generic/include/clc/math/si

r296234 - Revert "[profiling] Fix profile counter increment when emitting selects (PR32019)"

2017-02-24 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Fri Feb 24 20:59:47 2017 New Revision: 296234 URL: http://llvm.org/viewvc/llvm-project?rev=296234&view=rev Log: Revert "[profiling] Fix profile counter increment when emitting selects (PR32019)" This reverts commit r296231. It causes an assertion failure on 32-bit machines

r296237 - Revert r296166, "clang-format: Don't leave behind temp files in -i mode on Windows, PR26125", and r296171.

2017-02-24 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Fri Feb 24 21:45:49 2017 New Revision: 296237 URL: http://llvm.org/viewvc/llvm-project?rev=296237&view=rev Log: Revert r296166, "clang-format: Don't leave behind temp files in -i mode on Windows, PR26125", and r296171. (MemoryBuffer)Code.reset() was too early. ==26912==

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-02-24 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added a comment. Sounds good, I will commit https://reviews.llvm.org/D26061 and split out the tests from this (https://reviews.llvm.org/D28952). https://reviews.llvm.org/D28952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

r296239 - AMDGPU: export s_waitcnt builtin

2017-02-24 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Feb 24 22:20:20 2017 New Revision: 296239 URL: http://llvm.org/viewvc/llvm-project?rev=296239&view=rev Log: AMDGPU: export s_waitcnt builtin Differential Revision: https://reviews.llvm.org/D30359 Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/tru

r296240 - AMDGPU: export l1 cache invalidation intrinsics

2017-02-24 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Feb 24 22:20:22 2017 New Revision: 296240 URL: http://llvm.org/viewvc/llvm-project?rev=296240&view=rev Log: AMDGPU: export l1 cache invalidation intrinsics Differential Revision: https://reviews.llvm.org/D30360 Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.

r296241 - AMDGPU: export s_sendmsg{halt} instrinsics

2017-02-24 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Feb 24 22:20:24 2017 New Revision: 296241 URL: http://llvm.org/viewvc/llvm-project?rev=296241&view=rev Log: AMDGPU: export s_sendmsg{halt} instrinsics Differential Revision: https://reviews.llvm.org/D30366 Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def

r296242 - [analyzer] Refactor and simplify SimpleConstraintManager

2017-02-24 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Fri Feb 24 22:51:31 2017 New Revision: 296242 URL: http://llvm.org/viewvc/llvm-project?rev=296242&view=rev Log: [analyzer] Refactor and simplify SimpleConstraintManager Summary: SimpleConstraintManager is difficult to use, and makes assumptions about capabilities of the constr

[PATCH] D26061: [analyzer] Refactor and simplify SimpleConstraintManager

2017-02-24 Thread Dominic Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL296242: [analyzer] Refactor and simplify SimpleConstraintManager (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26061?vs=89054&id=89773#toc Repository: rL LLVM https://review

[PATCH] D30341: [analyzer] clarify error messages about uninitialized function arguments

2017-02-24 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added a comment. I agree this can clarify the error message quite a bit! Comment at: lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:160 if (ParamDecl->getType()->isPointerType()) { -Message = "Function call argument is a pointer to uninitialized value";

[PATCH] D30289: [Analyzer] Add bug visitor for taint checker

2017-02-24 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Looks great! https://reviews.llvm.org/D30289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D29419: [Analyzer] Checker for mismatched iterators

2017-02-24 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added a comment. > So it would be a wast of resources to duplicate these data. So now I am > also working on the merged version. Would it make sense to just resume the review on the merged patch? https://reviews.llvm.org/D29419 ___ cfe

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

2017-02-24 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added a comment. > Firstly I uploaded Glib-MallocChecker-single-size-value.patch for code > review, if submitted to UPSTREAM, then upload another one, correct? Yes. By the way, you can model XXX_n variants similarly to how calloc is modeled (see CallocMem). Comment

[PATCH] D28278: [StaticAnalyzer] dont show wrong 'garbage value' warning when there is array index out of bounds

2017-02-24 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thank you! Repository: rL LLVM https://reviews.llvm.org/D28278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r296245 - Retry: [profiling] Fix profile counter increment when emitting selects (PR32019)

2017-02-24 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Sat Feb 25 00:35:45 2017 New Revision: 296245 URL: http://llvm.org/viewvc/llvm-project?rev=296245&view=rev Log: Retry: [profiling] Fix profile counter increment when emitting selects (PR32019) 2nd attempt: the first was in r296231, but it had a use after lifetime bug. Clang

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-02-24 Thread Dominic Chen via Phabricator via cfe-commits
ddcc updated this revision to Diff 89777. ddcc added a comment. Drop tests, move to https://reviews.llvm.org/D30373 https://reviews.llvm.org/D28952 Files: CMakeLists.txt cmake/modules/FindZ3.cmake include/clang/Config/config.h.cmake include/clang/StaticAnalyzer/Core/Analyses.def inclu

r296246 - Fix -Wparentheses warning

2017-02-24 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Sat Feb 25 00:47:00 2017 New Revision: 296246 URL: http://llvm.org/viewvc/llvm-project?rev=296246&view=rev Log: Fix -Wparentheses warning Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp URL: http://llvm.org/viewvc/llvm-

r296247 - Suppress uninteresting warnings in test/CoverageMapping, NFC.

2017-02-24 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Sat Feb 25 01:05:41 2017 New Revision: 296247 URL: http://llvm.org/viewvc/llvm-project?rev=296247&view=rev Log: Suppress uninteresting warnings in test/CoverageMapping, NFC. Modified: cfe/trunk/test/CoverageMapping/implicit-def-in-macro.m cfe/trunk/test/CoverageMappi

r296248 - Weaken test/Profile/c-ternary.c

2017-02-24 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Sat Feb 25 01:21:23 2017 New Revision: 296248 URL: http://llvm.org/viewvc/llvm-project?rev=296248&view=rev Log: Weaken test/Profile/c-ternary.c There is a bot which doesn't use '%1' as the IR name of the first argument to a function: http://lab.llvm.org:8011/builders/clang-

<    1   2