Author: rsmith
Date: Tue Feb 21 02:42:39 2017
New Revision: 295710
URL: http://llvm.org/viewvc/llvm-project?rev=295710&view=rev
Log:
Fix lookup through injected-class-names in implicit deduction guides in the
case where the class template has a parameter pack.
Checking of the template arguments e
rogfer01 updated this revision to Diff 89172.
rogfer01 marked 2 inline comments as done.
rogfer01 added a comment.
Updated patch. Use TargetInfo::getCharWidth and remove unnecessary else.
https://reviews.llvm.org/D30166
Files:
include/clang/AST/ASTContext.h
lib/AST/ASTContext.cpp
lib/AST/
bkramer created this revision.
Herald added a subscriber: JDevlieghere.
The check doesn't really know if the code it is warning about came before
or after the header guard, so phrase it more neutral instead of complaining
about code before the header guard. The location for the warning is still
no
Author: krasimir
Date: Tue Feb 21 04:54:50 2017
New Revision: 295714
URL: http://llvm.org/viewvc/llvm-project?rev=295714&view=rev
Log:
[clang-format] Remove unused member variables from BreakableToken
Modified:
cfe/trunk/lib/Format/BreakableToken.cpp
cfe/trunk/lib/Format/BreakableToken.h
danielmarjamaki created this revision.
Diagnose array index out of bounds when there is overloaded C++ operators also.
Repository:
rL LLVM
https://reviews.llvm.org/D30192
Files:
lib/Sema/SemaChecking.cpp
test/SemaCXX/array-bounds.cpp
Index: test/SemaCXX/array-bounds.cpp
===
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you for the fix!
https://reviews.llvm.org/D30191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295715: [clang-tidy] Reword the "code outside header guard"
warning. (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D30191?vs=89182&id=89184#toc
Repository:
rL LLVM
https://rev
Author: d0k
Date: Tue Feb 21 05:25:45 2017
New Revision: 295715
URL: http://llvm.org/viewvc/llvm-project?rev=295715&view=rev
Log:
[clang-tidy] Reword the "code outside header guard" warning.
The check doesn't really know if the code it is warning about came before
or after the header guard, so ph
danielmarjamaki reopened this revision.
danielmarjamaki added a comment.
This revision is now accepted and ready to land.
I reverted the change because there were buildbot failures.
Repository:
rL LLVM
https://reviews.llvm.org/D28297
___
cfe-comm
xazax.hun updated this revision to Diff 89185.
xazax.hun added a comment.
- Address some review comments.
- Add some additional tests.
- Fixed some false positives (checking for symbolic values for va_copy and more
robust detection of which valist model is used by the platform)
- I have run the c
xazax.hun marked 3 inline comments as done.
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:178
+VaListModelledAsArray = Cast->getCastKind() == CK_ArrayToPointerDecay;
+ const MemRegion *Reg = SV.getAsRegion();
+ if (const auto *De
xazax.hun updated this revision to Diff 89187.
xazax.hun marked 3 inline comments as done.
xazax.hun added a comment.
- Fixed a comment.
https://reviews.llvm.org/D30157
Files:
lib/StaticAnalyzer/Checkers/ValistChecker.cpp
test/Analysis/valist-uninitialized-no-undef.c
test/Analysis/valist-
Friendly ping.
> On 14 feb 2017, at 12:05, Marcwell Helpdesk wrote:
>
> The intention of the patch is to extend the functionality of annotations
> while utilizing existing infrastructure in the AST and IR as much as
> possible. Annotations are indeed a general purpose solution, sufficient for
xazax.hun added inline comments.
Comment at: test/Analysis/valist-uninitialized-no-undef.c:19
+ // FIXME: There should be no warning for this.
+ (void)va_arg(*fst, int); // expected-warning{{va_arg() is called on an
uninitialized va_list}} expected-note{{va_arg() is called on
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1007
+
+defined_in=\ *string-literal*
+ The name of the source container in which the declaration was defined. The
arphaman wrote:
> aaron.ballman wrote:
> > Would this hold somethi
mclow.lists added a comment.
Absent I good motivation (i.e, a documented, significant performance change), I
don't think we want this - not because it's not a reasonable change (it is!),
but because it's an ABI break.
It's unfortunate the `__atoms` were not passed as const in the first place.
A
On Tue, Feb 14, 2017 at 6:05 AM, Marcwell Helpdesk wrote:
> The intention of the patch is to extend the functionality of annotations
> while utilizing existing infrastructure in the AST and IR as much as
> possible. Annotations are indeed a general purpose solution, sufficient for
> many use cases
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:308-311
+ // - An attribute requires delayed parsing (LateParsed is on)
+ // - An attribute has no GNU/CXX11 spelling
+ // - An attribute has no subject list
+ // - An attribute derives from a StmtAt
alexfh added a comment.
Ping ;)
Do you have time to finish this?
https://reviews.llvm.org/D21815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sepavloff updated this revision to Diff 89206.
sepavloff added a comment.
Implement `isDefined` through `isThisDeclarationADefinition`.
https://reviews.llvm.org/D30170
Files:
include/clang/AST/Decl.h
lib/AST/Decl.cpp
lib/Sema/SemaDecl.cpp
test/SemaCXX/cxx0x-cursory-default-delete.cpp
baloghadamsoftware updated this revision to Diff 89211.
baloghadamsoftware added a comment.
checkBind replaces checking of DeclStmt, CXXConstructExpr and assignment
operators. Incremention by 0 is not a bug anymore regardless the position of
the iterator.
https://reviews.llvm.org/D28771
Files
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:530
+ auto value = RVal;
+ if (auto loc = value.getAs()) {
+value = State->getRawSVal(*loc);
NoQ wrote:
> baloghadamsoftware wrote:
> > NoQ wrote:
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295728: [mips] Define macros related to -mabicalls in the
preprocessor (authored by sdardis).
Changed prior to commit:
https://reviews.llvm.org/D29032?vs=85392&id=89219#toc
Repository:
rL LLVM
https
Author: sdardis
Date: Tue Feb 21 10:01:00 2017
New Revision: 295728
URL: http://llvm.org/viewvc/llvm-project?rev=295728&view=rev
Log:
[mips] Define macros related to -mabicalls in the preprocessor
Summary:
Historically, NetBSD, FreeBSD and OpenBSD have defined the macro ABICALLS in
the preprocess
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D30135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
dexonsmith added a comment.
Ping.
https://reviews.llvm.org/D27689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
In https://reviews.llvm.org/D30174#681890, @ahatanak wrote:
> In https://reviews.llvm.org/D30174#681843, @arphaman wrote:
>
> > Yes, we do. Primarily for the following reason: even if some target may
> > return a struct in a register, another target isn't guaranteed to
sammccall created this revision.
Add usage count to find-all-symbols.
FindAllSymbols now finds (most!) main-file usages of the discovered symbols.
The per-TU map output has NumUses=0 or 1 (only one use per file is counted).
The reducer aggregates these to find the number of files that use a symbo
sammccall updated this revision to Diff 89236.
sammccall added a comment.
Remove obsolete comment.
https://reviews.llvm.org/D30210
Files:
include-fixer/IncludeFixer.cpp
include-fixer/SymbolIndexManager.cpp
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/
Hahnfeld created this revision.
https://reviews.llvm.org/D30214
Files:
lib/Driver/ToolChains.cpp
Index: lib/Driver/ToolChains.cpp
===
--- lib/Driver/ToolChains.cpp
+++ lib/Driver/ToolChains.cpp
@@ -4642,6 +4642,7 @@
std::string
I'm Ok with it if Alexey approves.
On Fri, Feb 17, 2017 at 10:52 AM, Hahnfeld, Jonas
wrote:
> Hi Hans, Alexey,
>
> can we merge this commit and r295474 for the 4.0 release or is it already
> too late for that? I will totally understand that and can apply these
> commits locally prior to installin
Merged to 4.0 in r295752 as requested in PR32013.
On Sun, Feb 19, 2017 at 11:33 AM, Brad Smith via cfe-commits
wrote:
> Author: brad
> Date: Sun Feb 19 13:33:26 2017
> New Revision: 295610
>
> URL: http://llvm.org/viewvc/llvm-project?rev=295610&view=rev
> Log:
> Link static PIE programs against r
twoh added a comment.
@eric_niebler Do you want any more experiments with this patch? I think Windows
machines not printing warnings/fixits for absolute path is a separate issue
with this.
https://reviews.llvm.org/D3
___
cfe-commits mailing li
danielcdh created this revision.
AddDiscriminator pass is only useful for sample pgo. This patch restricts
AddDiscriminator to -fdebug-info-for-profiling so that it does not introduce
unecessary debug size increases for non-sample-pgo builds.
https://reviews.llvm.org/D30220
Files:
lib/CodeG
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Did you want to enable all DebugInfoForProfiling features when there's a sample
profile specified? (not sure if all of the features are needed when stitching
things back up, or if some of
danielcdh updated this revision to Diff 89258.
danielcdh added a comment.
update
https://reviews.llvm.org/D30220
Files:
lib/CodeGen/BackendUtil.cpp
test/CodeGenObjC/arc-linetable-autorelease.m
Index: test/CodeGenObjC/arc-linetable-autorelease.m
danielcdh added a comment.
You are right, only discriminator is needed, the encoding and emission part
should be orthogonal. Patch updated.
https://reviews.llvm.org/D30220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Merged in r295760.
On Mon, Feb 20, 2017 at 3:12 PM, NAKAMURA Takumi via cfe-commits
wrote:
> Hans, could you pull this (and r294954) into release_40, please?
>
> This is a regression from previous releases that clang standalone build
> cannot be configured on msbuild.
>
>
> On Sun, Feb 19, 2017 a
Author: epilk
Date: Tue Feb 21 14:31:01 2017
New Revision: 295763
URL: http://llvm.org/viewvc/llvm-project?rev=295763&view=rev
Log:
Fix copy and paste mistake in header comment, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGObjC.cpp
Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp
URL:
http://llvm.org/v
Author: dehao
Date: Tue Feb 21 14:36:21 2017
New Revision: 295764
URL: http://llvm.org/viewvc/llvm-project?rev=295764&view=rev
Log:
Only enable AddDiscriminator pass when -fdebug-info-for-profiling is true
Summary: AddDiscriminator pass is only useful for sample pgo. This patch
restricts AddDisc
eric_niebler accepted this revision.
eric_niebler added a comment.
This revision is now accepted and ready to land.
Nope looks good.
https://reviews.llvm.org/D3
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Serialization/ASTBitCodes.h:258
+ /// A block containing unhashed contents. It currently holds Diagnostic
+ /// Options and Sign
Author: timshen
Date: Tue Feb 21 16:30:00 2017
New Revision: 295778
URL: http://llvm.org/viewvc/llvm-project?rev=295778&view=rev
Log:
[XRay] Merge xray clang flag tests, and add powerpc64le.
Summary: I'm not sure why they were in different files, but it's kind of harder
to maintain. I create thi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295778: [XRay] Merge xray clang flag tests, and add
powerpc64le. (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D30118?vs=88953&id=89284#toc
Repository:
rL LLVM
https://rev
Author: twoh
Date: Tue Feb 21 16:30:55 2017
New Revision: 295779
URL: http://llvm.org/viewvc/llvm-project?rev=295779&view=rev
Log:
Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters
Summary: This is a patch for PR31836. As the bug replaces the path separators
in the inclu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295779: Fix for pr31836 - pp_nonportable_path on absolute
paths: broken delimiters (authored by twoh).
Changed prior to commit:
https://reviews.llvm.org/D3?vs=88584&id=89285#toc
Repository:
rL LL
Author: jgravelle
Date: Tue Feb 21 16:37:27 2017
New Revision: 295781
URL: http://llvm.org/viewvc/llvm-project?rev=295781&view=rev
Log:
Declare lgamma library builtins as never being const
Summary:
POSIX requires lgamma writes to an external global variable, signgam.
This prevents annotating lgam
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295781: Declare lgamma library builtins as never being const
(authored by jgravelle).
Changed prior to commit:
https://reviews.llvm.org/D29778?vs=88629&id=89287#toc
Repository:
rL LLVM
https://revie
hans added a comment.
I'm not really qualified to review the implementation details, but this seems
good as far as I can tell. A few comments, mostly style related.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:39
private string style = "file";
+
Author: brad
Date: Tue Feb 21 17:13:09 2017
New Revision: 295786
URL: http://llvm.org/viewvc/llvm-project?rev=295786&view=rev
Log:
Hook up OpenBSD AArch64 support
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/Frontend/gnu-mcount.c
cfe/trunk/test/Preprocessor/init.c
Modifie
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
This seems to be stuck. Bruno, Richard, do you think there's a chance this can
be fixed for 4.0?
https://reviews.llvm.org/D29753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: rsmith
Date: Tue Feb 21 17:49:18 2017
New Revision: 295790
URL: http://llvm.org/viewvc/llvm-project?rev=295790&view=rev
Log:
Fix deduction of type of pack-expanded non-type template parameter.
We need to look through the PackExpansionType in the parameter type when
deducing, and we need t
Author: rsmith
Date: Tue Feb 21 17:58:29 2017
New Revision: 295791
URL: http://llvm.org/viewvc/llvm-project?rev=295791&view=rev
Log:
[c++1z] Mark constexpr lambdas as done on status page and start advertising
them via feature test macro __cpp_constexpr.
Thanks to Faisal for implementing this feat
Timeout -- committed r295791 on your behalf.
On 16 February 2017 at 05:04, Faisal Vali wrote:
> Of course Richard - I'll be happy to bump that value for C++1z
> hopefully later today.
> Thanks!
> Faisal Vali
>
>
>
> On Wed, Feb 15, 2017 at 10:30 PM, Richard Smith
> wrote:
> > On 15 February 201
arphaman updated this revision to Diff 89298.
arphaman marked 8 inline comments as done.
arphaman added a comment.
I've addressed Aaron's comments and made the language a string literal.
Repository:
rL LLVM
https://reviews.llvm.org/D29819
Files:
include/clang/Basic/Attr.td
include/clang/
arphaman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1005
+language=\ *identifier*
+ The source language in which this declaration was defined.
+
aaron.ballman wrote:
> This being an identifier makes me wonder about languages that aren't a
Author: rsmith
Date: Tue Feb 21 18:13:14 2017
New Revision: 295794
URL: http://llvm.org/viewvc/llvm-project?rev=295794&view=rev
Log:
Fix assertion failure when generating debug information for a variable
declaration declared using class template argument deduction.
Patch by Eric Fiselier (who is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295794: Fix assertion failure when generating debug
information for a variable (authored by rsmith).
Changed prior to commit:
https://reviews.llvm.org/D30082?vs=88943&id=89300#toc
Repository:
rL LLVM
Author: rtrieu
Date: Tue Feb 21 19:11:25 2017
New Revision: 295800
URL: http://llvm.org/viewvc/llvm-project?rev=295800&view=rev
Log:
Add more ODR checking.
Add the basics for the ODRHash class, which will only process Decl's from
a whitelist, which currently only has AccessSpecDecl. Different ac
Hello everyone,
Below are some buildbot numbers for the week of 02/05/2017 - 02/11/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Hello everyone,
Below are some buildbot numbers for the last week of 02/12/2017 -
02/18/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
erik.pilkington updated this revision to Diff 89305.
erik.pilkington added a comment.
This new patch addresses all of Alex's comments:
- Remove `ObjC` from function names
- Rename `_IsOSVersionAtLeast` -> `__isOSVersionAtLeast`
- Improve testcase
https://reviews.llvm.org/D27827
Files:
lib/Co
mcgrathr created this revision.
The runtime support is provided directly by the Fuchsia system C library.
Repository:
rL LLVM
https://reviews.llvm.org/D30238
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
Index: lib/Driver/ToolChains.h
mcgrathr added a comment.
This assumes https://reviews.llvm.org/D30237
Repository:
rL LLVM
https://reviews.llvm.org/D30238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: gbiv
Date: Tue Feb 21 20:35:51 2017
New Revision: 295805
URL: http://llvm.org/viewvc/llvm-project?rev=295805&view=rev
Log:
Call the correct @llvm.objectsize.
The following code would crash clang:
void foo(unsigned *const __attribute__((pass_object_size(0;
void bar(unsigned *i) { foo(
phosek added a comment.
Could you also please update test/Driver/fuchsia.c and add a case for
`-fsanitize=safe-stack`?
Repository:
rL LLVM
https://reviews.llvm.org/D30238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
pcc added subscribers: cfe-commits, pcc.
pcc added a comment.
Can you please add a ThinLTO test to lld before adding driver support?
https://reviews.llvm.org/D30239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
mehdi_amini added a comment.
In https://reviews.llvm.org/D30239#683116, @pcc wrote:
> Can you please add a ThinLTO test to lld before adding driver support?
Is clang-cl using lld as default? How is the switch done? Ideally we should
have a nice error message from the driver if -flto is used wi
arsenm created this revision.
Herald added subscribers: tpr, dstuttard, tony-tye, yaxunl, nhaehnle, wdng,
kzhuravl.
https://reviews.llvm.org/D30241
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/builtins-amdgcn-gfx9.cl
t
amaiorano added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:39
private string style = "file";
+private bool formatOnSaveEnabled = false;
+private string formatOnSaveFileExtensions =
hans wrote:
> P
amaiorano added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:276
+
+if (Vsix.IsDocumentDirty(document))
+{
hans wrote:
> Perhaps return early if `!Vsix.IsDocumentDirty(document)` instead?
Yes, will d
Author: hahnfeld
Date: Wed Feb 22 00:49:10 2017
New Revision: 295808
URL: http://llvm.org/viewvc/llvm-project?rev=295808&view=rev
Log:
[OpenMP] Generate better diagnostics for cancel and cancellation point
checkNestingOfRegions uses CancelRegion to determine whether cancel and
cancellation point
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295808: [OpenMP] Generate better diagnostics for cancel and
cancellation point (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D30135?vs=89106&id=89326#toc
Repository:
rL LL
ahatanak added a comment.
I'm not sure how common it is to pass a function that doesn't return an object
or void, I think it's OK to allow returning primitive types if you think being
too strict would catch too many false positives.
Comment at: lib/AST/DeclObjC.cpp:987
75 matches
Mail list logo
