Author: arphaman
Date: Wed Feb 15 17:24:15 2017
New Revision: 295256
URL: http://llvm.org/viewvc/llvm-project?rev=295256&view=rev
Log:
[Docs] Add missing space to an option doc
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/Options.td
URL:
http:
Author: hans
Date: Wed Feb 15 17:28:07 2017
New Revision: 295257
URL: http://llvm.org/viewvc/llvm-project?rev=295257&view=rev
Log:
[dllimport] Look through typedefs and arrays in HasNonDllImportDtor
The function is used to check whether a type is a class with
non-dllimport destructor. It needs to
Author: hans
Date: Wed Feb 15 17:28:10 2017
New Revision: 295258
URL: http://llvm.org/viewvc/llvm-project?rev=295258&view=rev
Log:
[dllimport] Check for dtor references in functions
Destructor references are not modelled explicitly in the AST. This adds
checks for destructor calls due to variable
vsk added a comment.
Ping.
https://reviews.llvm.org/D29723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma added a comment.
(Resigning as a reviewer; I don't know enough about standard conversion
sequences off the top of my head to review this properly.)
https://reviews.llvm.org/D29723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
efriedma added inline comments.
Comment at: docs/LanguageExtensions.rst:2344
+declaration failed to receive the attribute because of a compilation error. The
+attributes that aren't applied to any declaration are not verified
semantically.
+
I think "to each dec
arphaman added a comment.
I'm quite surprised by the fact that we have to change so many diagnostics in
tests. Do these diagnostics have the full qualifiers for errors that occur with
record types instead of typedefs?
https://reviews.llvm.org/D29944
_
smeenai updated this revision to Diff 88627.
smeenai edited the summary of this revision.
smeenai removed a reviewer: dexonsmith.
smeenai removed a subscriber: dexonsmith.
smeenai added a comment.
Guarding behind ABI macro
https://reviews.llvm.org/D27387
Files:
include/__config
include/func
arphaman added inline comments.
Comment at: docs/LanguageExtensions.rst:2349
+attribute is supported by the pragma by referring to the
+:doc:`individual documentation for that attribute `.
efriedma wrote:
> I'm wondering if we can tweak the approach so that we do
https://bugs.llvm.org/show_bug.cgi?id=31977 makes the good point that this
is warning on a certain idiomatic use of capture-by-value to extend the
lifetime of an RAII object; consider:
shared_ptr p = /*...*/;
int *q = &p->n;
return [=, p] { return *q++; }
Here, we'll warn that the capture o
Author: rsmith
Date: Wed Feb 15 18:36:47 2017
New Revision: 295264
URL: http://llvm.org/viewvc/llvm-project?rev=295264&view=rev
Log:
[c++1z] Diagnose non-deducible template parameters in deduction guide
templates, per [temp.param]p11.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKin
jgravelle-google updated this revision to Diff 88629.
jgravelle-google added a comment.
- Add comment to lgamma builtins
https://reviews.llvm.org/D29778
Files:
include/clang/Basic/Builtins.def
test/CodeGen/libcall-declarations.c
Index: test/CodeGen/libcall-declarations.c
=
On 15 February 2017 at 14:43, George Burgess IV via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: gbiv
> Date: Wed Feb 15 16:43:27 2017
> New Revision: 295252
>
> URL: http://llvm.org/viewvc/llvm-project?rev=295252&view=rev
> Log:
> [Modules] Consider enable_if attrs in isSameEntity.
jgravelle-google marked an inline comment as done.
jgravelle-google added a comment.
Thanks, added a comment
https://reviews.llvm.org/D29778
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
probinson added a comment.
In https://reviews.llvm.org/D28404#675687, @chandlerc wrote:
> In https://reviews.llvm.org/D28404#675616, @mehdi_amini wrote:
>
> > We're still waiting for @rsmith to comment whether it'd be better to `have
> > a LangOpts flag that basically means "pragma clang optimiz
Author: vedantk
Date: Wed Feb 15 19:20:00 2017
New Revision: 295266
URL: http://llvm.org/viewvc/llvm-project?rev=295266&view=rev
Log:
[Sema] Add lvalue-to-rvalue cast in direct-list-initialization of enum
After r264564, we allowed direct-list-initialization of an enum from an
integral value in C+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295266: [Sema] Add lvalue-to-rvalue cast in
direct-list-initialization of enum (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D29723?vs=87679&id=88632#toc
Repository:
rL LLV
I remember that we wanted to pretend that pass_object_size isn't a part of
the FunctionType during the review that added it, though. Do you think that
would be better than serializing parameters before we serialize template
info? AFAICT, we only do merging after we start reading the template info,
On 15 February 2017 at 17:32, George Burgess IV wrote:
> I remember that we wanted to pretend that pass_object_size isn't a part of
> the FunctionType during the review that added it, though.
>
I remember we wanted to not add extra fake "parameters" to the FunctionType
to model pass_object_size.
danalbert accepted this revision.
danalbert added a comment.
This revision is now accepted and ready to land.
LGTM, but should probably get signoff from someone else as well.
https://reviews.llvm.org/D30015
___
cfe-commits mailing list
cfe-commits@l
hfinkel added a comment.
I don't understand why it only supports some attributes. Is there some handling
that needs to take place (I don't see anything obvious in this patch)? If most
attributes will "just work", I'd much rather opt-out the few exceptions (which
we can then explicitly document)
Author: eugenis
Date: Wed Feb 15 19:35:23 2017
New Revision: 295267
URL: http://llvm.org/viewvc/llvm-project?rev=295267&view=rev
Log:
Add missing regexp quantifiers in a test.
Modified:
cfe/trunk/test/CodeGen/sanitize-init-order.cpp
Modified: cfe/trunk/test/CodeGen/sanitize-init-order.cpp
UR
rsmith added a comment.
In https://reviews.llvm.org/D28510#654821, @faisalv wrote:
> In https://reviews.llvm.org/D28510#653794, @rsmith wrote:
>
> > I don't think it's possible to check this in the way you're doing so here.
> > In general, there's no way to know whether a constant expression wil
On 15 February 2017 at 17:45, Hal Finkel via Phabricator via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> hfinkel added a comment.
>
> I don't understand why it only supports some attributes. Is there some
> handling that needs to take place (I don't see anything obvious in this
> patch)? If
dberris created this revision.
Herald added a subscriber: mehdi_amini.
We define the `__xray_customeevent` builtin that gets translated to
IR calls to the correct intrinsic. The default implementation of this is
a no-op function. The codegen side of this follows the following logic:
- When `-fxra
srhines added inline comments.
Comment at: include/clang/Driver/ToolChain.h:304
+ // Returns /lib//. When -fopenmp is specified,
+ // this directory is added to the linker search path if it exists
+ const std::string getOpenMPLibPath() const;
Add a period at
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D29778
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
herzka updated this revision to Diff 88650.
herzka added a comment.
Added test, used auto
https://reviews.llvm.org/D29967
Files:
lib/Sema/SemaExprObjC.cpp
test/SemaObjC/objc-class-property.m
Index: test/SemaObjC/objc-class-property.m
===
herzka updated this revision to Diff 88652.
herzka added a comment.
Rename selectors
https://reviews.llvm.org/D29967
Files:
lib/Sema/SemaExprObjC.cpp
test/SemaObjC/objc-class-property.m
Index: test/SemaObjC/objc-class-property.m
Author: rsmith
Date: Wed Feb 15 21:49:44 2017
New Revision: 295277
URL: http://llvm.org/viewvc/llvm-project?rev=295277&view=rev
Log:
Add missing "deduced A == A" check for function template partial ordering.
This appears to be the only template argument deduction context where we were
missing thi
Author: faisalv
Date: Wed Feb 15 22:12:21 2017
New Revision: 295279
URL: http://llvm.org/viewvc/llvm-project?rev=295279&view=rev
Log:
[cxx1z-constexpr-lambda] Implement captures - thus completing implementation of
constexpr lambdas.
Enable evaluation of captures within constexpr lambdas by using
On 15 February 2017 at 20:12, Faisal Vali via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: faisalv
> Date: Wed Feb 15 22:12:21 2017
> New Revision: 295279
>
> URL: http://llvm.org/viewvc/llvm-project?rev=295279&view=rev
> Log:
> [cxx1z-constexpr-lambda] Implement captures - thus comp
Author: rsmith
Date: Wed Feb 15 22:22:56 2017
New Revision: 295281
URL: http://llvm.org/viewvc/llvm-project?rev=295281&view=rev
Log:
Revert r295277 to fix buildbot.
Modified:
cfe/trunk/include/clang/Basic/Diagnostic.h
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Sema/SemaTemplate
Author: rtrieu
Date: Wed Feb 15 22:53:40 2017
New Revision: 295284
URL: http://llvm.org/viewvc/llvm-project?rev=295284&view=rev
Log:
Add better ODR checking for modules.
Recommit r293585 that was reverted in r293611 with new fixes. The previous
issue was determined to be an overly aggressive AST
Author: phosek
Date: Wed Feb 15 23:18:08 2017
New Revision: 295285
URL: http://llvm.org/viewvc/llvm-project?rev=295285&view=rev
Log:
[libunwind][CMake] Use libc++ headers when available
libunwind depends on C++ library headers. When building libunwind
as part of LLVM and libc++ is available, use
Author: rtrieu
Date: Wed Feb 15 23:48:25 2017
New Revision: 295286
URL: http://llvm.org/viewvc/llvm-project?rev=295286&view=rev
Log:
Loosen a Type check ODR checking to try to fix the build bot.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk/lib/Serialization/ASTRead
The assert below is throwing a -Wsign-compare warning because std::distance
returns a signed type.
+ const size_t NumFields =
+ std::distance(ClosureClass->field_begin(),
ClosureClass->field_end());
+
+ assert(NumFields ==
+std::distance(E->capture_init_begin(), E->capture_init_end()) &
Author: ctopper
Date: Thu Feb 16 00:32:07 2017
New Revision: 295291
URL: http://llvm.org/viewvc/llvm-project?rev=295291&view=rev
Log:
[AVX-512] Replace 512-bit masked packss/packus builtins and replace with new
unmasked builtins.
These new unmasked builtins will enable us to easily support optim
mgorny created this revision.
Herald added a subscriber: dberris.
Make the use of #pragma redefine_extname and appropriate renames of
builtins conditional to using clang. GCC used not to support it outside
Solaris and currently seems to be very restrictive on applying it.
In other words, it does n
Hahnfeld added a comment.
Why is this only for OpenMP? I imagine this should be done for **all** runtime
libraries
https://reviews.llvm.org/D30015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: rtrieu
Date: Thu Feb 16 01:09:18 2017
New Revision: 295293
URL: http://llvm.org/viewvc/llvm-project?rev=295293&view=rev
Log:
Revert r295284: Add better ODR checking for modules.
Fix modules build bot.
Removed:
cfe/trunk/include/clang/AST/ODRHash.h
cfe/trunk/lib/AST/ODRHash.cpp
pirama added a comment.
In https://reviews.llvm.org/D30015#678243, @Hahnfeld wrote:
> Why is this only for OpenMP? I imagine this should be done for **all**
> runtime libraries
The other runtime libraries have the arch included in the library's name and
the driver links the correct file. cbe
Hahnfeld added a subscriber: mgorny.
Hahnfeld added a comment.
Yes, that's the current state. We had some discussion on cfe-dev on that
matter: http://lists.llvm.org/pipermail/cfe-dev/2017-January/052512.html
Could you slightly adapt your patch so that other runtime libraries can follow
this id
twoh added a comment.
@eric_niebler I just tried it on Windows machine, and it just succeeded with no
warnings/fix-it. Is that expected?
https://reviews.llvm.org/D3
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
101 - 144 of 144 matches
Mail list logo
