vlad.tsyrklevich added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:442
+
+const RecordDecl *RD = RT->getDecl()->getDefinition();
+for (const auto *I : RD->fields()) {
a.sidorin wrote:
> vlad.tsyrklevich wrote:
> > a.si
Author: echristo
Date: Wed Feb 15 01:50:11 2017
New Revision: 295156
URL: http://llvm.org/viewvc/llvm-project?rev=295156&view=rev
Log:
Add a definition for __STRUCT_PARM_ALIGN__ for elfv2 and 64-bit darwin
platforms to match what other compilers produce.
Modified:
cfe/trunk/lib/Basic/Targets
On Wed, Feb 15, 2017, 00:01 Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Wed Feb 15 01:50:11 2017
> New Revision: 295156
>
> URL: http://llvm.org/viewvc/llvm-project?rev=295156&view=rev
> Log:
> Add a definition for __STRUCT_PARM_ALIGN__ for elfv
The PPC one should inherit from this. You're right I should have tested it
though. Mostly ppc Darwin isn't well supported.
On Wed, Feb 15, 2017, 12:06 AM Tim Shen wrote:
> On Wed, Feb 15, 2017, 00:01 Eric Christopher via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Author: echristo
> D
vlad.tsyrklevich updated this revision to Diff 88493.
vlad.tsyrklevich added a comment.
Remove an unnecessary call to `getBaseRegion()`, remove the logic to create a
new SymbolDerived as it's currently unused, and add a comment to reflect that
`getLCVSymbol()` is called in a PostStmt and a defau
vlad.tsyrklevich added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:502
+RegionBindingsRef B = getRegionBindings(S);
+const MemRegion *MR = L.getRegion()->getBaseRegion();
+if (Optional V = B.getDefaultBinding(MR))
vlad.tsyrkl
ABataev added a comment.
In https://reviews.llvm.org/D29910#676777, @arpith-jacob wrote:
> Hi Alexey,
>
> Thank you for reviewing this patch.
>
> > I don't like the idea of adding some kind of default scheduling, that is
> > not defined in standard in Sema
>
> Actually, "default scheduling" is d
Hi,
Saw now that it's already been fixed. Sorry for the spam :/
Regards,
Mikael
On 02/15/2017 07:39 AM, Mikael Holmén wrote:
Hi Aaron,
On 02/14/2017 11:47 PM, Aaron Ballman via cfe-commits wrote:
Author: aaronballman
Date: Tue Feb 14 16:47:20 2017
New Revision: 295114
URL: http://llvm.org/
mgorny abandoned this revision.
mgorny added a comment.
I've opened http://bugs.llvm.org/show_bug.cgi?id=31964 to track this further. I
don't really have time to look into it in more detail at the moment.
Repository:
rL LLVM
https://reviews.llvm.org/D28862
Author: slthakur
Date: Wed Feb 15 04:41:38 2017
New Revision: 295163
URL: http://llvm.org/viewvc/llvm-project?rev=295163&view=rev
Log:
[XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el
Summary: Adds xray instrument option for mips/mipsel/mips64/mips64el.
Reviewed by sdardis, dbe
danielmarjamaki added a comment.
I am not against that the error is shown as long as it's not misleading/wrong.
To avoid misleading, in my humble opinion the error message should say "array
index out of bounds".
Repository:
rL LLVM
https://reviews.llvm.org/D28278
danielmarjamaki added a comment.
In https://reviews.llvm.org/D28297#642523, @NoQ wrote:
> Looks good. I assume the crash is in `getTypeInfo()`; do you have any idea
> what are exact prerequisites for using this method? So that there were no
> more crashes here.
Yes. The crash happens during t
Author: sepavloff
Date: Wed Feb 15 05:34:11 2017
New Revision: 295167
URL: http://llvm.org/viewvc/llvm-project?rev=295167&view=rev
Log:
Removed stale comment. NFC.
The case of extern inline functions in GNU89 mode is now handled
in `canRedefineFunction`, which has appropriate comment.
Modified:
rmaprath added a comment.
I've raised PR31966 to poke this :)
https://reviews.llvm.org/D13289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun updated this revision to Diff 88506.
xazax.hun marked 3 inline comments as done.
xazax.hun retitled this revision from "[Clang-tidy] CERT-MSC53-CPP (checker for
std namespace modification)" to "[Clang-tidy] CERT-DCL58-CPP (checker for std
namespace modification)".
xazax.hun edited the s
sdardis added a comment.
@joerg ping?
https://reviews.llvm.org/D29032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sepavloff
Date: Wed Feb 15 06:30:35 2017
New Revision: 295172
URL: http://llvm.org/viewvc/llvm-project?rev=295172&view=rev
Log:
Use dedicated method instead of copying conditions. NFC.
Modified:
cfe/trunk/lib/AST/Decl.cpp
Modified: cfe/trunk/lib/AST/Decl.cpp
URL:
http://llvm.org/vie
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LGTM. Please wait for Aaron as well.
Repository:
rL LLVM
https://reviews.llvm.org/D28768
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
bkramer updated this revision to Diff 88515.
bkramer marked 16 inline comments as done.
bkramer added a comment.
- Address review comments.
https://reviews.llvm.org/D29886
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/CMakeLists.txt
clangd/ClangDMain.cpp
clangd/DocumentStore
bkramer added inline comments.
Comment at: clangd/ASTManager.cpp:21
+using namespace clang;
+using namespace clangd;
+
ioeric wrote:
> Any reason not to wrap code in namespaces instead?
I don't really have an opinion one way or the other, but this seems to be the
rogfer01 created this revision.
This patch fixes an assertion that is hit when a redeclaration with differing
types only differs in the unaligned type-qualifier.
https://reviews.llvm.org/D29986
Files:
lib/AST/ASTContext.cpp
test/Sema/unaligned-qualifier.c
Index: test/Sema/unaligned-quali
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:28
+ anyOf(hasName("std"), hasName("posix")),
+ has(decl(unless(cxxRecordDecl(isExplicitTemplateSpecialization())
+ .bind("nmspc"),
I t
Author: asiri
Date: Wed Feb 15 07:43:05 2017
New Revision: 295175
URL: http://llvm.org/viewvc/llvm-project?rev=295175&view=rev
Log:
Fix couple of test failures when using the LIBCXXABI_SILENT_TERMINATE mode.
When libcxxabi is built in LIBCXXABI_SILENT_TERMINATE mode, libcxx test suite
reports
tw
cierpuchaw added inline comments.
Comment at: clangd/DocumentStore.h:42
/// Delete a document from the store.
- void removeDocument(StringRef Uri) { Docs.erase(Uri); }
+ void removeDocument(StringRef Uri) { Docs.erase(Uri);
+for (const auto &Listener : Listeners)
---
Author: malcolm.parsons
Date: Wed Feb 15 08:01:41 2017
New Revision: 295176
URL: http://llvm.org/viewvc/llvm-project?rev=295176&view=rev
Log:
[clang-tidy] Don't warn about call to unresolved operator*
Summary:
The misc-unconventional-assign-operator check had a false positive
warning when the 'op
This revision was automatically updated to reflect the committed changes.
malcolm.parsons marked 4 inline comments as done.
Closed by commit rL295176: [clang-tidy] Don't warn about call to unresolved
operator* (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D293
aaron.ballman accepted this revision.
aaron.ballman added a comment.
There's one small wording nit with the diagnostic, but once that's resolved,
LGTM as well.
Comment at: clang-tidy/modernize/ReturnBracedInitListCheck.cpp:65
+
+ auto Diag = diag(Loc, "to avoid repeating the
rmaprath added a comment.
Ping?
https://reviews.llvm.org/D29757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
herzka updated this revision to Diff 88519.
herzka edited the summary of this revision.
herzka added a comment.
Added full context. Sorry about that! This is my first contribution, and I
don't know how I completely missed that line while going through the steps.
https://reviews.llvm.org/D29967
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295178: [clang-tidy] Ignore instantiated functions and
static data members of classes… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D29957?vs=88413&id=88520#toc
Repository:
Author: hokein
Date: Wed Feb 15 08:10:50 2017
New Revision: 295178
URL: http://llvm.org/viewvc/llvm-project?rev=295178&view=rev
Log:
[clang-tidy] Ignore instantiated functions and static data members of classes
in misc-definitions-in-headers.
Reviewers: alexfh
Reviewed By: alexfh
Subscribers:
joerg added a comment.
No need to preserve the BSD behavior for NetBSD.
https://reviews.llvm.org/D29032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
Ping?
https://reviews.llvm.org/D29818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer updated this revision to Diff 88522.
bkramer added a comment.
- Do not lock while running DocumentStore callbacks
- Replace fake queue with a real queue (but it still has at most one element.
https://reviews.llvm.org/D29886
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/C
klimek added inline comments.
Comment at: clangd/ASTManager.h:67
+ /// Setting Done to true will make the worker thread terminate.
+ std::atomic Done;
+};
bkramer wrote:
> klimek wrote:
> > arphaman wrote:
> > > It looks like `Done` is always accessed in a scop
bkramer updated this revision to Diff 88523.
bkramer added a comment.
- Inline the request struct again.
https://reviews.llvm.org/D29886
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/CMakeLists.txt
clangd/ClangDMain.cpp
clangd/DocumentStore.h
test/clangd/diagnostics.test
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: clangd/ASTManager.cpp:138-139
+ // Currently we discard all pending requests and just enqueue the latest one.
+ while (!RequestQueue.empty())
+RequestQue
dmitry updated this revision to Diff 88529.
dmitry added a comment.
Byval attribute was added for ndrange in enqueue kernel call.
https://reviews.llvm.org/D28058
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/AST/Type.h
include/clang/Serialization
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yep, seems that somebody has missed these issues :)
I guess there's no way to test the operator case, because nobody made a
CallDescription with an empty name for us (maybe we should even assert tha
Author: d0k
Date: Wed Feb 15 09:04:20 2017
New Revision: 295180
URL: http://llvm.org/viewvc/llvm-project?rev=295180&view=rev
Log:
[clangd] Wire up ASTUnit and publish diagnostics with it.
Summary:
This requires an accessible compilation database. The parsing is done
asynchronously on a separate t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295180: [clangd] Wire up ASTUnit and publish diagnostics
with it. (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D29886?vs=88523&id=88532#toc
Repository:
rL LLVM
https://review
Author: rksimon
Date: Wed Feb 15 09:12:06 2017
New Revision: 295183
URL: http://llvm.org/viewvc/llvm-project?rev=295183&view=rev
Log:
Fix spelling mistake - paramater -> parameter. NFCI.
Modified:
cfe/trunk/lib/AST/MicrosoftMangle.cpp
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/lib/Sem
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D28058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I sometimes wish ASTContext methods just didn't crash :)
Oh well, let's just see if more problems show up.
Comment at: lib/StaticAnalyzer/Checkers/CastToStructChecker.cpp:93
Author: d0k
Date: Wed Feb 15 09:19:13 2017
New Revision: 295184
URL: http://llvm.org/viewvc/llvm-project?rev=295184&view=rev
Log:
[clangd] Add missing include.
Modified:
clang-tools-extra/trunk/clangd/DocumentStore.h
Modified: clang-tools-extra/trunk/clangd/DocumentStore.h
URL:
http://llvm.
Author: xazax
Date: Wed Feb 15 09:35:56 2017
New Revision: 295186
URL: http://llvm.org/viewvc/llvm-project?rev=295186&view=rev
Log:
[analyzer] Proper caching in CallDescription objects.
During the review of D29567 it turned out the caching in CallDescription is not
implemented properly. In case
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295186: [analyzer] Proper caching in CallDescription
objects. (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D29884?vs=88166&id=88537#toc
Repository:
rL LLVM
https://reviews.
Author: d0k
Date: Wed Feb 15 09:56:14 2017
New Revision: 295187
URL: http://llvm.org/viewvc/llvm-project?rev=295187&view=rev
Log:
[clangd] Fix use after free.
Modified:
clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp
Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp
URL:
htt
xazax.hun updated this revision to Diff 88541.
xazax.hun added a comment.
- Do not warn for function specializations within the std namespace.
- Add a test case for swap.
https://reviews.llvm.org/D23421
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/ce
alexfh added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+<< FixItHint::CreateRemoval(NoExceptRan
xazax.hun added a comment.
In https://reviews.llvm.org/D29884#677387, @NoQ wrote:
> Yep, seems that somebody has missed these issues :)
>
> I guess there's no way to test the operator case, because nobody made a
> CallDescription with an empty name for us (maybe we should even assert that).
Th
NoQ added inline comments.
Comment at:
cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:73
+ : II(nullptr), IsLookupDone(false), FuncName(FuncName),
+RequiredArgs(RequiredArgs) {}
Maybe `assert(FuncName.size() > 0)` here?
Re
xazax.hun added inline comments.
Comment at:
cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:73
+ : II(nullptr), IsLookupDone(false), FuncName(FuncName),
+RequiredArgs(RequiredArgs) {}
NoQ wrote:
> Maybe `assert(FuncName.size
Author: akirtzidis
Date: Wed Feb 15 10:16:27 2017
New Revision: 295191
URL: http://llvm.org/viewvc/llvm-project?rev=295191&view=rev
Log:
[index] USR generation: use getTemplateArgs() instead of
getTemplateInstantiationArgs()
Otherwise we may end up creating a different USR for the definition of
NoQ added inline comments.
Comment at:
cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:73
+ : II(nullptr), IsLookupDone(false), FuncName(FuncName),
+RequiredArgs(RequiredArgs) {}
xazax.hun wrote:
> NoQ wrote:
> > Maybe `asser
Author: malcolm.parsons
Date: Wed Feb 15 10:32:55 2017
New Revision: 295192
URL: http://llvm.org/viewvc/llvm-project?rev=295192&view=rev
Log:
[clang-tidy] Don't delay parsing of templates in test for
misc-unconventional-assign-operator
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-
JDevlieghere updated this revision to Diff 88550.
JDevlieghere added a comment.
Fixed latest comment from @aaron.ballman before landing.
Repository:
rL LLVM
https://reviews.llvm.org/D28768
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tid
Author: d0k
Date: Wed Feb 15 10:34:58 2017
New Revision: 295193
URL: http://llvm.org/viewvc/llvm-project?rev=295193&view=rev
Log:
[clangd] Initialize the thread after the mutex.
Otherwise locking the mutex yields a racy assertion failure on picky
implementations.
Modified:
clang-tools-extra/
Author: d0k
Date: Wed Feb 15 10:44:11 2017
New Revision: 295194
URL: http://llvm.org/viewvc/llvm-project?rev=295194&view=rev
Log:
[clangd] Synchronize logs access.
I don't think that this is necessary for correctness, but makes tsan
much more useful.
Modified:
clang-tools-extra/trunk/clangd/
erichkeane added a comment.
Ah, I see! Sorry for missing that. I don't see a reason why we cannot support
that, but I wasn't really considering it. In general, this attribute is a
compiler hint for some C standard library stuff in glibc.
I've been playing with it a few hours now, and it seem
Author: d0k
Date: Wed Feb 15 10:58:44 2017
New Revision: 295196
URL: http://llvm.org/viewvc/llvm-project?rev=295196&view=rev
Log:
[clangd] Silence GCC warning about falling off a fully covered switch.
Modified:
clang-tools-extra/trunk/clangd/ASTManager.cpp
Modified: clang-tools-extra/trunk/c
Author: d0k
Date: Wed Feb 15 11:04:57 2017
New Revision: 295198
URL: http://llvm.org/viewvc/llvm-project?rev=295198&view=rev
Log:
[clangd] Fix another use after free that I missed because COW strings.
Modified:
clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp
Modified: clang-tools-extra/t
Author: jdevlieghere
Date: Wed Feb 15 11:06:06 2017
New Revision: 295199
URL: http://llvm.org/viewvc/llvm-project?rev=295199&view=rev
Log:
[clang-tidy] Add check 'modernize-return-braced-init-list'
Summary:
Replaces explicit calls to the constructor in a return with a braced
initializer list. Thi
sdardis added a comment.
Ok, I'll have `__mips_abicalls` unconditionally defined for everyone, The other
two BSD's will have the traditional macro defined as well.
https://reviews.llvm.org/D29032
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Author: phosek
Date: Wed Feb 15 11:15:41 2017
New Revision: 295202
URL: http://llvm.org/viewvc/llvm-project?rev=295202&view=rev
Log:
Revert "[libunwind][CMake] Use libc++ headers when available"
This causing build failure on sanitizer bots because of the unused
argument '-nostdinc++' during linki
Author: jdevlieghere
Date: Wed Feb 15 11:19:44 2017
New Revision: 295205
URL: http://llvm.org/viewvc/llvm-project?rev=295205&view=rev
Log:
Fixed indentation issue in release notes
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst
Author: jdevlieghere
Date: Wed Feb 15 11:37:58 2017
New Revision: 295207
URL: http://llvm.org/viewvc/llvm-project?rev=295207&view=rev
Log:
[clang-tidy] Fix test modernize-return-braced-init-list
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-return-braced-init-list.cpp
Modified
bkramer added inline comments.
Comment at: clangd/ProtocolHandlers.cpp:117
+ // starting from there.
+ StringRef Code = Store.getDocument(DOTFP->textDocument.uri);
+ size_t CursorPos = positionToOffset(Code, DOTFP->position);
This should be a std::string in tr
phosek updated this revision to Diff 88575.
Repository:
rL LLVM
https://reviews.llvm.org/D26654
Files:
cmake/caches/Fuchsia-stage2.cmake
cmake/caches/Fuchsia.cmake
Index: cmake/caches/Fuchsia.cmake
===
--- /dev/null
+++ cmake
Author: hans
Date: Wed Feb 15 12:40:52 2017
New Revision: 295214
URL: http://llvm.org/viewvc/llvm-project?rev=295214&view=rev
Log:
Merging r294431:
r294431 | mgorny | 2017-02-08 01:57:32 -0800 (Wed, 08 Feb 2017) | 7 lines
[t
Michal requested this to be merged in PR31965, it seems fine to me,
and Marshall OK'd it in an email to me. Merged in r295214.
On Wed, Feb 8, 2017 at 1:57 AM, Michal Gorny via cfe-commits
wrote:
> Author: mgorny
> Date: Wed Feb 8 03:57:32 2017
> New Revision: 294431
>
> URL: http://llvm.org/view
twoh created this revision.
This is a patch for PR31836. As the bug replaces the path separators in the
included file name with the characters following them, the test script makes
sure that there's no "Ccase-insensitive-include-pr31836.h" in the warning
message.
https://reviews.llvm.org/D300
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for working on this!
https://reviews.llvm.org/D23421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
eric_niebler added a subscriber: karies.
eric_niebler added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:1983
+ isLeadingSeparator = false;
+else
+ Path.append(Component);
What happens on Windows for an absolute path like "C:/he
idlecode created this revision.
idlecode added a project: clang-tools-extra.
Herald added a subscriber: JDevlieghere.
Fix generated by modernize-use-override caused syntax error when method
used try-statement as a body. `override` keyword was inserted after last
declaration token which happened to
efriedma added inline comments.
Comment at: include/clang/Basic/Builtins.def:1091
+LIBBUILTIN(lgammaf, "ff", "fn", "math.h", ALL_LANGUAGES)
+LIBBUILTIN(lgammal, "LdLd", "fn", "math.h", ALL_LANGUAGES)
Please add a comment explaining why this doesn't have an "e"
IIUC, this is a follow-up to r291955, which was merged to 4.0. Should
this one be merged also?
Cheers,
Hans
On Tue, Feb 14, 2017 at 8:18 PM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Tue Feb 14 22:18:23 2017
> New Revision: 295149
>
> URL: http://llvm.org/viewvc/llvm-project?
alekseyshl added a comment.
http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/2437 is
broken by this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D29886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
Hans,
Can this be merged to 4.0 too?
> On Feb 14, 2017, at 9:15 PM, Akira Hatanaka via cfe-commits
> wrote:
>
> Author: ahatanak
> Date: Tue Feb 14 23:15:28 2017
> New Revision: 295150
>
> URL: http://llvm.org/viewvc/llvm-project?rev=295150&view=rev
> Log:
> [Sema] Disallow returning a __bloc
twoh updated this revision to Diff 88584.
twoh added a comment.
Make it explicit that the test doesn't support windows. @eric_niebler, my
original intention was avoiding use of platform-dependent path separator, but
now made it explicit that the test is not for windows, it should be okay to use
+Richard for risk/reward analysis.
r274291 was also in 3.9, so this isn't strictly speaking a regression.
On Wed, Feb 15, 2017 at 11:43 AM, Akira Hatanaka wrote:
> Hans,
>
> Can this be merged to 4.0 too?
>
>> On Feb 14, 2017, at 9:15 PM, Akira Hatanaka via cfe-commits
>> wrote:
>>
>> Author:
Author: rsmith
Date: Wed Feb 15 13:57:10 2017
New Revision: 295224
URL: http://llvm.org/viewvc/llvm-project?rev=295224&view=rev
Log:
PR24440: Do not silently discard a fold-expression appearing as the operand of
a cast-expression.
Modified:
cfe/trunk/lib/Parse/ParseExpr.cpp
cfe/trunk/lib
On 15 February 2017 at 11:39, Hans Wennborg wrote:
> IIUC, this is a follow-up to r291955, which was merged to 4.0. Should
> this one be merged also?
>
Yes, please.
> Cheers,
> Hans
>
> On Tue, Feb 14, 2017 at 8:18 PM, Richard Smith via cfe-commits
> wrote:
> > Author: rsmith
> > Date: Tue Fe
Hans, this would be a good candidate for Clang 4. The bug in question is
not a regression, but it is an accepts-invalid / wrong-code bug.
On 15 February 2017 at 11:57, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Wed Feb 15 13:57:10 2017
> New Revisi
On 15 February 2017 at 11:50, Hans Wennborg wrote:
> +Richard for risk/reward analysis.
>
This is an extremely safe change, and fixes what amounts to a subtle
miscompile. I think we should take it.
> r274291 was also in 3.9, so this isn't strictly speaking a regression.
>
> On Wed, Feb 15, 201
On Wed, Feb 15, 2017 at 12:14 PM, Richard Smith wrote:
> On 15 February 2017 at 11:39, Hans Wennborg wrote:
>>
>> IIUC, this is a follow-up to r291955, which was merged to 4.0. Should
>> this one be merged also?
>
>
> Yes, please.
r295233.
>
>>
>> Cheers,
>> Hans
>>
>> On Tue, Feb 14, 2017 at 8
On Wed, Feb 15, 2017 at 12:17 PM, Richard Smith wrote:
> On 15 February 2017 at 11:50, Hans Wennborg wrote:
>>
>> +Richard for risk/reward analysis.
>
>
> This is an extremely safe change, and fixes what amounts to a subtle
> miscompile. I think we should take it.
Very good; merged in r295234.
Hi All,
I am re-submitting my patch for Bug 30413, this time with a test case included
as well (ivar-type-encoding.m). The test case file should be added to
clang/test/CodeGenObjC. The test verifies that correct metadata is emitted by
clang for an object-valued instance variable. I've verifi
erichkeane updated this revision to Diff 88602.
erichkeane added a comment.
I was able to get the templated versions working in response to the discussion
with Akira. Note the added test file which shows off all of the combos I could
think of.
It required a little bit of surgery inside the Sem
eric_niebler added a comment.
My question was more about whether the code is correct for absolute paths on
Windows, not about whether this particular test would pass or fail. Have you
tested an incorrectly-cased absolute path on a Windows machine?
https://reviews.llvm.org/D3
___
rnk added inline comments.
Comment at: test/CodeGenCXX/static-init.cpp:14
+// CHECK98: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global
%"struct.test4::HasVTable" zeroinitializer, comdat, align 8
+// CHECK11: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global { i8*
zaks.anna added a comment.
Please, make sure future reviews go through cfg-dev list. See
http://llvm.org/docs/Phabricator.html.
Repository:
rL LLVM
https://reviews.llvm.org/D28297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
zaks.anna added a comment.
Does the code you added detects array out of bounds cases without false
positives? Is it an option to just have this checkers produce a more precise
error message in the specific case.
A lot of work will probably need to be done to implement a proper array out of
bou
Author: rafael
Date: Wed Feb 15 16:19:04 2017
New Revision: 295245
URL: http://llvm.org/viewvc/llvm-project?rev=295245&view=rev
Log:
Fix the static build.
Modified:
cfe/trunk/tools/c-index-test/CMakeLists.txt
Modified: cfe/trunk/tools/c-index-test/CMakeLists.txt
URL:
http://llvm.org/viewvc/
Author: gbiv
Date: Wed Feb 15 16:43:27 2017
New Revision: 295252
URL: http://llvm.org/viewvc/llvm-project?rev=295252&view=rev
Log:
[Modules] Consider enable_if attrs in isSameEntity.
Two functions that differ only in their enable_if attributes are
considered overloads, so we should check for thos
arphaman created this revision.
This patch adds support for the `#pragma clang attribute` directive that was
proposed recently at
http://lists.llvm.org/pipermail/cfe-dev/2017-February/052689.html.
Initially it supports the `annotate`, `require_constant_initialization` and
`objc_subclassing_res
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
Please add a test for this.
Comment at: lib/Sema/SemaExprObjC.cpp:1989
+ Selector SetterSel;
+ if (ObjCPropertyDecl *PD = IFace->FindPropertyDeclaration(
+
beanz added a comment.
Thanks for all your work on these!
Repository:
rL LLVM
https://reviews.llvm.org/D26654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tigerleapgorge updated this revision to Diff 88617.
tigerleapgorge added a comment.
Changed "CHECK11" to "CHECK11-NEXT".
https://reviews.llvm.org/D24812
Files:
test/CodeGenCXX/mangle-unnamed.cpp
test/CodeGenCXX/static-init.cpp
test/CodeGenCXX/volatile-1.cpp
test/CodeGenCXX/volatile.cpp
1 - 100 of 144 matches
Mail list logo
