[PATCH] D28785: Split exception.cpp and new.cpp implementation into different files for different runtimes

compnerd added a comment. While I love this direction (the original version really was an unintelligible pile of code), I really think that this change may be taking on too much. Why not split it up first and do nothing else. We could do the MS ABI implementation in a subsequent change. This

[PATCH] D28849: [compiler-rt] [test] Fix page address logic in clear_cache_test to use binary negation

compnerd added a comment. I wonder if we should take this a bit further. Use something like a `PAGE_SIZE` constant to avoid this confusion entirely. Furthremore, different targets could use different page sizes. IIRC, SPARC has a 8K page size by default. Repository: rL LLVM https://revi

Re: [PATCH] D28467: [Sema] Add warning for unused lambda captures

On Jan 18, 2017 7:34 PM, "Akira Hatanaka via Phabricator" < revi...@reviews.llvm.org> wrote: ahatanak added a comment. In https://reviews.llvm.org/D28467#649861, @krasin wrote: > This change makes Clang hardly incompatible with MSVC++. Consider the following program: > > #include > > int ma

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 84926. hintonda marked 22 inline comments as done. hintonda added a comment. - Add support for matching MemberPointerType's. - Add noexcept(false) option plus test; allow invalid replacement ranges; enhance diagnostics. - Updated docs. https://reviews.llvm

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. Thanks for all the feedback. I've tried to address all your comments, and reworked the documentation. Please let me know if I missed or misunderstood anything. https://reviews.llvm.org/D20693 ___ cfe-commits mailing lis

[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

george.burgess.iv created this revision. As it turns out, emitting diagnostics from places where you're not meant to emit them from is a very bad idea. :) After some looking around, it seems that it's less insane to check for `diagnose_if` attributes in code that's already checking for e.g. nul

<    1   2