mgorny created this revision.
mgorny added a reviewer: beanz.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Use the new llvm_canonicalize_cmake_booleans() function to canonicalize
booleans for lit tests. Replace the duplicate ENABLE_CLANG* variables
used to hold canoni
chandlerc added a comment.
In https://reviews.llvm.org/D28404#641696, @mehdi_amini wrote:
> In https://reviews.llvm.org/D28404#641632, @probinson wrote:
>
> > In https://reviews.llvm.org/D28404#641606, @mehdi_amini wrote:
> >
> > > If we want to support `-O0 -flto` and `optnone` it the way to con
fowles added a subscriber: jdennett.
fowles added a comment.
@jdennett wanted this matcher for something he is working on and I had some
free cycles to write it up. Unfortunately, I am about to leave on an extended
vacation, so I will not be able to follow up with this patch for 2 months at
th
efriedma requested changes to this revision.
efriedma added a reviewer: efriedma.
efriedma added a comment.
This revision now requires changes to proceed.
We really should be checking this much earlier.
IsGlobalLValue() in ExprConstant.cpp is the canonical place to answer the
question "is the ad
Hello Benjamin,
It looks like this commit added warnings to the builder:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/3596
C:\Program Files (x86)\Microsoft Visual Studio
14.0\VC\INCLUDE\ppltasks.h(1531): warning C4530: C++ exception handler
used, but
Author: rsmith
Date: Tue Jan 10 14:52:50 2017
New Revision: 291597
URL: http://llvm.org/viewvc/llvm-project?rev=291597&view=rev
Log:
Don't try to check implicit conversion sequences for an object argument if
there is no object argument, when early checking of implicit conversion
sequences for a fu
cryptoad marked 4 inline comments as done.
cryptoad added a comment.
Thank you for the review Renato!
https://reviews.llvm.org/D28238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cryptoad created this revision.
cryptoad added a reviewer: rengolin.
cryptoad added a subscriber: cfe-commits.
The binary files added as part of https://reviews.llvm.org/rL291598 seem to be
empty. Those are the actual files that should have been uploaded by arc.
https://reviews.llvm.org/D28530
Chandler Carruth via cfe-commits writes:
> Author: chandlerc
> Date: Fri Dec 23 14:44:01 2016
> New Revision: 290450
>
> URL: http://llvm.org/viewvc/llvm-project?rev=290450&view=rev
> Log:
> [PM] Introduce options to enable the (still experimental) new pass
> manager, and a code path to use it.
>
Author: rnk
Date: Tue Jan 10 15:27:03 2017
New Revision: 291600
URL: http://llvm.org/viewvc/llvm-project?rev=291600&view=rev
Log:
Serialize the UsesSEH bit on FunctionDecl
Fixes PR31539
Added:
cfe/trunk/test/PCH/uses-seh.cpp
Modified:
cfe/trunk/lib/Serialization/ASTReaderDecl.cpp
cfe
cryptoad abandoned this revision.
cryptoad added a comment.
Nevermind, it seems to be working with empty files!
https://reviews.llvm.org/D28530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
(explicitly adding Richard so he sees this discussion as some of this
involves a discussion between myself and him)
On Tue, Jan 10, 2017 at 4:36 PM Justin Bogner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Chandler Carruth via cfe-commits writes:
> > Author: chandlerc
> > Date: Fri De
hxy9243 marked an inline comment as done.
hxy9243 added a comment.
Addressed previous issues in the comments. The patch still shows consistent
perf uplift in proprietary benchmark on shared_ptr.
@EricWF @sebpop @hiraditya Any thoughts?
Repository:
rL LLVM
https://reviews.llvm.org/D24991
weimingz added a comment.
Hi Eli,
Thanks for the comments!
I though of implementation in Sema and I actually experimented a little bit.
Then it seemed that the CodeGenOpts is only available in the CGM. Any ideas?
https://reviews.llvm.org/D28526
_
efriedma added a comment.
If there isn't already a LangOptions flag which reflects this, it probably
makes sense to add one.
https://reviews.llvm.org/D28526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
probinson added a comment.
I guess I'm getting irritated because people are trying to tell me what optnone
means. I know what it means; I spent probably a whole year pushing to get it
adopted.
Optnone means: When you are running optimizations, try not to optimize this
part, if you can.
That'
Author: cryptoad
Date: Tue Jan 10 15:13:08 2017
New Revision: 291598
URL: http://llvm.org/viewvc/llvm-project?rev=291598&view=rev
Log:
[Driver] Add openSuse AArch64 Triple
Summary:
openSuse has AArch64 support, with images running on the Raspberry Pi 3.
The libraries and headers live under the aa
probinson added a comment.
In https://reviews.llvm.org/D28404#641757, @chandlerc wrote:
> % ag OptimizeNone lib/Transforms/IPO
> lib/Transforms/IPO/ForceFunctionAttrs.cpp
> 47: .Case("optnone", Attribute::OptimizeNone)
This is implementing a debugging option, not skipping a pass.
>
Author: rsmith
Date: Tue Jan 10 16:59:18 2017
New Revision: 291608
URL: http://llvm.org/viewvc/llvm-project?rev=291608&view=rev
Log:
Remove a couple of parameters that are always false.
Modified:
cfe/trunk/include/clang/Parse/Parser.h
cfe/trunk/lib/Parse/Parser.cpp
Modified: cfe/trunk/in
Author: rsmith
Date: Tue Jan 10 17:04:46 2017
New Revision: 291610
URL: http://llvm.org/viewvc/llvm-project?rev=291610&view=rev
Log:
Remove dead code.
Modified:
cfe/trunk/lib/Parse/Parser.cpp
Modified: cfe/trunk/lib/Parse/Parser.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Par
agutowski added a comment.
For my part, LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D28503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:99
+
+ assert(CRange.isValid() && "Exception Specification Range is invalid.");
+ assert(FnTy && "Functi
benlangmuir added inline comments.
Comment at: include/clang/Basic/FileManager.h:176
+ /// Manage memory buffers associated with pcm files.
+ std::unique_ptr BufferMgr;
+
manmanren wrote:
> benlangmuir wrote:
> > Why is this inside the FileManager? It isn't use
Hello everyone,
LLVM buildmaster will be updated and restarted after 5 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:6-8
+The check converts dynamic exception specifications, e.g.,
+``throw()``, ``throw([,...])``, or ``throw(...)``, to
+``noexcept``, ``noexcept(false)``, blank, or a user defined macro.
Author: mren
Date: Tue Jan 10 18:48:19 2017
New Revision: 291628
URL: http://llvm.org/viewvc/llvm-project?rev=291628&view=rev
Log:
Module: Do not create Implicit ImportDecl for module X if we
are building an implemenation of module X.
This fixes a regression caused by r280409.
rdar://problem/299
Hi Richard,
I fixed a regression caused by this commit in r291628.
Let me know if you see any problem!
Manman
> On Sep 1, 2016, at 1:15 PM, Richard Smith via cfe-commits
> wrote:
>
> Author: rsmith
> Date: Thu Sep 1 15:15:25 2016
> New Revision: 280409
>
> URL: http://llvm.org/viewvc/llvm-
kubabrecka added inline comments.
Comment at: libcxx/include/memory:3702
+inline T
+__libcpp_atomic_increment(T& t) _NOEXCEPT
+{
I don't think this should be named `__libcpp_atomic_increment`, because it uses
relaxed ordering and thus it's not a generic incremen
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:6-8
+The check converts dynamic exception specifications, e.g.,
+``throw()``, ``throw([,...])``, or ``throw(...)``, to
+``noexcept``, ``noexcept(false)``, blank, or a user defined m
Author: phosek
Date: Tue Jan 10 18:56:10 2017
New Revision: 291632
URL: http://llvm.org/viewvc/llvm-project?rev=291632&view=rev
Log:
[CMake][libcxx] Do not rely on the existence of c++abi or unwind targets
There is no guaranteed order in which CMake files for individual
runtimes are invoked and t
Author: dcoughlin
Date: Tue Jan 10 19:02:34 2017
New Revision: 291635
URL: http://llvm.org/viewvc/llvm-project?rev=291635&view=rev
Log:
[analyzer] Fix crash in body farm for getter without implicit self.
Fix a crash in body farm when synthesizing a getter for a property
synthesized for a property
aaron.ballman added inline comments.
Comment at: include/clang/Sema/ScopeInfo.h:457
+/// lambda.
+bool Used = false;
+
arphaman wrote:
> malcolm.parsons wrote:
> > Should this be moved into one of the `PointerIntPair`s?
> I'm not sure.. If we needed other
lethalantidote created this revision.
lethalantidote added a reviewer: thakis.
lethalantidote added a subscriber: cfe-commits.
Elliminates uninitialized warning for volitile variables.
https://reviews.llvm.org/D28543
Files:
clang/lib/Sema/AnalysisBasedWarnings.cpp
Index: clang/lib/Sema/Anal
Quuxplusone added inline comments.
Comment at: test/SemaCXX/warn-unused-lambda-capture.cpp:17
+ auto explicit_by_value_unused = [i] {}; // expected-warning{{lambda capture
'i' is not used}}
+ auto explicit_by_value_unused_sizeof = [i] { return sizeof(i); }; //
expected-warnin
On 10 January 2017 at 16:48, Manman Ren via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mren
> Date: Tue Jan 10 18:48:19 2017
> New Revision: 291628
>
> URL: http://llvm.org/viewvc/llvm-project?rev=291628&view=rev
> Log:
> Module: Do not create Implicit ImportDecl for module X if we
On 10 January 2017 at 17:57, Richard Smith wrote:
> On 10 January 2017 at 16:48, Manman Ren via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: mren
>> Date: Tue Jan 10 18:48:19 2017
>> New Revision: 291628
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=291628&view=rev
>> Log:
thakis added a comment.
Thanks! Can you add a test somewhere? `grep -R W.*uninitialized test/Sema*`
will probably show you the existing test for this code. (Another technique:
Comment some of the existing tests, run `ninja check-clang`, and see which
tests start failing.)
You can run an indiv
Author: bruno
Date: Tue Jan 10 20:14:51 2017
New Revision: 291644
URL: http://llvm.org/viewvc/llvm-project?rev=291644&view=rev
Log:
[Modules] Support #import when entering files with modules
Textual headers and builtins that are #import'd from different
modules should get re-entered when these mo
bruno closed this revision.
bruno added a comment.
Thanks for the review Richard.
Committed 291644
Comment at: lib/Lex/HeaderSearch.cpp:1082
+ auto TryEnterImported = [&](void) -> bool {
+if (!ModulesEnabled)
rsmith wrote:
> Maybe add a FIXME here indic
On Tue, Jan 10, 2017 at 5:59 PM, Richard Smith
wrote:
> On 10 January 2017 at 17:57, Richard Smith wrote:
>
>> On 10 January 2017 at 16:48, Manman Ren via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: mren
>>> Date: Tue Jan 10 18:48:19 2017
>>> New Revision: 291628
>>>
>>> U
dylanmckay updated this revision to Diff 83913.
dylanmckay marked 2 inline comments as done.
dylanmckay added a comment.
[AVR] Document the 'interrupt' and 'naked' attributes
https://reviews.llvm.org/D28451
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/Tar
dylanmckay added inline comments.
Comment at: include/clang/Basic/Attr.td:488
+
+def AVRSignal : InheritableAttr, TargetSpecificAttr {
+ let Spellings = [GNU<"signal">];
aaron.ballman wrote:
> Does this attribute appertain to any specific subjects, or can you ap
pekka.jaaskelainen requested changes to this revision.
pekka.jaaskelainen added a comment.
This revision now requires changes to proceed.
Great work.
Comment at: docs/UsersManual.rst:44
- :ref:`Objective C++ Language `
+- :ref:`OpenCL Language `: v1.0, v1.1, v1.2, v2.0.
--
Author: klimek
Date: Wed Jan 11 01:20:46 2017
New Revision: 291653
URL: http://llvm.org/viewvc/llvm-project?rev=291653&view=rev
Log:
Only launch asynchronously if threading is enabled.
Modified:
clang-tools-extra/trunk/include-fixer/SymbolIndexManager.h
Modified: clang-tools-extra/trunk/incl
101 - 144 of 144 matches
Mail list logo
