r291188 - Remove the ppc insertword/extractword expected fail tests.

2017-01-05 Thread Sean Fertile via cfe-commits
Author: sfertile Date: Thu Jan 5 16:54:34 2017 New Revision: 291188 URL: http://llvm.org/viewvc/llvm-project?rev=291188&view=rev Log: Remove the ppc insertword/extractword expected fail tests. Removed: cfe/trunk/test/CodeGen/builtins-ppc-extractword-error.c cfe/trunk/test/CodeGen/builtin

Re: r291179 - Add vec_insert4b and vec_extract4b functions to altivec.h

2017-01-05 Thread Sean Fertile via cfe-commits
  Sorry about that I've removed the  2 tests causing the issue for now.   Sean   - Original message -From: Evgenii Stepanov To: Sean Fertile/Toronto/IBM@IBMCACc: cfe-commits Subject: Re: r291179 - Add vec_insert4b and vec_extract4b functions to altivec.hDate: Thu, Jan 5, 2017 5:16 PM  Tests

r291190 - Add missing "original call argument has same type as deduced parameter type"

2017-01-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jan 5 17:02:44 2017 New Revision: 291190 URL: http://llvm.org/viewvc/llvm-project?rev=291190&view=rev Log: Add missing "original call argument has same type as deduced parameter type" check for deductions from elements of a braced-init-list. Modified: cfe/trunk/inclu

[PATCH] D27429: [Chrono][Darwin] On Darwin use CLOCK_UPTIME_RAW instead of CLOCK_MONOTONIC

2017-01-05 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. @EricWF ok to commit? https://reviews.llvm.org/D27429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-05 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd created this revision. compnerd added reviewers: EricWF, mclow.lists, smeenai, kastiglione. compnerd added subscribers: cfe-commits, rnk. compnerd set the repository for this revision to rL LLVM. Herald added a subscriber: mgorny. We need to have a more principled method to detect the C++

r291191 - Fix bug where types other than 'cv auto', 'cv auto &', and 'cv auto &&' could

2017-01-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jan 5 17:12:16 2017 New Revision: 291191 URL: http://llvm.org/viewvc/llvm-project?rev=291191&view=rev Log: Fix bug where types other than 'cv auto', 'cv auto &', and 'cv auto &&' could incorrectly be deduced from an initializer list in pathological cases. Modified: c

[libcxx] r291192 - config_elast: fix typo (NFC)

2017-01-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Jan 5 17:25:44 2017 New Revision: 291192 URL: http://llvm.org/viewvc/llvm-project?rev=291192&view=rev Log: config_elast: fix typo (NFC) Missed the original typo which was duplicated. NFC. Modified: libcxx/trunk/src/include/config_elast.h Modified: libcxx/trunk/s

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

2017-01-05 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood updated this revision to Diff 83318. hamzasood added a comment. - Re-implemented the PATH searching behaviour (thanks @amccarth for pointing that out) - Updated the base revision. https://reviews.llvm.org/D28365 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/MSVCT

[PATCH] D28258: [Sema] Handle invalid noexcept expressions correctly.

2017-01-05 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. Looks OK. Is it possible to add a test case for this without https://reviews.llvm.org/D20428? If not, this is small enough that rolling it into https://reviews.llvm.org/D20428 (so it can be committed with its testcase) would make sense. https://reviews.llvm.org/D28258

[PATCH] D28385: Add a cc1 option to force disabling lifetime-markers emission from clang

2017-01-05 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini created this revision. mehdi_amini added reviewers: chandlerc, rsmith. mehdi_amini added a subscriber: cfe-commits. This intended as a debugging/development flag only. https://reviews.llvm.org/D28385 Files: clang/include/clang/Driver/CC1Options.td clang/include/clang/Frontend/Co

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-05 Thread David Majnemer via Phabricator via cfe-commits
majnemer added a comment. Why isn't this equivalent to `_MSC_VER` ? Repository: rL LLVM https://reviews.llvm.org/D28383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-05 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In https://reviews.llvm.org/D28383#637570, @majnemer wrote: > Why isn't this equivalent to `_MSC_VER` ? You can have scenarios where you're targeting the Itanium ABI but still have `_MSC_VER` defined, e.g. % clang -target i686-windows-itanium -fmsc-version=1900 -E -

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

2017-01-05 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood updated this revision to Diff 83325. hamzasood added a comment. Improved the code slightly. Sorry for the spam everyone, this is definitely the one. https://reviews.llvm.org/D28365 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/MSVCToolChain.cpp lib/Driver/ToolCh

[PATCH] D28212: typeinfo: provide a partial implementation for Win32

2017-01-05 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd set the repository for this revision to rL LLVM. compnerd updated this revision to Diff 83326. Repository: rL LLVM https://reviews.llvm.org/D28212 Files: include/typeinfo src/typeinfo.cpp Index: src/typeinfo.cpp ===

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-05 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In https://reviews.llvm.org/D28383#637570, @majnemer wrote: > Why isn't this equivalent to `_MSC_VER` ? It might also be nice for clang to define some macro to indicate which C++ ABI is in use. All that said, I think it makes sense to encode this in libc++ include/__conf

[PATCH] D28387: [tsan] Do not report errors in __destroy_helper_block_

2017-01-05 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna created this revision. zaks.anna added a reviewer: kubabrecka. zaks.anna added a subscriber: cfe-commits. There is a synchronization point between the reference count of a block dropping to zero and it's destruction, which TSan does not observe. Do not report errors in the compiler-emi

r291202 - shared_ptrify (from InclusiveRefCntPtr) HeaderSearchOptions

2017-01-05 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Thu Jan 5 19:04:46 2017 New Revision: 291202 URL: http://llvm.org/viewvc/llvm-project?rev=291202&view=rev Log: shared_ptrify (from InclusiveRefCntPtr) HeaderSearchOptions Modified: cfe/trunk/include/clang/Frontend/ASTUnit.h cfe/trunk/include/clang/Frontend/Compiler

[clang-tools-extra] r291203 - Fixes for Clang API change

2017-01-05 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Thu Jan 5 19:09:06 2017 New Revision: 291203 URL: http://llvm.org/viewvc/llvm-project?rev=291203&view=rev Log: Fixes for Clang API change Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp clang-tools-extra/trunk/modularize/ModularizeUtilities.h

Re: r291123 - CodeGen: plumb header search down to the IAS

2017-01-05 Thread Eric Christopher via cfe-commits
Hi Saleem, Love that you wanted to add a test for it, but I'd really prefer that you not engage the backend here in order to do it. You can verify some of it from the backend and just that the module is correct via the front end if you'd like. Ensuring the paths are correct is a bit of a sticky pr

Re: r291123 - CodeGen: plumb header search down to the IAS

2017-01-05 Thread Saleem Abdulrasool via cfe-commits
This was certainly the problem that I had. The test really needs a way to check that the field was set. As you state, this is a problematic area. The backend already has a test to ensure that the paths are honored, but, I didn't see any way to actually ensure that it was getting sent to the backe

Re: r291123 - CodeGen: plumb header search down to the IAS

2017-01-05 Thread Eric Christopher via cfe-commits
Ok, thanks. I agree that it's a problem. I'm definitely open for testing ideas here. There are a few other things in the TargetOptions/MCTargetOptions area that are already problematic to test. -eric On Thu, Jan 5, 2017 at 6:27 PM Saleem Abdulrasool wrote: > This was certainly the problem that

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

2017-01-05 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. @rnk happy to add such a macro. Would `__cpp_abi_itanium` and `__cpp_abi_microsoft` be palatable? This actually does get encoded into `__config` albeit in a round-about way. The `__config_site` gets concatenated with `__config` into `__generated_config` which is ins

r291208 - CodeGen: address post commit review comments for r291123

2017-01-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Jan 5 20:27:40 2017 New Revision: 291208 URL: http://llvm.org/viewvc/llvm-project?rev=291208&view=rev Log: CodeGen: address post commit review comments for r291123 This test would force the execution of the backend. However, the backend already has a test for this. E

Re: r291123 - CodeGen: plumb header search down to the IAS

2017-01-05 Thread Saleem Abdulrasool via cfe-commits
SVN r291208 On Thu, Jan 5, 2017 at 6:30 PM, Eric Christopher wrote: > Ok, thanks. I agree that it's a problem. I'm definitely open for testing > ideas here. There are a few other things in the > TargetOptions/MCTargetOptions area that are already problematic to test. > > -eric > > On Thu, Jan 5,

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

2017-01-05 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai updated this revision to Diff 83339. xiangzhai added a comment. Hi Anna, Thanks for your review! I resubmit the patch with context, please check is it correct, thanks a lot! And I add testcase: test/Analysis/gmalloc.c Repository: rL LLVM https://reviews.llvm.org/D28348 Files: l

Re: [libcxx] r291192 - config_elast: fix typo (NFC)

2017-01-05 Thread David Majnemer via cfe-commits
On Thu, Jan 5, 2017 at 3:25 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Thu Jan 5 17:25:44 2017 > New Revision: 291192 > > URL: http://llvm.org/viewvc/llvm-project?rev=291192&view=rev > Log: > config_elast: fix typo (NFC) > > Missed the o

Re: r291123 - CodeGen: plumb header search down to the IAS

2017-01-05 Thread Eric Christopher via cfe-commits
Thanks! -eric On Thu, Jan 5, 2017 at 6:38 PM Saleem Abdulrasool wrote: > SVN r291208 > > On Thu, Jan 5, 2017 at 6:30 PM, Eric Christopher > wrote: > > Ok, thanks. I agree that it's a problem. I'm definitely open for testing > ideas here. There are a few other things in the > TargetOptions/MCTa

[PATCH] D20428: Tracking exception specification source locations

2017-01-05 Thread don hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 83346. hintonda added a comment. - Fix compile errors. - When noexcept expr is invalid, set NoexceptType to EST_BasicNoexcept https://reviews.llvm.org/D20428 Files: include/clang/AST/Decl.h include/clang/AST/TypeLoc.h lib/AST/Decl.cpp lib/Parse/Par

[PATCH] D28258: [Sema] Handle invalid noexcept expressions correctly.

2017-01-05 Thread don hinton via Phabricator via cfe-commits
hintonda abandoned this revision. hintonda added a comment. Unable to test change here, so have included fix directly in https://reviews.llvm.org/D20428. https://reviews.llvm.org/D28258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D28296: [ObjC] The declarator for a block literal should be a definition

2017-01-05 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D28296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

<    1   2