[PATCH] D28316: [libc++] Cleanup and document <__threading_support>

EricWF added a comment. @compnerd Just waiting on @rmaprath before committing. This is a breaking change for his use case since this patch changes the semantics of `_LIBCPP_HAS_THREAD_API_EXTERNAL` and `-DLIBCXX_HAS_EXTERNAL_THREAD_API`. https://reviews.llvm.org/D28316 _

[PATCH] D28346: [AVR] Allow specifying the CPU on the command line

dylanmckay created this revision. dylanmckay added a reviewer: jroelofs. dylanmckay added a subscriber: cfe-commits. This tells clang about all of the different AVR microcontrollers. It also adds code to define the correct preprocessor macros for each device. https://reviews.llvm.org/D28346 Fi

[libcxx] r291091 - Get tests linking on Windows.

Author: ericwf Date: Thu Jan 5 02:07:17 2017 New Revision: 291091 URL: http://llvm.org/viewvc/llvm-project?rev=291091&view=rev Log: Get tests linking on Windows. This patch is a temporary hack to get the tests passing on Windows. Modified: libcxx/trunk/test/libcxx/test/config.py Modified:

[PATCH] D28316: [libc++] Cleanup and document <__threading_support>

smeenai added inline comments. Comment at: docs/DesignDocs/ThreadingSupportAPI.rst:17 + +The ``<__threading_support>`` header is where libc++ defines it's internal +threading interface. It contains forward declarations of the internal threading s/it's/its https

[PATCH] D28316: [libc++] Cleanup and document <__threading_support>

EricWF updated this revision to Diff 83201. EricWF added a comment. - Address inline comments https://reviews.llvm.org/D28316 Files: CMakeLists.txt docs/DesignDocs/ThreadingSupportAPI.rst docs/index.rst include/__config include/__config_site.in include/__threading_support lib/CMak

[libcxx] r291093 - Use C++11 static_assert in variant tests. Patch from Michael Park

Author: ericwf Date: Thu Jan 5 03:03:43 2017 New Revision: 291093 URL: http://llvm.org/viewvc/llvm-project?rev=291093&view=rev Log: Use C++11 static_assert in variant tests. Patch from Michael Park Modified: libcxx/trunk/test/libcxx/utilities/variant/variant.variant/variant.assign/copy.pass

[libcxx] r291094 - Add gcc-[56] clang-3.[678] to list of XFAILS for variant tests. Patch from Michael Park

Author: ericwf Date: Thu Jan 5 03:06:30 2017 New Revision: 291094 URL: http://llvm.org/viewvc/llvm-project?rev=291094&view=rev Log: Add gcc-[56] clang-3.[678] to list of XFAILS for variant tests. Patch from Michael Park Modified: libcxx/trunk/test/libcxx/utilities/variant/variant.variant/v

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

dvyukov added a comment. Yes, for tsan runtime detection does not make lots of sense -- we only have few SSE instructions on inlined fast path. The SSE code provides quite substantial speedup. User -march flag won't help as runtime is prebuilt. SCUDO is sse4.2, but tsan is sse3. Do you actually

[PATCH] D28315: Update tools to use new getStyle API

hokein added a comment. In https://reviews.llvm.org/D28315#635865, @amaiorano wrote: > I made these changes, and they build, but I didn't really test them. Are > there unit tests for these tools that I can run? If you use ninja build, you can run `ninja check-clang-tools` to run all tests. h

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

rengolin added a comment. Please, add tests to test/Driver. https://reviews.llvm.org/D28238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28316: [libc++] Cleanup and document <__threading_support>

rmaprath added a comment. This is much better (few nits inline). And many thanks for the docs update (btw, do those docs updates land on some web URL automagically when committed?). I think we should point out on the docs that `_LIBCPP_HAS_THREAD_LIBRARY_EXTERNAL` is only meant for `libc++` dev

r291096 - No canonical-prefixes match in avr-toolchain.c.

Author: hokein Date: Thu Jan 5 04:06:58 2017 New Revision: 291096 URL: http://llvm.org/viewvc/llvm-project?rev=291096&view=rev Log: No canonical-prefixes match in avr-toolchain.c. Modified: cfe/trunk/test/Driver/avr-toolchain.c Modified: cfe/trunk/test/Driver/avr-toolchain.c URL: http://ll

[PATCH] D28316: [libc++] Cleanup and document <__threading_support>

EricWF marked 3 inline comments as done. EricWF added a comment. In https://reviews.llvm.org/D28316#636686, @rmaprath wrote: > (btw, do those docs updates land on some web URL automagically when > committed?). Assuming the builder isn't broken then yes, the docs should automagically update wi

[PATCH] D28316: [libc++] Cleanup and document <__threading_support>

EricWF updated this revision to Diff 83211. EricWF marked an inline comment as done. https://reviews.llvm.org/D28316 Files: CMakeLists.txt docs/DesignDocs/ThreadingSupportAPI.rst docs/index.rst include/__config include/__config_site.in include/__threading_support lib/CMakeLists.txt

[PATCH] D28349: [Frontend] The macro that describes the Objective-C bool type should be defined in C as well

arphaman created this revision. arphaman added reviewers: doug.gregor, t.p.northover. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch defines __OBJC_BOOL_IS_BOOL for C code as well, since Objective-C's BOOL can be also used by C code.

[PATCH] D28330: [analyzer] Fix false positives in Keychain API checker

NoQ added a comment. > Do not check if the return status has been compared to error (or no error) at > the time when leaks are reported since the status symbol might no longer be > alive. Instead, pattern match on the assume and stop tracking allocated > symbols on error paths. Aha, i see! So

[PATCH] D28316: [libc++] Cleanup and document <__threading_support>

rmaprath added a comment. In https://reviews.llvm.org/D28316#636700, @EricWF wrote: > In https://reviews.llvm.org/D28316#636686, @rmaprath wrote: > > > (btw, do those docs updates land on some web URL automagically when > > committed?). > > > Assuming the builder isn't broken then yes, the docs

[PATCH] D28350: [Sema] Avoid -Wshadow warning when a "redefinition of " error is presented

arphaman created this revision. arphaman added reviewers: rsmith, rnk, bruno. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch ensures that clang avoids the redundant -Wshadow warning for variables that already get a "redefinition of "

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

sfantao marked an inline comment as done. sfantao added a comment. Hi Jonas, Thanks for the review. Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252 + // \brief Flags associated the device global. + int32_t Flags; + Hahnfeld wrote: > Is that intenti

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

Hahnfeld added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252 + // \brief Flags associated the device global. + int32_t Flags; + sfantao wrote: > Hahnfeld wrote: > > Is that intentionally not in the `protected` section below? > Yes,

[PATCH] D28315: Update tools to use new getStyle API

amaiorano added a comment. In https://reviews.llvm.org/D28315#636670, @hokein wrote: > In https://reviews.llvm.org/D28315#635865, @amaiorano wrote: > > > I made these changes, and they build, but I didn't really test them. Are > > there unit tests for these tools that I can run? > > > If you use

[PATCH] D28346: [AVR] Allow specifying the CPU on the command line

jroelofs added a comment. Testcase? https://reviews.llvm.org/D28346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291121 - [OpenMP] Update target codegen for NVPTX device.

Author: arpith Date: Thu Jan 5 09:24:05 2017 New Revision: 291121 URL: http://llvm.org/viewvc/llvm-project?rev=291121&view=rev Log: [OpenMP] Update target codegen for NVPTX device. This patch includes updates for codegen of the target region for the NVPTX device. It moves initializers from the c

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

sfantao updated this revision to Diff 83236. sfantao marked 2 inline comments as done. sfantao added a comment. - Privatize Order, Flags and Kind of the offload entry. https://reviews.llvm.org/D28298 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGOpenMP

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252 + // \brief Flags associated the device global. + int32_t Flags; + Hahnfeld wrote: > sfantao wrote: > > Hahnfeld wrote: > > > Is that intentionally not in the `protected` s

[PATCH] D28315: Update tools to use new getStyle API

hokein added a comment. In https://reviews.llvm.org/D28315#636821, @amaiorano wrote: > Is there a way to run tests without ninja? I'm on Windows. If not, I'll use > my Linux VM. It is not related to the build system. There should be a `check-clang-tools` project, you can run tests by building

[PATCH] D28257: [OpenCL] Re-enable supported core extensions based on opencl version when disabling all extensions using pragma

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Ok, LGTM! Thanks! https://reviews.llvm.org/D28257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D28298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

mgorny added a comment. In https://reviews.llvm.org/D28304#636669, @dvyukov wrote: > User -march flag won't help as runtime is prebuilt. I meant the flag used by the compiler vendor when compiler-rt is built. > SCUDO is sse4.2, but tsan is sse3. Do you actually see any problems with > sse3? I

r291124 - [OpenMP] Add fields for flags in the offload entry descriptor.

Author: sfantao Date: Thu Jan 5 10:02:49 2017 New Revision: 291124 URL: http://llvm.org/viewvc/llvm-project?rev=291124&view=rev Log: [OpenMP] Add fields for flags in the offload entry descriptor. Summary: This patch adds two fields to the offload entry descriptor. One field is meant to signal C

r291123 - CodeGen: plumb header search down to the IAS

Author: compnerd Date: Thu Jan 5 10:02:32 2017 New Revision: 291123 URL: http://llvm.org/viewvc/llvm-project?rev=291123&view=rev Log: CodeGen: plumb header search down to the IAS inline assembly may use the `.include` directive to include other content into the file. Without the integrated asse

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( aaron.ballman wrote: > firolin

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis added a comment. Ping. https://reviews.llvm.org/D25866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291125 - test: add an explicit triple

Author: compnerd Date: Thu Jan 5 10:36:15 2017 New Revision: 291125 URL: http://llvm.org/viewvc/llvm-project?rev=291125&view=rev Log: test: add an explicit triple Not all targets use the integrated assembler. Specify a triple to ensure we use the integrated as for this. Modified: cfe/trunk

[PATCH] D28349: [Frontend] The macro that describes the Objective-C bool type should be defined in C as well

doug.gregor added a comment. The "!LangOpts.CPlusPlus" doesn't make sense to me. You're presumably defining this macro in C because the Objective-C runtime is usable from C, but that same logic applies to C++ code. It seems like we should be defining this macro unconditionally. Repository:

r291128 - [Windows] Remove functions in intrin.h that are defined in Builtin.def.

Author: jlebar Date: Thu Jan 5 10:51:37 2017 New Revision: 291128 URL: http://llvm.org/viewvc/llvm-project?rev=291128&view=rev Log: [Windows] Remove functions in intrin.h that are defined in Builtin.def. Summary: These duplicate declarations cause a problem for CUDA compiles on Windows. All imp

[PATCH] D28318: [TableGen] Only normalize the spelling of GNU-style attributes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291129: [TableGen] Only normalize the spelling of GNU-style attributes. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28318?vs=83125&id=83253#toc Repository: rL LLVM https

r291129 - [TableGen] Only normalize the spelling of GNU-style attributes.

Author: jlebar Date: Thu Jan 5 10:51:54 2017 New Revision: 291129 URL: http://llvm.org/viewvc/llvm-project?rev=291129&view=rev Log: [TableGen] Only normalize the spelling of GNU-style attributes. Summary: When Sema looks up an attribute name, it strips off leading and trailing "__" if the attrib

r291130 - [CUDA] Make CUDAInstallationDetector take the host triple in its constructor.

Author: jlebar Date: Thu Jan 5 10:52:11 2017 New Revision: 291130 URL: http://llvm.org/viewvc/llvm-project?rev=291130&view=rev Log: [CUDA] Make CUDAInstallationDetector take the host triple in its constructor. Summary: Previously it was taking the true target triple, which is not really what it

[PATCH] D28319: [CUDA] Make CUDAInstallationDetector take the host triple in its constructor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291130: [CUDA] Make CUDAInstallationDetector take the host triple in its constructor. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28319?vs=83126&id=83254#toc Repository:

r291131 - [Driver] Driver changes to support CUDA compilation on Windows.

Author: jlebar Date: Thu Jan 5 10:52:29 2017 New Revision: 291131 URL: http://llvm.org/viewvc/llvm-project?rev=291131&view=rev Log: [Driver] Driver changes to support CUDA compilation on Windows. Summary: For the most part this is straightforward: Just add a CudaInstallation object to the MSVC a

r291133 - [ToolChains] Use "static" instead of an anonymous namespace for a function. NFC

Author: jlebar Date: Thu Jan 5 10:52:47 2017 New Revision: 291133 URL: http://llvm.org/viewvc/llvm-project?rev=291133&view=rev Log: [ToolChains] Use "static" instead of an anonymous namespace for a function. NFC Modified: cfe/trunk/lib/Driver/MinGWToolChain.cpp Modified: cfe/trunk/lib/Driv

[PATCH] D28320: [Driver] Driver changes to support CUDA compilation on Windows.

This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL291131: [Driver] Driver changes to support CUDA compilation on Windows. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28320?vs=83127&i

r291134 - [CUDA] Add __declspec spellings for CUDA attributes.

Author: jlebar Date: Thu Jan 5 10:53:04 2017 New Revision: 291134 URL: http://llvm.org/viewvc/llvm-project?rev=291134&view=rev Log: [CUDA] Add __declspec spellings for CUDA attributes. Summary: CUDA attributes are spelled __declspec(__foo__) on Windows. Reviewers: tra Subscribers: cfe-commits,

r291135 - [CUDA] More correctly inherit primitive types from the host during device compilation.

Author: jlebar Date: Thu Jan 5 10:53:21 2017 New Revision: 291135 URL: http://llvm.org/viewvc/llvm-project?rev=291135&view=rev Log: [CUDA] More correctly inherit primitive types from the host during device compilation. Summary: CUDA lets users share structs between the host and device, so for t

[PATCH] D28322: [CUDA] More correctly inherit primitive types from the host during device compilation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291135: [CUDA] More correctly inherit primitive types from the host during device… (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28322?vs=83129&id=83258#toc Repository: rL

[PATCH] D28321: [CUDA] Add __declspec spellings for CUDA attributes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291134: [CUDA] Add __declspec spellings for CUDA attributes. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28321?vs=83128&id=83257#toc Repository: rL LLVM https://reviews.

r291136 - [CUDA] Let NVPTX inherit the host's calling conventions.

Author: jlebar Date: Thu Jan 5 10:53:38 2017 New Revision: 291136 URL: http://llvm.org/viewvc/llvm-project?rev=291136&view=rev Log: [CUDA] Let NVPTX inherit the host's calling conventions. Summary: When compiling device code, we may still see host code with explicit calling conventions. NVPTX n

r291137 - [CUDA] Don't define functions that the CUDA headers themselves define on Windows.

Author: jlebar Date: Thu Jan 5 10:53:55 2017 New Revision: 291137 URL: http://llvm.org/viewvc/llvm-project?rev=291137&view=rev Log: [CUDA] Don't define functions that the CUDA headers themselves define on Windows. Reviewers: tra Subscribers: cfe-commits Differential Revision: https://reviews.

[PATCH] D28324: [CUDA] Don't define functions that the CUDA headers themselves define on Windows.

This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL291137: [CUDA] Don't define functions that the CUDA headers themselves define on… (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28324?

r291138 - [CUDA] Rename keywords used in macro so they don't conflict with MSVC.

Author: jlebar Date: Thu Jan 5 10:54:11 2017 New Revision: 291138 URL: http://llvm.org/viewvc/llvm-project?rev=291138&view=rev Log: [CUDA] Rename keywords used in macro so they don't conflict with MSVC. Summary: MSVC seems to use "__in" and "__out" for its own purposes, so we have to pick differ

[PATCH] D28317: [Windows] Remove functions in intrin.h that are defined in Builtin.def.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291128: [Windows] Remove functions in intrin.h that are defined in Builtin.def. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28317?vs=83124&id=83252#toc Repository: rL LLV

[PATCH] D28325: [CUDA] Rename keywords used in macro so they don't conflict with MSVC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291138: [CUDA] Rename keywords used in macro so they don't conflict with MSVC. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28325?vs=83133&id=83261#toc Repository: rL LLVM

[PATCH] D28326: [Docs] Update docs to indicate that CUDA compilation is supported on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291139: [Docs] Update docs to indicate that CUDA compilation is supported on Windows. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28326?vs=83134&id=83262#toc Repository:

[PATCH] D28323: [CUDA] Let NVPTX inherit the host's calling conventions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291136: [CUDA] Let NVPTX inherit the host's calling conventions. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28323?vs=83130&id=83259#toc Repository: rL LLVM https://revi

r291142 - test: add a requires registered target

Author: compnerd Date: Thu Jan 5 11:09:20 2017 New Revision: 291142 URL: http://llvm.org/viewvc/llvm-project?rev=291142&view=rev Log: test: add a requires registered target It seems that the ARM buildbots do not include x86 support. However, other x86 targets do not support the ARM target. Use

[PATCH] D28131: [libcxx] Fix PR31402: map::__find_equal_key has undefined behavior.

mclow.lists added inline comments. Comment at: include/__tree:1400 __parent_pointer& __parent, const key_type& __v); +// FIXME: Make this function const qualified. Unfortunetly doing so +// breaks existing code which uses non-const callable comparator

[PATCH] D28362: [ThinLTO] Optionally ignore empty index file

tejohnson created this revision. tejohnson added a reviewer: mehdi_amini. tejohnson added a subscriber: cfe-commits. In order to simplify distributed build system integration, where actions may be scheduled before the Thin Link which determines the list of objects selected by the linker. The gold

[PATCH] D28348: Taught the analyzer about Glib API to check Memory-leak

zaks.anna added a comment. Thanks for the patch! Could you, please, resubmit the patch with context as described here http://llvm.org/docs/Phabricator.html Also, please, add tests. See test/Analysis/ for examples. Repository: rL LLVM https://reviews.llvm.org/D28348 __

r291143 - Migrate PathDiagnosticPiece to std::shared_ptr

Author: dblaikie Date: Thu Jan 5 11:26:53 2017 New Revision: 291143 URL: http://llvm.org/viewvc/llvm-project?rev=291143&view=rev Log: Migrate PathDiagnosticPiece to std::shared_ptr Simplifies and makes explicit the memory ownership model rather than implicitly passing/acquiring ownership. Modif

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

aaron.ballman added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( firolino wrote: > aaron.b

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

hamzasood created this revision. hamzasood added reviewers: rnk, ruiu, hans. hamzasood added a subscriber: cfe-commits. The patch updates the MSVC ToolChain for the changes made in Visual Studio 2017 (https://blogs.msdn.microsoft.com/vcblog/2016/10/07/compiler-tools-layout-in-visual-studio-15/).

Re: Fix for Visual Studio 2017

I’ve submitted an updated version via Phabricator (https://reviews.llvm.org/D28365 ), so this one can be ignored.___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D28330: [analyzer] Fix false positives in Keychain API checker

zaks.anna added a comment. I did not think of solution #1! It's definitely better than the pattern matching I've added here. However, this checker fires so infrequently, that I do not think it's worth investing more time into perfecting it. I suspect the solution #2 is what this checker was try

[libcxx] r291145 - thread_support: split out {,non-}recursive mutex

Author: compnerd Date: Thu Jan 5 11:54:45 2017 New Revision: 291145 URL: http://llvm.org/viewvc/llvm-project?rev=291145&view=rev Log: thread_support: split out {,non-}recursive mutex Split out the recursive and non-recursive mutex. This split is needed for platforms which may use differing type

[PATCH] D28338: thread_support: split out {,non-}recursive mutex

compnerd closed this revision. compnerd added a comment. SVN r291145 Repository: rL LLVM https://reviews.llvm.org/D28338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291148 - Typo

Author: joerg Date: Thu Jan 5 11:59:44 2017 New Revision: 291148 URL: http://llvm.org/viewvc/llvm-project?rev=291148&view=rev Log: Typo Modified: cfe/trunk/unittests/Format/FormatTestJS.cpp Modified: cfe/trunk/unittests/Format/FormatTestJS.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/t

[PATCH] D28220: provide Win32 native threading

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: include/__threading_support:474 + system_clock::time_point(duration_cast(duration)); + auto timeout_ms = duration_cast(abstime - system_clock::now()); + halyavin wrote:

[PATCH] D27424: Add the diagnose_if attribute to clang.

aaron.ballman added a comment. In https://reviews.llvm.org/D27424#636496, @george.burgess.iv wrote: > Do we have a page that details when we should/shouldn't use `auto`? I was > under the impression that it was preferred only in cases where the type's > spelled out (e.g. `cast`, ...). (To be cl

r291150 - Use shared_ptr instead of IntrusiveRefCntPtr for ModuleFileExtension

Author: dblaikie Date: Thu Jan 5 12:23:18 2017 New Revision: 291150 URL: http://llvm.org/viewvc/llvm-project?rev=291150&view=rev Log: Use shared_ptr instead of IntrusiveRefCntPtr for ModuleFileExtension The intrusiveness wasn't needed here, so this simplifies/clarifies the ownership model. Modi

[PATCH] D28362: [ThinLTO] Optionally ignore empty index file

mehdi_amini added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:65 +"Ignore an empty index file and perform non-ThinLTO compilation"), +llvm::cl::init(false)); + Is it common to do this in clang? https://reviews.llvm.org/D28362 ___

[PATCH] D28362: [ThinLTO] Optionally ignore empty index file

tejohnson added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:65 +"Ignore an empty index file and perform non-ThinLTO compilation"), +llvm::cl::init(false)); + mehdi_amini wrote: > Is it common to do this in clang? Doesn't look common, but

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

manmanren added a comment. I forgot to upload the testing case, I will add it now. Manman Comment at: include/clang/Basic/FileManager.h:176 + /// Manage memory buffers associated with pcm files. + std::unique_ptr BufferMgr; + benlangmuir wrote: > Why is this

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

manmanren updated this revision to Diff 83273. manmanren added a comment. Add testing case. https://reviews.llvm.org/D28299 Files: include/clang/Basic/DiagnosticSerializationKinds.td include/clang/Basic/FileManager.h include/clang/Serialization/ASTReader.h include/clang/Serialization/AS

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

manmanren added inline comments. Comment at: include/clang/Basic/DiagnosticSerializationKinds.td:131 + "diagnostic options now it is a non-system module">, + InGroup; + aprantl wrote: > Is this better? > > "module file '%0' was validated as a system module and

r291155 - Simplify ASTReader ctor by using in-class initializers for many member variables

Author: dblaikie Date: Thu Jan 5 12:45:45 2017 New Revision: 291155 URL: http://llvm.org/viewvc/llvm-project?rev=291155&view=rev Log: Simplify ASTReader ctor by using in-class initializers for many member variables Modified: cfe/trunk/include/clang/Serialization/ASTWriter.h cfe/trunk/lib

r291154 - Simplify ASTReader ctor by using in-class initializers (NSDMIs to the rest of you) for many member variables

Author: dblaikie Date: Thu Jan 5 12:45:43 2017 New Revision: 291154 URL: http://llvm.org/viewvc/llvm-project?rev=291154&view=rev Log: Simplify ASTReader ctor by using in-class initializers (NSDMIs to the rest of you) for many member variables Modified: cfe/trunk/include/clang/Serialization/

r291156 - Move VariantMatcher's Payload to std::shared_ptr rather than IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 12:51:54 2017 New Revision: 291156 URL: http://llvm.org/viewvc/llvm-project?rev=291156&view=rev Log: Move VariantMatcher's Payload to std::shared_ptr rather than IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h cfe/t

r291160 - Move PreprocessorOptions to std::shared_ptr from IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:11:36 2017 New Revision: 291160 URL: http://llvm.org/viewvc/llvm-project?rev=291160&view=rev Log: Move PreprocessorOptions to std::shared_ptr from IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/Frontend/CompilerInvocation.h cfe/trunk/include/clan

r291159 - Move FailedModulesSet over to shared_ptr from IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:11:31 2017 New Revision: 291159 URL: http://llvm.org/viewvc/llvm-project?rev=291159&view=rev Log: Move FailedModulesSet over to shared_ptr from IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/Lex/PreprocessorOptions.h cfe/trunk/lib/Frontend/Compil

r291166 - Move Preprocessor over to std::shared_ptr rather than IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:48:07 2017 New Revision: 291166 URL: http://llvm.org/viewvc/llvm-project?rev=291166&view=rev Log: Move Preprocessor over to std::shared_ptr rather than IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/Frontend/ASTUnit.h cfe/trunk/include/clang/Fron

r291167 - Move SerializedDiagnosticPrinter's SharedState to std::shared_ptr rather than IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:48:10 2017 New Revision: 291167 URL: http://llvm.org/viewvc/llvm-project?rev=291167&view=rev Log: Move SerializedDiagnosticPrinter's SharedState to std::shared_ptr rather than IntrusiveRefCntPtr Modified: cfe/trunk/lib/Frontend/SerializedDiagnosticPrinter

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

dvyukov added a comment. > I don't see a big issue enabling it for x86-64 but for 32-bit systems you're > ruling out quite a lot of hardware. Tsan does not support 32-bits. https://reviews.llvm.org/D28304 ___ cfe-commits mailing list cfe-commits@l

r291170 - If an explicitly-specified pack might have been extended by template argument

Author: rsmith Date: Thu Jan 5 14:27:28 2017 New Revision: 291170 URL: http://llvm.org/viewvc/llvm-project?rev=291170&view=rev Log: If an explicitly-specified pack might have been extended by template argument deduction, don't forget to check the argument is valid. Modified: cfe/trunk/lib/Se

[PATCH] D28220: provide Win32 native threading

halyavin added inline comments. Comment at: include/__threading_support:474 + system_clock::time_point(duration_cast(duration)); + auto timeout_ms = duration_cast(abstime - system_clock::now()); + compnerd wrote: > halyavin wrote: > > Since negative timeou

[libcxx] r291174 - typeinfo: style adjustments for adding MS ABI RTTI

Author: compnerd Date: Thu Jan 5 15:22:22 2017 New Revision: 291174 URL: http://llvm.org/viewvc/llvm-project?rev=291174&view=rev Log: typeinfo: style adjustments for adding MS ABI RTTI This is motivated by adding a third RTTI scheme to libc++. Split out the two forms of the itanium RTTI represe

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

mgorny added a comment. Oh, sorry that I didn't check that. Then I guess it's good enough for me, we're losing just few old Athlon 64 CPUs, I guess. I'll update the patch to remove 4.2 only. https://reviews.llvm.org/D28304 ___ cfe-commits mailing

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse4.2 flag implicitly

mgorny retitled this revision from "[compiler-rt] [cmake] Disable appending -msse* flags implicitly" to "[compiler-rt] [cmake] Disable appending -msse4.2 flag implicitly". mgorny updated the summary for this revision. mgorny updated this revision to Diff 83298. https://reviews.llvm.org/D28304 F

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse4.2 flag implicitly

mgorny added a comment. @cryptoad good to go then? https://reviews.llvm.org/D28304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28242: [ubsan] Minimize size of data for type_mismatch (Redo of D19667)

vitalybuka added a comment. LGTM, but I am not the owner. https://reviews.llvm.org/D28242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291179 - Add vec_insert4b and vec_extract4b functions to altivec.h

Author: sfertile Date: Thu Jan 5 15:43:30 2017 New Revision: 291179 URL: http://llvm.org/viewvc/llvm-project?rev=291179&view=rev Log: Add vec_insert4b and vec_extract4b functions to altivec.h Add builtins for the functions and custom codegen mapping the builtins to their corresponding intrinsics

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

hamzasood updated this revision to Diff 83303. hamzasood added a comment. - Fixed an error in retrieving a toolchain path from the registry. - Updated the base revision. https://reviews.llvm.org/D28365 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/MSVCToolChain.cpp lib/Dr

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

amccarth added a comment. (I could be missing something because the diff doesn't have much context.) If I'm reading this right, it looks like it will no longer search the PATH in order to find cl.exe. If that's the case, then I'm mildly worried about this change in behavior. I know I have mul

Re: r291179 - Add vec_insert4b and vec_extract4b functions to altivec.h

Tests on linux/x86_64 are failing with: fatal error: error in backend: Cannot select: intrinsic %llvm.ppc.vsx.xxinsertw On Thu, Jan 5, 2017 at 1:43 PM, Sean Fertile via cfe-commits wrote: > Author: sfertile > Date: Thu Jan 5 15:43:30 2017 > New Revision: 291179 > > URL: http://llvm.org/viewvc/ll

r291184 - IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and CodeCompleteConsumer

Author: dblaikie Date: Thu Jan 5 16:19:11 2017 New Revision: 291184 URL: http://llvm.org/viewvc/llvm-project?rev=291184&view=rev Log: IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and CodeCompleteConsumer Modified: cfe/trunk/include/clang/Frontend/ASTUnit.h cfe/trunk/

[PATCH] D28231: -Wunreachable-code: Avoid multiple diagnostics that are triggered by the same source range and fix the unary operator fixit source range

ahatanak added inline comments. Comment at: lib/Analysis/ReachableCode.cpp:229 + if (SilenceableCondValNotSet && SilenceableCondVal->getBegin().isValid()) +*SilenceableCondVal = UO->getSourceRange(); + return UO->getOpcode() == UO_LNot && IsSubExprConfigValue; -

r291185 - Fix examples for recent shared_ptrification

Author: dblaikie Date: Thu Jan 5 16:36:44 2017 New Revision: 291185 URL: http://llvm.org/viewvc/llvm-project?rev=291185&view=rev Log: Fix examples for recent shared_ptrification Modified: cfe/trunk/examples/clang-interpreter/main.cpp Modified: cfe/trunk/examples/clang-interpreter/main.cpp U

[PATCH] D28381: [WebAssembly] Always inline atomics

jgravelle-google created this revision. jgravelle-google added reviewers: dschuff, sunfish. jgravelle-google added a subscriber: cfe-commits. Herald added a subscriber: jfb. Wasm MVP doesn't have any mechanism to respect atomicity. Skip emitting libcalls for the time being. https://reviews.llvm.

[clang-tools-extra] r291186 - Fix for shared_ptrification in Clang

Author: dblaikie Date: Thu Jan 5 16:44:07 2017 New Revision: 291186 URL: http://llvm.org/viewvc/llvm-project?rev=291186&view=rev Log: Fix for shared_ptrification in Clang Modified: clang-tools-extra/trunk/include-fixer/IncludeFixer.cpp clang-tools-extra/trunk/include-fixer/IncludeFixer.h

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( aaron.ballman wrote: > firolin

  1   2   >