dylanmckay added a comment.
Signed off by Jonathan Roelofs via cfe-commits
https://reviews.llvm.org/D27123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jan 4 23:18:37 2017
New Revision: 291081
URL: http://llvm.org/viewvc/llvm-project?rev=291081&view=rev
Log:
Fix test suite configuration when no lit.site.cfg is available
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config
Author: dylanmckay
Date: Wed Jan 4 23:20:27 2017
New Revision: 291082
URL: http://llvm.org/viewvc/llvm-project?rev=291082&view=rev
Log:
Add AVR target and toolchain to Clang
Summary:
Authored by Senthil Kumar Selvaraj
This patch adds barebones support in Clang for the (experimental) AVR target.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291082: Add AVR target and toolchain to Clang (authored by
dylanmckay).
Changed prior to commit:
https://reviews.llvm.org/D27123?vs=80721&id=83191#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Author: dylanmckay
Date: Wed Jan 4 23:31:12 2017
New Revision: 291083
URL: http://llvm.org/viewvc/llvm-project?rev=291083&view=rev
Log:
[AVR] Support r26 through r31 in inline assembly
These are synonyms for the X,Y, and Z registers.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/
dylanmckay created this revision.
dylanmckay added a reviewer: saaadhu.
dylanmckay added a subscriber: cfe-commits.
These do not match up with the register numbers defined in LLVM's
AVRRegisterInfo.td
Adding Senthil as a reviewer as he originally implemented this.
https://reviews.llvm.org/D2834
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This LGTM. I'm sure we can flush out any bugs once we get the tests running.
Repository:
rL LLVM
https://reviews.llvm.org/D28220
___
cfe-comm
EricWF added inline comments.
Comment at: include/typeinfo:75
+#elif defined(_WIN32)
+#define _LIBCPP_HAS_WINDOWS_TYPEINFO
+#else
compnerd wrote:
> rnk wrote:
> > Is _WIN32 the right condition? It seems like this is intended to match the
> > MS ABI RTTI structur
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D28131#632516, @vsk wrote:
> LGTM. I'm not sure what to do for a test. Have you tried checking the IR for
> the affected object fil
dylanmckay created this revision.
dylanmckay added a reviewer: jroelofs.
dylanmckay added subscribers: cfe-commits, saaadhu.
Previously the method would simply return false, causing every single
inline assembly constraint to trigger a compile error.
This adds inline assembly constraint support fo
Author: ericwf
Date: Thu Jan 5 00:06:18 2017
New Revision: 291087
URL: http://llvm.org/viewvc/llvm-project?rev=291087&view=rev
Log:
[libcxx] Fix PR31402: map::__find_equal_key has undefined behavior.
Summary:
This patch fixes llvm.org/PR31402 by replacing `map::__find_equal_key` with
`__tree::
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
I'm resigning as a reviewer. I suggested an alternative fix and explained why
this fix wasn't correct in a comment above.
Please re-add me as a reviewer if you disagree with my analysis.
https://revi
EricWF added inline comments.
Comment at: include/memory:1962
+#if _LIBCPP_STD_VER <= 14 || defined(_LIBCPP_NO_REMOVE_AUTOPTR)
template
I would love to have a semi-consistent naming scheme for macros which re-enable
removed C++17 features. Maybe `_LIBCPP_ENA
saaadhu added a comment.
If you've added X, Y, Z and SP to GCCRegNames, you don't need AddlRegNames
array at all,
The reason I had them in AddlRegNames was to tell Clang that they alias regs in
GCCRegNames. I followed X86TargetInfo's example - it has "ax" in GCCRegNames,
and "al", "ah", "eax"
Hahnfeld added a subscriber: cfe-commits.
Hahnfeld added a comment.
Otherwise SGTM
Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252
+ // \brief Flags associated the device global.
+ int32_t Flags;
+
Is that intentionally not in the `protected` sectio
I see, that's a good idea.
I'll revert r291083 and we can go forward with this patch.
On Thu, Jan 5, 2017 at 8:05 PM, Senthil Kumar Selvaraj via Phabricator <
revi...@reviews.llvm.org> wrote:
> saaadhu added a comment.
>
> If you've added X, Y, Z and SP to GCCRegNames, you don't need AddlRegName
Author: dylanmckay
Date: Thu Jan 5 01:17:46 2017
New Revision: 291090
URL: http://llvm.org/viewvc/llvm-project?rev=291090&view=rev
Log:
[AVR] Revert the functional part of r291083
As Senthil points out, this is unnecessary as we already have these
registers in AddlRegNames.
Modified:
cfe/tr
halyavin added inline comments.
Comment at: include/__threading_support:474
+
system_clock::time_point(duration_cast(duration));
+ auto timeout_ms = duration_cast(abstime - system_clock::now());
+
Since negative timeouts can't be avoided, we must make sure
201 - 218 of 218 matches
Mail list logo
