[PATCH] D28279: [clang-move] Support moving type alias declarations.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D28279 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/type_alias.h test/clang-move/move-type-alias.cpp unittests/clang-move/ClangMoveTests.cpp Index: un

[PATCH] D28222: [libcxx] Re-implement LWG 2770 again: Fix tuple_size to work with structured bindings

mpark accepted this revision. mpark added a reviewer: mpark. mpark added a comment. That was fun =D https://reviews.llvm.org/D28222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28220: provide Win32 native threading

halyavin added inline comments. Comment at: include/__threading_support:458 + __libcpp_mutex_reference&& __m, + timespec* __ts) +{ In posix, pthread_cond_timedwait uses absolute time but we use relative

[PATCH] D28279: [clang-move] Support moving type alias declarations.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg https://reviews.llvm.org/D28279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

ioeric created this revision. ioeric added a reviewer: hokein. ioeric added a subscriber: cfe-commits. https://reviews.llvm.org/D28282 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-namespace/ChangeNamespaceTests.cpp ==

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

alexshap added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:563 + // Create a replacement merely for retrieving file path and start offset. + const auto R = createReplacement(Start, Start, "", *Result.SourceManager); MoveNamespace MoveNs; ---

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

ioeric updated this revision to Diff 83024. ioeric marked an inline comment as done. ioeric added a comment. - Get rid of hacky replacement. https://reviews.llvm.org/D28282 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/chan

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

ioeric added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:563 + // Create a replacement merely for retrieving file path and start offset. + const auto R = createReplacement(Start, Start, "", *Result.SourceManager); MoveNamespace MoveNs;

[PATCH] D28246: clang-format: [JS] avoid indent after ambient function declarations.

mprobst updated this revision to Diff 83028. mprobst added a comment. - Handle type declarations. https://reviews.llvm.org/D28246 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp ==

[PATCH] D28286: [CodeCompletion] Code complete the missing C++11 keywords

arphaman created this revision. arphaman added reviewers: manmanren, akyrtzi. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds context sensitive code completion support for the C++11 keywords that currently don't have completion r

[PATCH] D28231: -Wunreachable-code: Avoid multiple diagnostics that are triggered by the same source range and fix the unary operator fixit source range

arphaman updated this revision to Diff 83032. arphaman added a comment. You're right, the fixit for `if (!s->p || 1)` is wrong, but that was another existing bug. The updated patch fixes this issue. Repository: rL LLVM https://reviews.llvm.org/D28231 Files: lib/Analysis/ReachableCode.cpp

[PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

jckooijman added a comment. Hi, this is my first time posting here so excuse me if i am giving you not enough information. I found this bugreport from: https://blog.yuo.be/2016/05/11/columns-ui-can-now-be-compiled-using-clang/ I am getting the exact same issue using clang-tidy e.g. C:\Progr

[PATCH] D28289: Fix tests with CLANG_DEFAULT_LINKER

Hahnfeld created this revision. Hahnfeld added reviewers: phosek, mgorny. Hahnfeld added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert. I originally requested this to be tested in https://reviews.llvm.org/D25263 but in the end forgot to make sure that it was done. http

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

alexshap added a comment. thx, LGTM https://reviews.llvm.org/D28282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28246: clang-format: [JS] avoid indent after ambient function declarations.

sammccall accepted this revision. sammccall added a reviewer: sammccall. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: unittests/Format/FormatTestJS.cpp:382 + "let x = 1;\n"); + verifyFormat("declare function foo(): s

[PATCH] D28246: clang-format: [JS] avoid indent after ambient function declarations.

mprobst updated this revision to Diff 83038. mprobst added a comment. - Handle type declarations. - test for object literal return types https://reviews.llvm.org/D28246 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp ===

r290959 - clang-format: [JS] avoid indent after ambient function declarations.

Author: mprobst Date: Wed Jan 4 07:36:43 2017 New Revision: 290959 URL: http://llvm.org/viewvc/llvm-project?rev=290959&view=rev Log: clang-format: [JS] avoid indent after ambient function declarations. Summary: Before: declare function foo(); let x = 1; After: declare function foo();

[PATCH] D28246: clang-format: [JS] avoid indent after ambient function declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290959: clang-format: [JS] avoid indent after ambient function declarations. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D28246?vs=83038&id=83039#toc Repository: rL LLVM

[PATCH] D28246: clang-format: [JS] avoid indent after ambient function declarations.

mprobst marked an inline comment as done. mprobst added inline comments. Comment at: unittests/Format/FormatTestJS.cpp:382 + "let x = 1;\n"); + verifyFormat("declare function foo(): string;\n" + "let x = 1;\n"); sammccall wrote: > May

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

This revision was automatically updated to reflect the committed changes. arphaman marked 5 inline comments as done. Closed by commit rL290960: Add -f[no-]strict-return flag that can be used to avoid undefined behaviour (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D

r290960 - Add -f[no-]strict-return flag that can be used to avoid undefined behaviour

Author: arphaman Date: Wed Jan 4 07:40:34 2017 New Revision: 290960 URL: http://llvm.org/viewvc/llvm-project?rev=290960&view=rev Log: Add -f[no-]strict-return flag that can be used to avoid undefined behaviour in non-void functions that fall off at the end without returning a value when compiling

[PATCH] D28229: [libcxx] Fix testing of the externally-threaded library build after r290850

rmaprath added a comment. In https://reviews.llvm.org/D28229#634278, @compnerd wrote: > I dont think that making Win32 threading an external one makes much sense > unless we also do the same for pthreads. Its just as valid a threading model > as pthreads, so why give preferential treatment to

[PATCH] D27478: Make ASTContext::getDeclAlign return the correct alignment for FunctionDecls

arphaman accepted this revision. arphaman added a reviewer: arphaman. arphaman added a comment. This revision is now accepted and ready to land. Thanks. LGTM, I think the patch makes sense. https://reviews.llvm.org/D27478 ___ cfe-commits mailing lis

Re: [PATCH] D27123: Add AVR target and toolchain to Clang

On 1/4/17 2:52 AM, Dylan McKay wrote: I've just raised a bug here https://llvm.org/bugs/show_bug.cgi?id=31530 > What's necessary for sign-off? Should I ping the reviewer (Richard Smith) again? I think so long as Richard or someone else who actively works on Clang signs off. Perhaps somebo

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM with some nits. Would be clearer to elaborate more descriptions in the commit message. Looks like the patch actually resolves newline character "\n" rather than whitespace...

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

ioeric updated this revision to Diff 83051. ioeric marked an inline comment as done. ioeric added a comment. - fix a nit. https://reviews.llvm.org/D28282 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-namespace/Change

[clang-tools-extra] r290966 - [change-namespace] get newlines around moved namespace right.

Author: ioeric Date: Wed Jan 4 08:49:08 2017 New Revision: 290966 URL: http://llvm.org/viewvc/llvm-project?rev=290966&view=rev Log: [change-namespace] get newlines around moved namespace right. Summary: Previously, a `\n` might be left in the old namespace and thus not copied to the new namespa

[PATCH] D28282: [change-namespace] get newlines around moved namespace right.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290966: [change-namespace] get newlines around moved namespace right. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D28282?vs=83051&id=83052#toc Repository: rL LLVM https:/

[PATCH] D28279: [clang-move] Support moving type alias declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290967: [clang-move] Support moving type alias declarations. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D28279?vs=83016&id=83053#toc Repository: rL LLVM https://reviews.

[clang-tools-extra] r290967 - [clang-move] Support moving type alias declarations.

Author: hokein Date: Wed Jan 4 08:50:49 2017 New Revision: 290967 URL: http://llvm.org/viewvc/llvm-project?rev=290967&view=rev Log: [clang-move] Support moving type alias declarations. Reviewers: ioeric Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D28279 Added:

[PATCH] D28257: [OpenCL] Re-enable supported core extensions based on opencl version when disabling all extensions using pragma

Anastasia added inline comments. Comment at: test/SemaOpenCL/extensions.cl:47 +#ifndef _OPENCL_H_ int isnan(float x) { Why do you need this? https://reviews.llvm.org/D28257 ___ cfe-commits mailing list cfe-commi

Re: [PATCH] D27123: Add AVR target and toolchain to Clang

Did you get the BugZilla account sorted Senthil? On Thu, Dec 22, 2016 at 10:47 AM, Nico Weber wrote: > On Wed, Dec 21, 2016 at 6:42 AM, Senthil Kumar Selvaraj via Phabricator > via cfe-commits wrote: > >> saaadhu added a comment. >> >> Would someone with a llvm bugzilla account please file the

Re: [PATCH] D27123: Add AVR target and toolchain to Clang

I've just raised a bug here https://llvm.org/bugs/show_bug.cgi?id=31530 > What's necessary for sign-off? Should I ping the reviewer (Richard Smith) again? I think so long as Richard or someone else who actively works on Clang signs off. Perhaps somebody else is keen to review? On the other hand

[PATCH] D28287: [clang-tidy] Ignore default arguments in modernize-default-member-init

aaron.ballman added a comment. Btw, when creating a patch, it's helpful to the reviewers (especially ones who are only casually interested) to put some of the context from the bug report into the patch summary rather than only list the PR. Comment at: clang-tidy/modernize/Use

r290968 - Fix a buildbot failure introduced by r290960.

Author: arphaman Date: Wed Jan 4 09:07:13 2017 New Revision: 290968 URL: http://llvm.org/viewvc/llvm-project?rev=290968&view=rev Log: Fix a buildbot failure introduced by r290960. The commit r290960 checked the the basic block label name which isn't there when clang is compiled in release mode.

[PATCH] D28287: [clang-tidy] Ignore default arguments in modernize-default-member-init

malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:161 cxxBoolLiteral(), cxxNullPtrLiteralExpr(), implicitValueInitExpr(), -declRefExpr()); +declRefExpr(unless(to(varDecl();

[PATCH] D28293: [clang-move] Dump enum and type alias declarations.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D28293 Files: clang-move/ClangMove.cpp unittests/clang-move/ClangMoveTests.cpp Index: unittests/clang-move/ClangMoveTests.cpp =

[PATCH] D28287: [clang-tidy] Ignore default arguments in modernize-default-member-init

malcolm.parsons updated this revision to Diff 83056. malcolm.parsons added a comment. Only match DeclRefExprs to EnumConstantDecls. https://reviews.llvm.org/D28287 Files: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp test/clang-tidy/modernize-use-default-member-init.cpp Index: test/c

[PATCH] D28287: [clang-tidy] Ignore default arguments in modernize-default-member-init

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:161 cxxBoolLiteral(), cxxNullPtrLiteralExpr(), implicitValueInitExpr(), -declRefExpr()); +declRefExpr(unless(to(varDecl(); --

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

aaron.ballman added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( firolino wrote: > aaron.b

[PATCH] D28295: [libunwind] [cmake] Support overriding LLVM_CMAKE_PATH

mgorny created this revision. mgorny added reviewers: mclow.lists, beanz, phosek, EricWF. mgorny added a subscriber: cfe-commits. Make LLVM_CMAKE_PATH a cache variable in order to support user overrides. This is useful when building multiple multilib variants of libunwind using CMake files from a

[PATCH] D28271: [Sema] Get rid of unused default argument to Sema::CheckCallingConvAttr.

rnk added a comment. I think you've discovered this bug: struct F { void __attribute__((pcs("aapcs"))) f(); }; void __attribute__((pcs("aapcs"))) F::f() {} Clang ignores the pcs convention on 32-bit x86, and because we don't have an FD here, we choose the wrong default calling convention (n

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

mcrosier added inline comments. Comment at: include/clang/Driver/Options.td:1731 def mno_pie_copy_relocations : Flag<["-"], "mno-pie-copy-relocations">, Group; +def mfentry : Flag<["-"], "mfentry">, HelpText<"insert calls to fentry at function entry">, Flags<[CC1Option]>, Grou

[PATCH] D28274: [MS] Instantiate default args during instantiation of exported default ctors

rnk updated this revision to Diff 83059. rnk added a comment. simplify https://reviews.llvm.org/D28274 Files: lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp test/CodeGenCXX/dllexport.cpp test/SemaCXX/default-arg-closures.cpp test/SemaCXX/dllexport.cpp Index: test/S

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

mcrosier added inline comments. Comment at: test/CodeGen/fentry.c:11 + +//HAS: attributes #{{[0-9]+}} = { {{.*}}"fentry-call"="true"{{.*}} } +//NOHAS-NOT: attributes #{{[0-9]+}} = { {{.*}}"fentry-call"{{.*}} } mcrosier wrote: > I'd prefer we stick with the defaul

[PATCH] D28166: Properly merge K&R functions that have attributes

rnk added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11958-11962 +// The type location may be attributed; strip the attributes to get to +// the function type location. +while (auto ATL = TL.getAs()) { + TL = ATL.getModifiedLoc(); +

[PATCH] D28296: [ObjC] The declarator for a block literal should be a definition

arphaman created this revision. arphaman added reviewers: bruno, ahatanak. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This avoids the -Wstrict-prototypes warning for block literals with an empty or without argument lists. Repository: rL

[PATCH] D28297: [StaticAnalyzer] Fix crash in CastToStructChecker

danielmarjamaki created this revision. danielmarjamaki added a reviewer: NoQ. danielmarjamaki added a subscriber: cfe-commits. danielmarjamaki set the repository for this revision to rL LLVM. This fix the crash reported in https://llvm.org/bugs/show_bug.cgi?id=31173 Repository: rL LLVM https:

[PATCH] D28166: Properly merge K&R functions that have attributes

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11958-11962 +// The type location may be attributed; strip the attributes to get to +// the function type location. +while (auto ATL = TL.getAs()) { + TL = ATL.getModifiedLoc()

[PATCH] D28220: provide Win32 native threading

rnk added inline comments. Comment at: include/__threading_support:44 +#define WIN32_LEAN_AND_MEAN +#define VC_EXTRA_LEAN +#include kimgr wrote: > EricWF wrote: > > compnerd wrote: > > > EricWF wrote: > > > > Do these definitions have any affect when `` has alre

[PATCH] D28287: [clang-tidy] Ignore default arguments in modernize-default-member-init

malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:161 cxxBoolLiteral(), cxxNullPtrLiteralExpr(), implicitValueInitExpr(), -declRefExpr()); +declRefExpr(unless(to(varDecl();

[PATCH] D28287: [clang-tidy] Ignore default arguments in modernize-default-member-init

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:161 cxxBoolLiteral(), cxxNullPtrLiteralExpr(), implicitValueInitExpr(), -declRefExpr()); +declRefExpr(unless(to(varDecl(); --

[PATCH] D28287: [clang-tidy] Ignore default arguments in modernize-default-member-init

malcolm.parsons added inline comments. Comment at: test/clang-tidy/modernize-use-default-member-init.cpp:224 +struct NegativeDefaultArg +{ aaron.ballman wrote: > Can we also have a positive test with an enumerator? See lines 159-166. https://reviews.llvm.org/

[PATCH] D28287: [clang-tidy] Ignore default arguments in modernize-default-member-init

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: test/clang-tidy/modernize-use-default-member-init.cpp:224 +struct NegativeDefaultArg +{ malcolm.parsons wrote: > aaron.ball

[PATCH] D27486: Correct class-template deprecation behavior

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:301 bit DuplicatesAllowedWhileMerging = 0; + // Set to true if this attribute should apply to template declaration, + // remains false if this should only be applied on definition.

[clang-tools-extra] r290972 - [clang-tidy] Ignore default arguments in modernize-default-member-init

Author: malcolm.parsons Date: Wed Jan 4 11:33:55 2017 New Revision: 290972 URL: http://llvm.org/viewvc/llvm-project?rev=290972&view=rev Log: [clang-tidy] Ignore default arguments in modernize-default-member-init Summary: Default member initializers cannot refer to constructor parameters, but mo

[PATCH] D28287: [clang-tidy] Ignore default arguments in modernize-default-member-init

This revision was automatically updated to reflect the committed changes. Closed by commit rL290972: [clang-tidy] Ignore default arguments in modernize-default-member-init (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D28287?vs=83056&id=83066#toc Repository:

[PATCH] D28287: [clang-tidy] Ignore default arguments in modernize-default-member-init

malcolm.parsons added a comment. In https://reviews.llvm.org/D28287#635442, @aaron.ballman wrote: > LGTM! Thanks! Repository: rL LLVM https://reviews.llvm.org/D28287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

manmanren updated this revision to Diff 83068. manmanren added a comment. Addressing review comments! I still need to measure the performance impact of calculating the hash then decide how to enable this. https://reviews.llvm.org/D27689 Files: include/clang/AST/ExternalASTSource.h include

[PATCH] D28212: typeinfo: provide a partial implementation for Win32

rnk added inline comments. Comment at: include/typeinfo:75 +#elif defined(_WIN32) +#define _LIBCPP_HAS_WINDOWS_TYPEINFO +#else Is _WIN32 the right condition? It seems like this is intended to match the MS ABI RTTI structure, not the Itanium one. _MSC_VER maybe?

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

manmanren created this revision. manmanren added reviewers: rsmith, benlangmuir, dexonsmith. manmanren added subscribers: cfe-commits, bruno. We create a PCMCache class to manage memory buffers associated with pcm files. With implicit modules, we currently use lock files to make sure we are makin

[PATCH] D28301: [CUDA] Pre-include sm_60 and sm_61 headers.

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. CUDA-8.0 comes with new headers which nvcc pre-includes via cuda_runtime.h Clang now makes them available as well. https://reviews.llvm.org/D28301 Files: lib/Headers/__clang_cuda_runtime_wrapper.h

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane marked 6 inline comments as done. erichkeane added a comment. All Aaron's comments addressed in a patch that is on its way! Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:320 +CXXRecordDecl *ThisContext = +dyn_cast_or_null(ND->getDeclContext()); +

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane updated this revision to Diff 83072. erichkeane marked 2 inline comments as done. erichkeane added a comment. Updated based on Aarons comments. https://reviews.llvm.org/D27486 Files: include/clang/Basic/Attr.td include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp lib/Sema/Sema

[libcxx] r290976 - Implement the last bit of P0031: 'A Proposal to Add Constexpr Modifiers to reverse_iterator, move_iterator, array and Range Access' for C++17

Author: marshall Date: Wed Jan 4 11:58:17 2017 New Revision: 290976 URL: http://llvm.org/viewvc/llvm-project?rev=290976&view=rev Log: Implement the last bit of P0031: 'A Proposal to Add Constexpr Modifiers to reverse_iterator, move_iterator, array and Range Access' for C++17 Modified: libcx

[PATCH] D28212: typeinfo: provide a partial implementation for Win32

compnerd added inline comments. Comment at: include/typeinfo:75 +#elif defined(_WIN32) +#define _LIBCPP_HAS_WINDOWS_TYPEINFO +#else rnk wrote: > Is _WIN32 the right condition? It seems like this is intended to match the MS > ABI RTTI structure, not the Itanium o

[PATCH] D26034: [CodeCompletion] Block property setters: Use dynamic priority heuristic

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman Repository: rL LLVM https://reviews.llvm.org/D26034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D28257: [OpenCL] Re-enable supported core extensions based on opencl version when disabling all extensions using pragma

kzhuravl added inline comments. Comment at: test/SemaOpenCL/extensions.cl:47 +#ifndef _OPENCL_H_ int isnan(float x) { Anastasia wrote: > Why do you need this? `isnan` and `isfinite` are declared in opencl-c.h, so without guards I am getting redeclation diagno

[PATCH] D27486: Correct class-template deprecation behavior

aaron.ballman added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:322 + CXXThisScopeRAII ThisScope(*this, ThisContext, /*TypeQuals*/ 0, + ND && ND->isCXXInstanceMember()); + No need to check for `ND` he

r290979 - Accept and ignore -Wa, -mbig-obj on COFF targets for gas compatibility

Author: rnk Date: Wed Jan 4 12:16:32 2017 New Revision: 290979 URL: http://llvm.org/viewvc/llvm-project?rev=290979&view=rev Log: Accept and ignore -Wa,-mbig-obj on COFF targets for gas compatibility LLVM's integrated assembler will automatically switch to big objects when there are more than 2**

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane updated this revision to Diff 83081. erichkeane marked 3 inline comments as done. erichkeane added a comment. Aaron's new comments https://reviews.llvm.org/D27486 Files: include/clang/Basic/Attr.td include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp lib/Sema/SemaTemplateInsta

[PATCH] D28271: [Sema] Get rid of unused default argument to Sema::CheckCallingConvAttr.

jlebar added a comment. Thanks for the review, Reid. https://reviews.llvm.org/D28271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28271: [Sema] Get rid of unused default argument to Sema::CheckCallingConvAttr.

jlebar abandoned this revision. jlebar added a comment. > I think you've discovered this bug: Hm, I guess this is a step in the wrong direction, then. (I spun this patch after writing some code in this function that assumed I'd get a FunctionDecl where appropriate, which of course doesn't work.

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane added a comment. Marking Aaron's comments done. https://reviews.llvm.org/D27486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

mgorny created this revision. mgorny added reviewers: cryptoad, kcc, samsonov. mgorny added a subscriber: cfe-commits. Herald added subscribers: dberris, kubabrecka. Disable the code appending -msse3 and -msse4.2 flags implicitly when the compiler supports them. The compiler support for those flag

[PATCH] D27486: Correct class-template deprecation behavior

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but you should wait for @rsmith to sign off as well. https://reviews.llvm.org/D27486 ___ cfe-commits mailing list cfe-co

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane added a comment. Thanks for your help here Aaron. I agree about waiting for @rsmith, thanks! https://reviews.llvm.org/D27486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D28301: [CUDA] Pre-include sm_60 and sm_61 headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290982: [CUDA] Pre-include sm_60 and sm_61 headers. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D28301?vs=83071&id=83083#toc Repository: rL LLVM https://reviews.llvm.org/D28

r290982 - [CUDA] Pre-include sm_60 and sm_61 headers.

Author: tra Date: Wed Jan 4 12:39:29 2017 New Revision: 290982 URL: http://llvm.org/viewvc/llvm-project?rev=290982&view=rev Log: [CUDA] Pre-include sm_60 and sm_61 headers. CUDA-8.0 comes with new headers which nvcc pre-includes via cuda_runtime.h Clang now makes them available as well. Differe

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

cryptoad added a comment. Hey Michal, If I understand correctly, my next move is to move the CRC32 code into it's own file an only enable SSE 4.2 for this file? Shouldn't COMPILER_RT_HAS_MSSE4_2_FLAG be kept for that purpose or is there an alternative way to do it? Thanks https://reviews.llvm.

r290983 - [OpenMP] Update target codegen for NVPTX device.

Author: arpith Date: Wed Jan 4 12:44:50 2017 New Revision: 290983 URL: http://llvm.org/viewvc/llvm-project?rev=290983&view=rev Log: [OpenMP] Update target codegen for NVPTX device. This patch includes updates for codegen of the target region for the NVPTX device. It moves initializers from the c

[PATCH] D28125: [OpenMP] Update target codegen for NVPTX device.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290983: [OpenMP] Update target codegen for NVPTX device. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D28125?vs=82621&id=83085#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

rnk added inline comments. Comment at: include/clang/CodeGen/CGFunctionInfo.h:136 } + static ABIArgInfo getDirectHva(llvm::Type *T = nullptr) { +auto AI = getDirect(T); Marking HVAs with inreg is an x86-specific convention. Let's move this down to Target

[PATCH] D28306: Remove fixme, use ASTContext::getCanonicalTemplateSpecializationType

v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D28306 Files: lib/Sema/SemaTemplate.cpp Index: lib/Sema/SemaTe

r290984 - Use -### so the mbig-obj.c test passes when there is no registered x86 target

Author: rnk Date: Wed Jan 4 12:50:51 2017 New Revision: 290984 URL: http://llvm.org/viewvc/llvm-project?rev=290984&view=rev Log: Use -### so the mbig-obj.c test passes when there is no registered x86 target Modified: cfe/trunk/test/Driver/mbig-obj.c Modified: cfe/trunk/test/Driver/mbig-obj.

[PATCH] D28271: [Sema] Get rid of unused default argument to Sema::CheckCallingConvAttr.

rnk added a comment. In general we can't get an FD here because we might be in the middle of parsing the declarator. The calls from SemaType.cpp in particular can't actually provide one. They would have to thread through the IsVariadic and IsCXXMethod bools based on syntactic cues (the ellipsis

[PATCH] D22275: Support -fno-delayed-template-parsing in clang-cl.exe

rnk commandeered this revision. rnk edited reviewers, added: DaveBartolomeo; removed: rnk. rnk added a comment. Looks good, let me grab this and add a test. I think this just got lost in the shuffle over the summer. https://reviews.llvm.org/D22275

r290989 - Reverting commit r290983 while debugging test failure on windows.

Author: arpith Date: Wed Jan 4 13:14:43 2017 New Revision: 290989 URL: http://llvm.org/viewvc/llvm-project?rev=290989&view=rev Log: Reverting commit r290983 while debugging test failure on windows. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp cfe/trunk/lib/CodeGen/CGOpenMPRu

r290990 - Support -fno-delayed-template-parsing in clang-cl.exe

Author: rnk Date: Wed Jan 4 13:15:53 2017 New Revision: 290990 URL: http://llvm.org/viewvc/llvm-project?rev=290990&view=rev Log: Support -fno-delayed-template-parsing in clang-cl.exe Summary: This change adds support for the -fno-delayed-template-parsing option in clang-cl.exe. This allows devel

[PATCH] D22275: Support -fno-delayed-template-parsing in clang-cl.exe

This revision was automatically updated to reflect the committed changes. Closed by commit rL290990: Support -fno-delayed-template-parsing in clang-cl.exe (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D22275?vs=63713&id=83091#toc Repository: rL LLVM https://reviews.ll

r290991 - [Sema] Replace remove_if+erase with erase_if. NFC.

Author: gbiv Date: Wed Jan 4 13:16:29 2017 New Revision: 290991 URL: http://llvm.org/viewvc/llvm-project?rev=290991&view=rev Log: [Sema] Replace remove_if+erase with erase_if. NFC. Modified: cfe/trunk/lib/Sema/SemaCUDA.cpp cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

erichkeane marked 3 inline comments as done. erichkeane added a comment. patch incoming Comment at: include/clang/CodeGen/CGFunctionInfo.h:139 +AI.setInReg(true); +AI.setCanBeFlattened(false); +return AI; rnk wrote: > In the long run, I think ABIArg

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

erichkeane updated this revision to Diff 83092. erichkeane marked an inline comment as done. erichkeane added a comment. Reid's comments https://reviews.llvm.org/D27529 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/vectorcall.c test/CodeGenCXX/homogeneous-aggregates.cpp Index: lib/CodeG

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

rnk added a comment. Last thing, I promise. Comment at: lib/CodeGen/TargetInfo.cpp:1678 bool UsedInAlloca = false; - for (auto &I : FI.arguments()) { -I.info = classifyArgumentType(I.type, State); -UsedInAlloca |= (I.info.getKind() == ABIArgInfo::InAlloca); + if (S

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

erichkeane marked 2 inline comments as done. erichkeane added a comment. Good idea, building now! https://reviews.llvm.org/D27529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28226: threading_support: introduce __libcpp_recursive_mutex_t

compnerd added a comment. Im not tied to this approach. I really want to get @mclow.lists or @EricWF to weigh in as to which approach they prefer (new interfaces or the wrapper, or even a new approach). Repository: rL LLVM https://reviews.llvm.org/D28226

r290996 - Factor out duplicated code and simplify.

Author: rsmith Date: Wed Jan 4 13:47:19 2017 New Revision: 290996 URL: http://llvm.org/viewvc/llvm-project?rev=290996&view=rev Log: Factor out duplicated code and simplify. No functionality change intended. Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp cfe/trunk/test/SemaCXX/cx

r290997 - Revert accidentally-committed file.

Author: rsmith Date: Wed Jan 4 13:48:07 2017 New Revision: 290997 URL: http://llvm.org/viewvc/llvm-project?rev=290997&view=rev Log: Revert accidentally-committed file. Modified: cfe/trunk/test/SemaCXX/cxx0x-initializer-stdinitializerlist.cpp Modified: cfe/trunk/test/SemaCXX/cxx0x-initialize

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

mgorny added a comment. In https://reviews.llvm.org/D28304#635620, @cryptoad wrote: > Hey Michal, > If I understand correctly, my next move is to move the CRC32 code into it's > own file an only enable SSE 4.2 for this file? Yes, like that. Have a SSE4.2 CRC32 function in a separate file, and

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

kbarton added a comment. Sorry, I don't have time to go through the entire patch in detail right now. But I did notice several places where the lines are too long, which need to get fixed. Comment at: lib/Headers/altivec.h:14206

  1   2   3   >