r290146 - Fix completely bogus types for some builtins:

2016-12-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Dec 19 17:59:34 2016 New Revision: 290146 URL: http://llvm.org/viewvc/llvm-project?rev=290146&view=rev Log: Fix completely bogus types for some builtins: * In C++, never create a FunctionNoProtoType for a builtin (fixes C++1z crasher from r289754). * Fix type of __s

Re: r289754 - [c++1z] Permit constant evaluation of a call through a function pointer whose

2016-12-19 Thread Richard Smith via cfe-commits
On 19 December 2016 at 13:22, Mike Aizatsky wrote: > Richard, > > Clang crashes for me on this code while doing "check-all". This change > seems to introduce the assert. Can you take a look? > > BTW I'm not sure why bots are green. Do we build libcxx with bootstrap > compiler? > Apparently not i

[Diffusion] rL290025: [libclang] Remove the 'extern "C"' blocks from the implementation files.

2016-12-19 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni added subscribers: cfe-commits, chapuni. chapuni added a comment. See r290113. I saw linker error on mingw dll build. Cannot export clang_findIncludesInFileWithBlock: symbol not defined Cannot export clang_findReferencesInFileWithBlock: symbol not defined Cannot export clang_visitC

Re: r290146 - Fix completely bogus types for some builtins:

2016-12-19 Thread Friedman, Eli via cfe-commits
On 12/19/2016 3:59 PM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Mon Dec 19 17:59:34 2016 New Revision: 290146 URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/vfprintf-valid-redecl.c?rev=290146&r1=290145&r2=290146&view=diff ==

r290149 - Add the alloc_size attribute to clang.

2016-12-19 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Mon Dec 19 19:05:42 2016 New Revision: 290149 URL: http://llvm.org/viewvc/llvm-project?rev=290149&view=rev Log: Add the alloc_size attribute to clang. This patch does three things: - Gives us the alloc_size attribute in clang, which lets us infer the number of bytes handed b

[PATCH] D14274: Add alloc_size attribute to clang

2016-12-19 Thread George Burgess IV via Phabricator via cfe-commits
george.burgess.iv marked an inline comment as done. george.burgess.iv added a comment. Thanks, everyone! :) Repository: rL LLVM https://reviews.llvm.org/D14274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D14274: Add alloc_size attribute to clang

2016-12-19 Thread George Burgess IV via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL290149: Add the alloc_size attribute to clang. (authored by gbiv). Changed prior to commit: https://reviews.llvm.org/D14274?vs=77222&id=82046#toc Repository: rL LLVM https://reviews.llvm.org/D14274

[PATCH] D26410: [CodeGen] Don't emit the same global block multiple times.

2016-12-19 Thread George Burgess IV via Phabricator via cfe-commits
george.burgess.iv abandoned this revision. george.burgess.iv added a comment. Committed in https://reviews.llvm.org/rL290149. Thanks again! https://reviews.llvm.org/D26410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: Regression caused by r276159 - [modules] Don't emit initializers for VarDecls within a module eagerly whenever

2016-12-19 Thread Manman via cfe-commits
> On Dec 14, 2016, at 1:20 PM, Manman wrote: > > >> On Jul 20, 2016, at 12:10 PM, Richard Smith via cfe-commits >> wrote: >> >> Author: rsmith >> Date: Wed Jul 20 14:10:16 2016 >> New Revision: 276159 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=276159&view=rev >> Log: >> [modules] Do

Buildbot numbers for the week of 12/04/2016 - 12/10/2016

2016-12-19 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 12/04/2016 - 12/10/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

buildbot numbers for the week of 12/11/2016 - 12/17/2016

2016-12-19 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the last week of 12/11/2016 - 12/17/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

Re: r289996 - IRGen: Fix assertion failure when creating debug info for an integer constant wider than 64 bits.

2016-12-19 Thread Adrian Prantl via cfe-commits
> On Dec 16, 2016, at 2:10 PM, Peter Collingbourne via cfe-commits > wrote: > > Author: pcc > Date: Fri Dec 16 16:10:52 2016 > New Revision: 289996 > > URL: http://llvm.org/viewvc/llvm-project?rev=289996&view=rev > Log: > IRGen: Fix assertion failure when creating debug info for an integer con

r290155 - Update for LLVM global variable debug info API change.

2016-12-19 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Dec 19 20:10:02 2016 New Revision: 290155 URL: http://llvm.org/viewvc/llvm-project?rev=290155&view=rev Log: Update for LLVM global variable debug info API change. This reapplies r289921. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebu

r290156 - [Parser] Correct typo after lambda capture initializer is parsed.

2016-12-19 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Mon Dec 19 20:11:29 2016 New Revision: 290156 URL: http://llvm.org/viewvc/llvm-project?rev=290156&view=rev Log: [Parser] Correct typo after lambda capture initializer is parsed. This patch fixes an assertion that is triggered when RecordLayoutBuilder tries to compute the si

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

2016-12-19 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL290156: [Parser] Correct typo after lambda capture initializer is parsed. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D25206?vs=75819&id=82052#toc Repository: rL LLVM h

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

2016-12-19 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added inline comments. Comment at: llvm/include/llvm/ADT/APFloat.h:800 - void makeLargest(bool Neg) { getIEEE().makeLargest(Neg); } + void makeLargest(bool Neg) { +if (usesLayout(getSemantics())) { jtony wrote: > I know it is allowed to return

[PATCH] D26530: Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'.

2016-12-19 Thread Chandler Carruth via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL290159: Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'. (authored by chandlerc). Changed prior to commit: https://reviews.llvm.org/D26530?vs=81008&id=82055#toc Repository:

r290159 - Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'.

2016-12-19 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Dec 19 20:43:58 2016 New Revision: 290159 URL: http://llvm.org/viewvc/llvm-project?rev=290159&view=rev Log: Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'. The latter agrees with most existing diagnostics and the C and C++ standards. Diff

[PATCH] D21113: Add support for case-insensitive header lookup

2016-12-19 Thread Francisco Lopes da Silva via Phabricator via cfe-commits
francisco.lopes added a comment. I'm waiting for this to land as well, it's crucial for coding windows code with libclang assistance on a linux machine. https://reviews.llvm.org/D21113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D21113: Add support for case-insensitive header lookup

2016-12-19 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added inline comments. Comment at: lib/Basic/VirtualFileSystem.cpp:483 +CaseInsensitiveFileSystem::openFileForRead(const Twine &Path) { + SmallVector NewPath; + if (std::error_code EC = findCaseInsensitivePath(Path.str(), NewPath)) I wonder whether it would

[PATCH] D27153: [libc++] Make __num_get_float hidden

2016-12-19 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Ping. https://reviews.llvm.org/D27153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26949: [libc++abi] Clean up visibility

2016-12-19 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Ping. https://reviews.llvm.org/D26949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

2016-12-19 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai requested a review of this revision. smeenai added a comment. Actually, I think this can stand on its own. I'll do the extern template fixes in another diff. Also, ping :) https://reviews.llvm.org/D25208 ___ cfe-commits mailing list cfe-co

[PATCH] D27430: [libc++] Annotate template methods with visibility

2016-12-19 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai requested a review of this revision. smeenai added a comment. I think this actually stands well on its own. I'll do the extern template annotations in a different diff. Also, ping :) https://reviews.llvm.org/D27430 ___ cfe-commits mailing

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

2016-12-19 Thread David Blaikie via cfe-commits
I don't know much about who owns this sort of code, nor Vassil's work/responsibility in this area - but if he's OK with it/feels able to sign off on it, that'd be sufficient/fine by me (& others closer to it can pipe up if he seems like not the right person to approve). Thanks! - Dave On Mon, Dec

Re: [PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

2016-12-19 Thread David Blaikie via cfe-commits
On Mon, Dec 19, 2016 at 9:39 AM Sean Callanan wrote: > That would require making LLDB crash and collecting the relevant crash log > data out of the user's own logs. This isn't impossible – but additionally > the generation of that log is asynchronous and you don't quite know when > it'll land. >

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

2016-12-19 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. Thanks all for the review. Comment at: cfe/trunk/test/SemaCXX/lambda-expressions.cpp:572 +void foo1() { + auto s0 = S1{[name=]() {}}; // expected-error 2 {{expected expression}} + auto s1 = S1{[name=name]() {}}; // expected-error {{use of undeclared

[PATCH] D27971: Make FormatStyle.GetStyleOfFile test work on MSVC

2016-12-19 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano created this revision. amaiorano added reviewers: klimek, djasper, hans, cfe-commits. This is more a workaround than a real fix. The real problem is that FS.addFile uses clang::vfs::FileSystem::makeAbsolute to convert the input path to an absolute path, while getStyle uses llvm::sys::f

r290166 - Add test for DR692.

2016-12-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Dec 20 01:24:53 2016 New Revision: 290166 URL: http://llvm.org/viewvc/llvm-project?rev=290166&view=rev Log: Add test for DR692. Modified: cfe/trunk/test/CXX/drs/dr6xx.cpp Modified: cfe/trunk/test/CXX/drs/dr6xx.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/t

<    1   2