LLVM buildmaster will be restarted tonight

2016-12-16 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 5 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

2016-12-16 Thread Tim Shen via Phabricator via cfe-commits
timshen created this revision. timshen added reviewers: hfinkel, kbarton, iteratee, echristo. timshen added subscribers: llvm-commits, cfe-commits. Herald added subscribers: nemanjai, mehdi_amini. This patch changes the layout of DoubleAPFloat, and adjust all operations to do either: 1. (IEEEdoub

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

2016-12-16 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added inline comments. Comment at: llvm/include/llvm/ADT/APFloat.h:773 + return U.IEEE.makeZero(Neg); +} else if (usesLayout(getSemantics())) { + return U.Double.makeZero(Neg); You don't need else after return. https://reviews.llvm.org/D2

Re: r289995 - [libclang] Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType

2016-12-16 Thread Argyrios Kyrtzidis via cfe-commits
Looking into.. > On Dec 16, 2016, at 3:13 PM, Yung, Douglas wrote: > > Hi, this change seems to be causing the PS4 Windows build bot to be red, can > you take a look? > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/2784 > > C:\PROGRA~2\MICROS~1.0\

Re: r289995 - [libclang] Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType

2016-12-16 Thread Argyrios Kyrtzidis via cfe-commits
Yes, I see, thanks Reid! I’d just remove the 'extern "C” {‘ from the cpp file, which is not really necessary, I’ll do it in a subsequent commit anyway. > On Dec 16, 2016, at 4:48 PM, Yung, Douglas wrote: > > I think Reid already fixed the problem in r290009. > > Douglas Yung > >> -Origin

[PATCH] D27836: Store the "current position" index within the ASTRecordReader.

2016-12-16 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. I like moving `Idx` into the reader, but I have mixed feelings about the iterator-like interface. For consistency with the rest of the `ASTRecordReader` interface, and with how we model the writer side, I think perhaps `Record.ReadInt()` would fit better than using `*Rec

r290023 - [analyzer] UnixAPIChecker: Don't diagnose for functions in C++ namespaces

2016-12-16 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Fri Dec 16 19:08:17 2016 New Revision: 290023 URL: http://llvm.org/viewvc/llvm-project?rev=290023&view=rev Log: [analyzer] UnixAPIChecker: Don't diagnose for functions in C++ namespaces Update the UnixAPIChecker to not diagnose for calls to functions that are declared in C

r290025 - [libclang] Remove the 'extern "C"' blocks from the implementation files.

2016-12-16 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Fri Dec 16 19:09:40 2016 New Revision: 290025 URL: http://llvm.org/viewvc/llvm-project?rev=290025&view=rev Log: [libclang] Remove the 'extern "C"' blocks from the implementation files. These are unnecessary, the declarations already carry the 'extern C' property, and if

Re: [libcxx] r289963 - [CMake] Put headers relative to clang

2016-12-16 Thread Evgenii Stepanov via cfe-commits
Hi, this is using LLVM_BINARY_DIR when NOT LIBCXX_USING_INSTALLED_LLVM. HandleOutOfTreeLLVM.cmake defines LLVM_BINARY_DIR only when LIBCXX_USING_INSTALLED_LLVM. Is it supposed to come from the user cmake arguments? This broke sanitizer tests on Linux (check-tsan, check-msan). See add_custom_libc

Re: [libcxx] r289963 - [CMake] Put headers relative to clang

2016-12-16 Thread Evgenii Stepanov via cfe-commits
FTR, buildbot logs: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/2585/steps/test%20tsan%20in%20debug%20compiler-rt%20build/logs/stdio External project cmake error log: CMake Error at include/CMakeLists.txt:15 (file): file COPY cannot make directory "/include/c++/v1

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

2016-12-16 Thread Tony Jiang via Phabricator via cfe-commits
jtony added inline comments. Comment at: llvm/include/llvm/ADT/APFloat.h:800 - void makeLargest(bool Neg) { getIEEE().makeLargest(Neg); } + void makeLargest(bool Neg) { +if (usesLayout(getSemantics())) { I know it is allowed to return a void function call

<    1   2