[PATCH] D27754: [clang-format] Implement comment reflowing (again).

2016-12-14 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: lib/Format/BreakableToken.cpp:471 + WhitespaceManager &Whitespaces) { + if (Tok.is(TT_LineComment)) { +// If this is the first line of a token, inform Whitespace Manager about it. -

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

2016-12-14 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons added a comment. In https://reviews.llvm.org/D27166#622103, @Prazek wrote: > There is still one more problem: > > /home/prazek/llvm/lib/Analysis/ScalarEvolution.cpp:2442:11: warning: use > auto when initializing with a template cast to avoid duplicating the type > name [modern

[PATCH] D27744: Create SampleProfileLoader pass in llvm instead of clang

2016-12-14 Thread Diego Novillo via Phabricator via cfe-commits
dnovillo accepted this revision. dnovillo added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D27744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

2016-12-14 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons updated this revision to Diff 81377. malcolm.parsons added a comment. Use qualType(hasDescendant(autoType())) to fix skipping of declarations that are already using auto. https://reviews.llvm.org/D27166 Files: clang-tidy/modernize/UseAutoCheck.cpp docs/ReleaseNotes.rst doc

[PATCH] D27123: Add AVR target and toolchain to Clang

2016-12-14 Thread Jonathan Roelofs via Phabricator via cfe-commits
jroelofs added a comment. In https://reviews.llvm.org/D27123#617118, @jroelofs wrote: > In https://reviews.llvm.org/D27123#616887, @saaadhu wrote: > > > Make defines for CHAR16_TYPE, {U,}INT_{LEAST,FAST}16_TYPE use int instead > > of short. > > > > {U,}INT16_TYPE still gets defined as short thou

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

2016-12-14 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added a comment. In https://reviews.llvm.org/D27166#622108, @malcolm.parsons wrote: > In https://reviews.llvm.org/D27166#622103, @Prazek wrote: > > > There is still one more problem: > > > > /home/prazek/llvm/lib/Analysis/ScalarEvolution.cpp:2442:11: warning: use > > auto when initializ

[clang-tools-extra] r289656 - modernize-use-auto NFC fixes

2016-12-14 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Wed Dec 14 09:29:23 2016 New Revision: 289656 URL: http://llvm.org/viewvc/llvm-project?rev=289656&view=rev Log: modernize-use-auto NFC fixes Modified: clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp clang-tools-extra/trunk/clang-apply-replacements/lib/To

[PATCH] D27754: [clang-format] Implement comment reflowing (again).

2016-12-14 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: lib/Format/BreakableToken.cpp:471 + WhitespaceManager &Whitespaces) { + if (Tok.is(TT_LineComment)) { +// If this is the first line of a token, inform Whitespace Manager about it. ---

r289657 - Fix assert message. NFC.

2016-12-14 Thread Kelvin Li via cfe-commits
Author: kli Date: Wed Dec 14 09:39:58 2016 New Revision: 289657 URL: http://llvm.org/viewvc/llvm-project?rev=289657&view=rev Log: Fix assert message. NFC. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/tr

[clang-tools-extra] r289658 - Deleted unused typedef

2016-12-14 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Wed Dec 14 09:42:23 2016 New Revision: 289658 URL: http://llvm.org/viewvc/llvm-project?rev=289658&view=rev Log: Deleted unused typedef Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cp

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

2016-12-14 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons added a comment. In https://reviews.llvm.org/D27166#622127, @Prazek wrote: > In https://reviews.llvm.org/D27166#622108, @malcolm.parsons wrote: > > > In https://reviews.llvm.org/D27166#622103, @Prazek wrote: > > > > > There is also problem with function pointers > > > > > > The wa

r289660 - Update the default of the Mozilla coding style

2016-12-14 Thread Sylvestre Ledru via cfe-commits
Author: sylvestre Date: Wed Dec 14 10:09:29 2016 New Revision: 289660 URL: http://llvm.org/viewvc/llvm-project?rev=289660&view=rev Log: Update the default of the Mozilla coding style Summary: I also proposed the change in Firefox .clang-format file: https://bugzilla.mozilla.org/show_bug.cgi?id=13

[PATCH] D27754: [clang-format] Implement comment reflowing (again).

2016-12-14 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1174-1175 LineIndex != EndIndex; ++LineIndex) { -if (!DryRun) - Token->replaceWhitespaceBefore(LineIndex, Whitespaces); +Token->replaceWhitespaceBefore(LineIndex, RemainingTokenColu

[PATCH] D27758: [change-namespace] don't crash when type reference is in function type parameter list.

2016-12-14 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added a reviewer: hokein. ioeric added a subscriber: cfe-commits. https://reviews.llvm.org/D27758 Files: change-namespace/ChangeNamespace.cpp test/change-namespace/lambda-function.cpp Index: test/change-namespace/lambda-function.cpp ==

[PATCH] D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check

2016-12-14 Thread Martin Böhme via Phabricator via cfe-commits
mboehme accepted this revision. mboehme added a comment. This revision is now accepted and ready to land. LG apart from minor comments by others and me Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:18 using namespace clang::ast_matchers; +using namespace clang::tidy::utils

r289668 - [Driver] Allow setting the default linker during build

2016-12-14 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Dec 14 10:46:50 2016 New Revision: 289668 URL: http://llvm.org/viewvc/llvm-project?rev=289668&view=rev Log: [Driver] Allow setting the default linker during build This change allows setting the default linker used by the Clang driver when configuring the build. Different

[PATCH] D25263: [Driver] Allow setting the default linker during build

2016-12-14 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289668: [Driver] Allow setting the default linker during build (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D25263?vs=81276&id=81394#toc Repository: rL LLVM https://review

r289670 - Create SampleProfileLoader pass in llvm instead of clang

2016-12-14 Thread Dehao Chen via cfe-commits
Author: dehao Date: Wed Dec 14 10:49:34 2016 New Revision: 289670 URL: http://llvm.org/viewvc/llvm-project?rev=289670&view=rev Log: Create SampleProfileLoader pass in llvm instead of clang Summary: We used to create SampleProfileLoader pass in clang. This makes LTO/ThinLTO unable to add this pas

[PATCH] D27758: [change-namespace] don't crash when type reference is in function type parameter list.

2016-12-14 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D27758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

2016-12-14 Thread Amjad Aboud via Phabricator via cfe-commits
aaboud created this revision. aaboud added a reviewer: rnk. aaboud added a subscriber: cfe-commits. Changed DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. This way it will be easier to expand DIFile (e.g., to contain checksum) without the need to modify the crea

<    1   2