EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
Implemented from the LFTS v2 spec here:
https://rawgit.com/cplusplus/fundamentals-ts/v2/main.html#memory.resource.monotonic.buffer.
This patch could use some finishing touches, but for the
echuraev created this revision.
echuraev added a reviewer: Anastasia.
echuraev added subscribers: bader, cfe-commits, yaxunl.
https://reviews.llvm.org/D27403
Files:
test/CodeGenOpenCL/address-spaces-mangling.cl
Index: test/CodeGenOpenCL/address-spaces-mangling.cl
=
ABataev added inline comments.
Comment at: lib/Basic/OpenMPKinds.cpp:721
DKind == OMPD_target_parallel_for_simd;
// TODO add next directives.
}
You should consider this new directive as a parallel directive. And
OMPD_teams_distribute_parallel_for_s
EricWF added a reviewer: dexonsmith.
EricWF added a subscriber: dexonsmith.
EricWF added a comment.
In https://reviews.llvm.org/D27387#613071, @smeenai wrote:
> In https://reviews.llvm.org/D27387#612975, @EricWF wrote:
>
> > I wonder if we should consider this a breaking ABI change and control it
EricWF added a comment.
@dim Do you still need this to fix the chromium bug?
https://reviews.llvm.org/D27277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D26934#604325, @smeenai wrote:
> I'd prefer `#error`; that way we can eventually just drop the macro. Ideally
> there wouldn't be too many users to begin with, sinc
EricWF added a comment.
Huh, I thought I had already fixed this but apparently I forgot to commit the
patch. You can find my fix here: https://reviews.llvm.org/D24218
https://reviews.llvm.org/D27167
___
cfe-commits mailing list
cfe-commits@lists.ll
EricWF added a comment.
My main issue with this patch (and https://reviews.llvm.org/D27206) is that
there are now two different CMake options for building two different external
threading libraries. I would much prefer having libc++abi use libc++'s
`__threading_support` header and `cxx_external
baloghadamsoftware added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h:282
+ static inline bool isCompoundType(QualType T) {
+return T->isArrayType() || T->isRecordType() ||
Could you please move this function into a
EricWF added a comment.
In https://reviews.llvm.org/D27153#606296, @smeenai wrote:
> I'm having some second thoughts about this. Visibility for template functions
> makes my head spin :/ Is there a general policy we've been following for
> these? I didn't find much just scanning through other d
dim abandoned this revision.
dim added a comment.
No, let's drop it. In the FreeBSD ports bug I have posted a patch to use
`_LIBCPP_ABI_UNSTABLE ` instead, which appears to work fine. And at some point
we'll update to `_LIBCPP_ABI_VERSION` 2, but not today. :)
https://reviews.llvm.org/D27277
rogfer01 updated this revision to Diff 80235.
rogfer01 added a comment.
- Rewrite the adjusted tests in the way suggested by @EricWF
- Also check that this test works in a GCC-built libcxx
https://reviews.llvm.org/D27310
Files:
test/libcxx/strings/iterators.exceptions.pass.cpp
Index: test/l
EricWF added a comment.
Please address the inline comments before committing.
Comment at: test/libcxx/strings/iterators.exceptions.pass.cpp:29
+#ifndef TEST_HAS_NO_EXCEPTIONS
+constexpr bool expected = false;
+#else
We can't use constexpr because these tests ru
EricWF added a comment.
The tests LGTM. The implementation still needs some tweaks. Thanks for working
on this.
Comment at: include/__config:925
+#if !__has_builtin(__builtin_memcpy)
+#define _LIBCPP_HAS_NO_BUILTIN_MEMCPY
AntonBikineev wrote:
> EricWF wrote:
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM as well.
https://reviews.llvm.org/D27162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
rogfer01 added inline comments.
Comment at: test/libcxx/strings/iterators.exceptions.pass.cpp:29
+#ifndef TEST_HAS_NO_EXCEPTIONS
+constexpr bool expected = false;
+#else
EricWF wrote:
> We can't use constexpr because these tests run in C++03. However `const bool
EricWF added inline comments.
Comment at: test/libcxx/strings/iterators.exceptions.pass.cpp:29
+#ifndef TEST_HAS_NO_EXCEPTIONS
+constexpr bool expected = false;
+#else
rogfer01 wrote:
> EricWF wrote:
> > We can't use constexpr because these tests run in C++03. Ho
rmaprath added a comment.
In https://reviews.llvm.org/D27204#613122, @EricWF wrote:
> My main issue with this patch (and https://reviews.llvm.org/D27206) is that
> there are now two different CMake options for building two different external
> threading libraries. I would much prefer having lib
EricWF added a comment.
In https://reviews.llvm.org/D27204#613172, @rmaprath wrote:
> In https://reviews.llvm.org/D27204#613122, @EricWF wrote:
>
> > My main issue with this patch (and https://reviews.llvm.org/D27206) is that
> > there are now two different CMake options for building two differe
rogfer01 updated this revision to Diff 80238.
rogfer01 added a comment.
Do not use constexpr.
https://reviews.llvm.org/D27310
Files:
test/libcxx/strings/iterators.exceptions.pass.cpp
Index: test/libcxx/strings/iterators.exceptions.pass.cpp
===
EricWF added a comment.
@mclow.lists I'm going to leave this review up to you. I don't see any
immediate issues.
https://reviews.llvm.org/D27068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
EricWF added a comment.
Yeah this seems like a configuration that simply can't be supported. I'm not
sure if this patch is a great idea.
https://reviews.llvm.org/D26376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
rmaprath added a comment.
In https://reviews.llvm.org/D27204#613177, @EricWF wrote:
> In https://reviews.llvm.org/D27204#613172, @rmaprath wrote:
>
> > In https://reviews.llvm.org/D27204#613122, @EricWF wrote:
> >
> > > My main issue with this patch (and https://reviews.llvm.org/D27206) is
> > >
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D27350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: rogfer01
Date: Mon Dec 5 05:05:09 2016
New Revision: 288660
URL: http://llvm.org/viewvc/llvm-project?rev=288660&view=rev
Log:
Handle tests for noexcept that expect a false value
Under libcpp-no-exceptions, noexcept is trivially true. Some tests expect in
the usual setting to return false
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288660: Handle tests for noexcept that expect a false value
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D27310?vs=80238&id=80242#toc
Repository:
rL LLVM
https://reviews
Awesome, thanks for working on this. If you submit the patches via
phabricator (http://llvm.org/docs/Phabricator.html) I'll get to it faster
:) Feel free to directly add me as reviewer, btw (add 'klimek').
On Sat, Dec 3, 2016 at 6:53 AM Antonio Maiorano via cfe-commits <
cfe-commits@lists.llvm.org
Author: ioeric
Date: Mon Dec 5 05:17:04 2016
New Revision: 288662
URL: http://llvm.org/viewvc/llvm-project?rev=288662&view=rev
Log:
[change-namespace] get changing namespace to global correct.
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp
clang-tools-extra/trunk/
Author: d0k
Date: Mon Dec 5 05:30:24 2016
New Revision: 288664
URL: http://llvm.org/viewvc/llvm-project?rev=288664&view=rev
Log:
Clean out unused diagnostics. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modifi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288665: CFGBuilder: Fix crash when visiting delete
expression on dependent type (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D27350?vs=80080&id=80246#toc
Repository:
rL LL
Author: mboehme
Date: Mon Dec 5 05:33:19 2016
New Revision: 288665
URL: http://llvm.org/viewvc/llvm-project?rev=288665&view=rev
Log:
CFGBuilder: Fix crash when visiting delete expression on dependent type
Summary:
CXXDeleteExpr::getDestroyedType() can return a null QualType if the destroyed
type
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin.
NoQ added a subscriber: cfe-commits.
`OwnedSymbol` is not used anywhere; `OwnedAllocatedSymbol` is used instead. I
couldn't grasp the intended difference between the two, maybe we should remove
it?
https://reviews.llvm.org/D
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin.
NoQ added a subscriber: cfe-commits.
The hack that was previously applied to `CGBitmapContextCreateWithData()` is
now extended to another function, `dispatch_data_create()`.
This function accepts a callback block, and the anal
FlameTop created this revision.
FlameTop added a reviewer: rsmith.
FlameTop added a subscriber: cfe-commits.
The provided test shows a case where enabling coverage instrumentation causes a
link error during building. Normally the all the base class items (vtable,
ctors and dtors) would be remove
I haven't looked at the patch, but yes, many developers on our platform
back-deploy to older OS versions (and we support that via Clang flags, e.g.,
-miphoneos-version-min=8.0). They always build against the newest SDK/headers.
-- dpnes
> On Dec 5, 2016, at 00:35, Eric Fiselier via Phabricator
Are the minimum versions detectable in the processor? If so it seems like
we could safely configure this change that way.
/Eric
On Mon, Dec 5, 2016 at 7:37 AM, Duncan Exon Smith
wrote:
> I haven't looked at the patch, but yes, many developers on our platform
> back-deploy to older OS versions (
joerg added a comment.
Ping
https://reviews.llvm.org/D26564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joerg added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D27140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Manuel,
Okay, I'll submit both patches via phabricator as you recommend. I'll add
you, and I'll add Hans Wennborg and Zachary Turner, who were both involved
with the first clang-format-vsix patch I worked on:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161128/178569.html
Does tha
NoQ updated this revision to Diff 80264.
NoQ added a comment.
Update the comments in the surrounding code accordingly.
https://reviews.llvm.org/D27409
Files:
lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
test/Analysis/dispatch-data-leak.m
Index: test/Analysis/dispatch-data-leak.m
===
jroelofs added a comment.
LGTM
https://reviews.llvm.org/D27005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vangyzen added inline comments.
Comment at: src/locale.cpp:4339
if (loc == nullptr)
__throw_runtime_error("numpunct_byname::numpunct_byname"
" failed to construct for " + string(nm));
While you're here, you m
vangyzen abandoned this revision.
vangyzen added a comment.
I'm abandoning this revision because https://reviews.llvm.org/D24218 is clearly
superior.
https://reviews.llvm.org/D27167
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
On Mon, Dec 5, 2016 at 3:53 PM Antonio Maiorano wrote:
> Hi Manuel,
>
> Okay, I'll submit both patches via phabricator as you recommend. I'll add
> you, and I'll add Hans Wennborg and Zachary Turner, who were both involved
> with the first clang-format-vsix patch I worked on:
> http://lists.llvm.
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D27300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/address-spaces-mangling.cl:36
+
+__attribute__((overloadable)) void foo(private char *);
+__attribute__((overloadable)) void foo(global char *);
Just trying to understand what we are missing in the c
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
I suspect allocated owned means that the analyzer saw the allocation site.
Removing dead code is great! Thanks. This looks good to me other than the name
of the method that I commented a
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Sema/SemaTemplate.cpp:7710
+(Context.getTargetInfo().getCXXABI().isMicrosoft() ||
+ Context.getTargetInfo().getTriple().isWindowsItaniumEnvir
zaks.anna added inline comments.
Comment at: test/Analysis/dispatch-data-leak.m:50
+
+ malloc_buf = malloc(1024);
+ data = dispatch_data_create(buf, 1024, dispatch_get_main_queue(), ^{}); //
expected-warning{{Potential leak of memory pointed to by 'malloc_buf'}}
--
dcoughlin added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/ObjCRetainCount.h:179
- static RetEffect MakeOwned(ObjKind o, bool isAllocated = false) {
-return RetEffect(isAllocated ? OwnedAllocatedSymbol : OwnedSymbol, o);
+ static RetEffect MakeOw
Anastasia added a comment.
In https://reviews.llvm.org/D27334#612858, @bader wrote:
> In https://reviews.llvm.org/D27334#611703, @Anastasia wrote:
>
> > This change seems to modify normal C behavior again. Is there any strong
> > motivation for doing this and if yes could it be done generically
arphaman added inline comments.
Comment at: lib/Sema/SemaStmt.cpp:1165
if (!hasCasesNotInSwitch)
SS->setAllEnumCasesCovered();
ahatanak wrote:
> This function used to call setAllEnumCasesCovered() when parsing a switch
> statement with an opaqu
zaks.anna added a comment.
Also, have you evaluated this on real codebases? What results do you see? Are
there any false positives found? Are there any true positives found?
https://reviews.llvm.org/D25660
___
cfe-commits mailing list
cfe-commits@l
yaxunl added a comment.
ping
https://reviews.llvm.org/D26196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin added a comment.
Looks good to me!
To ease the future maintenance burden I would suggest moving the test into
'retain-release-arc.m' unless it really needs to be in its own separate file.
Comment at: test/Analysis/dispatch-data-leak.m:59
+#endif
+}
On 5 Dec 2016 9:42 am, "Anastasia Stulova via Phabricator via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Anastasia added a comment.
In https://reviews.llvm.org/D27334#612858, @bader wrote:
> In https://reviews.llvm.org/D27334#611703, @Anastasia wrote:
>
> > This change seems to modify nor
m_zuckerman added a comment.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D27418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman updated this revision to Diff 80285.
arphaman marked 2 inline comments as done.
arphaman added a comment.
The updated patch addresses Bruno's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D16533
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
l
Yes, they are:
--
$ clang -dM -x c /dev/null -E -mmacosx-version-min=10.10.0 | grep VERSION_MIN
#define __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ 101000
--
However, they're somewhat awkward, extremely vendor-specific, and unrelated to
libc++ version numbers. I think a separate ABI flag would
compnerd added a comment.
I really like the clean up this does. It removes the unnecessary usage of the
GCC pragmas and cleans up the definitions by using the headers more properly.
Comment at: src/abort_message.h:19
-__attribute__((visibility("hidden"), noreturn))
+_LIBCXX
Author: smeenai
Date: Mon Dec 5 12:01:35 2016
New Revision: 288682
URL: http://llvm.org/viewvc/llvm-project?rev=288682&view=rev
Log:
[Sema] Respect DLL attributes more faithfully
On MSVC, if an implicit instantiation already exists and an explicit
instantiation definition with a DLL attribute is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288682: [Sema] Respect DLL attributes more faithfully
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26657?vs=80193&id=80289#toc
Repository:
rL LLVM
https://reviews.llvm.o
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
I thought we had gotten this merged already. Oops. LGTM with the minor tweak
for windows.
Comment at: src/fallback_malloc.cpp:206
+return fallback_malloc(size);
}
vitalybuka created this revision.
vitalybuka added a reviewer: rsmith.
vitalybuka added subscribers: cfe-commits, aizatsky.
getExceptionSpec returns structure with pointers to temporarily object created
by computeImplicitExceptionSpec.
https://reviews.llvm.org/D27420
Files:
lib/Sema/SemaDeclC
> Perhaps that is the problem (that there are two modes that do different
> things)? Could we make the double overload be present but unselectable to
> diagnose this problem in that mode too?
If we could resolve the overload candidate to prefer ‘int -> float’ than
‘int->double’, it would work b
danielcdh added a comment.
ping
https://reviews.llvm.org/D25435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vitalybuka
Date: Mon Dec 5 12:30:22 2016
New Revision: 288685
URL: http://llvm.org/viewvc/llvm-project?rev=288685&view=rev
Log:
Fix stack-use-after-scope in EvaluateImplicitExceptionSpec
Summary:
getExceptionSpec returns structure with pointers to temporarily object created
by computeImp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288685: Fix stack-use-after-scope in
EvaluateImplicitExceptionSpec (authored by vitalybuka).
Changed prior to commit:
https://reviews.llvm.org/D27420?vs=80290&id=80292#toc
Repository:
rL LLVM
https:
vitalybuka created this revision.
vitalybuka added a reviewer: rsmith.
vitalybuka added subscribers: cfe-commits, aizatsky.
Similar to r288685.
getExceptionSpec returned structure with pointers to temporarily object created
by computeImplicitExceptionSpec.
https://reviews.llvm.org/D27422
Files:
mkuper added a comment.
If there are real-life usecases, then GCC-compatible behavior is probably
better than just rejecting it outright, so I'm retracting my comment from
PR30426.
(I would probably have liked x86_64 with -mno-sse2 and no -msoft-float to be an
error, but I would also like a po
mehdi_amini added a comment.
In https://reviews.llvm.org/D26376#597614, @mclow.lists wrote:
> More info - The following code:
>
> #include
> int main () {}
>
>
> fails to compile on either gcc 6.2 (locally), gcc 7 head (online compiler) or
> MSVC (online compiler).
Interesting, that le
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288689: Fix stack-use-after-scope in
CheckExplicitlyDefaultedMemberExceptionSpec (authored by vitalybuka).
Changed prior to commit:
https://reviews.llvm.org/D27422?vs=80299&id=80300#toc
Repository:
r
Author: vitalybuka
Date: Mon Dec 5 13:25:00 2016
New Revision: 288689
URL: http://llvm.org/viewvc/llvm-project?rev=288689&view=rev
Log:
Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec
Summary:
Similar to r288685.
getExceptionSpec returned structure with pointers to tempo
smeenai added a comment.
In https://reviews.llvm.org/D27153#613140, @EricWF wrote:
> In https://reviews.llvm.org/D27153#606296, @smeenai wrote:
>
> > I'm having some second thoughts about this. Visibility for template
> > functions makes my head spin :/ Is there a general policy we've been
> >
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288690: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26934?vs=79359&id=80304#toc
Repository:
rL LLVM
https://reviews.
Author: smeenai
Date: Mon Dec 5 13:40:12 2016
New Revision: 288690
URL: http://llvm.org/viewvc/llvm-project?rev=288690&view=rev
Log:
[libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS
It's useful to be able to disable visibility annotations entirely; for
example, if we're building libc++ static
On 5 December 2016 at 11:34, Mehdi AMINI via Phabricator <
revi...@reviews.llvm.org> wrote:
> mehdi_amini added a comment.
>
> In https://reviews.llvm.org/D26376#597614, @mclow.lists wrote:
>
> > More info - The following code:
> >
> > #include
> > int main () {}
> >
> >
> > fails to compile
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288692: [libc++abi] Add
_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS (authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26950?vs=78809&id=80306#toc
Repository:
rL LLVM
https://re
Author: smeenai
Date: Mon Dec 5 13:42:11 2016
New Revision: 288692
URL: http://llvm.org/viewvc/llvm-project?rev=288692&view=rev
Log:
[libc++abi] Add _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS
It's useful to be able to disable visibility annotations entirely; for
example, if we're building libc++a
yixiang added a comment.
Discover a case where my code breaks. When the block signature has a return
type in it, the indent doesn't gets reset properly. I need to fix this.
// clang-format -style='{ObjCBlockResetsIndent: true}' test.m
[self callAsyncMethodWithParam:2
withCompletio
george.burgess.iv created this revision.
george.burgess.iv added reviewers: rsmith, aaron.ballman.
george.burgess.iv added subscribers: EricWF, cfe-commits.
This patch adds the `diagnose_if` attribute to clang.
`diagnose_if` is meant to be a less powerful version of `enable_if`: it doesn't
inter
Author: ddcc
Date: Mon Dec 5 14:30:11 2016
New Revision: 288696
URL: http://llvm.org/viewvc/llvm-project?rev=288696&view=rev
Log:
[analyzer] Print type for SymbolRegionValues when dumping to stream
Reviewers: NoQ, dcoughlin, zaks.anna
Subscribers: cfe-commits
Differential Revision: https://rev
ddcc updated this revision to Diff 80310.
ddcc added a comment.
Fix rebase
https://reviews.llvm.org/D27365
Files:
lib/StaticAnalyzer/Core/SymbolManager.cpp
test/Analysis/expr-inspection.c
Index: test/Analysis/expr-inspection.c
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288696: [analyzer] Print type for SymbolRegionValues when
dumping to stream (authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D27365?vs=80310&id=80311#toc
Repository:
rL LLVM
htt
mehdi_amini abandoned this revision.
mehdi_amini added a comment.
Thanks for the information! Closing this.
https://reviews.llvm.org/D26376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
mgrang added a comment.
Moved error checking up to the driver and added another test case.
https://reviews.llvm.org/D27360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgrang updated this revision to Diff 80314.
https://reviews.llvm.org/D27360
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/Tools.cpp
test/Driver/defsym.s
tools/driver/cc1as_main.cpp
Index: tools/driver/cc1as_main.cpp
==
george.burgess.iv added a comment.
Ping :)
https://reviews.llvm.org/D14274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added reviewers: mclow.lists, dexonsmith, EricWF.
bruno added a subscriber: cfe-commits.
CLOCK_MONOTONIC is only defined on Darwin on libc versions >= 1133 and its
behaviour differs from Linux. CLOCK_UPTIME on Darwin actually matches
CLOCK_MONOTONIC on Linux, du
arichardson added a comment.
It would also be good to append --sysroot=DEFAULT_SYSROOT if DEFAULT_SYSROOT is
not empty and there is no explicit --sysroot flag. That way the compilation
database can also be consumed by a libclang based too that does not have the
same DEFAULT_SYSROOT set.
Repos
Author: compnerd
Date: Mon Dec 5 16:40:20 2016
New Revision: 288721
URL: http://llvm.org/viewvc/llvm-project?rev=288721&view=rev
Log:
CodeGen: fix windows itanium RTTI in EH mode
When emitting RTTI for EH only, we would mark the locally defined (LinkOnceODR)
RTTI definition as dllimport, which i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288723: [docs] Use x86_64 and i386 instead of x86 as arch
for triples. (authored by fhahn).
Changed prior to commit:
https://reviews.llvm.org/D26960?vs=78842&id=80332#toc
Repository:
rL LLVM
https:/
smeenai created this revision.
smeenai added reviewers: EricWF, mclow.lists.
smeenai added subscribers: cfe-commits, thakis.
https://reviews.llvm.org/D25208 switches `_LIBCPP_TYPE_VIS` to expand to
default visibility
instead of default type visibility, in order to ease building libc++
with hidden
smeenai updated this revision to Diff 80334.
smeenai added a comment.
Rebasing
https://reviews.llvm.org/D25208
Files:
docs/DesignDocs/VisibilityMacros.rst
include/__config
Index: include/__config
===
--- include/__config
+++
smeenai added a comment.
https://reviews.llvm.org/D27430 should unblock this.
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Mon Dec 5 17:16:07 2016
New Revision: 288728
URL: http://llvm.org/viewvc/llvm-project?rev=288728&view=rev
Log:
Adjust libc++ test infastructure to fully support modules
This patch overhalls the libc++ test format/configuration in order to fully
support modules. By "fully su
Author: fhahn
Date: Mon Dec 5 16:52:20 2016
New Revision: 288723
URL: http://llvm.org/viewvc/llvm-project?rev=288723&view=rev
Log:
[docs] Use x86_64 and i386 instead of x86 as arch for triples.
Summary: x86 is not a valid arch for target triples, but x86_64 and i386 are.
Reviewers: rengolin, si
Author: ericwf
Date: Mon Dec 5 17:33:19 2016
New Revision: 288730
URL: http://llvm.org/viewvc/llvm-project?rev=288730&view=rev
Log:
Add modules for any/optional/variant
Modified:
libcxx/trunk/include/module.modulemap
Modified: libcxx/trunk/include/module.modulemap
URL:
http://llvm.org/view
Author: rtrieu
Date: Mon Dec 5 17:41:46 2016
New Revision: 288732
URL: http://llvm.org/viewvc/llvm-project?rev=288732&view=rev
Log:
Warn on unsigned zero in call to std::max
New default warning that triggers when an unsigned zero is used in a call to
std::max. For unsigned values, zero is the m
Author: ericwf
Date: Mon Dec 5 17:53:23 2016
New Revision: 288733
URL: http://llvm.org/viewvc/llvm-project?rev=288733&view=rev
Log:
Add module definitions for string_view
Modified:
libcxx/trunk/include/module.modulemap
libcxx/trunk/include/string_view
Modified: libcxx/trunk/include/modu
1 - 100 of 157 matches
Mail list logo
