Author: compnerd
Date: Fri Dec 2 19:57:47 2016
New Revision: 288570
URL: http://llvm.org/viewvc/llvm-project?rev=288570&view=rev
Log:
Sema: delay the DLL exported member referencing
An explicit template specialization can cause the implicit template
specialization of a type which inherits the at
Ack. Will do in future.
Thanks Hal
On Fri, Dec 2, 2016 at 3:54 PM, Hal Finkel wrote:
> - Original Message -
> > From: "Eric Fiselier via cfe-commits"
> > To: cfe-commits@lists.llvm.org
> > Sent: Friday, December 2, 2016 4:30:53 PM
> > Subject: [libcxx] r288544 - Work around a bug in Cl
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459
// Notice that the lower bound is greater than the upper bound.
- RangeSet New = GetRange(St, Sym).Intersect(getBasicVals(), F, Upper, Lower);
+ RangeSet New = getRange(St, Sy
Author: ericwf
Date: Fri Dec 2 20:26:28 2016
New Revision: 288573
URL: http://llvm.org/viewvc/llvm-project?rev=288573&view=rev
Log:
Work around more -Wshadow warnings
Modified:
libcxx/trunk/test/libcxx/containers/sequences/vector/asan_throw.pass.cpp
libcxx/trunk/test/std/algorithms/alg.
Author: ericwf
Date: Fri Dec 2 20:47:40 2016
New Revision: 288574
URL: http://llvm.org/viewvc/llvm-project?rev=288574&view=rev
Log:
Mark various items as complete
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llvm-pro
Author: ericwf
Date: Fri Dec 2 21:22:11 2016
New Revision: 288575
URL: http://llvm.org/viewvc/llvm-project?rev=288575&view=rev
Log:
Make make_exception_ptr abort with -fno-exceptions
Modified:
libcxx/trunk/include/exception
Modified: libcxx/trunk/include/exception
URL:
http://llvm.org/view
Author: ericwf
Date: Fri Dec 2 21:29:45 2016
New Revision: 288576
URL: http://llvm.org/viewvc/llvm-project?rev=288576&view=rev
Log:
Turn off testsuite warnings by default with GCC
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config.py
URL:
http:
ddcc added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459
// Notice that the lower bound is greater than the upper bound.
- RangeSet New = GetRange(St, Sym).Intersect(getBasicVals(), F, Upper, Lower);
+ RangeSet New = getRange(St, Sym).In
EricWF updated this revision to Diff 80168.
EricWF added a comment.
- Add unit tests as requested.
This patch is ready to go. If there are no objections in the next day or two
I'll commit it.
https://reviews.llvm.org/D27005
Files:
utils/lit/lit/TestRunner.py
utils/lit/tests/Inputs/testrun
Hello,
I have two patches for clang-format-vsix to offer up for review:
0001-clang-format-vsix-versioning.patch
clang-format-vsix: add a date stamp to the VSIX version number to ensure
upgradability
Presently, the version number of the VSIX matches the LLVM version number.
However, as this numbe
EricWF added a comment.
FYI there is a relevent GCC bug here:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71537
https://reviews.llvm.org/D26896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
zaks.anna added a comment.
It's awesome to see that all the major issues have been addressed. Thank you
for working on this and diligently working through the code review!!!
I have a few minor comments below.
Could you add this example yours as a "no-warning" test case:
const auto start = v.beg
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Have you tested this against GCC which has different noexcept semantics?
If so this LGTM minus possibly addressing the inline comments.
Comment at: test/libcxx/strings/itera
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM nix inline comments. Please fix `MemCounter` to use `size_t` instead.
Comment at: test/support/count_new.hpp:62
int delete_called;
int last_new_size;
---
NoQ accepted this revision.
NoQ added a comment.
Thanks, i love dumps! Btw, did you encounter cases when types are unobvious
from the parent region?
Comment at: lib/StaticAnalyzer/Core/SymbolManager.cpp:89
+ os << "reg_$" << getSymbolID()
+ << "<" << getType().getAsString
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D27021
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
I may have considered doing the cast to `ptrdiff_t` for the other operand
instead of the `size_t` cast, but IDK which is better.
https://reviews.llvm.org/D27022
EricWF added a comment.
LGTM.
Feel free to address the inline comments or not.
Comment at:
test/std/containers/sequences/deque/deque.capacity/access.pass.cpp:55
std::deque c = make >(10);
for (unsigned i = 0; i < 10; ++i)
+assert(c[i] == static_c
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Random thought: It would be nice for C++ to have a
`non_truncating_cast(value)` which generated an error when the conversion
performs a truncation. This seems like the behavior we want
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D27269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
101 - 120 of 120 matches
Mail list logo
