[PATCH] D26991: Hoist redundant load

hiraditya added a comment. @mclow.lists I can remove this and update this patch with the load hoisted, if this is okay. https://reviews.llvm.org/D26991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

(Dropping Phabricator, since this isn't really about D27163...) On 28 November 2016 at 14:27, John McCall via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > In https://reviews.llvm.org/D27163#607100, @rsmith wrote: > > C has rather different and much less useful TBAA rules > >

[PATCH] D26991: Hoist redundant load

hiraditya updated this revision to Diff 79463. hiraditya added a comment. Removed unused code. https://reviews.llvm.org/D26991 Files: libcxx/include/algorithm Index: libcxx/include/algorithm === --- libcxx/include/algorithm +++

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

rnk added a comment. Adding the flag seems OK, but I'd rather not make the default setting be target-dependent, if that's workable. Repository: rL LLVM https://reviews.llvm.org/D27163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D26768: [analyzer] Improve VirtualCallChecker diagnostics and move out of alpha

zaks.anna added a comment. Not sure if we should make pure vs not an option so that users could turn the checking off. Is there a way to suppress the warning? Comment at: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp:210 + if (isPure) +os << "pure "; + --

Re: Upgrade and fix clang-format-vs

Hi again, I've made the changes so that the required assemblies are committed, so now we can build the clang-format-vsix with just VS 2015. Since the patch set is around 9 mb, I'm providing a link to it on my Dropbox (if you'd rather I attach it, let me know): https://dl.dropboxusercontent.com/u/

Re: Upgrade and fix clang-format-vs

Hi Hans, I saw that on September 15th, you checked in a change: clang-format VS plugin: upgrade the project files to VS2015. When I open the latest version of ClangFormat.sln on a machine that has only VS 2015, it doesn't build. The reason is that some of the referenced assemblies are from VS 201

Re: Upgrade and fix clang-format-vs

Okay, that's fine, I'll go for that and if all looks good, will attach a patch. Thanks. On Thu, 24 Nov 2016 at 15:09 Zachary Turner wrote: > I would use the first solution. We lock ourselves to specific versions of > vs, so i think it's fine to do the same with the assemblies and deal with > it

Re: Upgrade and fix clang-format-vs

Unfortunately, vsvarsall doesn't bring nuget onto path. I shared a few links earlier about this: https://nuget.codeplex.com/workitem/3615 http://stackoverflow.com/questions/22300375/nuget-auto-package-restore-does-not-work-with-msbuild/23935892#23935892 Your idea about -DMSVC_NUGET_PATH for CMake

Re: Upgrade and fix clang-format-vs

Ah, no, that's not what I meant. The required referenced assemblies are versions that are normally installed with VS 2010. The first time I worked on this, I had upgraded the referenced assemblies to the ones that ship with VS 2015, but then there was question of whether or not the VSIX would cont

Re: Upgrade and fix clang-format-vs

Okay, I'll see if upgrading to the 2015 assemblies would allow the VSIX to keep working in older versions of VS. Still waiting on an answer to this question: > In either case, though, I must ask: how is the offical vsix that's available on http://llvm.org/builds/ get built? Is it part of an autom

Re: Upgrade and fix clang-format-vs

> It's built with the script in utils/release/build_llvm_package.bat which I run manually on my machine once every few weeks. Okay, that's good news. So the simplest path to success would be to require the user to either pass the path to CMake via an arg like -DNUGET_EXE_PATH, or if it's not defin

[PATCH] D26082: Support for Python 3 in libclang python bindings

MathieuDuponchelle added a comment. I get tons of errors when running these tests with python 3 (version 3.4.3) with a fresh build of clang and llvm. The number of failures vs errors vary wildly between each invocation, the number of total failures + errors stays the same, which led me to think

Re: Upgrade and fix clang-format-vs

Great, I'll get this working soon and attach a new patch :) On Mon, 28 Nov 2016 at 14:27 Hans Wennborg wrote: > On Mon, Nov 28, 2016 at 11:11 AM, Antonio Maiorano > wrote: > >> It's built with the script in utils/release/build_llvm_package.bat > > which I run manually on my machine once every f

[PATCH] D27104: Unify and simplify the behavior of the hasDeclaration matcher.

lukasza added a comment. Forcing shallow matching means that unit test below will stop passing after this CL. TEST(HasDeclaration, DeepTagType) { std::string input = "class Foo {};\n" "using Bar = Foo;\n" "void Function(Bar param) {}\n"; // Matcher for declar

[PATCH] Update usage of RHEL devtoolsets

- remove devtoolset-1 (obsoleted gcc 4.7) - add devtoolset-6 (gcc 6.2+) (There is no devtoolset-5, RH switched to gcc major version numbering.) Please apply, I don't have commit access. Thanks, Michael diff -ru a/lib/Driver/ToolChains.cpp b/lib/Driver/ToolChains.cpp --- a/lib/Driver/ToolChai

Re: [PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

On Mon, Nov 28, 2016 at 2:48 PM, Richard Smith wrote: > (Dropping Phabricator, since this isn't really about D27163...) > > On 28 November 2016 at 14:27, John McCall via Phabricator via cfe-commits > wrote: > >> In https://reviews.llvm.org/D27163#607100, @rsmith wrote: >> > C has rather differen

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

ahatanak added a comment. I wonder whether it is possible to avoid calling DeclScopeObj.EnterDeclaratorScope at ParseDecl.cpp:5317 instead of fixing Sema::ActOnCXXEnterDeclaratorScope? I believe it's calling EnterDeclaratorScope to enable name lookup when a namespace-member variable is defined

Re: [PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

On 28 November 2016 at 15:33, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Nov 28, 2016 at 2:48 PM, Richard Smith > wrote: > >> (Dropping Phabricator, since this isn't really about D27163...) >> >> On 28 November 2016 at 14:27, John McCall via Phabricator via cfe-com

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

joerg added a comment. Can I interprete that as LGTM otherwise? Repository: rL LLVM https://reviews.llvm.org/D27138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r288089 - Avoid lambdas in default member initializers to work around clang bug

Author: rnk Date: Mon Nov 28 17:58:04 2016 New Revision: 288089 URL: http://llvm.org/viewvc/llvm-project?rev=288089&view=rev Log: Avoid lambdas in default member initializers to work around clang bug On Windows, Clang is mangling lambdas in default member initializers incorrectly. See PR31197. T

[PATCH] D26839: [analyzer] An attempt to fix pr19539 - crashes on temporaries life-extended via members

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This is great! Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:205 - // We need to be careful about treating a derived type's value as - // bindings for a base t

r288093 - Use ${:uid} to generate unique MS asm labels, not {:uid}

Author: rnk Date: Mon Nov 28 18:39:37 2016 New Revision: 288093 URL: http://llvm.org/viewvc/llvm-project?rev=288093&view=rev Log: Use ${:uid} to generate unique MS asm labels, not {:uid} Modified: cfe/trunk/lib/Sema/SemaStmtAsm.cpp cfe/trunk/test/CodeGen/mozilla-ms-inline-asm.c cfe/tr

[PATCH] D27140: Allow clang to write compilation database records

joerg updated this revision to Diff 79482. joerg added a comment. Move implementation into the Clang class, keep track of the raw_fd_stream. This avoids reopening it on multiple inputs and removes the need for append mode. Short circuit the function when -### is present. Add proper diagnostics o

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe created this revision. spyffe added reviewers: a.sidorin, beanz, loladiro, v.g.vassilev. spyffe added a subscriber: cfe-commits. spyffe set the repository for this revision to rL LLVM. Herald added a subscriber: mgorny. LLVM's JIT is now the foundation of dynamic-compilation features for ma

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai added a comment. Ping. https://reviews.llvm.org/D26657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai added a comment. Ping. Lmk if there's any other tests I should run on this to ensure there's no functional difference. https://reviews.llvm.org/D26949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D26950: [libc++abi] Add _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS

smeenai added a comment. Ping. https://reviews.llvm.org/D26950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r288097 - Add a warning for 'main' returning 'true' or 'false'.

Author: rsmith Date: Mon Nov 28 19:35:17 2016 New Revision: 288097 URL: http://llvm.org/viewvc/llvm-project?rev=288097&view=rev Log: Add a warning for 'main' returning 'true' or 'false'. Patch by Joshua Hurwitz! Added: cfe/trunk/test/Sema/warn-main-returns-bool-literal.cpp Modified: cfe/

Re: [PATCH] Warning for main returning a bool.

Committed as r288097. On 28 November 2016 at 05:27, Joshua Hurwitz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Thanks Richard for looking at the revised patch. > > On Mon, Nov 21, 2016 at 1:50 PM Richard Smith > wrote: > >> This looks good to me. (While we could generalize this furthe

[PATCH] D26991: Hoist redundant load

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks fine to me - though I wonder if the compiler can hoist `*__first2` w/o us helping it. https://reviews.llvm.org/D26991 ___ c

[PATCH] D27181: [ASTImporter] Support for importing UsingDecl and UsingShadowDecl

khazem created this revision. khazem added reviewers: spyffe, a.sidorin. khazem added subscribers: cfe-commits, phosek, seanklein, klimek. Some of this patch comes from Aleksei's branch [1], with minor revisions. I've added unit tests and AST Matcher support. Copying in Manuel in case there is no

[PATCH] D27162: Support relaxed constexpr on chrono::duration operations

AntonBikineev added a subscriber: cfe-commits. AntonBikineev updated this revision to Diff 79491. https://reviews.llvm.org/D27162 Files: include/chrono test/std/utilities/time/time.duration/time.duration.arithmetic/op_++.pass.cpp test/std/utilities/time/time.duration/time.duration.arithmet

[PATCH] D27187: [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop

flx created this revision. flx added reviewers: alexfh, sbenza, aaron.ballman. flx added a subscriber: cfe-commits. flx set the repository for this revision to rL LLVM. flx added a project: clang-tools-extra. Herald added a subscriber: JDevlieghere. This fixes a bug where the performance-unnecessa

[PATCH] D27180: Testbed and skeleton of a new expression parser

hfinkel added a comment. This seems like a great idea. btw, do you know about Cling (https://root.cern.ch/cling)? Repository: rL LLVM https://reviews.llvm.org/D27180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D27099: [OpenCL] Prohibit using reserve_id_t in program scope.

echuraev updated this revision to Diff 79508. https://reviews.llvm.org/D27099 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/SemaOpenCL/event_t.cl test/SemaOpenCL/invalid-clk-events-cl2.0.cl test/SemaOpenCL/invalid-pipes-cl2.0.cl Index: test/SemaOpenCL/inv

[PATCH] D26800: [Sema] Make __attribute__((notnull)) inheritable through function parameters

ahatanak added inline comments. Comment at: test/Sema/nonnull.c:171 + +void pr31040(char *p __attribute__((nonnull))); +void pr31040(char *p) {} Is this not pr30828? https://reviews.llvm.org/D26800 ___ cfe-commits

<    1   2