r287437 - Introduce a helper class for building complex constant initializers. NFC.

2016-11-19 Thread John McCall via cfe-commits
Author: rjmccall Date: Sat Nov 19 02:17:24 2016 New Revision: 287437 URL: http://llvm.org/viewvc/llvm-project?rev=287437&view=rev Log: Introduce a helper class for building complex constant initializers. NFC. I've adopted this in most of the places it makes sense, but v-tables and CGObjCMac will

[PATCH] D26887: [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config)

2016-11-19 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: chandlerc, bruno, bkramer. mgorny added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert. Fix the gcc-config code to support multilib gcc installs properly. This solves two problems: -mx32 using the 64-bit gcc directory (

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-19 Thread Anton Bikineev via cfe-commits
AntonBikineev added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:1716-1717 +StringLiteralParser::UDSuffixResult +StringLiteralParser::isValidUDSuffix(const LangOptions &LangOpts, + StringRef Suffix) { + if (!LangOpts.CPlusPlus11 ||

[PATCH] D25869: [Driver] Add unit tests for Distro detection

2016-11-19 Thread Michał Górny via cfe-commits
mgorny updated this revision to Diff 78625. mgorny added a comment. Added a test for Exherbo. https://reviews.llvm.org/D25869 Files: unittests/Driver/CMakeLists.txt unittests/Driver/DistroTest.cpp Index: unittests/Driver/DistroTest.cpp ==

[PATCH] D26458: Protect nested-exceptions tests under no-exceptions

2016-11-19 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. In https://reviews.llvm.org/D26458#594069, @EricWF wrote: > There are cases where it is useful to be able to name `std::nested_exception` > while exceptions are disabled. I was thinking about the opposite. That is, we might want to consider disabling the `` header al

[PATCH] D26458: Protect nested-exceptions tests under no-exceptions

2016-11-19 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. On the other hand, disabling `` would mean disabling some parts of the library as well (in this case, `std::promise::set_exception`). Perhaps that's a bad path to follow. Not sure. Repository: rL LLVM https://reviews.llvm.org/D26458 _

[PATCH] D26735: [OpenCL] Disable && (address of label) GNU extension for OpenCL

2016-11-19 Thread Ronan Keryell via cfe-commits
keryell added a comment. +1 Please do not remove anything, since it may be useful in some contexts. I do not think there are negative tests in the Khronos OpenCL conformance test suite anyway. https://reviews.llvm.org/D26735 ___ cfe-commits mailin

r287449 - Change setDiagnosticsOutputFile to take a unique_ptr from a raw pointer (NFC)

2016-11-19 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Sat Nov 19 12:19:41 2016 New Revision: 287449 URL: http://llvm.org/viewvc/llvm-project?rev=287449&view=rev Log: Change setDiagnosticsOutputFile to take a unique_ptr from a raw pointer (NFC) Summary: This makes it explicit that ownership is taken. Also replace all `new` w

r287458 - Remove alignment from ctors/dtors lists in an attempt to placate LTO.

2016-11-19 Thread John McCall via cfe-commits
Author: rjmccall Date: Sat Nov 19 14:12:25 2016 New Revision: 287458 URL: http://llvm.org/viewvc/llvm-project?rev=287458&view=rev Log: Remove alignment from ctors/dtors lists in an attempt to placate LTO. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/lib/CodeGen/CodeG

r287463 - [CMake] Fixing clang standalone build

2016-11-19 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Sat Nov 19 15:14:59 2016 New Revision: 287463 URL: http://llvm.org/viewvc/llvm-project?rev=287463&view=rev Log: [CMake] Fixing clang standalone build I broke this in r287406 and r287407. Modified: cfe/trunk/tools/clang-offload-bundler/CMakeLists.txt cfe/trunk/tool

Re: [PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-19 Thread Richard Smith via cfe-commits
On 19 Nov 2016 2:36 am, "Anton Bikineev" wrote: AntonBikineev added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:1716-1717 +StringLiteralParser::UDSuffixResult +StringLiteralParser::isValidUDSuffix(const LangOptions &LangOpts, + St

[PATCH] D26893: [Sema] Fix assert on valid during template argument deduction

2016-11-19 Thread Erik Pilkington via cfe-commits
erik.pilkington created this revision. erik.pilkington added a reviewer: rsmith. erik.pilkington added a subscriber: cfe-commits. This patch fixes an assert that fired when diagnosing a failed template argument deduction attempt. The problem is that when deducing template arguments for a templat