[PATCH] D26813: [libcxx] [test] allocator is non-Standard.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r287381. https://reviews.llvm.org/D26813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26815: [libcxx] [test] Fix an assumption about the state of moved-from std::functions.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r287382. https://reviews.llvm.org/D26815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26816: [libcxx] [test] Fix non-Standard assumptions when testing sample().

STL_MSFT closed this revision. STL_MSFT marked an inline comment as done. STL_MSFT added a comment. Thanks, r287383 (including the requested comment). https://reviews.llvm.org/D26816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

hans added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7670-7673 +if ((Old_TSK == TSK_ExplicitInstantiationDeclaration || + Old_TSK == TSK_ImplicitInstantiation) && (TSK == TSK_ExplicitInstantiationDefinition || DLLImportExplicitInstantia

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7670-7673 +if ((Old_TSK == TSK_ExplicitInstantiationDeclaration || + Old_TSK == TSK_ImplicitInstantiation) && (TSK == TSK_ExplicitInstantiationDefinition || DLLImportExplicitInstan

[PATCH] D26814: [libcxx] [test] Change ifstream constructor tests to handle read-only files.

STL_MSFT added a comment. My changes to the ofstream.cons tests preserve the test coverage (as they already contain the machinery to create writable files). Would you like it if I removed the "if (fs) { stuff }" blocks from the ifstream.cons tests entirely, and changed the comments to say thing

[libcxx] r287388 - Allow using libsupc++ with LIBCXX_ENABLE_STATIC_ABI_LIBRARY. Patch from Michael Daniels.

Author: ericwf Date: Fri Nov 18 16:25:41 2016 New Revision: 287388 URL: http://llvm.org/viewvc/llvm-project?rev=287388&view=rev Log: Allow using libsupc++ with LIBCXX_ENABLE_STATIC_ABI_LIBRARY. Patch from Michael Daniels. The code cannot currently link when using libsupc++ with the LIBCXX_ENABLE

[PATCH] D26186: Allow using libsupc++ with LIBCXX_ENABLE_STATIC_ABI_LIBRARY

EricWF closed this revision. EricWF added a comment. Committed as r287388. https://reviews.llvm.org/D26186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r287390 - [AMDGPU] Change frexp.exp builtin to return i16 for f16 input

Author: kzhuravl Date: Fri Nov 18 16:31:51 2016 New Revision: 287390 URL: http://llvm.org/viewvc/llvm-project?rev=287390&view=rev Log: [AMDGPU] Change frexp.exp builtin to return i16 for f16 input Differential Revision: https://reviews.llvm.org/D26863 Modified: cfe/trunk/include/clang/Basic/

[PATCH] D26863: [AMDGPU] Change frexp.exp builtin to return i16 for f16 input

This revision was automatically updated to reflect the committed changes. Closed by commit rL287390: [AMDGPU] Change frexp.exp builtin to return i16 for f16 input (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D26863?vs=78546&id=78586#toc Repository: rL LLVM https

[libcxx] r287391 - [libcxx] [test] D26812: In random tests, use real static_asserts and silence a warning.

Author: stl_msft Date: Fri Nov 18 16:45:32 2016 New Revision: 287391 URL: http://llvm.org/viewvc/llvm-project?rev=287391&view=rev Log: [libcxx] [test] D26812: In random tests, use real static_asserts and silence a warning. In C++11 mode and newer, use real static_asserts. In C++03 mode, min() an

[PATCH] D26812: [libcxx] [test] In random tests, use real static_asserts and silence a warning.

STL_MSFT accepted this revision. STL_MSFT added a reviewer: STL_MSFT. STL_MSFT added a comment. This revision is now accepted and ready to land. Made the requested changes, committed as r287391 with Eric's approval. Comment at: test/std/numerics/rand/rand.eng/rand.eng.lcong/val

[PATCH] D26814: [libcxx] [test] Change ifstream constructor tests to handle read-only files.

STL_MSFT updated the summary for this revision. STL_MSFT updated this revision to Diff 78589. STL_MSFT added a comment. Instead of skipping failures to open, just have comments pointing to the ofstream.cons tests where this coverage has moved. https://reviews.llvm.org/D26814 Files: test/std/

r287407 - [CMake] clang depends on intrinsics_gen

Author: cbieneman Date: Fri Nov 18 17:31:16 2016 New Revision: 287407 URL: http://llvm.org/viewvc/llvm-project?rev=287407&view=rev Log: [CMake] clang depends on intrinsics_gen cc1_main.cpp has the following include chain: llvm/LinkAllPasses.h llvm/Analysis/AliasSetTracker.h llvm/Analysis/AliasAn

r287406 - [CMake] clang-offload-bundler depends on intrinsics_gen

Author: cbieneman Date: Fri Nov 18 17:31:14 2016 New Revision: 287406 URL: http://llvm.org/viewvc/llvm-project?rev=287406&view=rev Log: [CMake] clang-offload-bundler depends on intrinsics_gen ClangOffloadBundler.cpp has the following include chain: llvm/Bitcode/BitcodeWriter.h llvm/IR/ModuleSumm

[PATCH] D21099: [Sema] Teach -Wcast-align to look at the aligned attribute of the declared variables

ahatanak updated this revision to Diff 78594. ahatanak marked 2 inline comments as done. ahatanak added a comment. Make the helper function return the Decl's alignment by value. https://reviews.llvm.org/D21099 Files: lib/Sema/SemaChecking.cpp test/Sema/warn-cast-align.c Index: test/Sema/w

[PATCH] D26186: Allow using libsupc++ with LIBCXX_ENABLE_STATIC_ABI_LIBRARY

mdaniels added a comment. I don't have commit access, could I trouble someone to do it on my behalf? https://reviews.llvm.org/D26186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26110: Add a check for GCC to the _LIBCPP_EXPLICIT define

mdaniels added a comment. I don't have commit access, could I trouble someone to do it on my behalf? https://reviews.llvm.org/D26110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r287410 - [Sema] Don't allow applying address-of operator to a call to a function

Author: ahatanak Date: Fri Nov 18 18:13:03 2016 New Revision: 287410 URL: http://llvm.org/viewvc/llvm-project?rev=287410&view=rev Log: [Sema] Don't allow applying address-of operator to a call to a function with __unknown_anytype return type. When the following code is compiled, Sema infers that

[PATCH] D26808: [Sema] Don't allow applying address-of operator to a call to a function with __unknown_anytype return type

This revision was automatically updated to reflect the committed changes. Closed by commit rL287410: [Sema] Don't allow applying address-of operator to a call to a function (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D26808?vs=78396&id=78598#toc Repository: rL L

[PATCH] D26868: Sema: As of MSVC 2015, a user-declared move operation causes the deletion of both copy operations.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Nice, lgtm https://reviews.llvm.org/D26868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

r287411 - Sema: As of MSVC 2015, a user-declared move operation causes the deletion of both copy operations.

Author: pcc Date: Fri Nov 18 18:30:56 2016 New Revision: 287411 URL: http://llvm.org/viewvc/llvm-project?rev=287411&view=rev Log: Sema: As of MSVC 2015, a user-declared move operation causes the deletion of both copy operations. Differential Revision: https://reviews.llvm.org/D26868 Modified:

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated this revision to Diff 78602. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp lib/Sema/SemaDeclCXX.cpp test/SemaCXX/cxx1z-user-defined-literals.cpp In

[PATCH] D26868: Sema: As of MSVC 2015, a user-declared move operation causes the deletion of both copy operations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL287411: Sema: As of MSVC 2015, a user-declared move operation causes the deletion of… (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D26868?vs=78576&id=78603#toc Repository: rL

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev added a comment. In https://reviews.llvm.org/D26829#599906, @malcolm.parsons wrote: > Does `Sema::CheckLiteralOperatorDeclaration` need to check > `StringLiteralParser::isValidUDSuffix`? Thanks, nice point! Just addressed it. https://reviews.llvm.org/D26829 _

[libcxx] r287413 - [libcxx] Implement locale.h to fix modules build

Author: ericwf Date: Fri Nov 18 19:14:15 2016 New Revision: 287413 URL: http://llvm.org/viewvc/llvm-project?rev=287413&view=rev Log: [libcxx] Implement locale.h to fix modules build Summary: Because `locale.h` isn't part of the libc++ modules the class definitions it provides are exported as par

[PATCH] D26760: Add the way to extract SVals of arguments used in a call for a given StackFrameCtx

NoQ added a comment. Note that the uncontrolled recursion checker will not be able to test this overwrite problem, because overwriting the argument region spoils the stack frame for it. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:743 +const

[PATCH] D26589: Add static analyzer checker for finding infinite recursion

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/RecursionChecker.cpp:65 + + for (const auto *ParentLC = C.getStackFrame()->getParent(); + ParentLC != nullptr; ParentLC = ParentLC->getParent()) { Off-by-1: `C.getStackFrame()` is already t

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticLexKinds.td:189-190 InGroup, DefaultIgnore; +def err_cxx1z_string_view_literal : Error< + "string_view literals are a C++1z feature">; def ext_binary_literal : Extension< I don't see a n

[PATCH] D26760: Add the way to extract SVals of arguments used in a call for a given StackFrameCtx

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:739 + if (SFC->inTopFrame()) { +// if we are in the top frame we don't have any arguments bound in the store +// because the call wasn't modeled in the first place. ---

[libcxx] r287417 - Mark test as unsupported in C++03

Author: ericwf Date: Fri Nov 18 19:38:00 2016 New Revision: 287417 URL: http://llvm.org/viewvc/llvm-project?rev=287417&view=rev Log: Mark test as unsupported in C++03 Modified: libcxx/trunk/test/libcxx/modules/clocale_exports.sh.cpp Modified: libcxx/trunk/test/libcxx/modules/clocale_exports.

[PATCH] D26826: [libcxx] Implement locale.h to fix modules build

rsmith added a comment. This should only be needed if you are not using `-fmodules-local-submodule-visibility` and do not have a module map for your C standard library. Is that really a configuration we want to support? Building without `-fmodules-local-submodule-visibility` typically only work

[PATCH] D26826: [libcxx] Implement locale.h to fix modules build

EricWF added inline comments. Comment at: include/locale.h:2 +// -*- C++ -*- +//=== math.h --===// +// rsmith wrote: > This is not math.h. It was fixed before committing but I didn't update phab. http

[PATCH] D24933: Enable configuration files in clang

srhines added a comment. Thanks to Hans for notifying me about this. Cross-compilation flags are a big challenge in Android, but I have similar concerns about looking for magic files/dirs. Richard's suggestion about improving @file is really interesting, and would satisfy a large part of our ne

[libcxx] r287435 - Fix stdint/cstdint modules

Author: ericwf Date: Fri Nov 18 21:29:03 2016 New Revision: 287435 URL: http://llvm.org/viewvc/llvm-project?rev=287435&view=rev Log: Fix stdint/cstdint modules Added: libcxx/trunk/test/libcxx/modules/cinttypes_exports.sh.cpp libcxx/trunk/test/libcxx/modules/cstdint_exports.sh.cpp libc

[PATCH] D26881: [libcxx] Remove CPlusPlus11 requirements from the module.modulemap

EricWF created this revision. EricWF added reviewers: rsmith, mclow.lists. EricWF added a subscriber: cfe-commits. This patch does two things: - Allow `std.strstream` to used in C++11. This is needed to get the libc++ test suite passing with modules enabled. Also enforcing that strstream is not

[PATCH] D26885: [libcxx] Fix max_size() across all containers

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. The `max_size()` method of containers should respect both the allocator's reported `max_size` and the range of the `difference_type`. This patch makes all containers choose the smallest of

r287436 - Doxygen comments for avxintrin.h.

Author: kromanova Date: Fri Nov 18 22:59:08 2016 New Revision: 287436 URL: http://llvm.org/viewvc/llvm-project?rev=287436&view=rev Log: Doxygen comments for avxintrin.h. Added doxygen comments to avxintrin.h's intrinsics. As of now, all the intrinsics in this file that were documented by Sony's

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai updated this revision to Diff 78620. smeenai updated the summary for this revision. smeenai added a comment. Addressing comments https://reviews.llvm.org/D26657 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp test/CodeGenCXX/dllexport.cpp test/CodeGenCXX/windows-itani

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai updated this revision to Diff 78621. smeenai added a comment. Typo in comment https://reviews.llvm.org/D26657 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp test/CodeGenCXX/dllexport.cpp test/CodeGenCXX/windows-itanium-dllexport.cpp Index: test/CodeGenCXX/windows-it

[PATCH] D25869: [Driver] Add unit tests for Distro detection

mgorny added a comment. In https://reviews.llvm.org/D25869#56, @bruno wrote: > LGTM! Please add this before https://reviews.llvm.org/D26850, which should > contain a testcase on top of this! I should probably also copy here that as I've mentioned on https://reviews.llvm.org/D26850, this a

<    1   2